)]}'
{"novaclient/api_versions.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"90a6ed275a7eb9af0fc7c8c7736f9ae35273b0b5","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"def get_substitutions(func_name, api_version\u003dNone):"},{"line_number":318,"context_line":"    substitutions \u003d _SUBSTITUTIONS.get(func_name, [])"},{"line_number":319,"context_line":"    if api_version and not api_version.is_null():"},{"line_number":320,"context_line":"        return [m for m in substitutions"},{"line_number":321,"context_line":"                if api_version.matches(m.start_version, m.end_version)]"},{"line_number":322,"context_line":"    return substitutions"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_b62018b2","side":"PARENT","line":319,"updated":"2015-09-08 16:30:58.000000000","message":"This check is required. If api_version is Null, ValueError will be thrown by L321(api_version.matches) - https://github.com/openstack/python-novaclient/blob/master/novaclient/api_versions.py#L135-L136","commit_id":"9e15b3d7c07d605947b8e712e36d982a0e14fb90"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"0d42346d9d88a37f1378fb5c3de9d800e6e56851","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"def get_substitutions(func_name, api_version\u003dNone):"},{"line_number":318,"context_line":"    substitutions \u003d _SUBSTITUTIONS.get(func_name, [])"},{"line_number":319,"context_line":"    if api_version and not api_version.is_null():"},{"line_number":320,"context_line":"        return [m for m in substitutions"},{"line_number":321,"context_line":"                if api_version.matches(m.start_version, m.end_version)]"},{"line_number":322,"context_line":"    return substitutions"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_ba6b121f","side":"PARENT","line":319,"in_reply_to":"da20952f_b62018b2","updated":"2015-09-08 20:34:23.000000000","message":"Andrey: agree that the is_null() check is needed, although I think the method name is unfortunate. :)","commit_id":"9e15b3d7c07d605947b8e712e36d982a0e14fb90"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c4f6ddf6a04549cc788deae77690964eefafd4e4","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                raise exceptions.VersionNotFoundForAPIMethod("},{"line_number":345,"context_line":"                    obj.api_version.get_string(), name)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"            method \u003d min(methods, key\u003dlambda f: f.start_version)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"            return method.func(obj, *args, **kwargs)"},{"line_number":350,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_7450250b","line":347,"updated":"2015-09-09 03:27:48.000000000","message":"Emm...this isn\u0027t right fix. The multiple version shell cmd use this wraps also. If you change this, then we change the CLI behavior also. We said the CIL will use latest version default. That is different with API.\n\n\nI think we should do thing like this https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L789 in v2 client class https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/client.py#L106","commit_id":"15cb5f20835dd21c71bd9363985266803db4182b"}]}