)]}'
{"id":"openstack%2Fpython-novaclient~221222","triplet_id":"openstack%2Fpython-novaclient~master~I1040539dc2bc26c5609b756dbfe3c85a5503fc8e","project":"openstack/python-novaclient","branch":"master","topic":"bug/1493207","hashtags":[],"change_id":"I1040539dc2bc26c5609b756dbfe3c85a5503fc8e","subject":"When no version given, default to v2.0","status":"ABANDONED","created":"2015-09-08 09:50:43.000000000","updated":"2015-09-09 10:32:27.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4d963d5a1f89df0ded8a9bb47d8c05cf3520faa0","_number":221222,"virtual_id_number":221222,"owner":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":1,"date":"2015-09-08 21:29:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"date":"2015-09-08 22:03:11.000000000","_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-09-08 21:46:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-1,"date":"2015-09-08 22:18:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":-1,"date":"2015-09-09 03:27:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"date":"2015-09-08 20:34:08.000000000","_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"date":"2015-09-09 02:46:54.000000000","_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-08 12:46:15.000000000","updated_by":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"reviewer":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"state":"REVIEWER"},{"updated":"2015-09-08 12:54:37.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2015-09-08 18:38:21.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-09-08 20:34:08.000000000","updated_by":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"reviewer":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"state":"REVIEWER"},{"updated":"2015-09-08 21:29:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-09-08 21:46:55.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-09-08 22:03:11.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2015-09-09 02:46:54.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"}],"messages":[{"id":"1f7166da4ec637198deca579966599f71ed0cacd","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2015-09-08 09:50:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f91b10a8f3a8faf5c8241db6a924c831cde1d0cb","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2015-09-08 10:16:04.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"be74ff7e8e6ba632841fb64bc01c64b4a764285c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 11:48:45.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/22/221222/2/check/gate-python-novaclient-python26/9197abf/ : FAILURE in 1m 33s\n- gate-python-novaclient-pep8 http://logs.openstack.org/22/221222/2/check/gate-python-novaclient-pep8/5f62a1a/ : FAILURE in 1m 07s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/22/221222/2/check/gate-python-novaclient-docs/111df6d//doc/build/html/ : SUCCESS in 1m 25s\n- gate-python-novaclient-python27 http://logs.openstack.org/22/221222/2/check/gate-python-novaclient-python27/b59e5d8/ : FAILURE in 3m 14s\n- gate-python-novaclient-python34 http://logs.openstack.org/22/221222/2/check/gate-python-novaclient-python34/c9b1f80/ : FAILURE in 1m 38s\n- gate-python-novaclient-pypy http://logs.openstack.org/22/221222/2/check/gate-python-novaclient-pypy/d972f8d/ : FAILURE in 2m 39s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/22/221222/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/98a1f48/ : SUCCESS in 1h 32m 34s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/22/221222/2/check/gate-novaclient-dsvm-functional/3179271/ : FAILURE in 23m 57s","accounts_in_message":[],"_revision_number":2},{"id":"6ada4343ec390af5a5fde00df98409af84620a41","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2015-09-08 12:48:40.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"62b3b1ce223bdce732153965cbeb8646e04a397f","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2015-09-08 12:53:17.000000000","message":"Patch Set 4: Commit message was updated","accounts_in_message":[],"_revision_number":4},{"id":"a3626fe7711cdbc6b7bcbf75ed5297994a72c14b","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2015-09-08 12:54:56.000000000","message":"Patch Set 4: Code-Review-1\n\nI think this fails when the min_version from something is higher than v2.0, we would not send the correct headers, and fail, where we should say its not supported by that version.\n\nI worry if this actually breaks the API defaulting to the latest version with 2.inf, but I am unsure.\n\nAlthough this might be a good quick fix.","accounts_in_message":[],"_revision_number":4},{"id":"a470a14e2dac45b438c701bebcc506b721eda297","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 14:07:34.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/22/221222/4/check/gate-python-novaclient-python26/ac117c4/ : SUCCESS in 2m 56s\n- gate-python-novaclient-pep8 http://logs.openstack.org/22/221222/4/check/gate-python-novaclient-pep8/8dbd73d/ : SUCCESS in 1m 16s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/22/221222/4/check/gate-python-novaclient-docs/4d0329f//doc/build/html/ : SUCCESS in 1m 23s\n- gate-python-novaclient-python27 http://logs.openstack.org/22/221222/4/check/gate-python-novaclient-python27/beb68be/ : SUCCESS in 1m 48s\n- gate-python-novaclient-python34 http://logs.openstack.org/22/221222/4/check/gate-python-novaclient-python34/a62b207/ : SUCCESS in 2m 09s\n- gate-python-novaclient-pypy http://logs.openstack.org/22/221222/4/check/gate-python-novaclient-pypy/1b626ec/ : SUCCESS in 2m 31s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/22/221222/4/check/gate-tempest-dsvm-neutron-src-python-novaclient/cc22e31/ : SUCCESS in 1h 08m 28s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/22/221222/4/check/gate-novaclient-dsvm-functional/d5d31e4/ : SUCCESS in 27m 30s","accounts_in_message":[],"_revision_number":4},{"id":"90a6ed275a7eb9af0fc7c8c7736f9ae35273b0b5","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-09-08 16:30:58.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"0b8e6e3385ee7293d37eeb9e8055e80723e23997","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-09-08 16:39:07.000000000","message":"Patch Set 4:\n\nThis problem should be fixed at horizon side. they use novaclient incorrect. Only novaclient.client should be used as entry point(it contains all version checks and backward compatibility for opts), but they use novaclient.v2.client directly... https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L448-L454\n\nFrom side of novaclient, we can add additional check at v2.client (https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/client.py#L158) that api_version is provided and set it to APIVersion(\"2.0\") if not. But, imo, current situation is a good chance to say \"use correct entrypoint for novaclient now!\"","accounts_in_message":[],"_revision_number":4},{"id":"3370a2a2d97af2db4e9382d238d35455cabc4be3","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2015-09-08 20:34:08.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"0d42346d9d88a37f1378fb5c3de9d800e6e56851","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2015-09-08 20:34:23.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1c13b3607b412e2c50f2050736713cbc24d8172d","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2015-09-08 20:35:02.000000000","message":"Patch Set 5:\n\nJust added back the is_null test() and removed the unrelated whitespace changes.","accounts_in_message":[],"_revision_number":5},{"id":"82734724c1ee5a1ad819b50414eb6c2ff8756c95","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 21:29:07.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/22/221222/5/check/gate-python-novaclient-python26/540362a/ : SUCCESS in 3m 20s\n- gate-python-novaclient-pep8 http://logs.openstack.org/22/221222/5/check/gate-python-novaclient-pep8/eeb731a/ : SUCCESS in 1m 16s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/22/221222/5/check/gate-python-novaclient-docs/0cc273e//doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-novaclient-python27 http://logs.openstack.org/22/221222/5/check/gate-python-novaclient-python27/e9222d7/ : SUCCESS in 1m 34s\n- gate-python-novaclient-python34 http://logs.openstack.org/22/221222/5/check/gate-python-novaclient-python34/41d2644/ : SUCCESS in 4m 28s\n- gate-python-novaclient-pypy http://logs.openstack.org/22/221222/5/check/gate-python-novaclient-pypy/7047388/ : SUCCESS in 2m 23s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/22/221222/5/check/gate-tempest-dsvm-neutron-src-python-novaclient/d2318cc/ : SUCCESS in 54m 50s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/22/221222/5/check/gate-novaclient-dsvm-functional/1ef2ac3/ : SUCCESS in 29m 00s","accounts_in_message":[],"_revision_number":5},{"id":"16e9406452fa8019016b6dd079c7f62000d056ee","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-09-08 21:46:55.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"f5145f8e43198e34abdec97765b34e28cbf88d94","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-09-08 22:03:11.000000000","message":"Patch Set 5:\n\nStill -1","accounts_in_message":[],"_revision_number":5},{"id":"c69082bd03144b04d722e06ecdf319eadd5cef22","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-09-08 22:18:00.000000000","message":"Patch Set 5: Code-Review-1\n\nCore issue: https://bugs.launchpad.net/python-novaclient/+bug/1493576","accounts_in_message":[],"_revision_number":5},{"id":"c4f6ddf6a04549cc788deae77690964eefafd4e4","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2015-09-09 03:27:48.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)\n\nSounds good point from Andrey, but I didn\u0027t see anyway said we should didn\u0027t allow user use v2 client class directly. So I hope get other people suggestion.\n\nThe fix I think it isn\u0027t right. I commented inline.","accounts_in_message":[],"_revision_number":5},{"id":"9ab2281e30db9062089019e8a1c45ad7aba0f00a","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-09-09 06:53:05.000000000","message":"Patch Set 5:\n\n@Alex: despite the fact that novaclient\u0027s docs are pure, they include page \"The novaclient Python API\"( http://docs.openstack.org/developer/python-novaclient/api.html ), where only one way is recommended to use novaclient. Direct import of versioned client is not proposed at all in out docs, so we can say that novaclient.v2.Client is a some inner class, which is not designed to direct initialization.\n\nPS: we need to update docs to be more clear and full.","accounts_in_message":[],"_revision_number":5},{"id":"30aa8041aecd335711a59a4359980d8a886cdb68","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2015-09-09 10:32:27.000000000","message":"Abandoned\n\ncool, lets drop this, it seems it not actually required.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"15cb5f20835dd21c71bd9363985266803db4182b","revisions":{"e5e616cb105a1395a31a879392af30c9bea756db":{"kind":"REWORK","_number":1,"created":"2015-09-08 09:50:43.000000000","uploader":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"ref":"refs/changes/22/221222/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/22/221222/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/1"}}},"commit":{"parents":[{"commit":"9e15b3d7c07d605947b8e712e36d982a0e14fb90","subject":"Merge \"[Bug-Fix] Update requests body for quota-update\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9e15b3d7c07d605947b8e712e36d982a0e14fb90"}]}],"author":{"name":"John Garbutt","email":"john.garbutt@rackspace.com","date":"2015-09-08 09:49:47.000000000","tz":60},"committer":{"name":"John Garbutt","email":"john.garbutt@rackspace.com","date":"2015-09-08 09:49:47.000000000","tz":60},"subject":"WIP: show up an error when not specifying version","message":"WIP: show up an error when not specifying version\n\nJust a unit test fail to show up the problem.\n\nChange-Id: I1040539dc2bc26c5609b756dbfe3c85a5503fc8e\nRelated-Bug: #1493207\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e5e616cb105a1395a31a879392af30c9bea756db"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e5e616cb105a1395a31a879392af30c9bea756db"}]},"branch":"refs/heads/master"},"0fd06846bcb69f3eb656dd67621d84bb58fcb796":{"kind":"REWORK","_number":2,"created":"2015-09-08 10:16:04.000000000","uploader":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"ref":"refs/changes/22/221222/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/22/221222/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/2"}}},"commit":{"parents":[{"commit":"9e15b3d7c07d605947b8e712e36d982a0e14fb90","subject":"Merge \"[Bug-Fix] Update requests body for quota-update\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9e15b3d7c07d605947b8e712e36d982a0e14fb90"}]}],"author":{"name":"John Garbutt","email":"john.garbutt@rackspace.com","date":"2015-09-08 09:49:47.000000000","tz":60},"committer":{"name":"John Garbutt","email":"john.garbutt@rackspace.com","date":"2015-09-08 10:14:11.000000000","tz":60},"subject":"WIP: when no version given, default to v2.0","message":"WIP: when no version given, default to v2.0\n\nCurrently horizon got broken when python-novaclient was upgraded,\nbecause it doesn\u0027t specify a version, and this lead to max version being\npicked, but not actually sending any version headers, thus leading to a\nfailed request, specifically when uploading keypairs.\n\nRelated-Bug: #1493207\n\nChange-Id: I1040539dc2bc26c5609b756dbfe3c85a5503fc8e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0fd06846bcb69f3eb656dd67621d84bb58fcb796"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0fd06846bcb69f3eb656dd67621d84bb58fcb796"}]},"branch":"refs/heads/master"},"a90ce7b2a875a8a4508ab1c65d7b3beeee0414ec":{"kind":"REWORK","_number":3,"created":"2015-09-08 12:48:40.000000000","uploader":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"ref":"refs/changes/22/221222/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/22/221222/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/3"}}},"commit":{"parents":[{"commit":"9e15b3d7c07d605947b8e712e36d982a0e14fb90","subject":"Merge \"[Bug-Fix] Update requests body for quota-update\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9e15b3d7c07d605947b8e712e36d982a0e14fb90"}]}],"author":{"name":"John Garbutt","email":"john.garbutt@rackspace.com","date":"2015-09-08 09:49:47.000000000","tz":60},"committer":{"name":"John Garbutt","email":"john.garbutt@rackspace.com","date":"2015-09-08 12:48:15.000000000","tz":60},"subject":"WIP: when no version given, default to v2.0","message":"WIP: when no version given, default to v2.0\n\nCurrently horizon got broken when python-novaclient was upgraded,\nbecause it doesn\u0027t specify a version, and this lead to max version being\npicked, but not actually sending any version headers, thus leading to a\nfailed request, specifically when uploading keypairs.\n\nRelated-Bug: #1493207\n\nChange-Id: I1040539dc2bc26c5609b756dbfe3c85a5503fc8e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a90ce7b2a875a8a4508ab1c65d7b3beeee0414ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a90ce7b2a875a8a4508ab1c65d7b3beeee0414ec"}]},"branch":"refs/heads/master"},"d47a04402c70eab737d9d87ab154885af9a4618d":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2015-09-08 12:53:17.000000000","uploader":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"ref":"refs/changes/22/221222/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/22/221222/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/4"}}},"commit":{"parents":[{"commit":"9e15b3d7c07d605947b8e712e36d982a0e14fb90","subject":"Merge \"[Bug-Fix] Update requests body for quota-update\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9e15b3d7c07d605947b8e712e36d982a0e14fb90"}]}],"author":{"name":"John Garbutt","email":"john.garbutt@rackspace.com","date":"2015-09-08 09:49:47.000000000","tz":60},"committer":{"name":"John Garbutt","email":"john@johngarbutt.com","date":"2015-09-08 12:53:17.000000000","tz":0},"subject":"When no version given, default to v2.0","message":"When no version given, default to v2.0\n\nCurrently horizon got broken when python-novaclient was upgraded,\nbecause it doesn\u0027t specify a version, and this lead to max version being\npicked, but not actually sending any version headers, thus leading to a\nfailed request, specifically when uploading keypairs.\n\nWe must ensure we still default it to v2.0 when using the client.\nOnly the CLI should default to the max version.\nThe current state is worse, defaults to max version but sending\nno version headers, which is totally broken.\n\nThis patch ensures we default to v2.0, by picking the min_version.\n\nRelated-Bug: #1493207\nRelated-Bug: #1493205\n\nChange-Id: I1040539dc2bc26c5609b756dbfe3c85a5503fc8e","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d47a04402c70eab737d9d87ab154885af9a4618d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d47a04402c70eab737d9d87ab154885af9a4618d"}]},"branch":"refs/heads/master"},"15cb5f20835dd21c71bd9363985266803db4182b":{"kind":"REWORK","_number":5,"created":"2015-09-08 20:34:08.000000000","uploader":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"ref":"refs/changes/22/221222/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/22/221222/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/22/221222/5"}}},"commit":{"parents":[{"commit":"9e15b3d7c07d605947b8e712e36d982a0e14fb90","subject":"Merge \"[Bug-Fix] Update requests body for quota-update\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9e15b3d7c07d605947b8e712e36d982a0e14fb90"}]}],"author":{"name":"John Garbutt","email":"john.garbutt@rackspace.com","date":"2015-09-08 09:49:47.000000000","tz":60},"committer":{"name":"EdLeafe","email":"ed@leafe.com","date":"2015-09-08 20:34:07.000000000","tz":0},"subject":"When no version given, default to v2.0","message":"When no version given, default to v2.0\n\nCurrently horizon got broken when python-novaclient was upgraded,\nbecause it doesn\u0027t specify a version, and this lead to max version being\npicked, but not actually sending any version headers, thus leading to a\nfailed request, specifically when uploading keypairs.\n\nWe must ensure we still default it to v2.0 when using the client.\nOnly the CLI should default to the max version.\nThe current state is worse, defaults to max version but sending\nno version headers, which is totally broken.\n\nThis patch ensures we default to v2.0, by picking the min_version.\n\nRelated-Bug: #1493207\nRelated-Bug: #1493205\n\nChange-Id: I1040539dc2bc26c5609b756dbfe3c85a5503fc8e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/15cb5f20835dd21c71bd9363985266803db4182b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/15cb5f20835dd21c71bd9363985266803db4182b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}