)]}'
{"id":"openstack%2Fpython-novaclient~221568","triplet_id":"openstack%2Fpython-novaclient~master~I890c72c62368418191d3dc71081ab1d73bb8d3fe","project":"openstack/python-novaclient","branch":"master","topic":"rackspace/fixs-bugs","hashtags":[],"change_id":"I890c72c62368418191d3dc71081ab1d73bb8d3fe","subject":"make sure os_password is set","status":"ABANDONED","created":"2015-09-09 02:14:58.000000000","updated":"2015-09-09 20:02:57.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d976b59c2dea49fb1259416ba00820b5d55adc67","_number":221568,"virtual_id_number":221568,"owner":{"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-09-09 02:18:57.000000000","_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},{"date":"2015-09-09 18:50:58.000000000","_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":1,"date":"2015-09-09 03:15:39.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-09 03:15:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-09-09 18:50:58.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"}],"messages":[{"id":"023a4c092ee6a676945ccfe9f719c7986e1054b4","author":{"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},"date":"2015-09-09 02:14:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f36b7e8f99e7c565ebf74b6ebd34b0b0a4ed24a8","author":{"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},"date":"2015-09-09 02:18:57.000000000","message":"Patch Set 1:\n\nI think I did this wrong.\n\nremote:   https://review.openstack.org/221568\nremote:   https://review.openstack.org/221569\nremote:   https://review.openstack.org/221570\n\nI ended up getting three changes..., instead of just one patch set.\n\nIf anyone can point me in the right direction in how to fix these, that would be awesome","accounts_in_message":[],"_revision_number":1},{"id":"ac9004df8e93dfa6f25b9f582d6833339ac21581","author":{"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},"date":"2015-09-09 02:26:09.000000000","message":"Patch Set 1:\n\nsquashed the commits to here\n\nhttps://review.openstack.org/#/c/221570/","accounts_in_message":[],"_revision_number":1},{"id":"ca0a03906e8f100aff05e7c7009e6de8dff2515a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-09 03:15:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/68/221568/1/check/gate-python-novaclient-python26/c98be5a/ : SUCCESS in 2m 35s\n- gate-python-novaclient-pep8 http://logs.openstack.org/68/221568/1/check/gate-python-novaclient-pep8/532336a/ : SUCCESS in 2m 19s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/68/221568/1/check/gate-python-novaclient-docs/d1cc2ff//doc/build/html/ : SUCCESS in 1m 23s\n- gate-python-novaclient-python27 http://logs.openstack.org/68/221568/1/check/gate-python-novaclient-python27/494460b/ : SUCCESS in 2m 05s\n- gate-python-novaclient-python34 http://logs.openstack.org/68/221568/1/check/gate-python-novaclient-python34/088adb7/ : SUCCESS in 3m 12s\n- gate-python-novaclient-pypy http://logs.openstack.org/68/221568/1/check/gate-python-novaclient-pypy/ecc3315/ : SUCCESS in 2m 41s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/68/221568/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/4418983/ : SUCCESS in 1h 00m 18s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/68/221568/1/check/gate-novaclient-dsvm-functional/d9f38fa/ : SUCCESS in 26m 37s","accounts_in_message":[],"_revision_number":1},{"id":"a287a3648582b26383260ad23cef9622ff6e8c6e","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-09-09 18:50:58.000000000","message":"Patch Set 1:\n\nThe review is identified by the Change-Id in the commit message. As long as you use the same Change-Id, you will be able to update an existing review instead of creating a new one.\n\nThis change seems okay (unlike the Unauthorized handling, which already has a fix merged and released). I think you\u0027ll also want to add a unit test to verify this fixes the problem you\u0027re seeing\n\nI think it would be a good idea to open a bug explaining the problem (from what I understand, the problem is novaclient currently isn\u0027t working when auth system isn\u0027t keystone). And then explain similarly in the commit message, and add \"Closes-Bug: #1234\" to the commit message to reference the bug [1].\n\nhttp://docs.openstack.org/infra/manual/developers.html#committing-a-change","accounts_in_message":[],"_revision_number":1},{"id":"8a5ee2ac55fbc70895d7e5dc39d3fcf5326f345b","author":{"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},"date":"2015-09-09 19:31:18.000000000","message":"Patch Set 1:\n\nwoops, didn\u0027t think about merging it back on this one.\n\nI have already created https://bugs.launchpad.net/bugs/1493977 and https://review.openstack.org/#/c/221921/\n\nsorry","accounts_in_message":[],"_revision_number":1},{"id":"f0b0a1f4baed2ce9c7fe974f7346016103e6093d","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-09-09 20:01:27.000000000","message":"Patch Set 1:\n\nOkay, you can abandon this one then (otherwise the review queue gets messy with duplicates). In the future, keep in mind to just update your existing review","accounts_in_message":[],"_revision_number":1},{"id":"5ba20ca07b014faca00a201c18b5a188395b58a6","author":{"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},"date":"2015-09-09 20:02:30.000000000","message":"Patch Set 1:\n\nSounds good","accounts_in_message":[],"_revision_number":1},{"id":"effdd1fee88adc2db432f66bdf9bd0bf501813f6","author":{"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},"date":"2015-09-09 20:02:57.000000000","message":"Abandoned\n\nhttps://review.openstack.org/#/c/221921/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ddae08e7c05aad4319b4db76bba11f77f5d9cfde","revisions":{"ddae08e7c05aad4319b4db76bba11f77f5d9cfde":{"kind":"REWORK","_number":1,"created":"2015-09-09 02:14:58.000000000","uploader":{"_account_id":8016,"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","username":"gtmanfred"},"ref":"refs/changes/68/221568/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/68/221568/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/221568/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/221568/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/221568/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/68/221568/1"}}},"commit":{"parents":[{"commit":"e612205ab850b291a78e539d15923c8716d90158","subject":"Merge \"Enable i18n with Babel.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e612205ab850b291a78e539d15923c8716d90158"}]}],"author":{"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","date":"2015-09-09 01:13:39.000000000","tz":-300},"committer":{"name":"Daniel Wallace","email":"danielwallace@gtmanfred.com","date":"2015-09-09 02:14:14.000000000","tz":-300},"subject":"make sure os_password is set","message":"make sure os_password is set\n\nI am not sure where this is referning to it being set in the future,\nbut it is currently not being set when the client object is being passed\nto the plugin.\n\nSpecifically the rackspace-auth-openstack plugin.\n\nChange-Id: I890c72c62368418191d3dc71081ab1d73bb8d3fe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ddae08e7c05aad4319b4db76bba11f77f5d9cfde"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ddae08e7c05aad4319b4db76bba11f77f5d9cfde"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}