)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"057fb3977625b69a98f39095532ea2d771046f75","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix nova bash-completion needs authentication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix bash-completion works without authentication."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ic1a7f84b1b9cb7e8be6721c1b8096f49e9e9ab33"},{"line_number":12,"context_line":"Closes-Bug: #1495424"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba15a1d1_fb6ae419","line":9,"updated":"2015-09-14 15:49:25.000000000","message":"There\u0027s not enough detail here to understand the purpose of the change.  Even the bug wasn\u0027t enough to truly understand the change, but I was able to infer the purpose from the code change and a recent change I reviewed for that code path.  We really need you to expand the commit message here to explain what the problem is and how the change fixes it.","commit_id":"a82d24ed7507395e92d17d1be988a0cfad6be592"}],"novaclient/shell.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"069c95273182f509112786c18c25d3fcb76c707a","unresolved":false,"context_lines":[{"line_number":555,"context_line":"        (args, args_list) \u003d parser.parse_known_args(argv)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        self.setup_debugging(args.debug)"},{"line_number":558,"context_line":"        self.extensions \u003d []"},{"line_number":559,"context_line":"        do_help \u003d (\u0027help\u0027 in argv) or ("},{"line_number":560,"context_line":"            \u0027--help\u0027 in argv) or (\u0027-h\u0027 in argv) or ("},{"line_number":561,"context_line":"            \u0027bash-completion\u0027 in argv) or not argv"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_4a4bdc87","line":558,"updated":"2015-09-15 09:33:27.000000000","message":"It would be nice to left here a note about why \"bash-completion\" is checked for \"do_help\" var. Just something simple like \"bash-completion should not require authentification\"","commit_id":"3a495c8c891b4ac246ef90914c8c31fc4486f08b"},{"author":{"_account_id":17207,"name":"Atsushi SAKAI","email":"sakaia@jp.fujitsu.com","username":"sakaia"},"change_message_id":"be2571133b878c14c6fcf254ae4d491897a055f5","unresolved":false,"context_lines":[{"line_number":555,"context_line":"        (args, args_list) \u003d parser.parse_known_args(argv)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        self.setup_debugging(args.debug)"},{"line_number":558,"context_line":"        self.extensions \u003d []"},{"line_number":559,"context_line":"        do_help \u003d (\u0027help\u0027 in argv) or ("},{"line_number":560,"context_line":"            \u0027--help\u0027 in argv) or (\u0027-h\u0027 in argv) or ("},{"line_number":561,"context_line":"            \u0027bash-completion\u0027 in argv) or not argv"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_dd69f426","line":558,"in_reply_to":"ba15a1d1_4a4bdc87","updated":"2015-09-15 09:50:29.000000000","message":"Thank you for suggesting me a simple comment.","commit_id":"3a495c8c891b4ac246ef90914c8c31fc4486f08b"},{"author":{"_account_id":16839,"name":"Cale Rath","email":"ctrath@us.ibm.com","username":"ctrath"},"change_message_id":"e210a7b907916e65f1186d7c3da51df69121a536","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        do_help \u003d (\u0027help\u0027 in argv) or ("},{"line_number":562,"context_line":"            \u0027--help\u0027 in argv) or (\u0027-h\u0027 in argv) or ("},{"line_number":563,"context_line":"            \u0027bash-completion\u0027 in argv) or not argv"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        # Discover available auth plugins"},{"line_number":566,"context_line":"        novaclient.auth_plugin.discover_auth_systems()"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_68e1f699","line":564,"updated":"2015-09-15 15:53:37.000000000","message":"To me, it seems like overriding the do_help var to also include bash-completion shouldn\u0027t be done.  Can we use a different variable name or separate variable names for options that don\u0027t need authentication, as the variable \"do_help\" may be used for other things besides auth checking.","commit_id":"a86d3332d2701cc61d4eb873f010e7d80f9ad59c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dc1c260a3b6bb1562a5ba9d251e241a3db45cd36","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        self.setup_debugging(args.debug)"},{"line_number":558,"context_line":"        self.extensions \u003d []"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        # bash-completion should not require authentification"},{"line_number":561,"context_line":"        do_help \u003d (\u0027help\u0027 in argv) or ("},{"line_number":562,"context_line":"            \u0027--help\u0027 in argv) or (\u0027-h\u0027 in argv) or not argv"},{"line_number":563,"context_line":"        skip_auth \u003d do_help or ("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_0e6aa61a","line":560,"updated":"2015-09-16 08:24:23.000000000","message":"NIT: move this comment to L563","commit_id":"06f93f8028f72791b890d0cfd052c732ab93eb95"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"5a66d98c589c2a34bb3c3248c7314df8244a3f6d","unresolved":false,"context_lines":[{"line_number":692,"context_line":"                os_password \u003d args.os_password"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        if not skip_auth and \\"},{"line_number":695,"context_line":"           not any([args.os_tenant_id, args.os_tenant_name,"},{"line_number":696,"context_line":"                    args.os_project_id, args.os_project_name]):"},{"line_number":697,"context_line":"            raise exc.CommandError(_(\"You must provide a project name or\""},{"line_number":698,"context_line":"                                     \" project id via --os-project-name,\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_29f98bc7","line":695,"updated":"2015-09-16 17:26:25.000000000","message":"Please use parentheses to eliminate the backslash continuation, e.g.:\n\n    if (not skip_auth and\n            not any([args.os_tenant_id, args.os_tenant_name,\n                     args.os_project_id, args.os_project_name])):","commit_id":"eddeef23561c8248d470e5d729012261b54fba96"},{"author":{"_account_id":17207,"name":"Atsushi SAKAI","email":"sakaia@jp.fujitsu.com","username":"sakaia"},"change_message_id":"0dd1eaa4c25b57eab79047e93d22aaae1a5e8ad6","unresolved":false,"context_lines":[{"line_number":692,"context_line":"                os_password \u003d args.os_password"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        if not skip_auth and \\"},{"line_number":695,"context_line":"           not any([args.os_tenant_id, args.os_tenant_name,"},{"line_number":696,"context_line":"                    args.os_project_id, args.os_project_name]):"},{"line_number":697,"context_line":"            raise exc.CommandError(_(\"You must provide a project name or\""},{"line_number":698,"context_line":"                                     \" project id via --os-project-name,\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_0a382bee","line":695,"in_reply_to":"ba15a1d1_29f98bc7","updated":"2015-09-17 00:25:37.000000000","message":"Done","commit_id":"eddeef23561c8248d470e5d729012261b54fba96"}]}