)]}'
{"id":"openstack%2Fpython-novaclient~2286","triplet_id":"openstack%2Fpython-novaclient~master~Iba6ef2c1f789c2eb12b210d42261d63796db3407","project":"openstack/python-novaclient","branch":"master","topic":"jd/fix-volume-show","hashtags":[],"change_id":"Iba6ef2c1f789c2eb12b210d42261d63796db3407","subject":"Add list() method to ManagerWithFind","status":"MERGED","created":"2011-12-13 16:03:45.000000000","updated":"2011-12-31 00:09:33.000000000","submitted":"2011-12-31 00:09:33.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"992e7b6dc61c17b3090fa6fb63499cbd88a9fe6a","_number":2286,"virtual_id_number":2286,"owner":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":1,"date":"2011-12-31 00:09:33.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"all":[{"value":2,"date":"2011-12-31 00:03:00.000000000","_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"date":"2011-12-31 00:09:33.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2011-12-28 09:06:15.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":2,"date":"2011-12-28 16:10:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"all":[{"value":1,"date":"2011-12-31 00:03:00.000000000","_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"date":"2011-12-28 16:10:46.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-12-28 16:10:46.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2011-12-31 00:03:00.000000000","updated_by":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"reviewer":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"state":"REVIEWER"},{"updated":"2011-12-31 00:09:33.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"fb712478447bf0789171527f9f1a36e54868fa68","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2011-12-13 16:06:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"df8c56dad921b02992901625ffaf0dbe85ff9098","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2011-12-20 19:20:21.000000000","message":"Patch Set 2:\n\nI\u0027m not certain I understand why this is necessary.  If the method does not exist, you\u0027ll get an AttributeError when you attempt to execute it.  Wouldn\u0027t that serve the same purpose?","accounts_in_message":[],"_revision_number":2},{"id":"ab7408cdb0bca289b447809930606abf948da102","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2011-12-21 09:01:33.000000000","message":"Patch Set 2:\n\nYes, in both case it would raise, but the AttributeError is not the good one to raise and not the good way to raise it.\n\n\nNotImplementedError:\nThis exception is derived from RuntimeError. In user defined base classes, abstract methods should raise this exception when they require derived classes to override the method.","accounts_in_message":[],"_revision_number":2},{"id":"3f64bcc319665951104d5d83f1474d038102e78a","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2011-12-22 11:04:43.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4ad79df781bc1f738107e083071d6d7d48051900","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2011-12-27 17:18:45.000000000","message":"Patch Set 3:\n\nI still don\u0027t understand why this is needed.  Is there a bug this fixes?  Is there something not being caught properly in the test suite?\n\nI don\u0027t mind purity patches—I\u0027ve certainly made several of my own!—but I really don\u0027t see how this can possibly fix anything.  (That said, I\u0027m not -1\u0027ing this, and if someone else wants to approve it, that\u0027s fine; I\u0027m just trying and failing to understand the patch…)","accounts_in_message":[],"_revision_number":3},{"id":"c51a1e015c08a61d7cc72403f15b48e878a255cd","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2011-12-28 09:06:15.000000000","message":"Patch Set 3:\n\nYes, this is a purity patch, it does not fix any bug.","accounts_in_message":[],"_revision_number":3},{"id":"bafbb5c8557a5ed197a6d5c21372de1ce365568a","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2011-12-28 16:10:46.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nOK.  And given that I\u0027m a little more awake today, I think I understand the purpose of this patch a little better…","accounts_in_message":[],"_revision_number":3},{"id":"506771965fbd2c0acc2473f9959c3e6dbc967116","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-12-31 00:03:00.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"a1d60443864b64d161d65848dbbc979612fb0943","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-31 00:09:33.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/53/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/53/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/55/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"6bfcc974718e49ac32d97ab04c2802b53e95c828","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-31 00:09:33.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"3fcf4a13740af5c82ef394fffe1bd3761a67757c","revisions":{"a6baf6caec83392ac98188347fe7ebd78c73ed8b":{"kind":"REWORK","_number":1,"created":"2011-12-13 16:03:45.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/86/2286/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/86/2286/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/1"}}},"commit":{"parents":[{"commit":"f737a8c3bbbd30428cdecec500d2275a5f74ba89","subject":"Add MANIFEST.in and setup.cfg back.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f737a8c3bbbd30428cdecec500d2275a5f74ba89"}]}],"author":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2011-12-13 15:57:14.000000000","tz":60},"committer":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2011-12-13 16:03:16.000000000","tz":60},"subject":"Add list() method to ManagerWithFind","message":"Add list() method to ManagerWithFind\n\nManagerWithFind.find() method wants to use self.list() but Manager does not\nprovides it. Therefore, it\u0027s better to implement it as an interface here,\nand raise a NotImplementedError.\n\nChange-Id: Iba6ef2c1f789c2eb12b210d42261d63796db3407\nSigned-off-by: Julien Danjou \u003cjulien@danjou.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a6baf6caec83392ac98188347fe7ebd78c73ed8b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a6baf6caec83392ac98188347fe7ebd78c73ed8b"}]},"branch":"refs/heads/master"},"bca1bf8137575178e563e02e231e227fbb88e044":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2011-12-13 16:06:00.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/86/2286/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/86/2286/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/2"}}},"commit":{"parents":[{"commit":"f737a8c3bbbd30428cdecec500d2275a5f74ba89","subject":"Add MANIFEST.in and setup.cfg back.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f737a8c3bbbd30428cdecec500d2275a5f74ba89"}]}],"author":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-13 15:57:14.000000000","tz":60},"committer":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-13 16:05:18.000000000","tz":60},"subject":"Add list() method to ManagerWithFind","message":"Add list() method to ManagerWithFind\n\nManagerWithFind.find() method wants to use self.list() but Manager does not\nprovides it. Therefore, it\u0027s better to implement it as an interface here,\nand raise a NotImplementedError.\n\nChange-Id: Iba6ef2c1f789c2eb12b210d42261d63796db3407\nSigned-off-by: Julien Danjou \u003cjulien.danjou@enovance.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/bca1bf8137575178e563e02e231e227fbb88e044"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/bca1bf8137575178e563e02e231e227fbb88e044"}]},"branch":"refs/heads/master"},"3fcf4a13740af5c82ef394fffe1bd3761a67757c":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2011-12-22 11:04:43.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/86/2286/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/86/2286/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/86/2286/3"}}},"commit":{"parents":[{"commit":"88bdfdd12f832c0bfbde6680828d86fa4e2f74e1","subject":"Extensions can now modify resources.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/88bdfdd12f832c0bfbde6680828d86fa4e2f74e1"}]}],"author":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-13 15:57:14.000000000","tz":60},"committer":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-22 09:07:00.000000000","tz":60},"subject":"Add list() method to ManagerWithFind","message":"Add list() method to ManagerWithFind\n\nManagerWithFind.find() method wants to use self.list() but Manager does not\nprovides it. Therefore, it\u0027s better to implement it as an interface here,\nand raise a NotImplementedError.\n\nChange-Id: Iba6ef2c1f789c2eb12b210d42261d63796db3407\nSigned-off-by: Julien Danjou \u003cjulien.danjou@enovance.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3fcf4a13740af5c82ef394fffe1bd3761a67757c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3fcf4a13740af5c82ef394fffe1bd3761a67757c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}