)]}'
{"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f46de2f12b6b4d797e9c53e3e07ed8d89ea4b376","unresolved":false,"context_lines":[{"line_number":1806,"context_line":"def do_image_create(cs, args):"},{"line_number":1807,"context_line":"    \"\"\"Create a new image by taking a snapshot of a running server.\"\"\""},{"line_number":1808,"context_line":"    server \u003d _find_server(cs, args.server)"},{"line_number":1809,"context_line":"    meta \u003d dict(v.split(\u0027\u003d\u0027, 1) for v in args.metadata)"},{"line_number":1810,"context_line":"    image_uuid \u003d cs.servers.create_image(server, args.name, meta)"},{"line_number":1811,"context_line":""},{"line_number":1812,"context_line":"    if args.poll:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_8cb1b203","line":1809,"updated":"2015-09-29 16:22:34.000000000","message":"So, if there\u0027s no metadata specified, the meta argument will be passed as an empty dictionary, rather than None as it was before.  This is probably the source of the functional test error, though I haven\u0027t actually looked at the test output to verify that.  I would suggest adding the clause \"or None\" to the end of this line, or in the line below in passing \"meta\" to create_image().","commit_id":"b7d03df421e96850b6c30f64acba70eb460f3709"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"6d5b99d4cd71b76136ca3cb857c0c2205f42c458","unresolved":false,"context_lines":[{"line_number":1806,"context_line":"def do_image_create(cs, args):"},{"line_number":1807,"context_line":"    \"\"\"Create a new image by taking a snapshot of a running server.\"\"\""},{"line_number":1808,"context_line":"    server \u003d _find_server(cs, args.server)"},{"line_number":1809,"context_line":"    meta \u003d dict(v.split(\u0027\u003d\u0027, 1) for v in args.metadata)"},{"line_number":1810,"context_line":"    image_uuid \u003d cs.servers.create_image(server, args.name, meta)"},{"line_number":1811,"context_line":""},{"line_number":1812,"context_line":"    if args.poll:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_d732c15d","line":1809,"in_reply_to":"9a1a9d01_8cb1b203","updated":"2015-09-30 01:24:16.000000000","message":"Yes, I thought that it was because of that, too. So it\u0027s my first thing to do this morning :-)","commit_id":"b7d03df421e96850b6c30f64acba70eb460f3709"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"2cebed5f62768907b1c4ac511a5a6abe84e90010","unresolved":false,"context_lines":[{"line_number":1806,"context_line":"def do_image_create(cs, args):"},{"line_number":1807,"context_line":"    \"\"\"Create a new image by taking a snapshot of a running server.\"\"\""},{"line_number":1808,"context_line":"    server \u003d _find_server(cs, args.server)"},{"line_number":1809,"context_line":"    meta \u003d dict(v.split(\u0027\u003d\u0027, 1) for v in args.metadata) or None"},{"line_number":1810,"context_line":"    image_uuid \u003d cs.servers.create_image(server, args.name, meta)"},{"line_number":1811,"context_line":""},{"line_number":1812,"context_line":"    if args.poll:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_beb8262b","line":1809,"updated":"2015-09-30 16:22:37.000000000","message":"I see that such code is duplicated in several places in the whole novaclient. Can we have some common util for parsing metadata?","commit_id":"3866bfb2979b0434ae62feaf9637818447f51c12"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"4979f19ff7428ca9cf7eb32a6387d838cb6b4372","unresolved":false,"context_lines":[{"line_number":1806,"context_line":"def do_image_create(cs, args):"},{"line_number":1807,"context_line":"    \"\"\"Create a new image by taking a snapshot of a running server.\"\"\""},{"line_number":1808,"context_line":"    server \u003d _find_server(cs, args.server)"},{"line_number":1809,"context_line":"    meta \u003d dict(v.split(\u0027\u003d\u0027, 1) for v in args.metadata) or None"},{"line_number":1810,"context_line":"    image_uuid \u003d cs.servers.create_image(server, args.name, meta)"},{"line_number":1811,"context_line":""},{"line_number":1812,"context_line":"    if args.poll:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_6e4adb56","line":1809,"in_reply_to":"9a1a9d01_beb8262b","updated":"2015-09-30 17:52:40.000000000","message":"Michal: I think that\u0027s a great idea, but let\u0027s not make it a requirement for this change :)  Would you mind opening a novaclient bug for that?","commit_id":"3866bfb2979b0434ae62feaf9637818447f51c12"}]}