)]}'
{"novaclient/tests/unit/test_shell.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"a25b2f45224ea7d1bddd33c0dc5ac65131ba2cd2","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        # CLI is the latest (incremental) microversion that we are known to"},{"line_number":522,"context_line":"        # support.  As new incremental microversion support is added, this"},{"line_number":523,"context_line":"        # should be updated."},{"line_number":524,"context_line":"        self.assertEqual(\u00272.5\u0027,"},{"line_number":525,"context_line":"                         novaclient.shell.DEFAULT_OS_COMPUTE_API_VERSION)"},{"line_number":526,"context_line":"        # The default should never be the latest."},{"line_number":527,"context_line":"        self.assertNotEqual(\u00272.latest\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_9dc3b18a","line":524,"updated":"2015-10-01 18:35:39.000000000","message":"This is fragile, and will have to be changed every time we update the version. I think that the second test is all that is needed.","commit_id":"9eeb69da3ebe061b2cdc486ec514347cdf1ebd85"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1af6ef34a6172b336150dae0a59115d6bfdb957a","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        # CLI is the latest (incremental) microversion that we are known to"},{"line_number":522,"context_line":"        # support.  As new incremental microversion support is added, this"},{"line_number":523,"context_line":"        # should be updated."},{"line_number":524,"context_line":"        self.assertEqual(\u00272.5\u0027,"},{"line_number":525,"context_line":"                         novaclient.shell.DEFAULT_OS_COMPUTE_API_VERSION)"},{"line_number":526,"context_line":"        # The default should never be the latest."},{"line_number":527,"context_line":"        self.assertNotEqual(\u00272.latest\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_b8224300","line":524,"in_reply_to":"9a1a9d01_788cab7f","updated":"2015-10-01 19:08:23.000000000","message":"Yeah I understood you were wanting to do like we have for objects unittests... \n\nProbably the docstring you added in __init__.py is sufficient, but I wonder if we should find some way to say \u0027okay, here is the version we support, and we can make sure that it\u0027s okay\u0027.\n\nI\u0027m not very opiniated, I wonder if discovering all the api_versions.wraps() max versions calls could automate this kind of test, but that would be a bit huge.","commit_id":"9eeb69da3ebe061b2cdc486ec514347cdf1ebd85"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9f6b60ca427d99965d4a17ab26e2ef1d5c43a6b4","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        # CLI is the latest (incremental) microversion that we are known to"},{"line_number":522,"context_line":"        # support.  As new incremental microversion support is added, this"},{"line_number":523,"context_line":"        # should be updated."},{"line_number":524,"context_line":"        self.assertEqual(\u00272.5\u0027,"},{"line_number":525,"context_line":"                         novaclient.shell.DEFAULT_OS_COMPUTE_API_VERSION)"},{"line_number":526,"context_line":"        # The default should never be the latest."},{"line_number":527,"context_line":"        self.assertNotEqual(\u00272.latest\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_788cab7f","line":524,"in_reply_to":"9a1a9d01_9d0bb12b","updated":"2015-10-01 18:57:21.000000000","message":"Yeah, this was intentionally static.  I wanted something like what we have for object version changes in nova but those are smarter in that they detect changes w/o a version bump, I\u0027m not sure how to actually do that since we don\u0027t have something like the object registry in the client.  So this might be pointless.\n\nI guess I could add that DEFAULT_OS_COMPUTE_API_VERSION should be \u003c\u003d API_MAX_VERSION.","commit_id":"9eeb69da3ebe061b2cdc486ec514347cdf1ebd85"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"76866b3dfb953956d81f1351ea887f292f52e8b0","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        # CLI is the latest (incremental) microversion that we are known to"},{"line_number":522,"context_line":"        # support.  As new incremental microversion support is added, this"},{"line_number":523,"context_line":"        # should be updated."},{"line_number":524,"context_line":"        self.assertEqual(\u00272.5\u0027,"},{"line_number":525,"context_line":"                         novaclient.shell.DEFAULT_OS_COMPUTE_API_VERSION)"},{"line_number":526,"context_line":"        # The default should never be the latest."},{"line_number":527,"context_line":"        self.assertNotEqual(\u00272.latest\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_9d0bb12b","line":524,"in_reply_to":"9a1a9d01_9dc3b18a","updated":"2015-10-01 18:53:38.000000000","message":"But that\u0027s what we want, no ? I mean, each time we would bump a new version, we would also need to update the test...\n\nOf course, we could perhaps use a test attribute instead of directly changing the value, but that sounds a bit fishy.","commit_id":"9eeb69da3ebe061b2cdc486ec514347cdf1ebd85"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"cf4f8d4e55364658db20f9082af1a647cf846657","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        self.assertFalse(default_version.is_latest())"},{"line_number":524,"context_line":"        # The default should be less than or equal to API_MAX_VERSION."},{"line_number":525,"context_line":"        self.assertLessEqual(default_version, novaclient.API_MAX_VERSION)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"class TestLoadVersionedActions(utils.TestCase):"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_b080058d","line":526,"updated":"2015-10-02 09:28:51.000000000","message":"We could maybe discuss a lot of time about how to test correctly, but I think the above is good enough for being merged, we could refine the logic later.","commit_id":"d045019f0f2d28f26730b3617f7d7b993506b6e8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2b8177cd64d22bdbccc59313ca7f5d40b8d6348a","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        self.assertFalse(default_version.is_latest())"},{"line_number":524,"context_line":"        # The default should be less than or equal to API_MAX_VERSION."},{"line_number":525,"context_line":"        self.assertLessEqual(default_version, novaclient.API_MAX_VERSION)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"class TestLoadVersionedActions(utils.TestCase):"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_4b245cae","line":526,"in_reply_to":"9a1a9d01_b080058d","updated":"2015-10-02 09:33:07.000000000","message":"We had a solid plan, just needs writing down and enforcing I think.","commit_id":"d045019f0f2d28f26730b3617f7d7b993506b6e8"}]}