)]}'
{"id":"openstack%2Fpython-novaclient~230024","triplet_id":"openstack%2Fpython-novaclient~master~I52074f9a3e7faa6a7a51c3fa9766100acf25dee2","project":"openstack/python-novaclient","branch":"master","topic":"bug/1500688","hashtags":[],"change_id":"I52074f9a3e7faa6a7a51c3fa9766100acf25dee2","subject":"Set DEFAULT_OS_COMPUTE_API_VERSION to 2.5","status":"MERGED","created":"2015-10-01 17:17:03.000000000","updated":"2015-10-02 16:25:31.000000000","submitted":"2015-10-02 16:25:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8da09fba8ca03e71ff8dbf19856d4b12858dfeba","_number":230024,"virtual_id_number":230024,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-10-02 16:25:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2015-10-02 13:45:23.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"date":"2015-10-02 09:33:07.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-10-02 15:21:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":2,"date":"2015-10-02 15:25:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":1,"date":"2015-10-02 09:28:51.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":2,"date":"2015-10-02 13:46:43.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":1,"date":"2015-10-02 15:25:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2015-10-01 22:41:40.000000000","_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-01 22:41:40.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"},{"updated":"2015-10-02 09:28:51.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2015-10-02 09:33:07.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2015-10-02 13:46:43.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-10-02 15:21:07.000000000","updated_by":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"reviewer":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"state":"REVIEWER"},{"updated":"2015-10-02 15:25:03.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-10-02 16:25:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"685855bf70bce3f8ffbbdba54f00ad0cf0c72462","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-01 17:17:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2f0905fdc4afa9a725ba7a18399ee9e242975051","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-01 17:17:42.000000000","message":"Patch Set 1: Workflow-1\n\nI still need to run the functional tests.  Wanted to get this out there to make sure it\u0027s the agreed direction.","accounts_in_message":[],"_revision_number":1},{"id":"df98a2741ef328c87651884ce098569f271b9ec2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-01 18:05:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/24/230024/1/check/gate-python-novaclient-python26/622895c/ : SUCCESS in 1m 27s\n- gate-python-novaclient-pep8 http://logs.openstack.org/24/230024/1/check/gate-python-novaclient-pep8/7a95946/ : SUCCESS in 1m 02s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/24/230024/1/check/gate-python-novaclient-docs/08fc299//doc/build/html/ : SUCCESS in 1m 14s\n- gate-python-novaclient-python27 http://logs.openstack.org/24/230024/1/check/gate-python-novaclient-python27/73d0915/ : SUCCESS in 1m 24s\n- gate-python-novaclient-python34 http://logs.openstack.org/24/230024/1/check/gate-python-novaclient-python34/149c373/ : SUCCESS in 2m 05s\n- gate-python-novaclient-pypy http://logs.openstack.org/24/230024/1/check/gate-python-novaclient-pypy/5662924/ : SUCCESS in 2m 10s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/24/230024/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/c045a16/ : SUCCESS in 48m 06s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/24/230024/1/check/gate-novaclient-dsvm-functional/17349ba/ : SUCCESS in 32m 02s","accounts_in_message":[],"_revision_number":1},{"id":"b3d747c3b04930edae25465681383cda305187cc","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-01 18:15:34.000000000","message":"Patch Set 1: -Workflow\n\nfunctional tests are passing","accounts_in_message":[],"_revision_number":1},{"id":"a25b2f45224ea7d1bddd33c0dc5ac65131ba2cd2","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2015-10-01 18:35:39.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"76866b3dfb953956d81f1351ea887f292f52e8b0","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2015-10-01 18:53:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9f6b60ca427d99965d4a17ab26e2ef1d5c43a6b4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-01 18:57:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1af6ef34a6172b336150dae0a59115d6bfdb957a","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2015-10-01 19:08:23.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a72fa079b7af32d3fec951398be65422ef7aa4a3","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2015-10-01 19:21:57.000000000","message":"Patch Set 1:\n\nThe reason you have to update the object tests is because of the inter-dependencies between the objects and the different versions. Let\u0027s say you update the DEFAULT_OS_COMPUTE_API_VERSION to \u0027foo\u0027. If you then change the test to expect \u0027foo\u0027, it will pass, but that doesn\u0027t do squat to ensure that the code is working.","accounts_in_message":[],"_revision_number":1},{"id":"287213574d018414c0f176373976521e7f3013aa","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2015-10-01 19:44:15.000000000","message":"Patch Set 1:\n\nI don\u0027t think I explained the difference well enough. Let\u0027s say you change some code in an object that should require a version bump, but you don\u0027t realize that. It gets merged, and now we\u0027re back where we were before versioning: we don\u0027t know what to expect. The test for the object hash catches that.\n\nNow consider the similar case in this code: what does the test catch? If we do the right thing and bump the value when we add new microversion support, it will fail. If, however, we forget to update the DEFAULT_OS_COMPUTE_API_VERSION as we should, the test will pass! That, IMO, is the very definition of a bad test.","accounts_in_message":[],"_revision_number":1},{"id":"cdb087d0a98cbe79b132406ed78994dd84a0b79e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-01 21:18:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"aed6395b4ad58decfeea4c72c903e3cb6e2908ce","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-01 22:13:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/24/230024/2/check/gate-python-novaclient-python26/c897d15/ : SUCCESS in 1m 34s\n- gate-python-novaclient-pep8 http://logs.openstack.org/24/230024/2/check/gate-python-novaclient-pep8/30b268f/ : SUCCESS in 54s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/24/230024/2/check/gate-python-novaclient-docs/4eba0d0//doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-novaclient-python27 http://logs.openstack.org/24/230024/2/check/gate-python-novaclient-python27/ab2489e/ : SUCCESS in 2m 19s\n- gate-python-novaclient-python34 http://logs.openstack.org/24/230024/2/check/gate-python-novaclient-python34/9d35cba/ : SUCCESS in 1m 44s\n- gate-python-novaclient-pypy http://logs.openstack.org/24/230024/2/check/gate-python-novaclient-pypy/b4b7f14/ : SUCCESS in 2m 48s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/24/230024/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/7c94fa5/ : SUCCESS in 55m 27s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/24/230024/2/check/gate-novaclient-dsvm-functional/9c58ded/ : SUCCESS in 32m 51s","accounts_in_message":[],"_revision_number":2},{"id":"cf4f8d4e55364658db20f9082af1a647cf846657","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2015-10-02 09:28:51.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2b8177cd64d22bdbccc59313ca7f5d40b8d6348a","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2015-10-02 09:33:07.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nSo, does this work when the cloud only supports 2.4, but the client max is 2.5?","accounts_in_message":[],"_revision_number":2},{"id":"a7a5856b67a7e0afc3c2e1a92965491e39a29b9a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-02 13:45:23.000000000","message":"Patch Set 2:\n\n@John, I think we found out that we can\u0027t tell what version the nova-api is because some deployments don\u0027t enable that (RAX was the big one I remember).  So we are basically saying this version of the client can support at least x by default based on what\u0027s available on trunk nova-api today.  But if someone is running a kilo cloud and using this client, the default might not work, in which case they can use the --os-compute-api-version option or OS_COMPUTE_API_VERSION env var.","accounts_in_message":[],"_revision_number":2},{"id":"f6830c1cd06d031825aa763c9ef15abe9f858654","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-02 13:46:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d6672398929caa2608e0bcfbe7f93e4952eb15a6","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2015-10-02 15:21:07.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"a1966360c7d661e66ed1239dff7ca65351c42c42","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-02 15:25:03.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"b6c2aadb0f435e5dca3d843ac4f050c68a8b77ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-02 15:25:31.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"1edcfc1dd64d86170bcac4e0d607bb9faed9ee9a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-02 16:25:31.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/24/230024/2/gate/gate-python-novaclient-python26/a3a78e6/ : SUCCESS in 1m 40s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/24/230024/2/gate/gate-python-novaclient-docs/14561a3//doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-novaclient-pep8 http://logs.openstack.org/24/230024/2/gate/gate-python-novaclient-pep8/7181b44/ : SUCCESS in 1m 02s\n- gate-python-novaclient-python27 http://logs.openstack.org/24/230024/2/gate/gate-python-novaclient-python27/8a4a27f/ : SUCCESS in 1m 28s\n- gate-python-novaclient-python34 http://logs.openstack.org/24/230024/2/gate/gate-python-novaclient-python34/72c49e1/ : SUCCESS in 2m 03s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/24/230024/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient/e9a6a4e/ : SUCCESS in 59m 48s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/24/230024/2/gate/gate-novaclient-dsvm-functional/90dca8e/ : SUCCESS in 39m 53s","accounts_in_message":[],"_revision_number":2},{"id":"da277ddf99acdf5d4ed446b5857b172a95cdfe0e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-02 16:25:31.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d045019f0f2d28f26730b3617f7d7b993506b6e8","revisions":{"9eeb69da3ebe061b2cdc486ec514347cdf1ebd85":{"kind":"REWORK","_number":1,"created":"2015-10-01 17:17:03.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/24/230024/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/24/230024/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/230024/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/230024/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/230024/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/24/230024/1"}}},"commit":{"parents":[{"commit":"abd0630badaff18ca998db2feccb058e8ee75f23","subject":"Always send volume_id when booting with legacy bdm","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/abd0630badaff18ca998db2feccb058e8ee75f23"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-01 16:19:14.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-01 17:16:51.000000000","tz":-420},"subject":"Set DEFAULT_OS_COMPUTE_API_VERSION to 2.5","message":"Set DEFAULT_OS_COMPUTE_API_VERSION to 2.5\n\nThe client currently implements support for microversions 2.2, 2.4 and\n2.11.\n\nAccording the nova API microversion history:\n\nhttp://docs.openstack.org/developer/nova/api_microversion_history.html\n\n2.3 just returns extra attributes in the response so it\u0027s not a problem\nfor the client. We should expose those at some point but it\u0027s not a\nbreaking change.\n\n2.5 is a server-side only change since the client allows filtering\nservers by IPv6 address but the server wasn\u0027t honoring that until 2.5.\nThere are no client side changes for that microversion.\n\n2.6 is the first backwards incompatible microversion since it replaces\nthe old specific console APIs (RDP/serial/SPICE/VNC) with a new generic\nremote-consoles API. The client must be updated to handle this since\nrequesting any microversion \u003e\u003d2.6 for consoles will fail right now. This\nis exposed on the CLI right now because the CLI defaults to the 2.latest\nmicroversion.\n\nSo even though the client actually supports the 2.11 microversion, we\nshouldn\u0027t default to higher than 2.5 because we have gaps in handling\n2.6-\u003e2.10.\n\nThis change fixes the default for the CLI by setting\nDEFAULT_OS_COMPUTE_API_VERSION\u003d2.5.\n\nPartial-Bug: #1500688\n\nChange-Id: I52074f9a3e7faa6a7a51c3fa9766100acf25dee2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9eeb69da3ebe061b2cdc486ec514347cdf1ebd85"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9eeb69da3ebe061b2cdc486ec514347cdf1ebd85"}]},"branch":"refs/heads/master"},"d045019f0f2d28f26730b3617f7d7b993506b6e8":{"kind":"REWORK","_number":2,"created":"2015-10-01 21:18:16.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/24/230024/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/24/230024/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/230024/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/230024/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/230024/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/24/230024/2"}}},"commit":{"parents":[{"commit":"abd0630badaff18ca998db2feccb058e8ee75f23","subject":"Always send volume_id when booting with legacy bdm","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/abd0630badaff18ca998db2feccb058e8ee75f23"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-01 16:19:14.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-01 21:18:05.000000000","tz":-420},"subject":"Set DEFAULT_OS_COMPUTE_API_VERSION to 2.5","message":"Set DEFAULT_OS_COMPUTE_API_VERSION to 2.5\n\nThe client currently implements support for microversions 2.2, 2.4 and\n2.11.\n\nAccording the nova API microversion history:\n\nhttp://docs.openstack.org/developer/nova/api_microversion_history.html\n\n2.3 just returns extra attributes in the response so it\u0027s not a problem\nfor the client. We should expose those at some point but it\u0027s not a\nbreaking change.\n\n2.5 is a server-side only change since the client allows filtering\nservers by IPv6 address but the server wasn\u0027t honoring that until 2.5.\nThere are no client side changes for that microversion.\n\n2.6 is the first backwards incompatible microversion since it replaces\nthe old specific console APIs (RDP/serial/SPICE/VNC) with a new generic\nremote-consoles API. The client must be updated to handle this since\nrequesting any microversion \u003e\u003d2.6 for consoles will fail right now. This\nis exposed on the CLI right now because the CLI defaults to the 2.latest\nmicroversion.\n\nSo even though the client actually supports the 2.11 microversion, we\nshouldn\u0027t default to higher than 2.5 because we have gaps in handling\n2.6-\u003e2.10.\n\nThis change fixes the default for the CLI by setting\nDEFAULT_OS_COMPUTE_API_VERSION\u003d2.5.\n\nPartial-Bug: #1500688\n\nChange-Id: I52074f9a3e7faa6a7a51c3fa9766100acf25dee2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d045019f0f2d28f26730b3617f7d7b993506b6e8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d045019f0f2d28f26730b3617f7d7b993506b6e8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
