)]}'
{"id":"openstack%2Fpython-novaclient~230769","triplet_id":"openstack%2Fpython-novaclient~master~Ife88c163cca1e9544aa8f26549f188ca497177a6","project":"openstack/python-novaclient","branch":"master","topic":"bug/1502522","hashtags":[],"change_id":"Ife88c163cca1e9544aa8f26549f188ca497177a6","subject":"novaclient.v1_1: replace MovedModule with pep302 finder/loader","status":"ABANDONED","created":"2015-10-03 23:09:37.000000000","updated":"2015-10-08 04:01:18.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"01c19767b5a43efc215f3a9918173a2507cbee43","_number":230769,"virtual_id_number":230769,"owner":{"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-1,"date":"2015-10-06 04:53:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},"disliked":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"all":[{"value":-1,"date":"2015-10-07 09:30:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":1,"date":"2015-10-06 03:51:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-05 15:21:10.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-10-06 04:53:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-10-07 09:30:57.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"}],"messages":[{"id":"bc5e74f16d084db998a284833cbcc8ac69f8d042","author":{"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},"date":"2015-10-03 23:09:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"28d124f5a5f6fef4db2160320e6d0c275bd6d871","author":{"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},"date":"2015-10-03 23:16:51.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4e52b212c16f5ad26c38d1f2b20044dfdb328407","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-04 00:31:56.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/69/230769/1/check/gate-python-novaclient-python26/d3ba440/ : SUCCESS in 1m 22s\n- gate-python-novaclient-pep8 http://logs.openstack.org/69/230769/1/check/gate-python-novaclient-pep8/26d5fcb/ : FAILURE in 45s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/69/230769/1/check/gate-python-novaclient-docs/649350a//doc/build/html/ : SUCCESS in 1m 18s\n- gate-python-novaclient-python27 http://logs.openstack.org/69/230769/1/check/gate-python-novaclient-python27/46ddbcf/ : SUCCESS in 1m 35s\n- gate-python-novaclient-python34 http://logs.openstack.org/69/230769/1/check/gate-python-novaclient-python34/6498b04/ : SUCCESS in 1m 40s\n- gate-python-novaclient-pypy http://logs.openstack.org/69/230769/1/check/gate-python-novaclient-pypy/e6d9dbf/ : SUCCESS in 7m 44s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/69/230769/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/c4b74ce/ : SUCCESS in 1h 22m 12s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/69/230769/1/check/gate-novaclient-dsvm-functional/fb3b9e8/ : SUCCESS in 26m 46s","accounts_in_message":[],"_revision_number":1},{"id":"122ca23fa9a7a755292e81b2e0e980f1d8eca665","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-05 15:21:10.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"048b2d6ba481f56c1498046a5787953de63a02b6","author":{"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},"date":"2015-10-06 03:48:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"968495e33334fe533446a7f367d9df17e6456cb0","author":{"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},"date":"2015-10-06 03:51:00.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"2a65ed75dab8cdc1146208f20f865274a05f49da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-06 04:53:46.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/69/230769/2/check/gate-python-novaclient-python26/76cf2f9/ : SUCCESS in 1m 10s\n- gate-python-novaclient-pep8 http://logs.openstack.org/69/230769/2/check/gate-python-novaclient-pep8/971481a/ : FAILURE in 1m 06s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/69/230769/2/check/gate-python-novaclient-docs/6872557//doc/build/html/ : SUCCESS in 1m 24s\n- gate-python-novaclient-python27 http://logs.openstack.org/69/230769/2/check/gate-python-novaclient-python27/55ff810/ : SUCCESS in 1m 59s\n- gate-python-novaclient-python34 http://logs.openstack.org/69/230769/2/check/gate-python-novaclient-python34/72788fa/ : SUCCESS in 2m 12s\n- gate-python-novaclient-pypy http://logs.openstack.org/69/230769/2/check/gate-python-novaclient-pypy/161f22b/ : SUCCESS in 3m 04s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/69/230769/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/3bf00e4/ : SUCCESS in 1h 05m 27s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/69/230769/2/check/gate-novaclient-dsvm-functional/f8e898f/ : SUCCESS in 26m 12s","accounts_in_message":[],"_revision_number":2},{"id":"aa0d8d7d1566403ced34d5c288fc873a31f4509b","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-10-07 09:30:57.000000000","message":"Patch Set 2: Code-Review-1\n\nSince Mitaka is opened, we can remove whole v1_1 module(it was mentioned in Liberty Release notes - https://wiki.openstack.org/wiki/ReleaseNotes/Liberty#Deprecations ). Patch with with re-movement is here - https://review.openstack.org/#/c/217131/ .","accounts_in_message":[],"_revision_number":2},{"id":"852ac300b73fc3f0a786ece1ad72fe13296cffc3","author":{"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},"date":"2015-10-08 04:01:18.000000000","message":"Abandoned\n\nhttps://review.openstack.org/#/c/217131/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"67cfdf47c27cff6e18c627f4496da0e1221c5c16","revisions":{"aa7399c0f4ad96669f38e864ff6a9adb4f93a97b":{"kind":"REWORK","_number":1,"created":"2015-10-03 23:09:37.000000000","uploader":{"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},"ref":"refs/changes/69/230769/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/69/230769/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/230769/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/230769/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/230769/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/69/230769/1"}}},"commit":{"parents":[{"commit":"3697782616fa0dbc9141736e4f6027bf7bb1ea15","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3697782616fa0dbc9141736e4f6027bf7bb1ea15"}]}],"author":{"name":"Zack Buhman","email":"zack@buhman.org","date":"2015-10-03 22:55:02.000000000","tz":-300},"committer":{"name":"Zack Buhman","email":"zack@buhman.org","date":"2015-10-03 23:08:15.000000000","tz":-300},"subject":"novaclient.v1_1: replace MovedModule with pep302 finder/loader","message":"novaclient.v1_1: replace MovedModule with pep302 finder/loader\n\nThe current MovedModule implementation causes the interpreter to create\nmultiple objects for the same source because the each module is loaded\ntwice: once for the novaclient.v2 name, and again for novaclient.v1_1\nname.\n\nOne negative effect of this is that multiple non-equivalent types are\ncreated for the same class definition, depending on the import used.\n\nThis replaces MovedModule with a pep302 finder and loader, which will\nreturn the same v2 module instance for arbitrary v1_1 names.\n\nCloses-Bug: #1502522\nChange-Id: Ife88c163cca1e9544aa8f26549f188ca497177a6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa7399c0f4ad96669f38e864ff6a9adb4f93a97b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa7399c0f4ad96669f38e864ff6a9adb4f93a97b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3697782616fa0dbc9141736e4f6027bf7bb1ea15","is_merged_in_target_branch":true,"change_id":"I3fcd0aa48f225b311ad4d64e355e059983944b58","change_number":230583,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"67cfdf47c27cff6e18c627f4496da0e1221c5c16":{"kind":"REWORK","_number":2,"created":"2015-10-06 03:48:12.000000000","uploader":{"_account_id":18682,"name":"Zack Buhman","email":"zack@buhman.org","username":"buhman"},"ref":"refs/changes/69/230769/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/69/230769/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/230769/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/230769/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/69/230769/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/69/230769/2"}}},"commit":{"parents":[{"commit":"3697782616fa0dbc9141736e4f6027bf7bb1ea15","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3697782616fa0dbc9141736e4f6027bf7bb1ea15"}]}],"author":{"name":"Zack Buhman","email":"zack@buhman.org","date":"2015-10-03 22:55:02.000000000","tz":-300},"committer":{"name":"Zack Buhman","email":"zack@buhman.org","date":"2015-10-06 03:47:58.000000000","tz":-300},"subject":"novaclient.v1_1: replace MovedModule with pep302 finder/loader","message":"novaclient.v1_1: replace MovedModule with pep302 finder/loader\n\nThe current MovedModule implementation causes the interpreter to create\nmultiple objects for the same source because the each module is loaded\ntwice: once for the novaclient.v2 name, and again for novaclient.v1_1\nname.\n\nOne negative effect of this is that multiple non-equivalent types are\ncreated for the same class definition, depending on the import used.\n\nThis replaces MovedModule with a pep302 finder and loader, which will\nreturn the same v2 module instance for arbitrary v1_1 names.\n\nCloses-Bug: #1502522\nChange-Id: Ife88c163cca1e9544aa8f26549f188ca497177a6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/67cfdf47c27cff6e18c627f4496da0e1221c5c16"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/67cfdf47c27cff6e18c627f4496da0e1221c5c16"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3697782616fa0dbc9141736e4f6027bf7bb1ea15","is_merged_in_target_branch":true,"change_id":"I3fcd0aa48f225b311ad4d64e355e059983944b58","change_number":230583,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
