)]}'
{"id":"openstack%2Fpython-novaclient~230965","triplet_id":"openstack%2Fpython-novaclient~master~Ic68690b3d985d78ba0312bf5421989ccba7ceea8","project":"openstack/python-novaclient","branch":"master","topic":"bug/1502866","hashtags":[],"change_id":"Ic68690b3d985d78ba0312bf5421989ccba7ceea8","subject":"Check flavor option before image checks","status":"MERGED","created":"2015-10-05 11:47:19.000000000","updated":"2015-11-12 17:02:01.000000000","submitted":"2015-11-12 17:01:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fbc62ce9d594c1264c94f21bdc65a3f274f103a7","_number":230965,"virtual_id_number":230965,"owner":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},{"value":0,"date":"2015-11-10 19:10:11.000000000","_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2015-11-12 17:01:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"date":"2015-10-27 06:31:40.000000000","_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":16935,"name":"Pramod Raghavendra Jayathirth","email":"pramod.raghavendra.jayathirth@intel.com","username":"pramod.rj07"},{"value":0,"date":"2015-11-12 14:36:28.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2015-10-27 09:25:20.000000000","_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},"all":[{"value":1,"date":"2015-11-04 23:27:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":2,"date":"2015-10-27 15:58:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2015-11-12 15:33:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16935,"name":"Pramod Raghavendra Jayathirth","email":"pramod.raghavendra.jayathirth@intel.com","username":"pramod.rj07"},{"value":2,"date":"2015-11-12 15:05:03.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":16935,"name":"Pramod Raghavendra Jayathirth","email":"pramod.raghavendra.jayathirth@intel.com","username":"pramod.rj07"},{"value":1,"date":"2015-11-12 15:05:03.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":16935,"name":"Pramod Raghavendra Jayathirth","email":"pramod.raghavendra.jayathirth@intel.com","username":"pramod.rj07"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":16935,"name":"Pramod Raghavendra Jayathirth","email":"pramod.raghavendra.jayathirth@intel.com","username":"pramod.rj07"},{"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-05 11:47:30.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2015-10-23 12:30:13.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-10-27 06:31:40.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2015-10-27 15:58:05.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-11-04 23:27:58.000000000","updated_by":{"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},"reviewer":{"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},"state":"REVIEWER"},{"updated":"2015-11-10 19:10:11.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2015-11-12 15:05:03.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2015-11-12 15:33:59.000000000","updated_by":{"_account_id":16935,"name":"Pramod Raghavendra Jayathirth","email":"pramod.raghavendra.jayathirth@intel.com","username":"pramod.rj07"},"reviewer":{"_account_id":16935,"name":"Pramod Raghavendra Jayathirth","email":"pramod.raghavendra.jayathirth@intel.com","username":"pramod.rj07"},"state":"REVIEWER"},{"updated":"2015-11-12 17:01:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c854d7e16695b547968cebe4ffbd4ea75a14064f","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2015-10-05 11:47:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"abdedba60ccef971b4179a4fc0c8c4446a97f18a","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2015-10-05 11:47:30.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"fd3b86a06b5c271959ff6f82cf1b7ab0c234d1c8","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2015-10-05 12:02:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d5655ea454b1bd7c85620cfaddc4fc88ee199ba1","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2015-10-05 12:06:10.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"33c859d0e38845964e8c8bbb6eccaa47f800f1e2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-05 12:59:45.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/65/230965/3/check/gate-python-novaclient-python26/0d08390/ : SUCCESS in 1m 27s\n- gate-python-novaclient-pep8 http://logs.openstack.org/65/230965/3/check/gate-python-novaclient-pep8/7d9dfca/ : SUCCESS in 52s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/65/230965/3/check/gate-python-novaclient-docs/4ad91bf//doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-novaclient-python27 http://logs.openstack.org/65/230965/3/check/gate-python-novaclient-python27/03b6341/ : SUCCESS in 1m 19s\n- gate-python-novaclient-python34 http://logs.openstack.org/65/230965/3/check/gate-python-novaclient-python34/ea72a77/ : SUCCESS in 2m 06s\n- gate-python-novaclient-pypy http://logs.openstack.org/65/230965/3/check/gate-python-novaclient-pypy/e8000c2/ : SUCCESS in 2m 06s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/65/230965/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/effd2be/ : SUCCESS in 53m 08s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/65/230965/3/check/gate-novaclient-dsvm-functional/560aa37/ : SUCCESS in 28m 26s","accounts_in_message":[],"_revision_number":3},{"id":"6b11447f34803d0cc28582926777079d0c9456bb","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-05 15:29:49.000000000","message":"Patch Set 3:\n\nI\u0027m conflicted on this one.  Normally I advocate using positional arguments for items that are required, though obviously this did not use that convention before.  Also, there are so many options to the boot command that adding another required argument may become unwieldy…\n\nWould love to hear thoughts from other reviewers on this one; do we change this (in a backwards-compatible way) to listing a positional argument for flavor, or do we stick with making a required option?","accounts_in_message":[],"_revision_number":3},{"id":"87c502170c5cb14bc0b3ac6603bb7fab8231c7d5","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2015-10-07 16:30:07.000000000","message":"Patch Set 3: Code-Review-1\n\nOf the 4600+ lines in shell.py, there is currently only one `required\u003dTrue`.\n\nhttps://github.com/openstack/python-novaclient/blob/03f1f67ccde6f495e264da08f0bb7d707cf3ff66/novaclient/v2/shell.py#L4194\n\nNote how it behaves (calling \u0027tenant\u0027 both \u0027required\u0027 and \u0027optional\u0027 which is confusing):\n\n$ nova help quota-delete\nusage: nova quota-delete --tenant \u003ctenant-id\u003e [--user \u003cuser-id\u003e]\n\nDelete quota for a tenant/user so their quota will Revert back to default.\n\nOptional arguments:\n  --tenant \u003ctenant-id\u003e  ID of tenant to delete quota for.\n  --user \u003cuser-id\u003e      ID of user to delete quota for.\n\n$ nova quota-delete\nusage: nova quota-delete --tenant \u003ctenant-id\u003e [--user \u003cuser-id\u003e]\nerror: argument --tenant is required\n\nAlso note the tip from the Python docs:\n\nhttps://docs.python.org/3/library/argparse.html#required\n\n\"Required options are generally considered bad form because users expect options to be optional, and thus they should be avoided when possible.\"\n\nI don\u0027t think we should introduce a second `required\u003dTrue` in this case.","accounts_in_message":[],"_revision_number":3},{"id":"49f6128963125bff68c8cc14378da7bc9d4f5569","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2015-10-07 16:33:42.000000000","message":"Patch Set 3:\n\nThat one example didn\u0027t cut \u0026 paste properly. Trying again:\n\n$ nova quota-delete\nusage: nova quota-delete --tenant \u003ctenant-id\u003e [--user \u003cuser-id\u003e]\nerror: argument --tenant is required","accounts_in_message":[],"_revision_number":3},{"id":"362c4643c1fd6da91fa25ec3c649ac14cfd25b75","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2015-10-07 16:40:14.000000000","message":"Patch Set 3:\n\nWell that\u0027s frustrating (the formatting in the comment).\n\nHere\u0027s the command line example using pastebin instead:\n\n    http://paste.openstack.org/show/475635/\n\nNote that it says \u0027tenant\u0027 is \"optional\" in the first help message, but \"required\" in the second help message.\n\nAnd that\u0027s using `required\u003dTrue`.","accounts_in_message":[],"_revision_number":3},{"id":"66db696e9985d9caece6b89879102ba26ebfe9c0","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-07 17:13:41.000000000","message":"Patch Set 3:\n\nDiana: You can indent examples in your comments to get proper formatting:\n\n    $ nova quota-delete\n    usage: nova quota-delete --tenant \u003ctenant-id\u003e [--user \u003cuser-id\u003e]\n    error: argument --tenant is required","accounts_in_message":[],"_revision_number":3},{"id":"565a4ae9d59de3b3c99f24e3287ea6b8855854cb","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2015-10-07 17:14:32.000000000","message":"Patch Set 3:\n\nMuch better. Thanks a ton, Kevin!","accounts_in_message":[],"_revision_number":3},{"id":"331b7a107e655f5911a1b94ba892c9e6bd139ced","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2015-10-09 13:10:25.000000000","message":"Patch Set 3:\n\nAnother approach is that we can check whether flavor is specified or not before [1] to avoid unnecessary image available check. Please let me know your suggestion on the same.\n\n\n[1] https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L153","accounts_in_message":[],"_revision_number":3},{"id":"5361e6f1e00d06998c1bd11f14b2549e11294a78","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-23 12:30:13.000000000","message":"Patch Set 3: Code-Review-1\n\n@ravi - I\u0027d like that check before image approach better\n\n@diana - whether upstream python believes in required args doesn\u0027t mean that they aren\u0027t required here. Flavor definitely is during boot.\n\n@kevin - positional args only really make sense if they are of the same type. Otherwise they require far too much thinking, and are likely to get fat fingered in scripts. So I really don\u0027t want to go to positional args here.","accounts_in_message":[],"_revision_number":3},{"id":"a075e27751912136d3899aa1ef35c36d9b3a3323","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2015-10-27 06:22:45.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"a00087ac89c10bb71ac3237a4f9d94d6a9d7ce8b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-27 06:28:42.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-python26/1e2a437/ : SUCCESS in 1m 30s\n- gate-python-novaclient-pep8 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-pep8/5d9b0b4/ : NOT_REGISTERED\n- gate-python-novaclient-docs http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-docs/683e2fc/ : NOT_REGISTERED\n- gate-python-novaclient-python27 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-python27/a37ffb6/ : NOT_REGISTERED\n- gate-python-novaclient-python34 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-python34/af838ee/ : NOT_REGISTERED\n- gate-python-novaclient-pypy http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-pypy/aa3e194/ : NOT_REGISTERED (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/65/230965/4/check/gate-tempest-dsvm-neutron-src-python-novaclient/01f405a/ : NOT_REGISTERED\n- gate-novaclient-dsvm-functional http://logs.openstack.org/65/230965/4/check/gate-novaclient-dsvm-functional/e97f617/ : NOT_REGISTERED","accounts_in_message":[],"_revision_number":4},{"id":"52ba6e48dfea1b0b5d9c087573b3dcad1d1dc5c7","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2015-10-27 06:31:40.000000000","message":"Patch Set 4:\n\nrechek","accounts_in_message":[],"_revision_number":4},{"id":"8a63e6d5e693302a05fb9c85f70091952028fc30","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2015-10-27 09:25:20.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"b16175a5e6144e8135eed9304d261bdab2df44a0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-27 09:31:00.000000000","message":"Patch Set 4:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-python26/22cd64c/ : SUCCESS in 1m 28s\n- gate-python-novaclient-pep8 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-pep8/d2b7e8d/ : NOT_REGISTERED\n- gate-python-novaclient-docs http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-docs/5da8510/ : NOT_REGISTERED\n- gate-python-novaclient-python27 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-python27/35a9765/ : NOT_REGISTERED\n- gate-python-novaclient-python34 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-python34/305bb2c/ : NOT_REGISTERED\n- gate-python-novaclient-pypy http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-pypy/9838b50/ : NOT_REGISTERED (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/65/230965/4/check/gate-tempest-dsvm-neutron-src-python-novaclient/d07c79a/ : NOT_REGISTERED\n- gate-novaclient-dsvm-functional http://logs.openstack.org/65/230965/4/check/gate-novaclient-dsvm-functional/d0f1c69/ : NOT_REGISTERED","accounts_in_message":[],"_revision_number":4},{"id":"4cd91f2d17318a63c1af169f5f79ce2173613b1a","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2015-10-27 12:04:55.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"c44a98e54073854b8242c7e569cf878e1e4d2ccd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-27 12:56:41.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-python26/219cc52/ : SUCCESS in 1m 18s\n- gate-python-novaclient-pep8 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-pep8/f0259da/ : SUCCESS in 58s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/65/230965/4/check/gate-python-novaclient-docs/a04a580//doc/build/html/ : SUCCESS in 1m 20s\n- gate-python-novaclient-python27 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-python27/8d4e5c2/ : SUCCESS in 1m 35s\n- gate-python-novaclient-python34 http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-python34/9c88765/ : SUCCESS in 2m 07s\n- gate-python-novaclient-pypy http://logs.openstack.org/65/230965/4/check/gate-python-novaclient-pypy/ada4740/ : SUCCESS in 1m 56s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/65/230965/4/check/gate-tempest-dsvm-neutron-src-python-novaclient/97362b9/ : SUCCESS in 51m 40s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/65/230965/4/check/gate-novaclient-dsvm-functional/d10e210/ : SUCCESS in 34m 59s","accounts_in_message":[],"_revision_number":4},{"id":"639bdf7d4a3c9486dc29044e3b1efcf55bbb7ecb","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-27 15:58:05.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"c1f75b0ca4f5c069ba2eebb54f4e255732382617","author":{"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},"date":"2015-11-04 23:27:58.000000000","message":"Patch Set 4: Code-Review+1\n\nA small fix that makes a huge difference! And it looks like this is your first patch? Congrats!!","accounts_in_message":[],"_revision_number":4},{"id":"7c18f74e3b055053fb19156416a053a599be524c","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-11-10 19:10:11.000000000","message":"Patch Set 4:\n\nThis makes sense but to me it seems like it would be less error prone to add required\u003dTrue to the --flavor option and remove the manual check altogether","accounts_in_message":[],"_revision_number":4},{"id":"64c01b51ee95b62e15938570e364bb1465a39cf1","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-11-12 14:36:28.000000000","message":"Patch Set 4:\n\nI tend to agree with melwitt, why not just add required\u003dTrue to the --flavor option on do_boot and remove the manual check?","accounts_in_message":[],"_revision_number":4},{"id":"1ff8d4895e3998fe6b730bcd743a0ba84de72130","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-11-12 15:05:03.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nWe\u0027re going to cut 2.35.0 today so while this could be better, let\u0027s just get this in now before 3.0. We can make it better using required\u003dTrue later.","accounts_in_message":[],"_revision_number":4},{"id":"4ed071c4974f45bd2ab49fc3c26b3d458e6a01bc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-12 15:31:44.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"44559b8767c3f1dbb6c592b0d60cdd702c94c212","author":{"_account_id":16935,"name":"Pramod Raghavendra Jayathirth","email":"pramod.raghavendra.jayathirth@intel.com","username":"pramod.rj07"},"date":"2015-11-12 15:33:59.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"8f446205e803021c968760d33c9cb2aab8178833","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-12 17:01:59.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/65/230965/4/gate/gate-python-novaclient-python26/2730d77/ : SUCCESS in 1m 49s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/65/230965/4/gate/gate-python-novaclient-docs/e37ec6a//doc/build/html/ : SUCCESS in 1m 43s\n- gate-python-novaclient-pep8 http://logs.openstack.org/65/230965/4/gate/gate-python-novaclient-pep8/b28821b/ : SUCCESS in 58s\n- gate-python-novaclient-python27 http://logs.openstack.org/65/230965/4/gate/gate-python-novaclient-python27/e32f61f/ : SUCCESS in 2m 08s\n- gate-python-novaclient-python34 http://logs.openstack.org/65/230965/4/gate/gate-python-novaclient-python34/4522fc1/ : SUCCESS in 3m 42s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/65/230965/4/gate/gate-tempest-dsvm-neutron-src-python-novaclient/d34180f/ : SUCCESS in 1h 10m 28s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/65/230965/4/gate/gate-novaclient-dsvm-functional/bfea562/ : SUCCESS in 38m 50s","accounts_in_message":[],"_revision_number":4},{"id":"7acb982fef4a30be9bd16721670d7c001e53d0a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-12 17:02:01.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"c6a3c766ee336a6ba873b041a5ec5711a20a911a","revisions":{"594b63515d2883340f8127424815a26822819c5e":{"kind":"REWORK","_number":1,"created":"2015-10-05 11:47:19.000000000","uploader":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"ref":"refs/changes/65/230965/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/65/230965/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/1"}}},"commit":{"parents":[{"commit":"3697782616fa0dbc9141736e4f6027bf7bb1ea15","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3697782616fa0dbc9141736e4f6027bf7bb1ea15"}]}],"author":{"name":"Ravi Shekhar Jethani","email":"ravishekar.jethani@nttdata.com","date":"2015-09-30 06:58:09.000000000","tz":-420},"committer":{"name":"Ravi Shekhar Jethani","email":"ravishekar.jethani@nttdata.com","date":"2015-10-05 11:37:37.000000000","tz":-420},"subject":"Add required\u003dTrue in flavor option","message":"Add required\u003dTrue in flavor option\n\nFor boot command flavor option is mandatory. Currently this is checked\nusing if condition. A better way of doing this check is to add\nrequired\u003dTrue to flavor config option (arg decorator).This is\nalso the more efficient way as it will avoid unnecessary image\navailable check\n\nCloses bug: #1502866\nChange-Id: Ic68690b3d985d78ba0312bf5421989ccba7ceea8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/594b63515d2883340f8127424815a26822819c5e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/594b63515d2883340f8127424815a26822819c5e"}]},"branch":"refs/heads/master"},"53ebc99cc65362ac9a22bbf0eddacc595bc37b34":{"kind":"REWORK","_number":2,"created":"2015-10-05 12:02:31.000000000","uploader":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"ref":"refs/changes/65/230965/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/65/230965/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/2"}}},"commit":{"parents":[{"commit":"3697782616fa0dbc9141736e4f6027bf7bb1ea15","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3697782616fa0dbc9141736e4f6027bf7bb1ea15"}]}],"author":{"name":"Ravi Shekhar Jethani","email":"ravishekar.jethani@nttdata.com","date":"2015-09-30 06:58:09.000000000","tz":-420},"committer":{"name":"Ravi Shekhar Jethani","email":"ravishekar.jethani@nttdata.com","date":"2015-10-05 11:58:48.000000000","tz":-420},"subject":"Add required\u003dTrue in flavor option","message":"Add required\u003dTrue in flavor option\n\nFor boot command flavor option is mandatory. Currently this is checked\nusing if condition. A better way of doing this check is to add\nrequired\u003dTrue to flavor config option (arg decorator).This is\nalso the more efficient way as it will avoid unnecessary image\navailable check\n\nCloses-bug: #1502866\nChange-Id: Ic68690b3d985d78ba0312bf5421989ccba7ceea8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/53ebc99cc65362ac9a22bbf0eddacc595bc37b34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/53ebc99cc65362ac9a22bbf0eddacc595bc37b34"}]},"branch":"refs/heads/master"},"7d20410f92585a4409dd62ecd6dafdeae8678a17":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2015-10-05 12:06:10.000000000","uploader":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"ref":"refs/changes/65/230965/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/65/230965/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/3"}}},"commit":{"parents":[{"commit":"3697782616fa0dbc9141736e4f6027bf7bb1ea15","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3697782616fa0dbc9141736e4f6027bf7bb1ea15"}]}],"author":{"name":"Ravi Shekhar Jethani","email":"ravishekar.jethani@nttdata.com","date":"2015-09-30 06:58:09.000000000","tz":-420},"committer":{"name":"Ravi Shekhar Jethani","email":"ravishekar.jethani@nttdata.com","date":"2015-10-05 12:05:13.000000000","tz":-420},"subject":"Add required\u003dTrue in flavor option","message":"Add required\u003dTrue in flavor option\n\nFor boot command flavor option is mandatory. Currently this is checked\nusing if condition. A better way of doing this check is to add\nrequired\u003dTrue to flavor config option (arg decorator).This is\nalso the more efficient way as it will avoid unnecessary image\navailable check\n\nCloses-Bug: #1502866\nChange-Id: Ic68690b3d985d78ba0312bf5421989ccba7ceea8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7d20410f92585a4409dd62ecd6dafdeae8678a17"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7d20410f92585a4409dd62ecd6dafdeae8678a17"}]},"branch":"refs/heads/master"},"c6a3c766ee336a6ba873b041a5ec5711a20a911a":{"kind":"REWORK","_number":4,"created":"2015-10-27 06:22:45.000000000","uploader":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"ref":"refs/changes/65/230965/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/65/230965/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/65/230965/4"}}},"commit":{"parents":[{"commit":"217e7c184907ab80b33fb7eb378de162f8976114","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/217e7c184907ab80b33fb7eb378de162f8976114"}]}],"author":{"name":"Ravi Shekhar Jethani","email":"ravishekar.jethani@nttdata.com","date":"2015-09-30 06:58:09.000000000","tz":-420},"committer":{"name":"Ravi Shekhar Jethani","email":"ravishekar.jethani@nttdata.com","date":"2015-10-27 06:14:27.000000000","tz":-420},"subject":"Check flavor option before image checks","message":"Check flavor option before image checks\n\nCurrently flavor option is checked after performing the image checks\nwhich results in unnecessary image checks even if flavor option is\nnot passed at all. Moved flavor option check at the beginning of the\nmethod to eliminate the expensive operations performed as part of\nimage check.\n\nCloses-Bug: #1502866\nChange-Id: Ic68690b3d985d78ba0312bf5421989ccba7ceea8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c6a3c766ee336a6ba873b041a5ec5711a20a911a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c6a3c766ee336a6ba873b041a5ec5711a20a911a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}