)]}'
{"novaclient/tests/functional/v2/legacy/test_readonly_nova.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"8b8cbea9bdee4b3a00c6d7cf3c8cc6a8a9bdddab","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        self.nova(\u0027list\u0027, flags\u003d\u0027--debug\u0027)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def test_admin_timeout(self):"},{"line_number":182,"context_line":"        self.nova(\u0027list\u0027, flags\u003d\u0027--timeout %d\u0027 % 60)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_admin_timing(self):"},{"line_number":185,"context_line":"        self.nova(\u0027list\u0027, flags\u003d\u0027--timing\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_368f1b25","line":182,"updated":"2015-10-13 18:45:55.000000000","message":"Hrm…so why are we using a substitution here at all?  Why not hard-code the value in the string?  Alternatively, why not define the timeout as a constant and substitute the constant rather than the hard-coded 60 (or 10)?\n\nJust musings.  If you need to respin the patch, I\u0027d recommend folding the 60 into the string, but for now, +2…","commit_id":"afaa8a2d1ea601ec4beae33dd012b03fa38f74f1"}]}