)]}'
{"id":"openstack%2Fpython-novaclient~235558","triplet_id":"openstack%2Fpython-novaclient~master~Iec7247b715c38c29910b30e76413cead4e951a37","project":"openstack/python-novaclient","branch":"master","topic":"bug/1406586","hashtags":[],"change_id":"Iec7247b715c38c29910b30e76413cead4e951a37","subject":"Do not expose exceptions from requests library","status":"MERGED","created":"2015-10-15 19:21:05.000000000","updated":"2015-10-28 14:25:38.000000000","submitted":"2015-10-23 12:56:11.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":28,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2673d89fe5e37d561a014b51953d15bdeab71b09","_number":235558,"virtual_id_number":235558,"owner":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},{"value":2,"date":"2015-10-23 12:56:11.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},{"value":0,"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"date":"2015-10-28 14:03:57.000000000","post_submit":true,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":1,"date":"2015-10-23 12:18:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"value":2,"date":"2015-10-22 19:52:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2015-10-22 19:59:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},{"value":0,"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":1,"date":"2015-10-22 20:31:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},{"value":2,"date":"2015-10-23 11:44:50.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},{"value":0,"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},{"value":1,"date":"2015-10-23 11:44:50.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},{"value":0,"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-19 21:29:55.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2015-10-21 18:01:12.000000000","updated_by":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"reviewer":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"state":"REVIEWER"},{"updated":"2015-10-21 21:39:31.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2015-10-22 19:52:17.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-10-22 19:59:55.000000000","updated_by":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"reviewer":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"state":"REVIEWER"},{"updated":"2015-10-22 20:31:49.000000000","updated_by":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"reviewer":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"state":"REVIEWER"},{"updated":"2015-10-23 11:44:50.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-10-23 12:18:26.000000000","updated_by":{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},"reviewer":{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},"state":"REVIEWER"},{"updated":"2015-10-23 12:56:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-10-28 14:03:57.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"}],"messages":[{"id":"a95080087a73a24c698944d2bd3d15a2e4b796d7","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-15 19:21:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9f3a5bea327e3ff8b3023031f76a6983c2589065","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-15 20:00:20.000000000","message":"Patch Set 1:\n\nWhy?  The Python philosophy in general is, let exceptions bubble up.  I\u0027m not saying I\u0027m against this, but I want to see an explanation for why we should rewrite all requests exceptions…","accounts_in_message":[],"_revision_number":1},{"id":"83f066b3cfc152f7227fee2ec3f35d5b5ed13ffb","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-15 20:03:22.000000000","message":"Patch Set 1:\n\nHi Kevin,\n\nPlease see Melanie\u0027s explanation in the bug report:\n\n\"if for some reason novaclient switched to a different underlying library than requests, the person\u0027s code would continue to work because they handle novaclient exceptions, not requests exceptions.\"","accounts_in_message":[],"_revision_number":1},{"id":"30075250abf86df4284d9eff794898f78e3de597","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-15 20:18:41.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nOK, I don\u0027t see us switching from requests anytime soon, but I can see the argument for requests being an implementation detail.  That said, I don\u0027t expect this to pass unit tests (see in-line for an explanation)…\n\n(Also note that functional tests are failing for everybody right now…)","accounts_in_message":[],"_revision_number":1},{"id":"a8c4dc8a66952d7fb929347c1f82c8f13049cdc9","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-15 20:32:27.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nThanks","accounts_in_message":[],"_revision_number":1},{"id":"fe924c3b6b9c02d7f143f19343026c05b8879817","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-15 20:32:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4b13928ed3a9b6b66a6cd81db30d5de7f57ce2fc","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-15 21:03:30.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"40942909829a57fe470b05cfe888911a4853f6dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-15 22:11:25.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/58/235558/2/check/gate-python-novaclient-python26/199ba70/ : SUCCESS in 1m 30s\n- gate-python-novaclient-pep8 http://logs.openstack.org/58/235558/2/check/gate-python-novaclient-pep8/a40c522/ : SUCCESS in 30s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/58/235558/2/check/gate-python-novaclient-docs/09b6921//doc/build/html/ : SUCCESS in 49s\n- gate-python-novaclient-python27 http://logs.openstack.org/58/235558/2/check/gate-python-novaclient-python27/1c6d3fb/ : SUCCESS in 1m 34s\n- gate-python-novaclient-python34 http://logs.openstack.org/58/235558/2/check/gate-python-novaclient-python34/b4f607c/ : SUCCESS in 1m 56s\n- gate-python-novaclient-pypy http://logs.openstack.org/58/235558/2/check/gate-python-novaclient-pypy/805206a/ : FAILURE in 2m 31s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/58/235558/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/6db0865/ : SUCCESS in 53m 13s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/58/235558/2/check/gate-novaclient-dsvm-functional/3f0d757/ : FAILURE in 29m 23s","accounts_in_message":[],"_revision_number":2},{"id":"24f005f36695729c2cdc04d0fffde7e0895a4afe","author":{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},"date":"2015-10-16 02:06:49.000000000","message":"Patch Set 2: Code-Review+1\n\nNice","accounts_in_message":[],"_revision_number":2},{"id":"e60b330fe019576e919f7191a8fb32108d268d69","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-10-16 07:57:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"458f75b45039e068898a73a743f3451207631979","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-16 14:23:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b076075d4b381f296110ae96e529466f82d15dc5","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-16 14:24:32.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0390eb88c0f9073c142682b6cc92874d16e77af1","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-16 15:33:11.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"6a9a0efafc57e4485c2723055a8dbfe0a5f77878","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-16 15:48:13.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/58/235558/3/check/gate-python-novaclient-python26/b7129bf/ : SUCCESS in 1m 37s\n- gate-python-novaclient-pep8 http://logs.openstack.org/58/235558/3/check/gate-python-novaclient-pep8/382d99e/ : SUCCESS in 54s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/58/235558/3/check/gate-python-novaclient-docs/81d04b4//doc/build/html/ : SUCCESS in 1m 17s\n- gate-python-novaclient-python27 http://logs.openstack.org/58/235558/3/check/gate-python-novaclient-python27/902306a/ : SUCCESS in 1m 33s\n- gate-python-novaclient-python34 http://logs.openstack.org/58/235558/3/check/gate-python-novaclient-python34/8619622/ : SUCCESS in 1m 54s\n- gate-python-novaclient-pypy http://logs.openstack.org/58/235558/3/check/gate-python-novaclient-pypy/37ecc40/ : SUCCESS in 2m 07s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/58/235558/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/b7a27cf/ : SUCCESS in 1h 05m 28s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/58/235558/3/check/gate-novaclient-dsvm-functional/5d84377/ : FAILURE in 41m 36s","accounts_in_message":[],"_revision_number":3},{"id":"3cbdf146f0b4b2a0112701005be7897dcaa691fe","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2015-10-19 14:19:56.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"d714da44376208c6001385dae7ce19bd78287071","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-19 15:44:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/58/235558/3/check/gate-python-novaclient-python26/2f1c25d/ : SUCCESS in 1m 47s\n- gate-python-novaclient-pep8 http://logs.openstack.org/58/235558/3/check/gate-python-novaclient-pep8/72702bb/ : SUCCESS in 1m 12s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/58/235558/3/check/gate-python-novaclient-docs/293498c//doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-novaclient-python27 http://logs.openstack.org/58/235558/3/check/gate-python-novaclient-python27/34ec70b/ : SUCCESS in 1m 51s\n- gate-python-novaclient-python34 http://logs.openstack.org/58/235558/3/check/gate-python-novaclient-python34/cf62ddc/ : SUCCESS in 2m 07s\n- gate-python-novaclient-pypy http://logs.openstack.org/58/235558/3/check/gate-python-novaclient-pypy/5432806/ : SUCCESS in 2m 25s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/58/235558/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/866a69b/ : SUCCESS in 1h 07m 54s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/58/235558/3/check/gate-novaclient-dsvm-functional/8c48267/ : SUCCESS in 34m 23s","accounts_in_message":[],"_revision_number":3},{"id":"4f5a34facdb0c1e29a714857d3325d966ef8d768","author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"date":"2015-10-19 20:26:51.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"f771d10347ea82bf3732240c566d4fee0d5ac19f","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-10-19 21:29:55.000000000","message":"Patch Set 3: Code-Review+1\n\nLGTM, Thanks","accounts_in_message":[],"_revision_number":3},{"id":"2c11189e4ec4e06e9bf3eb34a764890f236d2192","author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"date":"2015-10-19 23:31:01.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"e815f67f0e7798f69d4c466430b1c30bd661c8cf","author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"date":"2015-10-21 18:01:12.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"777b69c9a3621222c2cc40928544131771c397d5","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-10-21 21:39:31.000000000","message":"Patch Set 3: Code-Review-1\n\n(11 comments)","accounts_in_message":[],"_revision_number":3},{"id":"f128e190bceca6d4c27fbf910722a36774afbcc5","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-10-21 21:40:39.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"a05c68d1d19881db3f864c50fc6f12ece7431a21","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-22 19:34:02.000000000","message":"Patch Set 3:\n\n(12 comments)","accounts_in_message":[],"_revision_number":3},{"id":"5763563cebe3ece62a7e28ff794b0ce3506872d9","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-22 19:37:41.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"1144e4bbd0fed4ea7ad6ee44c8f2787661582df1","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-22 19:52:17.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"41cee14b9132c47d006d68ce378957deb9429d10","author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"date":"2015-10-22 19:59:55.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"d1cc88a00b2b80da924513a3c66548d7790afa49","author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"date":"2015-10-22 20:31:49.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"d0006c5291550ff8d1888c8664c38d53f01947fd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-22 20:32:15.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/58/235558/4/check/gate-python-novaclient-python26/366ed89/ : SUCCESS in 1m 32s\n- gate-python-novaclient-pep8 http://logs.openstack.org/58/235558/4/check/gate-python-novaclient-pep8/0701c13/ : SUCCESS in 56s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/58/235558/4/check/gate-python-novaclient-docs/4ab627a//doc/build/html/ : SUCCESS in 1m 21s\n- gate-python-novaclient-python27 http://logs.openstack.org/58/235558/4/check/gate-python-novaclient-python27/ac3e26a/ : SUCCESS in 1m 52s\n- gate-python-novaclient-python34 http://logs.openstack.org/58/235558/4/check/gate-python-novaclient-python34/ac71d6e/ : SUCCESS in 2m 11s\n- gate-python-novaclient-pypy http://logs.openstack.org/58/235558/4/check/gate-python-novaclient-pypy/de0818c/ : SUCCESS in 2m 51s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/58/235558/4/check/gate-tempest-dsvm-neutron-src-python-novaclient/082c87d/ : SUCCESS in 53m 35s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/58/235558/4/check/gate-novaclient-dsvm-functional/d165f22/ : SUCCESS in 33m 04s","accounts_in_message":[],"_revision_number":4},{"id":"61fc47613baf7eca5df76e88b16d2abfd471d061","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-23 11:44:50.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"96609648e7c8070531d1ca4fb66d5b81552bfb12","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-23 11:48:04.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"c5f11901604e13f15b9995b0eb8937fc1d0ea074","author":{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},"date":"2015-10-23 12:18:26.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"65be513e3b7290e41ea711ec250e4b8b8e610d84","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-23 12:56:11.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/58/235558/4/gate/gate-python-novaclient-python26/201afaa/ : SUCCESS in 1m 38s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/58/235558/4/gate/gate-python-novaclient-docs/19600f5//doc/build/html/ : SUCCESS in 58s\n- gate-python-novaclient-pep8 http://logs.openstack.org/58/235558/4/gate/gate-python-novaclient-pep8/f1c6213/ : SUCCESS in 1m 19s\n- gate-python-novaclient-python27 http://logs.openstack.org/58/235558/4/gate/gate-python-novaclient-python27/b0021dc/ : SUCCESS in 1m 46s\n- gate-python-novaclient-python34 http://logs.openstack.org/58/235558/4/gate/gate-python-novaclient-python34/f05b3d9/ : SUCCESS in 2m 18s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/58/235558/4/gate/gate-tempest-dsvm-neutron-src-python-novaclient/ff66ef8/ : SUCCESS in 1h 05m 09s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/58/235558/4/gate/gate-novaclient-dsvm-functional/9f24a17/ : SUCCESS in 32m 23s","accounts_in_message":[],"_revision_number":4},{"id":"0584e54077a40cebd416c3c3741a1d3c92fff0f1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-23 12:56:12.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4},{"id":"786713a78026f0becb1def23a17cafc1509ed437","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 14:03:57.000000000","message":"Patch Set 4:\n\nThis broke cinder unit tests because cinder has a test where they mock out the requests library raising a Timeout exception and expected novaclient to pass that through, but now it\u0027s returning RequestTimeout:\n\nhttps://bugs.launchpad.net/cinder/+bug/1510656","accounts_in_message":[],"_revision_number":4},{"id":"34657a6b0dc671e857469735ca27ec2d84f3fffb","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 14:25:38.000000000","message":"Patch Set 4:\n\nRevert is proposed here:\n\nhttps://review.openstack.org/#/c/239941/","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2961e82bfa6e375ac3c17933fac532ed316ac976","revisions":{"7a0f5e4d9bb6661c0665877bcf088d738ce695cb":{"kind":"REWORK","_number":1,"created":"2015-10-15 19:21:05.000000000","uploader":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"ref":"refs/changes/58/235558/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/58/235558/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/1"}}},"commit":{"parents":[{"commit":"03f1f67ccde6f495e264da08f0bb7d707cf3ff66","subject":"Merge \"Revert \"Allow display project-id for server groups\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/03f1f67ccde6f495e264da08f0bb7d707cf3ff66"}]}],"author":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-15 17:00:39.000000000","tz":-300},"committer":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-15 19:21:04.000000000","tz":-300},"subject":"Do not expose exceptions from requests library","message":"Do not expose exceptions from requests library\n\nNovaclient expects the requests library to always be able to get a\nresponse back and doesn\u0027t handle other cases where it might raise\nan exception even before the request is completed (e.g.\nConnectionError).\n\nThese exceptions should be captured and properly converted to some\nnative novaclient exception.\n\nChange-Id: Iec7247b715c38c29910b30e76413cead4e951a37\nCo-Authored-By: Kuo-tung Kao \u003cjelly.k@inwinstack.com\u003e\nCloses-Bug: #1406586\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7a0f5e4d9bb6661c0665877bcf088d738ce695cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7a0f5e4d9bb6661c0665877bcf088d738ce695cb"}]},"branch":"refs/heads/master"},"23cb0b9d3854f1d197a7f304e8e86f42be42c0cd":{"kind":"REWORK","_number":2,"created":"2015-10-15 20:32:32.000000000","uploader":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"ref":"refs/changes/58/235558/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/58/235558/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/2"}}},"commit":{"parents":[{"commit":"03f1f67ccde6f495e264da08f0bb7d707cf3ff66","subject":"Merge \"Revert \"Allow display project-id for server groups\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/03f1f67ccde6f495e264da08f0bb7d707cf3ff66"}]}],"author":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-15 17:00:39.000000000","tz":-300},"committer":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-15 20:31:58.000000000","tz":-300},"subject":"Do not expose exceptions from requests library","message":"Do not expose exceptions from requests library\n\nNovaclient expects the requests library to always be able to get a\nresponse back and doesn\u0027t handle other cases where it might raise\nan exception even before the request is completed (e.g.\nConnectionError).\n\nThese exceptions should be captured and properly converted to some\nnative novaclient exception.\n\nChange-Id: Iec7247b715c38c29910b30e76413cead4e951a37\nCo-Authored-By: Kuo-tung Kao \u003cjelly.k@inwinstack.com\u003e\nCloses-Bug: #1406586\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/23cb0b9d3854f1d197a7f304e8e86f42be42c0cd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/23cb0b9d3854f1d197a7f304e8e86f42be42c0cd"}]},"branch":"refs/heads/master"},"bf58e9b93b96f47943beb3c9589fdc61a1c9d01f":{"kind":"REWORK","_number":3,"created":"2015-10-16 14:23:22.000000000","uploader":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"ref":"refs/changes/58/235558/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/58/235558/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/3"}}},"commit":{"parents":[{"commit":"03f1f67ccde6f495e264da08f0bb7d707cf3ff66","subject":"Merge \"Revert \"Allow display project-id for server groups\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/03f1f67ccde6f495e264da08f0bb7d707cf3ff66"}]}],"author":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-15 17:00:39.000000000","tz":-300},"committer":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-16 14:22:45.000000000","tz":-300},"subject":"Do not expose exceptions from requests library","message":"Do not expose exceptions from requests library\n\nNovaclient expects the requests library to always be able to get a\nresponse back and doesn\u0027t handle other cases where it might raise\nan exception even before the request is completed (e.g.\nConnectionError).\n\nThese exceptions should be captured and properly converted to some\nnative novaclient exception.\n\nChange-Id: Iec7247b715c38c29910b30e76413cead4e951a37\nCo-Authored-By: Kuo-tung Kao \u003cjelly.k@inwinstack.com\u003e\nCloses-Bug: #1406586\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/bf58e9b93b96f47943beb3c9589fdc61a1c9d01f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/bf58e9b93b96f47943beb3c9589fdc61a1c9d01f"}]},"branch":"refs/heads/master"},"2961e82bfa6e375ac3c17933fac532ed316ac976":{"kind":"REWORK","_number":4,"created":"2015-10-22 19:37:41.000000000","uploader":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"ref":"refs/changes/58/235558/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/58/235558/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/58/235558/4"}}},"commit":{"parents":[{"commit":"03f1f67ccde6f495e264da08f0bb7d707cf3ff66","subject":"Merge \"Revert \"Allow display project-id for server groups\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/03f1f67ccde6f495e264da08f0bb7d707cf3ff66"}]}],"author":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-15 17:00:39.000000000","tz":-300},"committer":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-22 19:34:23.000000000","tz":-300},"subject":"Do not expose exceptions from requests library","message":"Do not expose exceptions from requests library\n\nNovaclient expects the requests library to always be able to get a\nresponse back and doesn\u0027t handle other cases where it might raise\nan exception even before the request is completed (e.g.\nConnectionError).\n\nThese exceptions should be captured and properly converted to some\nnative novaclient exception.\n\nChange-Id: Iec7247b715c38c29910b30e76413cead4e951a37\nCo-Authored-By: Kuo-tung Kao \u003cjelly.k@inwinstack.com\u003e\nCloses-Bug: #1406586\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2961e82bfa6e375ac3c17933fac532ed316ac976"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2961e82bfa6e375ac3c17933fac532ed316ac976"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}