)]}'
{"id":"openstack%2Fpython-novaclient~23688","triplet_id":"openstack%2Fpython-novaclient~master~Id9973b1edb39ab76e7a232c262ae073cf44dfc0a","project":"openstack/python-novaclient","branch":"master","topic":"bp/python-novaclient-unittests","hashtags":[],"change_id":"Id9973b1edb39ab76e7a232c262ae073cf44dfc0a","subject":"Extend test coverage for v1_1/shell.py","status":"MERGED","created":"2013-03-06 12:18:22.000000000","updated":"2013-03-11 10:54:30.000000000","submitted":"2013-03-11 10:54:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c04eca8b78f089b7ac933a108f9c9628d3626798","_number":23688,"virtual_id_number":23688,"owner":{"_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-03-11 10:54:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-03-06 13:27:47.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"},{"value":2,"date":"2013-03-08 19:23:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2013-03-06 19:05:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":2,"date":"2013-03-10 15:07:03.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-03-06 12:20:43.000000000","_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"},{"value":0,"date":"2013-03-06 16:06:54.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2013-03-06 19:05:47.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":1,"date":"2013-03-10 15:07:03.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-06 16:06:54.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-03-06 19:05:47.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-03-10 15:07:03.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-03-11 10:54:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e9a482bfbfcc1ab85bf955993719895d0fabb246","author":{"_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"},"date":"2013-03-06 12:20:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a613d4cd4fb8cdc0684cc2e304e0ff6b8b28f949","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-03-06 12:20:49.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"0270cbcaeb3bad89c03a9f3e426399f8452f2d26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-06 13:02:48.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23688/2/check/gate-python-novaclient-pep8/1221 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-python-novaclient-docs/911 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-python-novaclient-python26/1010 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-python-novaclient-python27/1230 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-tempest-devstack-vm-full/7371 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-tempest-devstack-vm-postgres-full/7087 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-tempest-devstack-vm-quantum/12435 : FAILURE\n","accounts_in_message":[],"_revision_number":2},{"id":"6e87b9fb091b1cf53f82f856e2fa930e1b777eaa","author":{"_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"},"date":"2013-03-06 13:27:47.000000000","message":"Patch Set 2:\n\nreverify bug 1103760","accounts_in_message":[],"_revision_number":2},{"id":"acbfcc0c07bf1d283957a25dc7e587c8fa749efd","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-03-06 16:06:54.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"5c888c1a7d8f193f6dcd7713e3bc3e735b2f1ed8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-06 16:43:39.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23688/2/check/gate-python-novaclient-pep8/1223 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-python-novaclient-docs/913 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-python-novaclient-python26/1012 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-python-novaclient-python27/1232 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-tempest-devstack-vm-full/7402 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-tempest-devstack-vm-postgres-full/7118 : SUCCESS\n- http://logs.openstack.org/23688/2/check/gate-tempest-devstack-vm-quantum/12471 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"9a7c78749f2d4cc0ccc8da1b6803b6bbb2df1469","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-03-06 19:05:47.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nLGTM, although this doesn\u0027t shouldn\u0027t be a blueprint, its a bug at most.","accounts_in_message":[],"_revision_number":2},{"id":"9e7943aa96d237fafb9af00a6d4d4ede8d3239f2","author":{"_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"},"date":"2013-03-07 12:32:02.000000000","message":"Patch Set 2:\n\nI think so too, but how should i do it? Should i create bug with text \"missing tests\"?","accounts_in_message":[],"_revision_number":2},{"id":"89f8f17672eba65abb8c1a2ae7d63be67d134847","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-03-07 22:20:28.000000000","message":"Patch Set 2:\n\nIMHO, adding tests doesn\u0027t even need a bug  filed.","accounts_in_message":[],"_revision_number":2},{"id":"90db074670dce9f6b7585dc620af503417c653e7","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-03-08 19:23:42.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c4c1eeeabdde56561420fe7542bf01d365ad7cfd","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-03-10 15:07:03.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"e7c58becfb485e94b51471e7b3c35b67c4a8b22e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-10 15:07:05.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"451741183430664554a00731d95952b091d08965","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-10 15:15:06.000000000","message":"Patch Set 2: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23688/2/gate/gate-python-novaclient-docs/939 : SUCCESS\n- http://logs.openstack.org/23688/2/gate/gate-python-novaclient-pep8/1249 : SUCCESS\n- http://logs.openstack.org/23688/2/gate/gate-python-novaclient-python26/1038 : SUCCESS\n- http://logs.openstack.org/23688/2/gate/gate-python-novaclient-python27/1258 : SUCCESS\n- http://logs.openstack.org/23688/2/gate/gate-tempest-devstack-vm-full/7982 : FAILURE\n- http://logs.openstack.org/23688/2/gate/gate-tempest-devstack-vm-postgres-full/7698 : FAILURE\n- http://logs.openstack.org/23688/2/gate/gate-tempest-devstack-vm-quantum/13148 : FAILURE\n","accounts_in_message":[],"_revision_number":2},{"id":"0b0fd3afe0dbdf4ecb95ebb937b326778e73a635","author":{"_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"},"date":"2013-03-11 10:09:56.000000000","message":"Patch Set 2:\n\nreverify","accounts_in_message":[],"_revision_number":2},{"id":"f7afbb8d1ee9a2da5f3c02ccd9b3377035f01969","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-11 10:09:58.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"9bb92483c40d0e0efb3b0ac68e99cd375b9bcd3c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-11 10:54:30.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/23688/2/gate/gate-python-novaclient-docs/945 : SUCCESS\n- http://logs.openstack.org/23688/2/gate/gate-python-novaclient-pep8/1255 : SUCCESS\n- http://logs.openstack.org/23688/2/gate/gate-python-novaclient-python26/1044 : SUCCESS\n- http://logs.openstack.org/23688/2/gate/gate-python-novaclient-python27/1264 : SUCCESS\n- http://logs.openstack.org/23688/2/gate/gate-tempest-devstack-vm-full/8044 : SUCCESS\n- http://logs.openstack.org/23688/2/gate/gate-tempest-devstack-vm-postgres-full/7760 : SUCCESS\n- http://logs.openstack.org/23688/2/gate/gate-tempest-devstack-vm-quantum/13230 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"0918b25c54f82f22b143555adfc19138ff34fa26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-11 10:54:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"650f1c3d5343c2997c9789e9c2d924e4507c8f32","revisions":{"4db830f27badf875af0c6301cc027405051ac04e":{"kind":"REWORK","_number":1,"created":"2013-03-06 12:18:22.000000000","uploader":{"_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"},"ref":"refs/changes/88/23688/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/88/23688/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/88/23688/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/88/23688/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/88/23688/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/88/23688/1"}}},"commit":{"parents":[{"commit":"8ac304f7f577ffe7d0264e1248e4ae87bd74fc65","subject":"Fixed bug with password prompt, added tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8ac304f7f577ffe7d0264e1248e4ae87bd74fc65"}]}],"author":{"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","date":"2013-03-06 12:08:22.000000000","tz":-300},"committer":{"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","date":"2013-03-06 12:09:59.000000000","tz":-300},"subject":"Extend test coverage for v1_1/shell.py","message":"Extend test coverage for v1_1/shell.py\n\nAdded unit tests for shell code, that wasn\u0027t covered before.\n\nImplements: blueprint bp/python-novaclient-unittests\nChange-Id: Id9973b1edb39ab76e7a232c262ae073cf44dfc0a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4db830f27badf875af0c6301cc027405051ac04e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4db830f27badf875af0c6301cc027405051ac04e"}]},"branch":"refs/heads/master"},"650f1c3d5343c2997c9789e9c2d924e4507c8f32":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-03-06 12:20:43.000000000","uploader":{"_account_id":6724,"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","username":"vkhomenko"},"ref":"refs/changes/88/23688/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/88/23688/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/88/23688/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/88/23688/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/88/23688/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/88/23688/2"}}},"commit":{"parents":[{"commit":"8ac304f7f577ffe7d0264e1248e4ae87bd74fc65","subject":"Fixed bug with password prompt, added tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8ac304f7f577ffe7d0264e1248e4ae87bd74fc65"}]}],"author":{"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","date":"2013-03-06 12:08:22.000000000","tz":-300},"committer":{"name":"Vasyl Khomenko","email":"vasiliyk@yahoo-inc.com","date":"2013-03-06 12:19:54.000000000","tz":-300},"subject":"Extend test coverage for v1_1/shell.py","message":"Extend test coverage for v1_1/shell.py\n\nAdded unit tests for shell code, that wasn\u0027t covered before.\n\nImplements: blueprint python-novaclient-unittests\nChange-Id: Id9973b1edb39ab76e7a232c262ae073cf44dfc0a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/650f1c3d5343c2997c9789e9c2d924e4507c8f32"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/650f1c3d5343c2997c9789e9c2d924e4507c8f32"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
