)]}'
{"id":"openstack%2Fpython-novaclient~236897","triplet_id":"openstack%2Fpython-novaclient~master~Id0b14ff7e38028a403ad15e7a016990e5d230122","project":"openstack/python-novaclient","branch":"master","topic":"bug/1506103","hashtags":[],"change_id":"Id0b14ff7e38028a403ad15e7a016990e5d230122","subject":"Using openstackclient instead of keystoneclient","status":"ABANDONED","created":"2015-10-19 10:40:51.000000000","updated":"2016-01-07 09:05:34.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8b61755267613cf6c915128f8c541e0388e11e10","_number":236897,"virtual_id_number":236897,"owner":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":-1,"date":"2015-10-19 20:36:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-10-19 15:39:36.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"date":"2015-10-20 03:42:42.000000000","_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"all":[{"value":-1,"date":"2015-10-19 18:11:18.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-1,"date":"2015-10-19 21:45:29.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":-1,"date":"2015-10-28 08:53:03.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-19 15:39:36.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-10-19 18:11:18.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2015-10-19 20:36:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-10-19 21:45:29.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"}],"messages":[{"id":"13e7d57c80059327f5f7fd021fb13597bac3f754","author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"date":"2015-10-19 10:40:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3d61f259467bea33c896492137933ba514d32886","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-19 11:50:29.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-python26/96a8e75/ : SUCCESS in 1m 32s\n- gate-python-novaclient-pep8 http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-pep8/9b16bc8/ : SUCCESS in 1m 08s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/97/236897/1/check/gate-python-novaclient-docs/3cb9f65//doc/build/html/ : SUCCESS in 1m 35s\n- gate-python-novaclient-python27 http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-python27/cf8462c/ : SUCCESS in 1m 55s\n- gate-python-novaclient-python34 http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-python34/c6dc3f1/ : SUCCESS in 2m 09s\n- gate-python-novaclient-requirements http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-requirements/c9957a8/ : SUCCESS in 24s\n- gate-python-novaclient-pypy http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-pypy/90d3019/ : SUCCESS in 2m 29s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/97/236897/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/1fdcb38/ : SUCCESS in 1h 08m 48s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/97/236897/1/check/gate-novaclient-dsvm-functional/2edbaeb/ : FAILURE in 24m 55s","accounts_in_message":[],"_revision_number":1},{"id":"1026c9da52fa56803317ac9da812d97c936eb1d0","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2015-10-19 14:24:18.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"67235aeee5676d2799cdc791560c77e9f4922219","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-19 15:45:53.000000000","message":"Patch Set 1:\n\nIt appears the bug was fixed, or at least worked around, by [1].  The question now is, do we still need this series of fixes?  I make no assumptions either way, for the record, I just want to raise the question about whether [1] is the only fix we needed, or whether this or some other change provides a better long-term fix.\n\n[1] https://review.openstack.org/#/c/236160/","accounts_in_message":[],"_revision_number":1},{"id":"ffda45667a95dbd13f88c0a3338dae8dd62f3732","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-19 15:52:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-python26/70f8251/ : SUCCESS in 1m 50s\n- gate-python-novaclient-pep8 http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-pep8/22aef70/ : SUCCESS in 1m 07s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/97/236897/1/check/gate-python-novaclient-docs/4907593//doc/build/html/ : SUCCESS in 1m 28s\n- gate-python-novaclient-python27 http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-python27/a2d044b/ : SUCCESS in 1m 54s\n- gate-python-novaclient-python34 http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-python34/d844a43/ : SUCCESS in 2m 46s\n- gate-python-novaclient-requirements http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-requirements/d831bae/ : SUCCESS in 20s\n- gate-python-novaclient-pypy http://logs.openstack.org/97/236897/1/check/gate-python-novaclient-pypy/24c69f7/ : SUCCESS in 2m 42s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/97/236897/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/f5fc93f/ : SUCCESS in 1h 09m 31s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/97/236897/1/check/gate-novaclient-dsvm-functional/b008149/ : SUCCESS in 32m 10s","accounts_in_message":[],"_revision_number":1},{"id":"e98f48c3ef5ff6d6f3a4df813156f50037ae9a70","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-10-19 18:11:18.000000000","message":"Patch Set 1: Code-Review-1\n\nWe do need support in novaclient to handle keystone api v3 and I think we might need to be able to do so without relying on a version in the auth_url. \n\nBut I think we shouldn\u0027t do it by using openstackclient because openstackclient uses novaclient [1]. It would be a circular dependency.\n\n[1] https://github.com/openstack/python-openstackclient/blob/master/requirements.txt","accounts_in_message":[],"_revision_number":1},{"id":"68d5fd60da5010c6be9e4087391430174a54ba1a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-19 20:36:17.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"4c19fdb7206a702e66fdccb490b0716b9d291a32","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-10-19 21:45:29.000000000","message":"Patch Set 1: Code-Review-1\n\nThe problem not in keystoneclient. openstackclient uses it for all authentication stuff, so it works correctly and we can do the same in novaclient.","accounts_in_message":[],"_revision_number":1},{"id":"109cf810881d577bdc5bc5f5c560c8654c61ee28","author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"date":"2015-10-20 03:42:42.000000000","message":"Patch Set 1:\n\n@Kevin L. Mitchell:\nYes, the review had fixed problem. I will ask in IRC about whether we still need these patches.\n\n@melanie witt:\nI didn\u0027t notice openstack client will depend on nova client. If we still needs to fix that. Maybe we should modify keystone client to be able to do request without relying on a version in the auth_url?\n\n@Andrey Kurilin:\nHere is not using keystone client to authenticate. Those tests are using that to get tenant information. But keystoneclient can\u0027t handle those request when auth_url don\u0027t contain version. Therefore those tests are failed in 404 not found.","accounts_in_message":[],"_revision_number":1},{"id":"66f868509d12564a1e570aeca2d1f3ef2c86c958","author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"date":"2015-10-28 08:53:03.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"d4c54d53c6507ff5d71b8bb75e9134ac002223a7","author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"date":"2016-01-07 09:05:34.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6afc9ae8c2c707b27c51338f1eee14e600354331","revisions":{"6afc9ae8c2c707b27c51338f1eee14e600354331":{"kind":"REWORK","_number":1,"created":"2015-10-19 10:40:51.000000000","uploader":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"ref":"refs/changes/97/236897/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/97/236897/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/97/236897/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/97/236897/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/97/236897/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/97/236897/1"}}},"commit":{"parents":[{"commit":"03f1f67ccde6f495e264da08f0bb7d707cf3ff66","subject":"Merge \"Revert \"Allow display project-id for server groups\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/03f1f67ccde6f495e264da08f0bb7d707cf3ff66"}]}],"author":{"name":"Chung Chih, Hung","email":"lyan.h@inwinstack.com","date":"2015-10-19 09:55:59.000000000","tz":0},"committer":{"name":"Chung Chih, Hung","email":"lyan.h@inwinstack.com","date":"2015-10-19 09:57:15.000000000","tz":0},"subject":"Using openstackclient instead of keystoneclient","message":"Using openstackclient instead of keystoneclient\n\nSome functional test will use keystoneclient to get tenant\u0027s\nid. If user didn\u0027t specify identity version for auth_url(such as\nhttp://127.0.0.1:5000) in clouds.yaml, those request will return 404.\n\nWhy those request will return 404? Because of keystoneclient will assume\nauth_url will point to identity version 2.0 api. It will make\nauthentication request to url, which is just auth_url + \"/tokens\"(such\nas http://127.0.0.1:5000/tokens). We can also test that by following\ncommand.\n\u003e keystone --os-username admin --os-tenant-name admin --os-password\nadmin --os-auth-url http://127.0.0.1:5000 tenant-list\n\nMaybe we should use openstackclient instead of keystoneclient.\n\nChange-Id: Id0b14ff7e38028a403ad15e7a016990e5d230122\nCloses-Bug: 1507497\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6afc9ae8c2c707b27c51338f1eee14e600354331"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6afc9ae8c2c707b27c51338f1eee14e600354331"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}