)]}'
{"id":"openstack%2Fpython-novaclient~237850","triplet_id":"openstack%2Fpython-novaclient~master~Iba9bfa136245bd2899c427ac0c231a30c00bd7f3","project":"openstack/python-novaclient","branch":"master","topic":"bug/1508244","hashtags":[],"change_id":"Iba9bfa136245bd2899c427ac0c231a30c00bd7f3","subject":"Correct usage of API_MAX_VERSION and DEFAULT_OS_COMPUTE_API_VERSION","status":"MERGED","created":"2015-10-21 02:34:20.000000000","updated":"2015-10-21 14:38:56.000000000","submitted":"2015-10-21 14:38:55.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7fa33690530d8a545081578e1dbaec6555da0e62","_number":237850,"virtual_id_number":237850,"owner":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2015-10-21 14:38:55.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2015-10-21 09:21:09.000000000","_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"recommended":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-10-21 11:49:23.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":2,"date":"2015-10-21 13:05:45.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":2,"date":"2015-10-21 10:36:00.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":1,"date":"2015-10-21 11:01:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"date":"2015-10-21 03:25:14.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":1,"date":"2015-10-21 13:36:43.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-21 03:25:14.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2015-10-21 11:01:18.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2015-10-21 11:49:23.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2015-10-21 13:05:45.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2015-10-21 13:36:43.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-10-21 14:38:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bd9b79bce708839dc2870e43a6a68f9604fa2ada","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2015-10-21 02:34:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8c438411371c7708069bd1b6186124d198dbe682","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2015-10-21 02:59:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5ad2cd064f23ba34cebf2311022eb14e017fe2de","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-21 04:04:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/50/237850/2/check/gate-python-novaclient-python26/d588a08/ : SUCCESS in 1m 37s\n- gate-python-novaclient-pep8 http://logs.openstack.org/50/237850/2/check/gate-python-novaclient-pep8/4a80d5e/ : SUCCESS in 1m 02s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/50/237850/2/check/gate-python-novaclient-docs/c66c4a4//doc/build/html/ : SUCCESS in 1m 14s\n- gate-python-novaclient-python27 http://logs.openstack.org/50/237850/2/check/gate-python-novaclient-python27/e540f36/ : SUCCESS in 1m 54s\n- gate-python-novaclient-python34 http://logs.openstack.org/50/237850/2/check/gate-python-novaclient-python34/d9080ef/ : SUCCESS in 2m 00s\n- gate-python-novaclient-pypy http://logs.openstack.org/50/237850/2/check/gate-python-novaclient-pypy/2e573bb/ : SUCCESS in 2m 07s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/50/237850/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/263c4f7/ : SUCCESS in 1h 04m 55s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/50/237850/2/check/gate-novaclient-dsvm-functional/d4efbfa/ : SUCCESS in 27m 54s","accounts_in_message":[],"_revision_number":2},{"id":"fe4766ad78ac4037bae833cd3d45183a97132c3c","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2015-10-21 09:07:23.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI am not sure about the details, but I think part of this was very intentional.","accounts_in_message":[],"_revision_number":2},{"id":"1cc7f110e851a4d4ed4f4196d84c292546077bd1","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2015-10-21 09:21:09.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"afd52d7cefa89deceb4c8de5dfe4221a462bd247","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2015-10-21 09:31:04.000000000","message":"Patch Set 2: -Code-Review\n\nSo in IRC alex has convinced me that this might be correct.\n\nNeed to go dig deeper to double check whats going on before I vote any further.","accounts_in_message":[],"_revision_number":2},{"id":"304eaa464dcc7e8306b066be4d09416496041eb2","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-21 10:36:00.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"52a902df6f854140fa4a632b8b37b2397a24bd1e","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2015-10-21 11:01:18.000000000","message":"Patch Set 2: Code-Review+1\n\nSo I would like matt to ack this.\n\nBut before applying this change, and talking to Rackspace I got:\n\"ERROR (UnsupportedVersion): Server doesn\u0027t support microversions\"\n\nBut after applying this change, it worked.","accounts_in_message":[],"_revision_number":2},{"id":"8d90d42a5e897f3da2d9bb2e8457100a2b78ec24","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-10-21 11:49:23.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"2963a7a3ba155e479605c09579e1127bf8a4de2e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-21 12:59:22.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nI feel like this is reverting to bad UX but I\u0027m on vacation on my phone and don\u0027t have context so I won\u0027t down vote this.","accounts_in_message":[],"_revision_number":2},{"id":"004315d169d186f294022eaab372972242780973","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-21 13:05:45.000000000","message":"Patch Set 2: Code-Review+2\n\nAfter reading the bug report this is more clear. This is less evil than breaking infra so I\u0027ll +2.\n\nWe still have bad UX here and I\u0027m not sure what to do about that. Procedure wise we could make people implement the client side microversion support when they add the server side so we make sure it happens.\n\nBut that doesn\u0027t fix older clients against newer servers and vice versa.","accounts_in_message":[],"_revision_number":2},{"id":"07b3cbcdef5ed1048b965a9ca9d75bc1f7491d62","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-21 13:36:43.000000000","message":"Patch Set 2: Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e6255743ab387c282376fab0754b635eeb63e407","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-21 13:36:48.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"56f9f734ac270e0411452dc5a6cc35baad1fb278","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-21 14:38:55.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/50/237850/2/gate/gate-python-novaclient-python26/fc6a0b5/ : SUCCESS in 1m 20s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/50/237850/2/gate/gate-python-novaclient-docs/0316e45//doc/build/html/ : SUCCESS in 1m 12s\n- gate-python-novaclient-pep8 http://logs.openstack.org/50/237850/2/gate/gate-python-novaclient-pep8/4f7d099/ : SUCCESS in 58s\n- gate-python-novaclient-python27 http://logs.openstack.org/50/237850/2/gate/gate-python-novaclient-python27/eca1d55/ : SUCCESS in 1m 30s\n- gate-python-novaclient-python34 http://logs.openstack.org/50/237850/2/gate/gate-python-novaclient-python34/d0055c6/ : SUCCESS in 1m 51s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/50/237850/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient/46c39cd/ : SUCCESS in 1h 00m 40s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/50/237850/2/gate/gate-novaclient-dsvm-functional/fc52891/ : SUCCESS in 30m 43s","accounts_in_message":[],"_revision_number":2},{"id":"5171ffece18d5038826010dccd267b625aaf8a89","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-21 14:38:56.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"28bf8ddb06a618bec280c9fbc21b4be6af2c1787","revisions":{"769b0360cd9c755e009c8705d258019d48a49f72":{"kind":"REWORK","_number":1,"created":"2015-10-21 02:34:20.000000000","uploader":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"ref":"refs/changes/50/237850/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/50/237850/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/50/237850/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/50/237850/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/50/237850/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/50/237850/1"}}},"commit":{"parents":[{"commit":"095d72f652653307979998d93bb39d10d25b8471","subject":"Merge \"Rely on devstack for clouds.yaml\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/095d72f652653307979998d93bb39d10d25b8471"}]}],"author":{"name":"He Jie Xu","email":"hejie.xu@intel.com","date":"2015-10-21 02:36:53.000000000","tz":480},"committer":{"name":"He Jie Xu","email":"hejie.xu@intel.com","date":"2015-10-21 02:42:57.000000000","tz":480},"subject":"Correct the usage of API_MAX_VERSION and DEFAULT_OS_COMPUTE_API_VERSION","message":"Correct the usage of API_MAX_VERSION and DEFAULT_OS_COMPUTE_API_VERSION\n\nChange: I52074f9a3e7faa6a7a51c3fa9766100acf25dee2 use the variable\nAPI_MAX_VERSION and DEFAULT_OS_COMPUTE_API_VERSION with wrong way.\n\nAPI_MAX_VERSION means the max version of client supported. This variable\nonly be changed when client support the new version. And it must bump by\nsequential.\n\nDEFAULT_OS_COMPUTE_API_VERSION is default value of option\n\u0027--os-compute-api-version\u0027, this value decided the default behaviour of\nnova client. The nova client CLI behaviour should be that client negotiate\nwith server side to find out most recent version between client and\nserver. So the value should be \u00272.latest\u0027. And it won\u0027t be changed\nexcept we decided to change the default behaviour of nova client CLI.\n\nChange-Id: Iba9bfa136245bd2899c427ac0c231a30c00bd7f3\nCloses-Bug: #1508244\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/769b0360cd9c755e009c8705d258019d48a49f72"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/769b0360cd9c755e009c8705d258019d48a49f72"}]},"branch":"refs/heads/master"},"28bf8ddb06a618bec280c9fbc21b4be6af2c1787":{"kind":"REWORK","_number":2,"created":"2015-10-21 02:59:00.000000000","uploader":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"ref":"refs/changes/50/237850/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/50/237850/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/50/237850/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/50/237850/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/50/237850/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/50/237850/2"}}},"commit":{"parents":[{"commit":"095d72f652653307979998d93bb39d10d25b8471","subject":"Merge \"Rely on devstack for clouds.yaml\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/095d72f652653307979998d93bb39d10d25b8471"}]}],"author":{"name":"He Jie Xu","email":"hejie.xu@intel.com","date":"2015-10-21 02:36:53.000000000","tz":480},"committer":{"name":"He Jie Xu","email":"hejie.xu@intel.com","date":"2015-10-21 03:07:32.000000000","tz":480},"subject":"Correct usage of API_MAX_VERSION and DEFAULT_OS_COMPUTE_API_VERSION","message":"Correct usage of API_MAX_VERSION and DEFAULT_OS_COMPUTE_API_VERSION\n\nCommit d045019f0f2d28f26730b3617f7d7b993506b6e8 use the variables\nAPI_MAX_VERSION and DEFAULT_OS_COMPUTE_API_VERSION with wrong way.\n\nAPI_MAX_VERSION means the max version of client supported. This\nvariable only be changed when client support the new version. And\nit\u0027s must bumped sequentially.\n\nDEFAULT_OS_COMPUTE_API_VERSION is default value of option\n\u0027--os-compute-api-version\u0027, this value decided the default behaviour\nof nova client. The nova client CLI behaviour should be that client\nnegotiate with server side to find out most recent version betweeyn\nclient and server. So the value should be \u00272.latest\u0027. And it won\u0027t\nbe changed except we decided to change the default behaviour of nova\nclient CLI.\n\nChange-Id: Iba9bfa136245bd2899c427ac0c231a30c00bd7f3\nCloses-Bug: #1508244\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/28bf8ddb06a618bec280c9fbc21b4be6af2c1787"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/28bf8ddb06a618bec280c9fbc21b4be6af2c1787"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}