)]}'
{"id":"openstack%2Fpython-novaclient~239941","triplet_id":"openstack%2Fpython-novaclient~master~I368728588e5997eef860a168539eb66c58f2e72a","project":"openstack/python-novaclient","branch":"master","topic":"bug/1510790","hashtags":[],"change_id":"I368728588e5997eef860a168539eb66c58f2e72a","subject":"Revert \"Do not expose exceptions from requests library\"","status":"MERGED","created":"2015-10-28 14:14:07.000000000","updated":"2015-10-28 17:42:29.000000000","submitted":"2015-10-28 17:42:28.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d53e980d5b5df22f4e5fc02d74539b83489c687a","_number":239941,"virtual_id_number":239941,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":2,"date":"2015-10-28 17:42:28.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"value":0,"date":"2015-10-28 15:17:31.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2015-10-28 15:09:54.000000000","_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"date":"2015-10-28 14:49:15.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"all":[{"value":2,"date":"2015-10-28 15:53:27.000000000","_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":1,"date":"2015-10-28 16:11:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"value":2,"date":"2015-10-28 16:31:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":1,"date":"2015-10-28 15:30:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":1,"date":"2015-10-28 14:38:15.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2015-10-28 14:33:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"value":1,"date":"2015-10-28 16:31:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":0,"date":"2015-10-28 14:49:22.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-28 14:30:56.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2015-10-28 14:33:29.000000000","updated_by":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"reviewer":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"state":"REVIEWER"},{"updated":"2015-10-28 14:38:15.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2015-10-28 14:49:22.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-10-28 15:09:54.000000000","updated_by":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"reviewer":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"state":"REVIEWER"},{"updated":"2015-10-28 15:30:04.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2015-10-28 15:53:27.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2015-10-28 16:11:07.000000000","updated_by":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"reviewer":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"state":"REVIEWER"},{"updated":"2015-10-28 16:31:04.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-10-28 17:42:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d4ae4d56068007fff90036d74b9286d2c979f33b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 14:14:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"167cc2e0d893c6412da7263f8e350991488cdc25","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 14:24:06.000000000","message":"Patch Set 1:\n\nNote that cinder went and approved a change (which I didn\u0027t see until after I proposed this revert) which handles both exception types now:\n\nhttps://review.openstack.org/#/c/239837/\n\nHowever, that just fixes cinder, we don\u0027t know what other consumers of novaclient were broken by the change, so I think the revert is still justified, but we don\u0027t have to act as quickly now at least.","accounts_in_message":[],"_revision_number":1},{"id":"40342496fe42c3323a1097cd5930c88115336b0d","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2015-10-28 14:27:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"32663c2b2d74b288356fc6a3ca6ed15b43f9687c","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-10-28 14:27:40.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"08b08f44821faeca671e7ab7b67ac9d80899bd1f","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 14:27:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1cf0c1e9610eb9aaa800fc2f4067c95f6f9b4ea9","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-10-28 14:30:56.000000000","message":"Patch Set 1: Code-Review+1\n\nI\u0027m not as hard lined on the API change stuff that\u0027s been discussed as of late and don\u0027t have an issue with fixing it in Cinder and moving on.  But, your suggestion of extending the existing class is WAY better anyway.\n\nI\u0027m not sure about the Cinder change that was approved anyway, I\u0027m not sure it will catch the old exception for compat use with old clients but this patch will answer that faster than me trying to open anything else in my browser from here :(","accounts_in_message":[],"_revision_number":1},{"id":"14ba75fae904e616e7b5dac76a100cbd578d4318","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2015-10-28 14:33:29.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"1e926ffd6fb6504f99be2064797bb1cc0e5e5563","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-10-28 14:38:15.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"21aa4b486f1473ac9ce1ad211c10b01736cb2ace","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 14:49:15.000000000","message":"Patch Set 2:\n\nI\u0027m going to push an alternative change to novaclient to make RequestTimeout extend requests.Timeout since that class is meant to be inherited anyway, at least in how it\u0027s used in the requests library:\n\nhttps://github.com/kennethreitz/requests/blob/v2.8.1/requests/exceptions.py#L46\n\nSo it\u0027s simply a marker, it doesn\u0027t have a status code or anything.  Then cinder can just continue to handle catching requests.Timeout and slowly be moved to using novaclient.exceptions.RequestTimeout if needed.\n\nIf at some point novaclient doesn\u0027t use requests internally, I think that would be a major version bump anyway and we can work through it if/when that happens.  In the meantime we should probably block novaclient 2.33 in g-r on master and stable/liberty and revert the cinder change on master.","accounts_in_message":[],"_revision_number":2},{"id":"84e57eda4b4891a609202b381301c73cce7b7474","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 15:06:56.000000000","message":"Patch Set 2:\n\nHere is the alternative to avoid the revert:\n\nhttps://review.openstack.org/#/c/239963/\n\nAlso have a g-r block on 2.33 here:\n\nhttps://review.openstack.org/#/c/239964/","accounts_in_message":[],"_revision_number":2},{"id":"9616dd9c4a1c00d564a6bb297dcd20cc1c3771ea","author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"date":"2015-10-28 15:09:54.000000000","message":"Patch Set 2:\n\nMatt, I think the point of the previous patch was that novaclient must not explicitly depend on requests; i.e. we should be able to swap out requests for another library without breaking things. Extending the requests error classes won\u0027t resolve that issue.\n\nSince this wasn\u0027t done earlier, we now have projects that depend on certain errors being returned to be requests errors. IMO the fix should be in the downstream projects, but I\u0027m going to hold off -1 since this is summit time.","accounts_in_message":[],"_revision_number":2},{"id":"4379a3cbfa279ab05655526ac74723c62b728155","author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"date":"2015-10-28 15:12:48.000000000","message":"Patch Set 2:\n\nApologies, I just saw the other patch. I agree that subclassing is a better solution right now.","accounts_in_message":[],"_revision_number":2},{"id":"8120ee1793ae3865ae4df83d86f1498955e370e8","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-10-28 15:16:15.000000000","message":"Patch Set 2:\n\ng-r block for stable/liberty: https://review.openstack.org/#/c/239799/","accounts_in_message":[],"_revision_number":2},{"id":"ffb50b21008f961b1b271d15cb7c950f61ad6fb9","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-10-28 15:30:04.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"2a55cf3b178ef767acbc8501d8e532637df5f122","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-28 15:38:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/41/239941/2/check/gate-python-novaclient-python26/bca9426/ : SUCCESS in 1m 44s\n- gate-python-novaclient-pep8 http://logs.openstack.org/41/239941/2/check/gate-python-novaclient-pep8/52f9089/ : SUCCESS in 1m 07s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/41/239941/2/check/gate-python-novaclient-docs/fda5a70//doc/build/html/ : SUCCESS in 1m 29s\n- gate-python-novaclient-python27 http://logs.openstack.org/41/239941/2/check/gate-python-novaclient-python27/fe1a30f/ : SUCCESS in 1m 39s\n- gate-python-novaclient-python34 http://logs.openstack.org/41/239941/2/check/gate-python-novaclient-python34/a4d48ca/ : SUCCESS in 1m 57s\n- gate-python-novaclient-pypy http://logs.openstack.org/41/239941/2/check/gate-python-novaclient-pypy/f582410/ : SUCCESS in 2m 28s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/41/239941/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/595661a/ : SUCCESS in 1h 09m 58s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/41/239941/2/check/gate-novaclient-dsvm-functional/b19b729/ : SUCCESS in 29m 48s","accounts_in_message":[],"_revision_number":2},{"id":"9d7b28d4a250e7932d6854c15463153d503e0e48","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2015-10-28 15:53:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b93cf312ce5f4e81a1c9f8ac7edf10d62141dbaf","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 15:56:36.000000000","message":"Patch Set 2:\n\nPratik, making these backward incompatible changes for a future requirement of possibly removing novaclient\u0027s dependency on requests is premature - there is no desire to do that right now as far as I know, and if we did, it\u0027d probably be a major version release on novaclient anyway.\n\nAs pointed out in the other change, if we just subclass all of the requests exceptions in novaclient, what was then the point of the original change?  So I think the revert is most prudent and we can rethink the long term strategy here later when we\u0027re not breaking consumers of novaclient.","accounts_in_message":[],"_revision_number":2},{"id":"975a11902584e17ad2c067605309d56588c2c136","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-28 16:11:07.000000000","message":"Patch Set 2: Code-Review+1\n\nI\u0027ll re-propose a patch with the requests inheritance as soon as this merges.","accounts_in_message":[],"_revision_number":2},{"id":"3146c08fbc91e2051bdefefd68490d34e42962f2","author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"date":"2015-10-28 16:12:31.000000000","message":"Patch Set 2:\n\nThe long term strategy is to decouple exceptions from other libraries from bubbling up in novaclient. There has already been much discussion about it here: https://bugs.launchpad.net/cinder/+bug/1510656. The consensus from that discussion wasn\u0027t specifically a future requirement, but to prevent exactly these kinds of errors as we get more OS projects that depend on novaclient.","accounts_in_message":[],"_revision_number":2},{"id":"922740585b4dc17a75c69efbf0e00579ebde4e77","author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"date":"2015-10-28 16:16:46.000000000","message":"Patch Set 2:\n\nApologies, the correct bug is: https://bugs.launchpad.net/python-novaclient/+bug/1406586","accounts_in_message":[],"_revision_number":2},{"id":"ae94deba46de7fd0d83e5f9594ad15416aa46038","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-28 16:31:04.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"d39d6b3a9f96b513cc92c6e347fdb6ab6526c5aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-28 16:31:10.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2f37c7e55199553261bebeb5cbc6f2d46971d3c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-28 17:42:28.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/41/239941/2/gate/gate-python-novaclient-python26/e9dda54/ : SUCCESS in 1m 31s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/41/239941/2/gate/gate-python-novaclient-docs/0b6351a//doc/build/html/ : SUCCESS in 1m 17s\n- gate-python-novaclient-pep8 http://logs.openstack.org/41/239941/2/gate/gate-python-novaclient-pep8/aa7d327/ : SUCCESS in 1m 03s\n- gate-python-novaclient-python27 http://logs.openstack.org/41/239941/2/gate/gate-python-novaclient-python27/dafadb1/ : SUCCESS in 1m 37s\n- gate-python-novaclient-python34 http://logs.openstack.org/41/239941/2/gate/gate-python-novaclient-python34/e23afda/ : SUCCESS in 1m 45s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/41/239941/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient/b777880/ : SUCCESS in 1h 11m 17s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/41/239941/2/gate/gate-novaclient-dsvm-functional/3c06f72/ : SUCCESS in 26m 58s","accounts_in_message":[],"_revision_number":2},{"id":"acc2b6495398d0a938471361007c0b4f7de0fb4a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-28 17:42:29.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"63c7a576e194f48f0edb5a0b2d9c4f1d37516e74","revisions":{"9ef3cb86ec5ff4c9c38aeeb63724d685b2ef841b":{"kind":"REWORK","_number":1,"created":"2015-10-28 14:14:07.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/41/239941/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/41/239941/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/239941/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/239941/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/239941/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/41/239941/1"}}},"commit":{"parents":[{"commit":"217e7c184907ab80b33fb7eb378de162f8976114","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/217e7c184907ab80b33fb7eb378de162f8976114"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-28 14:07:28.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-28 14:13:56.000000000","tz":-420},"subject":"Revert \"Do not expose exceptions from requests library\"","message":"Revert \"Do not expose exceptions from requests library\"\n\nThis reverts commit 2961e82bfa6e375ac3c17933fac532ed316ac976\n\nThis broke cinder unit tests that have a timeout test for novaclient\nwhere they mock the requests library raising a Timeout exception. That\ntest expects to get a requests Timeout passed through but with the\nchange being reverted it was getting a RequestTimeout exception from\nnovaclient, which breaks the test and fails the gate runs.\n\nWe could change the cinder unit test to handle both the requests.Timeout\nand the new novaclient RequestTimeout, but that\u0027s just papering over\nthe cinder failure, we wouldn\u0027t know what other clients are failing\nin the same way because they have code working around the requests\nexceptions getting passed through, so we should treat this like an API\nchange.\n\nI\u0027d be in favor of making the same change again iff the novaclient\nexceptions extended the requests exception types so it would be transparent\nto consumers, since novaclient.exceptions.RequestTimeout would be a\nrequests.Timeout via inheritance. But given the gate breakage and it being\nsummit week I\u0027m inclined to revert first and think about a better long term\nfix later when people are back to discuss.\n\nChange-Id: I368728588e5997eef860a168539eb66c58f2e72a\nCloses-Bug: #1510656\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9ef3cb86ec5ff4c9c38aeeb63724d685b2ef841b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9ef3cb86ec5ff4c9c38aeeb63724d685b2ef841b"}]},"branch":"refs/heads/master"},"63c7a576e194f48f0edb5a0b2d9c4f1d37516e74":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-10-28 14:27:58.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/41/239941/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/41/239941/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/239941/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/239941/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/239941/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/41/239941/2"}}},"commit":{"parents":[{"commit":"217e7c184907ab80b33fb7eb378de162f8976114","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/217e7c184907ab80b33fb7eb378de162f8976114"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-28 14:07:28.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-28 14:27:40.000000000","tz":-420},"subject":"Revert \"Do not expose exceptions from requests library\"","message":"Revert \"Do not expose exceptions from requests library\"\n\nThis reverts commit 2961e82bfa6e375ac3c17933fac532ed316ac976\n\nThis broke cinder unit tests that have a timeout test for novaclient\nwhere they mock the requests library raising a Timeout exception. That\ntest expects to get a requests Timeout passed through but with the\nchange being reverted it was getting a RequestTimeout exception from\nnovaclient, which breaks the test and fails the gate runs.\n\nWe could change the cinder unit test to handle both the requests.Timeout\nand the new novaclient RequestTimeout, but that\u0027s just papering over\nthe cinder failure, we wouldn\u0027t know what other clients are failing\nin the same way because they have code working around the requests\nexceptions getting passed through, so we should treat this like an API\nchange.\n\nI\u0027d be in favor of making the same change again iff the novaclient\nexceptions extended the requests exception types so it would be transparent\nto consumers, since novaclient.exceptions.RequestTimeout would be a\nrequests.Timeout via inheritance. But given the gate breakage and it being\nsummit week I\u0027m inclined to revert first and think about a better long term\nfix later when people are back to discuss.\n\nChange-Id: I368728588e5997eef860a168539eb66c58f2e72a\nCloses-Bug: #1510790\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/63c7a576e194f48f0edb5a0b2d9c4f1d37516e74"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/63c7a576e194f48f0edb5a0b2d9c4f1d37516e74"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}