)]}'
{"id":"openstack%2Fpython-novaclient~239963","triplet_id":"openstack%2Fpython-novaclient~master~I15cbc8f88fd04c86dc46c9587ff631a34e040ff7","project":"openstack/python-novaclient","branch":"master","topic":"bug/1510790-2","hashtags":[],"change_id":"I15cbc8f88fd04c86dc46c9587ff631a34e040ff7","subject":"Make RequestTimeout extend requests.Timeout also","status":"ABANDONED","created":"2015-10-28 15:04:57.000000000","updated":"2015-10-28 15:58:16.000000000","total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"462d56696e57253b8f1dbbfce7129480d38b270c","_number":239963,"virtual_id_number":239963,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"date":"2015-10-28 15:53:58.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"date":"2015-10-28 15:13:54.000000000","_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":2,"date":"2015-10-28 15:18:43.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-1,"date":"2015-10-28 15:20:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-28 15:13:54.000000000","updated_by":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"reviewer":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"state":"REVIEWER"},{"updated":"2015-10-28 15:18:43.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-10-28 15:20:42.000000000","updated_by":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"reviewer":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"state":"REVIEWER"}],"messages":[{"id":"6fb07da8ead239630fedc38b5ad172b45ad79ff1","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 15:04:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5e6510edbf8926cd710e64c9fd596793a3db6ae8","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2015-10-28 15:13:54.000000000","message":"Patch Set 1:\n\nCurious why this was only done for requests.Timeout (aside from the fact that cinder is broken for just this one case)?\n\nWhat about the other exceptions that were transformed in the original patch (requests.TooManyRedirects, requests.RequestException, requests.ConnectionError)?\n\n   https://review.openstack.org/#/c/235558/4/novaclient/exceptions.py\n\n   https://review.openstack.org/#/c/235558/4/novaclient/utils.py","accounts_in_message":[],"_revision_number":1},{"id":"d57f662ecfdfbdf2df1858fa69c9dfa5c11c951f","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-10-28 15:18:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f533277d99a49a70cc7420aadd2fe9eadc4cefe4","author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"date":"2015-10-28 15:20:42.000000000","message":"Patch Set 1: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"5ecd82450c16f3e0977523abd2ca34797b92b383","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 15:53:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1e0ee71a20837cd99d30dc7f886da5c84c9fb182","author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"date":"2015-10-28 15:56:35.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"456524c842622bc7527e60487cf20576a0b0305e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 15:58:16.000000000","message":"Abandoned\n\nI think we should just revert. Duplicating all of the requests library exceptions in novaclient is a waste of time.\n\nhttps://review.openstack.org/#/c/239941/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"dd540f71dcf03b494ce095938ce91999eebbf7aa","revisions":{"dd540f71dcf03b494ce095938ce91999eebbf7aa":{"kind":"REWORK","_number":1,"created":"2015-10-28 15:04:57.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/63/239963/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/63/239963/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/63/239963/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/63/239963/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/63/239963/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/63/239963/1"}}},"commit":{"parents":[{"commit":"217e7c184907ab80b33fb7eb378de162f8976114","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/217e7c184907ab80b33fb7eb378de162f8976114"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-28 14:59:34.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-28 14:59:34.000000000","tz":-420},"subject":"Make RequestTimeout extend requests.Timeout also","message":"Make RequestTimeout extend requests.Timeout also\n\n2961e82bfa6e375ac3c17933fac532ed316ac976 added RequestTimeout and started\nraising RequestTimeout instead of requests.Timeout which broke cinder\nunit tests that expected to handle requests.Timeout but started getting\nRequestTimeout.\n\nChanging the type of exception raised from the client is a backward\nincompatible change and should be handled gracefully, and would require a\nmajor version bump.\n\nWe can get around this for now by making RequestTimeout extend\nrequests.Timeout so that cinder can still work with expecting that type\nof exception.\n\nIf we want to decouple this later, it would have to be in novaclient 3.x.\n\nChange-Id: I15cbc8f88fd04c86dc46c9587ff631a34e040ff7\nCloses-Bug: #1510790\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/dd540f71dcf03b494ce095938ce91999eebbf7aa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/dd540f71dcf03b494ce095938ce91999eebbf7aa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}