)]}'
{"id":"openstack%2Fpython-novaclient~240023","triplet_id":"openstack%2Fpython-novaclient~master~I40a6283a42a565f812a6115e382f852ad784aa92","project":"openstack/python-novaclient","branch":"master","topic":"bug/1406586","hashtags":[],"change_id":"I40a6283a42a565f812a6115e382f852ad784aa92","subject":"Do not expose exceptions from requests library","status":"ABANDONED","created":"2015-10-28 18:59:30.000000000","updated":"2015-12-04 15:06:30.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0bfef8e6802d312e8c13f9d380129e51081ca397","_number":240023,"virtual_id_number":240023,"owner":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":1,"date":"2015-12-01 22:54:27.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},{"date":"2015-12-02 14:39:13.000000000","_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":-1,"date":"2015-12-01 23:28:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":-2,"date":"2015-12-04 11:54:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":1,"date":"2015-12-01 21:54:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},{"value":-1,"date":"2015-12-04 04:18:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":-1,"date":"2015-12-03 21:30:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"date":"2015-12-02 21:02:34.000000000","_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-12-02 21:02:34.000000000","_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"date":"2015-12-02 21:02:34.000000000","_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"date":"2015-12-02 21:02:34.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"date":"2015-12-02 21:02:34.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"date":"2015-12-02 21:02:34.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"date":"2015-12-02 21:02:34.000000000","_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"date":"2015-12-02 21:02:34.000000000","_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"date":"2015-12-02 21:02:34.000000000","_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"date":"2015-12-02 21:02:34.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"date":"2015-12-02 21:02:34.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},{"date":"2015-12-02 21:02:34.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-28 19:01:35.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2015-10-28 19:02:17.000000000","updated_by":{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},"reviewer":{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},"state":"REVIEWER"},{"updated":"2015-10-28 19:02:31.000000000","updated_by":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"reviewer":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"state":"REVIEWER"},{"updated":"2015-10-28 19:03:11.000000000","updated_by":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"reviewer":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"state":"REVIEWER"},{"updated":"2015-10-28 19:03:32.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2015-11-05 16:08:52.000000000","updated_by":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"reviewer":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"state":"REVIEWER"},{"updated":"2015-12-01 21:54:25.000000000","updated_by":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"reviewer":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"state":"REVIEWER"},{"updated":"2015-12-01 22:54:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-12-01 23:28:44.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"reviewer":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"reviewer":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"state":"REVIEWER"},{"updated":"2015-12-02 21:02:34.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2015-12-04 04:18:51.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"}],"messages":[{"id":"df8f8737ea2ece11da117c00fb0d6e2cc9bb073a","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-28 18:59:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4cb1a01dd1715c9b99c260c4200597fd838db3dc","author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"date":"2015-10-28 19:13:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5fb766e3d973b3b0ff5df064fa4012a94b27a40a","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2015-10-28 19:49:20.000000000","message":"Patch Set 1:\n\nRelated discussions can be found here:\n\n    Revert \"Do not expose exceptions from requests library\"\n    https://review.openstack.org/#/c/239941/\n\n    Make RequestTimeout extend requests.Timeout also\n    https://review.openstack.org/#/c/239963/\n\n    Do not expose exceptions from requests library\n    https://review.openstack.org/#/c/235558/","accounts_in_message":[],"_revision_number":1},{"id":"9da39b93748cee4fa497b4c4b0b4f3c738c493ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-28 19:52:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/23/240023/1/check/gate-python-novaclient-python26/be12be4/ : SUCCESS in 1m 25s\n- gate-python-novaclient-pep8 http://logs.openstack.org/23/240023/1/check/gate-python-novaclient-pep8/50e7c50/ : SUCCESS in 1m 18s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/23/240023/1/check/gate-python-novaclient-docs/93327fd//doc/build/html/ : SUCCESS in 1m 18s\n- gate-python-novaclient-python27 http://logs.openstack.org/23/240023/1/check/gate-python-novaclient-python27/c00f378/ : SUCCESS in 1m 31s\n- gate-python-novaclient-python34 http://logs.openstack.org/23/240023/1/check/gate-python-novaclient-python34/91aa2ae/ : SUCCESS in 1m 53s\n- gate-python-novaclient-pypy http://logs.openstack.org/23/240023/1/check/gate-python-novaclient-pypy/26455c4/ : SUCCESS in 2m 08s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/23/240023/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/c50ba70/ : SUCCESS in 52m 37s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/23/240023/1/check/gate-novaclient-dsvm-functional/9d65f51/ : SUCCESS in 28m 03s","accounts_in_message":[],"_revision_number":1},{"id":"02f95d12fbfc15bb6b3fe43c75f1a2c30a889b75","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-28 19:54:11.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nI\u0027m kind of burned out on thinking about this since it\u0027s a mess, but the commit message should at least be updated.\n\nI think we\u0027re going to need to sit back and talk to some people like sdague after the summit about the long-term plan here and what this buys us.","accounts_in_message":[],"_revision_number":1},{"id":"b507f1a886fbd4af44531a65208d02fc9ba029b9","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-28 20:10:09.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nMatt, this buys us the ability to use python-novaclient without relying on an implementation detail that could change.  See this Heat patch for an example: https://review.openstack.org/#/c/238257/","accounts_in_message":[],"_revision_number":1},{"id":"31e8859b8fb65b336684dc9eb03e930195760d86","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-10-28 20:10:23.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1abe02187af23d7920c9556fc16c58f9f0328f82","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-28 21:00:59.000000000","message":"Patch Set 2: Code-Review-1\n\nAfter watching this break chain, I\u0027m not sure I understand why an abstraction layer on top of requests is useful in any way here. I think before going down this path we need a really strong justification about what future we\u0027re gonig to have a novaclient not based on requests.","accounts_in_message":[],"_revision_number":2},{"id":"92e64b852db019bd70142661aef7f0309845f646","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-28 21:02:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/23/240023/2/check/gate-python-novaclient-python26/961c15f/ : SUCCESS in 1m 26s\n- gate-python-novaclient-pep8 http://logs.openstack.org/23/240023/2/check/gate-python-novaclient-pep8/c9a2cc9/ : SUCCESS in 48s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/23/240023/2/check/gate-python-novaclient-docs/4352261//doc/build/html/ : SUCCESS in 1m 29s\n- gate-python-novaclient-python27 http://logs.openstack.org/23/240023/2/check/gate-python-novaclient-python27/27ae29e/ : SUCCESS in 1m 40s\n- gate-python-novaclient-python34 http://logs.openstack.org/23/240023/2/check/gate-python-novaclient-python34/0321732/ : SUCCESS in 2m 08s\n- gate-python-novaclient-pypy http://logs.openstack.org/23/240023/2/check/gate-python-novaclient-pypy/08eb892/ : SUCCESS in 2m 09s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/23/240023/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/e65c3c8/ : SUCCESS in 52m 29s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/23/240023/2/check/gate-novaclient-dsvm-functional/5f789e7/ : SUCCESS in 29m 05s","accounts_in_message":[],"_revision_number":2},{"id":"7fdd21e32d74c6cf6c212a573adafc70f6c41b53","author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"date":"2015-10-29 14:56:17.000000000","message":"Patch Set 2:\n\n\u003e I think before going down this path we need a really strong justification about what future we\u0027re gonig to have a novaclient not based on requests.\n\nWe cannot foresee exactly how the status might change in the future. I agree that it looks very unlikely that we will use something other than requests. But that does not mean that abstracting out requests from novaclient is not a good idea. Especially when there is a patch to fix this and a proposal which seems good.\n\nWe should really think about architectural principles rather than immediate future needs. Good principles tend to yield great results in the future.","accounts_in_message":[],"_revision_number":2},{"id":"2145a453a3edee35c0bdc9ba09d39c91a5186df8","author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"date":"2015-11-05 16:08:52.000000000","message":"Patch Set 2: Code-Review+1\n\nYes, its probably unlikely that a move from Requests is in the future, but this is an implementation detail that should be hidden from the client. Any exception that comes out of this library should be rooted in the library-specific exception hierarchy to allow users to only deal with those exceptions and not the multitude that may result from dependencies. Its just good user experience IMO.","accounts_in_message":[],"_revision_number":2},{"id":"dd146543fbcf32525ef11f3f256825082bf19689","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 12:55:10.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"aca6b8bae5750e41f87bd2977098071f4ed99701","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-12-01 21:50:52.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5bae0e0e9b693f145b4fd7c53d19b82e689f8dcb","author":{"_account_id":13720,"name":"Pratik Mallya","email":"pratik.mallya@gmail.com","username":"pmallya"},"date":"2015-12-01 21:54:25.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"47a411f289e60a0ce70ef8d6f2990623ad1d5d64","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-01 22:54:27.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/23/240023/3/check/gate-python-novaclient-python26/708cc7f/ : SUCCESS in 1m 55s\n- gate-python-novaclient-pep8 http://logs.openstack.org/23/240023/3/check/gate-python-novaclient-pep8/f644185/ : SUCCESS in 1m 03s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/23/240023/3/check/gate-python-novaclient-docs/f144f30//doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-novaclient-python27 http://logs.openstack.org/23/240023/3/check/gate-python-novaclient-python27/d51cd63/ : SUCCESS in 1m 54s\n- gate-python-novaclient-python34 http://logs.openstack.org/23/240023/3/check/gate-python-novaclient-python34/6466276/ : SUCCESS in 2m 22s\n- gate-python-novaclient-pypy http://logs.openstack.org/23/240023/3/check/gate-python-novaclient-pypy/6b942d8/ : SUCCESS in 2m 40s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/23/240023/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/5a0f05c/ : SUCCESS in 59m 35s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/23/240023/3/check/gate-novaclient-dsvm-functional/67851d7/ : SUCCESS in 27m 29s","accounts_in_message":[],"_revision_number":3},{"id":"92ac812f2028e21aabeb492802feda63ec03cf78","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-12-01 23:28:44.000000000","message":"Patch Set 3: Code-Review-1\n\nOnce burned, twice shy; philosophically, I was against this to begin with, and after seeing the breakage that resulted last time, I favor a more careful discussion before we go down this path.","accounts_in_message":[],"_revision_number":3},{"id":"21768d422d8389ad25e3e6718c68c04d326daff9","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-12-02 14:39:13.000000000","message":"Patch Set 3:\n\nLet\u0027s discuss it then.  There have been a few rebuttals from the exception-converting side of the fence.  Please share your concerns with this specific patch and ideas on how to move forward.","accounts_in_message":[],"_revision_number":3},{"id":"e69b84dbf5957fc41c494fdb496ad1e4c6468d41","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-12-03 21:27:30.000000000","message":"Patch Set 3:\n\nFor clarity, I meant, \"Let\u0027s start a discussion on the openstack-dev list\".\n\nBTW, we\u0027re gearing up toward a 3.0.0 release of novaclient, so if we\u0027re going to do this (which I and several other cores seem to think we don\u0027t), now would be the time to get this figured out…","accounts_in_message":[],"_revision_number":3},{"id":"a457688c24ca8ed55d0d3833d8a04aafc01d818a","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-12-03 21:30:49.000000000","message":"Patch Set 3: Code-Review-1\n\nhonestly, I don\u0027t see the point. If anything, I\u0027d rather have novaclient get thinner and look more like requests, not further abstract from it.","accounts_in_message":[],"_revision_number":3},{"id":"5ae83b97619bb7170fbec04396ed22bcfe472a13","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-12-03 23:45:25.000000000","message":"Patch Set 3:\n\nI get the point of this (client user agnostic to underlying library exception) but after some research I don\u0027t find examples of clients abstracting this away in openstack or otherwise. And it\u0027s unreasonable if you imagine a client trying to catch and convert *every* exception that could come out of any underlying library. Here we have some common ones, but thinking about it in general it gets unwieldy.","accounts_in_message":[],"_revision_number":3},{"id":"c8a546be552763080363be42abd6daffea47a522","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-12-04 04:18:51.000000000","message":"Patch Set 3: Code-Review-1\n\nThis sets a precedent that novaclient has to handle and wrap every exception that can come out from below it, which is unrealistic, and is not backwards compatible, so I\u0027m -1 on this change.","accounts_in_message":[],"_revision_number":3},{"id":"92de2706aba269749e29fbc6ff8a413c66274428","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2015-12-04 11:54:50.000000000","message":"Patch Set 3: Code-Review-2\n\nSeems like we have a consensus not to take this approach.\n\nIt might be something to talk to the OpenStack SDK folks about, as they have more room to change their interface.","accounts_in_message":[],"_revision_number":3},{"id":"868b2de6fa528e06e6fa8b6e0b538ef924674ca4","author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"date":"2015-12-04 15:06:30.000000000","message":"Abandoned\n\nThanks for the feedback","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"fe1b6996dd9a5c6c4949f63d7601ed18e635db1a","revisions":{"53cdabb06cee936a02193a715f8f6de65b65a3ce":{"kind":"REWORK","_number":1,"created":"2015-10-28 18:59:30.000000000","uploader":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"ref":"refs/changes/23/240023/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/23/240023/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/1"}}},"commit":{"parents":[{"commit":"63c7a576e194f48f0edb5a0b2d9c4f1d37516e74","subject":"Revert \"Do not expose exceptions from requests library\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/63c7a576e194f48f0edb5a0b2d9c4f1d37516e74"}]}],"author":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-15 17:00:39.000000000","tz":-300},"committer":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-28 18:58:35.000000000","tz":-300},"subject":"Do not expose exceptions from requests library","message":"Do not expose exceptions from requests library\n\nNovaclient expects the requests library to always be able to get a\nresponse back and doesn\u0027t handle other cases where it might raise\nan exception even before the request is completed (e.g.\nConnectionError).\n\nThese exceptions should be captured and properly converted to some\nnative novaclient exception.\n\nChange-Id: I40a6283a42a565f812a6115e382f852ad784aa92\nCo-Authored-By: Kuo-tung Kao \u003cjelly.k@inwinstack.com\u003e\nCloses-Bug: #1406586\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/53cdabb06cee936a02193a715f8f6de65b65a3ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/53cdabb06cee936a02193a715f8f6de65b65a3ce"}]},"branch":"refs/heads/master"},"2bb751d722b4655b37c402b552b86851ccf7e50c":{"kind":"REWORK","_number":2,"created":"2015-10-28 20:10:23.000000000","uploader":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"ref":"refs/changes/23/240023/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/23/240023/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/2"}}},"commit":{"parents":[{"commit":"63c7a576e194f48f0edb5a0b2d9c4f1d37516e74","subject":"Revert \"Do not expose exceptions from requests library\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/63c7a576e194f48f0edb5a0b2d9c4f1d37516e74"}]}],"author":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-15 17:00:39.000000000","tz":-300},"committer":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-28 20:01:20.000000000","tz":-300},"subject":"Do not expose exceptions from requests library","message":"Do not expose exceptions from requests library\n\nNovaclient expects the requests library to always be able to get a\nresponse back and doesn\u0027t handle other cases where it might raise\nan exception even before the request is completed (e.g.\nConnectionError).\n\nThese exceptions should be captured and properly converted to some\nnative novaclient exception.\n\nThis was originally proposed in https://review.openstack.org/#/c/235558/\nwithout inheriting exceptions from the requests library.  That broke the\ncinder gate, which relied on the old behavior, so it was reverted in\nhttps://review.openstack.org/#/c/239941/.\n\nIn this patch, the new exceptions inherit from the requests exceptions\nto ease the downstream projects\u0027 transition to expecting novaclient\nexceptions instead of requests exceptions.\n\nChange-Id: I40a6283a42a565f812a6115e382f852ad784aa92\nCo-Authored-By: Kuo-tung Kao \u003cjelly.k@inwinstack.com\u003e\nCloses-Bug: #1406586\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2bb751d722b4655b37c402b552b86851ccf7e50c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2bb751d722b4655b37c402b552b86851ccf7e50c"}]},"branch":"refs/heads/master"},"fe1b6996dd9a5c6c4949f63d7601ed18e635db1a":{"kind":"REWORK","_number":3,"created":"2015-12-01 21:50:52.000000000","uploader":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"ref":"refs/changes/23/240023/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/23/240023/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/23/240023/3"}}},"commit":{"parents":[{"commit":"f1b8a717d4ae077928791ecd73239dad0b9e08d2","subject":"Merge \"force releasenotes warnings to be treated as errors\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f1b8a717d4ae077928791ecd73239dad0b9e08d2"}]}],"author":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-10-15 17:00:39.000000000","tz":-300},"committer":{"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","date":"2015-12-01 21:50:39.000000000","tz":-360},"subject":"Do not expose exceptions from requests library","message":"Do not expose exceptions from requests library\n\nNovaclient expects the requests library to always be able to get a\nresponse back and doesn\u0027t handle other cases where it might raise\nan exception even before the request is completed (e.g.\nConnectionError).\n\nThese exceptions should be captured and properly converted to some\nnative novaclient exception.\n\nThis was originally proposed in https://review.openstack.org/#/c/235558/\nwithout inheriting exceptions from the requests library.  That broke the\ncinder gate, which relied on the old behavior, so it was reverted in\nhttps://review.openstack.org/#/c/239941/.\n\nIn this patch, the new exceptions inherit from the requests exceptions\nto ease the downstream projects\u0027 transition to expecting novaclient\nexceptions instead of requests exceptions.\n\nChange-Id: I40a6283a42a565f812a6115e382f852ad784aa92\nCo-Authored-By: Kuo-tung Kao \u003cjelly.k@inwinstack.com\u003e\nCloses-Bug: #1406586\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fe1b6996dd9a5c6c4949f63d7601ed18e635db1a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fe1b6996dd9a5c6c4949f63d7601ed18e635db1a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
