)]}'
{"id":"openstack%2Fpython-novaclient~2465","triplet_id":"openstack%2Fpython-novaclient~master~Iccfcfbc58eccfa12994dfd5f07f5b4719e85b2ef","project":"openstack/python-novaclient","branch":"master","topic":"jd/rename-api_key","hashtags":[],"change_id":"Iccfcfbc58eccfa12994dfd5f07f5b4719e85b2ef","subject":"Rename api_key to password","status":"ABANDONED","created":"2011-12-19 16:39:00.000000000","updated":"2012-02-08 06:03:02.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"44cd1769c9f8744f35ce921f2a065e9c83ca7f34","_number":2465,"virtual_id_number":2465,"owner":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":0,"date":"2011-12-19 20:15:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":-2,"date":"2011-12-19 17:24:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"date":"2011-12-19 16:47:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"date":"2011-12-19 16:51:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":2,"date":"2012-01-03 14:14:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"date":"2011-12-31 00:00:19.000000000","_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"date":"2012-01-03 14:14:31.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-12-19 16:51:39.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2011-12-19 17:24:39.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2011-12-31 00:00:19.000000000","updated_by":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"reviewer":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"state":"REVIEWER"},{"updated":"2012-01-03 14:14:31.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"}],"messages":[{"id":"fac567ef98c5720e8408e376ed24dfabf393d6ba","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-12-19 16:40:11.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"f928ee99c786688f520053694cb4ab6e6f13c743","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2011-12-19 16:47:07.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"6a402d817d51519cd69d25907ad953e6cb0ad6e7","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2011-12-19 17:24:39.000000000","message":"Patch Set 1: Do not submit\n\nKeystone Auth supports both passwords and API keys. At the moment, there is no way to distinguish between the two in python-novaclient, but that is something that will need to be addressed.","accounts_in_message":[],"_revision_number":1},{"id":"035c0096e850a6647282a53a5b9834b99df8aab7","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2011-12-19 17:54:58.000000000","message":"Patch Set 1:\n\n@Josh: could you elaborate on the reasons? I can\u0027t see why it\u0027s wrong, and I\u0027d like to :) Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"863742e7ab8f0cb643ae002684f31351afa74765","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2011-12-19 17:58:50.000000000","message":"Patch Set 1:\n\nKeystone will accept both a password and an API key for authentication. Right now, there is no way to distinguish between the two in novaclient, but that is something we will need to add down the road.","accounts_in_message":[],"_revision_number":1},{"id":"5f4dc4696c4d6398118f8939a6346b27628e5fd4","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-12-19 20:15:37.000000000","message":"Patch Set 1:\n\nthere is no API_KEY in keystone.  There is a proof of concept of a rackspace specific extension that is going to be removed since there isn\u0027t time to finish it during essex timeframe","accounts_in_message":[],"_revision_number":1},{"id":"e227ebeb1fc8506d352c826ab7012dee707e736f","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2011-12-20 09:16:11.000000000","message":"Patch Set 1:\n\nI can\u0027t see API_KEY in Keystone too, so any pointer appreciated, or please reset this review. :)","accounts_in_message":[],"_revision_number":1},{"id":"b71e6a4a06e16591e56ac9d67b7321358dd5923b","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-12-31 00:00:19.000000000","message":"Patch Set 1:\n\nI think removing api_key is correct for openstack.  we have no such thing as an api key in openstack","accounts_in_message":[],"_revision_number":1},{"id":"fca902df3c9cfb2f7d310b3acfaab930bbdd07b6","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-01-03 14:14:31.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nYeah, it makes sense to call this password internally.","accounts_in_message":[],"_revision_number":1},{"id":"37777fe1c1358a846366a4af558d42afdac2f6ef","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-01-24 06:03:14.000000000","message":"Patch Set 1:\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":1},{"id":"3e56bceaf7035cee50043610c993e42b3fac8241","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-01-24 06:03:14.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":1},{"id":"ca088612614a4e3359b86807760939b85681d43e","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2012-01-24 08:34:41.000000000","message":"Patch Set 1: Restored\n\nIt was so close to pass!","accounts_in_message":[],"_revision_number":1},{"id":"ec5a3427ce35c04512f0ea965e288f8be9ecfcae","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-02-08 06:03:02.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":1},{"id":"400e367962b949d15ecbef1d9cb82e6555a16559","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-02-08 06:03:02.000000000","message":"Patch Set 1:\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9bf15c729b880076a4fadedf4a5c037befe315f4","revisions":{"9bf15c729b880076a4fadedf4a5c037befe315f4":{"kind":"REWORK","_number":1,"created":"2011-12-19 16:39:00.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/65/2465/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/65/2465/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/2465/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/2465/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/65/2465/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/65/2465/1"}}},"commit":{"parents":[{"commit":"3661be66730efd4bce32fd54e2443c42ad91edbd","subject":"Removed v1.0 support.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3661be66730efd4bce32fd54e2443c42ad91edbd"}]}],"author":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-19 16:37:45.000000000","tz":60},"committer":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-19 16:37:45.000000000","tz":60},"subject":"Rename api_key to password","message":"Rename api_key to password\n\nChange I37e57e83187e3dd28c55ad33073e0ff7e4df5d76 removed the last usage of\napi_key as a keyword argument, therefore it is now safe to rename it.\n\nChange-Id: Iccfcfbc58eccfa12994dfd5f07f5b4719e85b2ef\nSigned-off-by: Julien Danjou \u003cjulien.danjou@enovance.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9bf15c729b880076a4fadedf4a5c037befe315f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9bf15c729b880076a4fadedf4a5c037befe315f4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}