)]}'
{"novaclient/api_versions.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d25e98b14ccbd4573e38b609862c650464daeefe","unresolved":false,"context_lines":[{"line_number":313,"context_line":"def check_headers(response, api_version):"},{"line_number":314,"context_line":"    \"\"\"Checks that \u0027X-OpenStack-Nova-API-Version\u0027 header in response.\"\"\""},{"line_number":315,"context_line":"    if api_version.ver_minor \u003e 0 and HEADER_NAME not in response.headers:"},{"line_number":316,"context_line":"        LOG.warning(_(\"Your request processed by Nova API, which doesn\u0027t \""},{"line_number":317,"context_line":"                      \"support microversion(%s header is missed in response). \""},{"line_number":318,"context_line":"                      \"Warning: Response can be incorrect.\") % HEADER_NAME)"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_d511b105","line":316,"updated":"2015-11-23 15:43:40.000000000","message":"This should use _LW.","commit_id":"268f14a91fe95f8d2aef7b966ed81a26090d75a0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a926f6be1bfd463dac42ed27633683762c845517","unresolved":false,"context_lines":[{"line_number":313,"context_line":"def check_headers(response, api_version):"},{"line_number":314,"context_line":"    \"\"\"Checks that \u0027X-OpenStack-Nova-API-Version\u0027 header in response.\"\"\""},{"line_number":315,"context_line":"    if api_version.ver_minor \u003e 0 and HEADER_NAME not in response.headers:"},{"line_number":316,"context_line":"        LOG.warning(_(\"Your request processed by Nova API, which doesn\u0027t \""},{"line_number":317,"context_line":"                      \"support microversion(%s header is missed in response). \""},{"line_number":318,"context_line":"                      \"Warning: Response can be incorrect.\") % HEADER_NAME)"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_35583d56","line":316,"in_reply_to":"ba8a016a_d511b105","updated":"2015-11-23 16:01:03.000000000","message":"Done","commit_id":"268f14a91fe95f8d2aef7b966ed81a26090d75a0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d25e98b14ccbd4573e38b609862c650464daeefe","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    \"\"\"Checks that \u0027X-OpenStack-Nova-API-Version\u0027 header in response.\"\"\""},{"line_number":315,"context_line":"    if api_version.ver_minor \u003e 0 and HEADER_NAME not in response.headers:"},{"line_number":316,"context_line":"        LOG.warning(_(\"Your request processed by Nova API, which doesn\u0027t \""},{"line_number":317,"context_line":"                      \"support microversion(%s header is missed in response). \""},{"line_number":318,"context_line":"                      \"Warning: Response can be incorrect.\") % HEADER_NAME)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_b5fd0d70","line":317,"updated":"2015-11-23 15:43:40.000000000","message":"Put a space between \u0027microversion\u0027 and (.","commit_id":"268f14a91fe95f8d2aef7b966ed81a26090d75a0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a926f6be1bfd463dac42ed27633683762c845517","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    \"\"\"Checks that \u0027X-OpenStack-Nova-API-Version\u0027 header in response.\"\"\""},{"line_number":315,"context_line":"    if api_version.ver_minor \u003e 0 and HEADER_NAME not in response.headers:"},{"line_number":316,"context_line":"        LOG.warning(_(\"Your request processed by Nova API, which doesn\u0027t \""},{"line_number":317,"context_line":"                      \"support microversion(%s header is missed in response). \""},{"line_number":318,"context_line":"                      \"Warning: Response can be incorrect.\") % HEADER_NAME)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_55538139","line":317,"in_reply_to":"ba8a016a_b5fd0d70","updated":"2015-11-23 16:01:03.000000000","message":"Done","commit_id":"268f14a91fe95f8d2aef7b966ed81a26090d75a0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d25e98b14ccbd4573e38b609862c650464daeefe","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    if api_version.ver_minor \u003e 0 and HEADER_NAME not in response.headers:"},{"line_number":316,"context_line":"        LOG.warning(_(\"Your request processed by Nova API, which doesn\u0027t \""},{"line_number":317,"context_line":"                      \"support microversion(%s header is missed in response). \""},{"line_number":318,"context_line":"                      \"Warning: Response can be incorrect.\") % HEADER_NAME)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"def add_substitution(versioned_method):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_75a3259f","line":318,"updated":"2015-11-23 15:43:40.000000000","message":"You should pass HEADER_NAME as an arg to the log method, i.e.:\n\nLOG.warning(_LW(\u0027Your request...\u0027), HEADER_NAME)","commit_id":"268f14a91fe95f8d2aef7b966ed81a26090d75a0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a926f6be1bfd463dac42ed27633683762c845517","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    if api_version.ver_minor \u003e 0 and HEADER_NAME not in response.headers:"},{"line_number":316,"context_line":"        LOG.warning(_(\"Your request processed by Nova API, which doesn\u0027t \""},{"line_number":317,"context_line":"                      \"support microversion(%s header is missed in response). \""},{"line_number":318,"context_line":"                      \"Warning: Response can be incorrect.\") % HEADER_NAME)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"def add_substitution(versioned_method):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_f5307509","line":318,"in_reply_to":"ba8a016a_75a3259f","updated":"2015-11-23 16:01:03.000000000","message":"Done","commit_id":"268f14a91fe95f8d2aef7b966ed81a26090d75a0"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"5624130d9a7565da83e779ca1d5cd7f56909b30f","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        LOG.warning(_LW("},{"line_number":317,"context_line":"            \"Your request processed by Nova API, which doesn\u0027t support \""},{"line_number":318,"context_line":"            \"microversions (%s header is missed in response). \""},{"line_number":319,"context_line":"            \"Warning: Response can be incorrect.\"), HEADER_NAME)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"def add_substitution(versioned_method):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_b38f5e22","line":319,"updated":"2015-11-23 17:53:28.000000000","message":"Rephrase as:\n\n    Your request was processed by a Nova API which does not support\n    microversions (%s header is missing from response).  Warning:\n    Response may be incorrect.","commit_id":"bc9e813d14b44edb2280d2e891a5945be29c62c4"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a8cadd85d7942e6552c56786a7edeefcc3da6425","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        LOG.warning(_LW("},{"line_number":317,"context_line":"            \"Your request processed by Nova API, which doesn\u0027t support \""},{"line_number":318,"context_line":"            \"microversions (%s header is missed in response). \""},{"line_number":319,"context_line":"            \"Warning: Response can be incorrect.\"), HEADER_NAME)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"def add_substitution(versioned_method):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_fe492dd1","line":319,"in_reply_to":"ba8a016a_b38f5e22","updated":"2015-11-23 18:13:48.000000000","message":"Thanks! Fixed","commit_id":"bc9e813d14b44edb2280d2e891a5945be29c62c4"}]}