)]}'
{"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2af0106df61ca1b315ea9e7fee83767e66f436b2","unresolved":false,"context_lines":[{"line_number":704,"context_line":"          \u0027 not specified.\u0027))"},{"line_number":705,"context_line":"def do_flavor_list(cs, args):"},{"line_number":706,"context_line":"    \"\"\"Print a list of available \u0027flavors\u0027 (sizes of servers).\"\"\""},{"line_number":707,"context_line":"    _sort_key \u003d None"},{"line_number":708,"context_line":"    _sort_dir \u003d None"},{"line_number":709,"context_line":"    if args.sort:"},{"line_number":710,"context_line":"        _sort_key, _sep, _sort_dir \u003d args.sort.partition(\u0027:\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_0a099c2c","line":707,"updated":"2015-11-24 17:04:16.000000000","message":"For variables in a function, a leading \u0027_\u0027 is usually used to indicate a dummy variable, that is, a variable to which an assignment is made, but which is then not referred to later.  An example of this is the \u0027_sep\u0027 variable on line 710—it captures the separator (\u0027:\u0027), but the rest of the function does not refer to it.  All that to say: please name these variables \"sort_key\" and \"sort_dir\" :)","commit_id":"5da8193ac6116637238e1d3bccffa6980b6c8c94"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2af0106df61ca1b315ea9e7fee83767e66f436b2","unresolved":false,"context_lines":[{"line_number":707,"context_line":"    _sort_key \u003d None"},{"line_number":708,"context_line":"    _sort_dir \u003d None"},{"line_number":709,"context_line":"    if args.sort:"},{"line_number":710,"context_line":"        _sort_key, _sep, _sort_dir \u003d args.sort.partition(\u0027:\u0027)"},{"line_number":711,"context_line":"        if not _sort_dir:"},{"line_number":712,"context_line":"            _sort_dir \u003d \u0027desc\u0027"},{"line_number":713,"context_line":"        elif _sort_dir not in (\u0027asc\u0027, \u0027desc\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_aa9c106a","line":710,"updated":"2015-11-24 17:04:16.000000000","message":"The argument help, apparently copied from the same argument in do_list(), specifies a comma-separated list of sort keys and directions; however, you are not splitting on commas or looping over the results here.  If you\u0027re going to copy the --sort description from do_list() (which consistency argues you should do), you should also copy the code for processing the option.  (Or better yet, factor it out as a utility method that returns the correct values of sort_key and sort_dir…)","commit_id":"5da8193ac6116637238e1d3bccffa6980b6c8c94"}]}