)]}'
{"novaclient/v2/shell.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1e383d8580f49d440017bce793d363735fde4e90","unresolved":false,"context_lines":[{"line_number":4677,"context_line":"        columns \u003d [\"Id\", \"Status\", \"Updated\"]"},{"line_number":4678,"context_line":""},{"line_number":4679,"context_line":"    print (_(\"current default nova client version is \""},{"line_number":4680,"context_line":"             \"%(v)s\") % {\u0027v\u0027: novaclient.API_MAX_VERSION})"},{"line_number":4681,"context_line":"    utils.print_list(result, columns)"},{"line_number":4682,"context_line":"    "}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_f2bea6d3","line":4680,"updated":"2015-11-24 11:20:58.000000000","message":"This version is not default. Default version is calculated based on supported by clients and server. If server supported MAX_VERSION will be equal to client (MAX_VERSION - 1) , (MAX_VERSION - 1) will be used as default.\n\nIt would be nice to display here MIN and MAX versions supported by client.","commit_id":"bd2885cea29f77f1c9fa16c3600300ed8188c3ff"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e60c2a19ebc2daaaaf10bc536f0deb00436a5944","unresolved":false,"context_lines":[{"line_number":4677,"context_line":"        columns \u003d [\"Id\", \"Status\", \"Updated\"]"},{"line_number":4678,"context_line":""},{"line_number":4679,"context_line":"    print (_(\"current default nova client version is \""},{"line_number":4680,"context_line":"             \"%(v)s\") % {\u0027v\u0027: novaclient.API_MAX_VERSION})"},{"line_number":4681,"context_line":"    utils.print_list(result, columns)"},{"line_number":4682,"context_line":"    "}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_587c7120","line":4680,"in_reply_to":"9a8ffd7b_f2bea6d3","updated":"2015-11-24 11:55:55.000000000","message":"yes, you are right, I will change it","commit_id":"bd2885cea29f77f1c9fa16c3600300ed8188c3ff"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1e383d8580f49d440017bce793d363735fde4e90","unresolved":false,"context_lines":[{"line_number":4678,"context_line":""},{"line_number":4679,"context_line":"    print (_(\"current default nova client version is \""},{"line_number":4680,"context_line":"             \"%(v)s\") % {\u0027v\u0027: novaclient.API_MAX_VERSION})"},{"line_number":4681,"context_line":"    utils.print_list(result, columns)"},{"line_number":4682,"context_line":"    "}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_329c2e69","line":4681,"updated":"2015-11-24 11:20:58.000000000","message":"I prefer to add message \"Server-side API versions:\" before this line.","commit_id":"bd2885cea29f77f1c9fa16c3600300ed8188c3ff"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e60c2a19ebc2daaaaf10bc536f0deb00436a5944","unresolved":false,"context_lines":[{"line_number":4678,"context_line":""},{"line_number":4679,"context_line":"    print (_(\"current default nova client version is \""},{"line_number":4680,"context_line":"             \"%(v)s\") % {\u0027v\u0027: novaclient.API_MAX_VERSION})"},{"line_number":4681,"context_line":"    utils.print_list(result, columns)"},{"line_number":4682,"context_line":"    "}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_985739ca","line":4681,"in_reply_to":"9a8ffd7b_329c2e69","updated":"2015-11-24 11:55:55.000000000","message":"ok","commit_id":"bd2885cea29f77f1c9fa16c3600300ed8188c3ff"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"36123adb4a6035a641444ce473b4115829b6ef40","unresolved":false,"context_lines":[{"line_number":4676,"context_line":"    else:"},{"line_number":4677,"context_line":"        columns \u003d [\"Id\", \"Status\", \"Updated\"]"},{"line_number":4678,"context_line":""},{"line_number":4679,"context_line":"    print (_(\"Client side API versions can be used on server side\"))"},{"line_number":4680,"context_line":"    print (_(\"Minimum version %(v)s\") % {\u0027v\u0027: novaclient.API_MIN_VERSION})"},{"line_number":4681,"context_line":"    print (_(\"Maximum version %(v)s\") % {\u0027v\u0027: novaclient.API_MAX_VERSION})"},{"line_number":4682,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_ea51b863","line":4679,"updated":"2015-11-24 17:09:37.000000000","message":"1. You have an extraneous space after the \u0027print\u0027 function name that needs to be removed.\n\n2. I\u0027d rephrase this as:\n\n    Client supported API versions:\n    Minimum version 2.1\n    Maximum version 2.6","commit_id":"b26d5438f53dede2908c7a41c0b7444bd6fd301d"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c905baed10901bd5e7248d463ae321d41a625164","unresolved":false,"context_lines":[{"line_number":4676,"context_line":"    else:"},{"line_number":4677,"context_line":"        columns \u003d [\"Id\", \"Status\", \"Updated\"]"},{"line_number":4678,"context_line":""},{"line_number":4679,"context_line":"    print (_(\"Client side API versions can be used on server side\"))"},{"line_number":4680,"context_line":"    print (_(\"Minimum version %(v)s\") % {\u0027v\u0027: novaclient.API_MIN_VERSION})"},{"line_number":4681,"context_line":"    print (_(\"Maximum version %(v)s\") % {\u0027v\u0027: novaclient.API_MAX_VERSION})"},{"line_number":4682,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_2dcb3120","line":4679,"in_reply_to":"9a8ffd7b_ea51b863","updated":"2015-11-25 11:33:01.000000000","message":"ok , I think it\u0027s more precise, thanks a lot ~","commit_id":"b26d5438f53dede2908c7a41c0b7444bd6fd301d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"36123adb4a6035a641444ce473b4115829b6ef40","unresolved":false,"context_lines":[{"line_number":4680,"context_line":"    print (_(\"Minimum version %(v)s\") % {\u0027v\u0027: novaclient.API_MIN_VERSION})"},{"line_number":4681,"context_line":"    print (_(\"Maximum version %(v)s\") % {\u0027v\u0027: novaclient.API_MAX_VERSION})"},{"line_number":4682,"context_line":""},{"line_number":4683,"context_line":"    print (_(\"\\nServer side API versions:\"))"},{"line_number":4684,"context_line":"    utils.print_list(result, columns)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_ead8d8f1","line":4683,"updated":"2015-11-24 17:09:37.000000000","message":"Along with my suggested change above, this could be rephrased as:\n\n    Server supported API versions:","commit_id":"b26d5438f53dede2908c7a41c0b7444bd6fd301d"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c905baed10901bd5e7248d463ae321d41a625164","unresolved":false,"context_lines":[{"line_number":4680,"context_line":"    print (_(\"Minimum version %(v)s\") % {\u0027v\u0027: novaclient.API_MIN_VERSION})"},{"line_number":4681,"context_line":"    print (_(\"Maximum version %(v)s\") % {\u0027v\u0027: novaclient.API_MAX_VERSION})"},{"line_number":4682,"context_line":""},{"line_number":4683,"context_line":"    print (_(\"\\nServer side API versions:\"))"},{"line_number":4684,"context_line":"    utils.print_list(result, columns)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_ed5d297a","line":4683,"in_reply_to":"9a8ffd7b_ead8d8f1","updated":"2015-11-25 11:33:01.000000000","message":"Done","commit_id":"b26d5438f53dede2908c7a41c0b7444bd6fd301d"}]}