)]}'
{"novaclient/tests/functional/v2/test_keypairs.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"88af829f03c0f1fd645aa05a13ae14e86ef0cbb8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        output \u003d self.another_nova(\"keypair-list\")"},{"line_number":119,"context_line":"        self.assertRaises("},{"line_number":120,"context_line":"            ValueError,"},{"line_number":121,"context_line":"            self._get_column_value_from_single_row_table(output, \"Name\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_e3a52d04","line":121,"updated":"2015-12-04 17:59:05.000000000","message":"last mistake","commit_id":"3a8a28d9d0f98e61da070dbe07518b0e7281d0f5"}],"novaclient/v2/shell.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c6733f54a3bb4c3430619061c0f531804b999a6c","unresolved":false,"context_lines":[{"line_number":3114,"context_line":"    help\u003d_(\u0027Id of key-pair owner (Admin only).\u0027))"},{"line_number":3115,"context_line":"def do_keypair_show(cs, args):"},{"line_number":3116,"context_line":"    \"\"\"Show details about the given keypair.\"\"\""},{"line_number":3117,"context_line":"    keypair \u003d cs.keypairs.get(args.keypair, args.user)"},{"line_number":3118,"context_line":"    _print_keypair(keypair)"},{"line_number":3119,"context_line":""},{"line_number":3120,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_cbef6d1c","line":3117,"updated":"2015-12-08 13:35:23.000000000","message":"maybe also use _find_keypair below with some args?","commit_id":"65658ed6fca868430a4d9e074e4345c7b7f4bfc9"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"3ebb868f4475e38e180f0aee04a07783d0d24120","unresolved":false,"context_lines":[{"line_number":3114,"context_line":"    help\u003d_(\u0027Id of key-pair owner (Admin only).\u0027))"},{"line_number":3115,"context_line":"def do_keypair_show(cs, args):"},{"line_number":3116,"context_line":"    \"\"\"Show details about the given keypair.\"\"\""},{"line_number":3117,"context_line":"    keypair \u003d cs.keypairs.get(args.keypair, args.user)"},{"line_number":3118,"context_line":"    _print_keypair(keypair)"},{"line_number":3119,"context_line":""},{"line_number":3120,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_1db4dc32","line":3117,"in_reply_to":"7a740942_2b587187","updated":"2015-12-08 13:48:49.000000000","message":"yeah, I am doing other patches and noticed this \nutils.find_resource(xxx) usage, I thought it\u0027s a recommended way to do it , but anyway, it LGTM, thanks for the detail info","commit_id":"65658ed6fca868430a4d9e074e4345c7b7f4bfc9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ced88c7958f07322c04b128b55dad97dcc0c5449","unresolved":false,"context_lines":[{"line_number":3114,"context_line":"    help\u003d_(\u0027Id of key-pair owner (Admin only).\u0027))"},{"line_number":3115,"context_line":"def do_keypair_show(cs, args):"},{"line_number":3116,"context_line":"    \"\"\"Show details about the given keypair.\"\"\""},{"line_number":3117,"context_line":"    keypair \u003d cs.keypairs.get(args.keypair, args.user)"},{"line_number":3118,"context_line":"    _print_keypair(keypair)"},{"line_number":3119,"context_line":""},{"line_number":3120,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_2b587187","line":3117,"in_reply_to":"7a740942_cbef6d1c","updated":"2015-12-08 13:42:25.000000000","message":"we can\u0027t use _find_keypair here, since it uses https://github.com/openstack/python-novaclient/blob/master/novaclient/utils.py#L190 . This method is too complicated and it is hard to extend it to use \"user_id\" parameter. \n\nAlso, since keypair can be identified only by name(it\u0027s unique), there is no reason to call _find_keypair at all, even in L3101(it doesn\u0027t relate to my patch).","commit_id":"65658ed6fca868430a4d9e074e4345c7b7f4bfc9"}]}