)]}'
{"novaclient/tests/functional/v2/legacy/test_os_services.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"48309946b09097a73cfe01975fe93dde407c20be","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_os_services_list(self):"},{"line_number":22,"context_line":"        table \u003d self.nova(\u0027service-list\u0027)"},{"line_number":23,"context_line":"        for i in range(0, len(self.client.services.list())):"},{"line_number":24,"context_line":"            self.assertIn(self.client.services.list()[i].binary, table)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_os_service_disable_enable(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_4395163e","line":23,"updated":"2015-12-10 16:21:15.000000000","message":"Why loop over indexes into the list?  Why not loop over list members?","commit_id":"717f48eccb0275c61497e1ea5c9fa7235cc02db5"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"48309946b09097a73cfe01975fe93dde407c20be","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        for i in range(0, len(self.client.services.list())):"},{"line_number":30,"context_line":"            host \u003d self._get_column_value_from_single_row_table("},{"line_number":31,"context_line":"                self.nova(\u0027service-list --binary %s\u0027"},{"line_number":32,"context_line":"                          % self.client.services.list()[i].binary), \u0027Host\u0027)"},{"line_number":33,"context_line":"            service \u003d self.nova("},{"line_number":34,"context_line":"                \u0027service-disable %s %s\u0027"},{"line_number":35,"context_line":"                % (host, self.client.services.list()[i].binary))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_2371ea44","line":32,"updated":"2015-12-10 16:21:15.000000000","message":"So, this is going to call list() over and over and over again.  Why not obtain the list once, at the top of the test method?","commit_id":"717f48eccb0275c61497e1ea5c9fa7235cc02db5"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"12f7607d45c2426707ff0f4d0f9b202eb961f25d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        for serv in self.client.services.list():"},{"line_number":30,"context_line":"            host \u003d self._get_column_value_from_single_row_table("},{"line_number":31,"context_line":"                self.nova(\u0027service-list --binary %s\u0027 % serv.binary), \u0027Host\u0027)"},{"line_number":32,"context_line":"            service \u003d self.nova(\u0027service-disable %s %s\u0027 % (host, serv.binary))"},{"line_number":33,"context_line":"            self.addCleanup(self.nova, \u0027service-enable\u0027,"},{"line_number":34,"context_line":"                            params\u003d\"%s %s\" % (host, serv.binary))"},{"line_number":35,"context_line":"            status \u003d self._get_column_value_from_single_row_table("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_bf042a15","line":32,"updated":"2015-12-17 12:43:49.000000000","message":"service disable has the chance in racing with other tests, how is this prevented? (Note: this is why we don\u0027t test it in tempest)","commit_id":"0d434a75eef02498429de73768a56a2832442d03"},{"author":{"_account_id":16437,"name":"Anna Babich","email":"anna.v.babich@gmail.com","username":"ababich"},"change_message_id":"b61082fe1d65b4e9b9c084d90ced97f5dd144a37","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        for serv in self.client.services.list():"},{"line_number":30,"context_line":"            host \u003d self._get_column_value_from_single_row_table("},{"line_number":31,"context_line":"                self.nova(\u0027service-list --binary %s\u0027 % serv.binary), \u0027Host\u0027)"},{"line_number":32,"context_line":"            service \u003d self.nova(\u0027service-disable %s %s\u0027 % (host, serv.binary))"},{"line_number":33,"context_line":"            self.addCleanup(self.nova, \u0027service-enable\u0027,"},{"line_number":34,"context_line":"                            params\u003d\"%s %s\" % (host, serv.binary))"},{"line_number":35,"context_line":"            status \u003d self._get_column_value_from_single_row_table("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_a8078b80","line":32,"in_reply_to":"3a7e1126_bf042a15","updated":"2015-12-21 10:42:10.000000000","message":"AFAIK, functional tests for novaclient are launched in serial way in accordance with https://review.openstack.org/#/c/217768/ So, service disabling seems not to be affecting other tests.","commit_id":"0d434a75eef02498429de73768a56a2832442d03"}]}