)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"e7ac092772e120c8560722cad2b701d9dfe3c329","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Haiwei Xu \u003cxu-haiwei@mxw.nes.nec.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-04-03 13:58:44 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make \"multi_host\" True when it is setted \u0027T\u0027 in network_create"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug 1161297"},{"line_number":10,"context_line":"Even if creating a network with the \"--multi_host\u003dT\", the \"multi_host\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAOX%2F%2F%2BEg%3D","line":7,"updated":"2013-04-04 03:10:47.000000000","message":"\u0027setted\u0027? Do you mean the past tense of set, which in english is set.\ne.g.\n\u0027Make \"multi_host\" True when it is set to \u0027T\u0027 in network_create.\u0027\n\n(Note too the full stop to get a correct sentence.","commit_id":"a2723ac161b4d62d6b82a679c1e5d43af7f2c098"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"c56e2c9983af03b59c02e63392326ab109d28e4f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Haiwei Xu \u003cxu-haiwei@mxw.nes.nec.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-04-03 13:58:44 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make \"multi_host\" True when it is setted \u0027T\u0027 in network_create"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug 1161297"},{"line_number":10,"context_line":"Even if creating a network with the \"--multi_host\u003dT\", the \"multi_host\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAOX%2F%2F8Fc%3D","line":7,"in_reply_to":"AAAAOX%2F%2F%2BEg%3D","updated":"2013-04-05 05:27:32.000000000","message":"Thank you . This is a big mistake.","commit_id":"a2723ac161b4d62d6b82a679c1e5d43af7f2c098"}],"novaclient/v1_1/shell.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"1de7995f47aabc78a7426c049f01c4e6cfac35d8","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2FtWc%3D","line":712,"updated":"2013-04-02 03:05:22.000000000","message":"If you do --multi_host\u003dF this will set the value to \u0027T\u0027. Also this shouldn\u0027t be T it should be True.","commit_id":"ceef9089befed31bf6cd7612c5982bb1c0a80221"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6cfa7c66a7f1157e1a28d16b41d32738678b20de","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2FtSU%3D","line":712,"updated":"2013-04-02 04:41:14.000000000","message":"Sorry xu i must be blind... I didn\u0027t see you had \u003d\u003d","commit_id":"ceef9089befed31bf6cd7612c5982bb1c0a80221"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"254c7028ce41b156f86dacc715cb0a13351e39e5","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2FtTE%3D","line":712,"in_reply_to":"AAAAOH%2F%2FtU8%3D","updated":"2013-04-02 04:09:22.000000000","message":"Hi, Aaron\n\n\u003eif you do --multi_host\u003dasdf it will set kwargs[\u0027multi_host\u0027] \u003d \u0027T\u0027 ?\n\nno, kwargs[\u0027multi_host\u0027] will be \u0027false\u0027.","commit_id":"ceef9089befed31bf6cd7612c5982bb1c0a80221"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"66a19249072464e7f38d35fde9e3d4e2f5c129ed","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2FtUY%3D","line":712,"in_reply_to":"AAAAOH%2F%2FtU8%3D","updated":"2013-04-02 03:26:46.000000000","message":"I feel we need some test cases for this in tests/v1_1/test_shell.py.","commit_id":"ceef9089befed31bf6cd7612c5982bb1c0a80221"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"254c7028ce41b156f86dacc715cb0a13351e39e5","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2FtTA%3D","line":712,"in_reply_to":"AAAAOH%2F%2FtUY%3D","updated":"2013-04-02 04:09:22.000000000","message":"Thank you for your comment, I will think about the test cases.","commit_id":"ceef9089befed31bf6cd7612c5982bb1c0a80221"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"3aaf7b01869b75caa3d165d8b67cf93e712cc8a3","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2FtU8%3D","line":712,"in_reply_to":"AAAAOH%2F%2FtVc%3D","updated":"2013-04-02 03:19:11.000000000","message":"My problem is with the if statement: if args.multi_host is not None: this means if you do --multi_host\u003dasdf it will set kwargs[\u0027multi_host\u0027] \u003d \u0027T\u0027 no?","commit_id":"ceef9089befed31bf6cd7612c5982bb1c0a80221"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"f353620a751d2ffafc0c10a2b935d5a4c567d192","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2FtVc%3D","line":712,"in_reply_to":"AAAAOH%2F%2FtWc%3D","updated":"2013-04-02 03:16:41.000000000","message":"Hi, Aaron\n\nI am afraid you didn\u0027t understand this source. When the multi_host is setted \u0027F\u0027, the \"arg.multi_host \u003d\u003d \u0027T\u0027 \" will get a bool value \"false\".","commit_id":"ceef9089befed31bf6cd7612c5982bb1c0a80221"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"79e61819276a01a1a65c28ab73835cce0d343977","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FtH8%3D","line":712,"updated":"2013-04-02 08:55:20.000000000","message":"could we change this to something like \n\nif args.multi_host not in [\u0027T\u0027, \u0027F\u0027, None]:\n     raise some error about invalid option\nelse:\n    kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027","commit_id":"0af00d9ff67756c0718b2e41ca15a26fd3eb385d"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"441d84a5863df9da631de0692bf8bec7196170bd","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F%2F%2F8%3D","line":712,"in_reply_to":"AAAAOH%2F%2Fr%2Fo%3D","updated":"2013-04-03 00:52:21.000000000","message":"Ok, I will think about it in that way.Thank you.","commit_id":"0af00d9ff67756c0718b2e41ca15a26fd3eb385d"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"7e9369d47fc832229ffa0d1274bdf69e3b3955da","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fr%2Fo%3D","line":712,"in_reply_to":"AAAAOH%2F%2FsAI%3D","updated":"2013-04-03 00:38:29.000000000","message":"Generally I prefer standardizing what is sent to the server on this end, so converting it here seems best.","commit_id":"0af00d9ff67756c0718b2e41ca15a26fd3eb385d"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"332f7f80d95269f220711354272b8cf2cdc6deaa","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FsAI%3D","line":712,"in_reply_to":"AAAAOH%2F%2Fsqo%3D","updated":"2013-04-03 00:33:23.000000000","message":"Hi, Vish Ishaya\t\n\nSince 1,\u0027True\u0027 and \u0027TRUE\u0027 are all accepted in the server side, what about just changing \u0027T\u0027 to True here?","commit_id":"0af00d9ff67756c0718b2e41ca15a26fd3eb385d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"98f16faa22af34ef92bc899d49ca3f6566d99b88","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fsqc%3D","line":712,"in_reply_to":"AAAAOH%2F%2Fsqo%3D","updated":"2013-04-02 15:42:21.000000000","message":"Or just use novaclient.openstack.common.strutils.bool_from_string() like everything else :)","commit_id":"0af00d9ff67756c0718b2e41ca15a26fd3eb385d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"884d8c2403b190dba5a523f7d0cd72bb1b029a35","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FtAc%3D","line":712,"in_reply_to":"AAAAOH%2F%2FtH8%3D","updated":"2013-04-02 11:28:47.000000000","message":"I like Aaron\u0027s idea because of user-friendly.","commit_id":"0af00d9ff67756c0718b2e41ca15a26fd3eb385d"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"cef5aa2992f66602ee9fe732d77cada1d0b74297","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \"Must specify eith fixed_range_v4 or fixed_range_v6\")"},{"line_number":710,"context_line":"    kwargs \u003d _filter_network_create_options(args)"},{"line_number":711,"context_line":"    if args.multi_host is not None:"},{"line_number":712,"context_line":"        kwargs[\u0027multi_host\u0027] \u003d args.multi_host \u003d\u003d \u0027T\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fsqo%3D","line":712,"in_reply_to":"AAAAOH%2F%2FtH8%3D","updated":"2013-04-02 15:36:09.000000000","message":"Lets do a more general conversion:\n\nI think we should accept 1, \u0027True\u0027, \u0027true\u0027, \u0027TRUE\u0027 in addition to \u0027T\u0027","commit_id":"0af00d9ff67756c0718b2e41ca15a26fd3eb385d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"c3dbb76f74f16b055c7d6018cc480ac9c1ab240c","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from novaclient import exceptions"},{"line_number":29,"context_line":"from novaclient.openstack.common import timeutils"},{"line_number":30,"context_line":"from novaclient.openstack.common import strutils"},{"line_number":31,"context_line":"from novaclient import utils"},{"line_number":32,"context_line":"from novaclient.v1_1 import availability_zones"},{"line_number":33,"context_line":"from novaclient.v1_1 import servers"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOX%2F%2F%2F0I%3D","line":30,"updated":"2013-04-03 04:48:29.000000000","message":"nit: abc order should be switched with line 29.","commit_id":"a44d8a1f8980b5ae7ebea2c08904629211dda00d"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"7897b7bc4aee4ddb02edafa51f9c7d9ee705209f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from novaclient import exceptions"},{"line_number":29,"context_line":"from novaclient.openstack.common import timeutils"},{"line_number":30,"context_line":"from novaclient.openstack.common import strutils"},{"line_number":31,"context_line":"from novaclient import utils"},{"line_number":32,"context_line":"from novaclient.v1_1 import availability_zones"},{"line_number":33,"context_line":"from novaclient.v1_1 import servers"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOX%2F%2F%2Fzw%3D","line":30,"in_reply_to":"AAAAOX%2F%2F%2F0I%3D","updated":"2013-04-03 04:57:51.000000000","message":"I will change the sequence in the next patch.","commit_id":"a44d8a1f8980b5ae7ebea2c08904629211dda00d"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"e7ac092772e120c8560722cad2b701d9dfe3c329","unresolved":false,"context_lines":[{"line_number":714,"context_line":"                                if args.multi_host \u003d\u003d \u0027T\u0027 or"},{"line_number":715,"context_line":"                                strutils.bool_from_string(args.multi_host)"},{"line_number":716,"context_line":"                                else"},{"line_number":717,"context_line":"                                False)"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":720,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2BEY%3D","line":717,"updated":"2013-04-04 03:10:47.000000000","message":"This can be written more compactly as\n    kwargs[\u0027multi_host\u0027] \u003d bool(\n        args.multi_host \u003d\u003d \u0027T\u0027 or strutils.bool_from_string(args.multi_host))","commit_id":"a2723ac161b4d62d6b82a679c1e5d43af7f2c098"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"c56e2c9983af03b59c02e63392326ab109d28e4f","unresolved":false,"context_lines":[{"line_number":714,"context_line":"                                if args.multi_host \u003d\u003d \u0027T\u0027 or"},{"line_number":715,"context_line":"                                strutils.bool_from_string(args.multi_host)"},{"line_number":716,"context_line":"                                else"},{"line_number":717,"context_line":"                                False)"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    cs.networks.create(**kwargs)"},{"line_number":720,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F8Fo%3D","line":717,"in_reply_to":"AAAAOX%2F%2F%2BEY%3D","updated":"2013-04-05 05:27:32.000000000","message":"Thank you for your comment. I will amend it in the next patch.","commit_id":"a2723ac161b4d62d6b82a679c1e5d43af7f2c098"}]}