)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"abe4c3b2c3639029d46a1acf47b54ced9aa62ab3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[functional-test] add v2.8 functional test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"add functional test for v2.8 API (webmks console type"},{"line_number":10,"context_line":"enablement)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7660a189cc3051dd7dbc802ad2d40a4995b44960"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a710552_42032010","line":10,"updated":"2015-12-14 19:41:25.000000000","message":"You should also mention the bug fix you have…","commit_id":"f4cd2d5eb15efc23dfa6f161ca495b8a8c033da8"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"2c0d48575e22fdc9126c6e32ef0677c7f6ddcefd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[functional-test] add v2.8 functional test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"add functional test for v2.8 API (webmks console type"},{"line_number":10,"context_line":"enablement)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7660a189cc3051dd7dbc802ad2d40a4995b44960"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a710552_993e5eb7","line":10,"in_reply_to":"5a710552_42032010","updated":"2015-12-14 20:05:01.000000000","message":"I am not sure this is a bug or not \n\nbut I checked the compute api log and don\u0027t see the mks request was sent to nova server side. the change is pretty simple...\nso I want to check whether the code has problem on the 2.8 version\n\nBTW: any hint on how to debug functional test of python-novaclient?","commit_id":"f4cd2d5eb15efc23dfa6f161ca495b8a8c033da8"}],"novaclient/tests/functional/v2/test_consoles.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"83e774db553fd5e6fb77ca54bd0acd19bc86179d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    COMPUTE_API_VERSION \u003d \"2.8\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _test_webmks_console_get(self):"},{"line_number":41,"context_line":"        self._test_console_get(\u0027get-mks-console %s \u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_webmks_console_get(self):"},{"line_number":44,"context_line":"        self._test_webmks_console_get()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_6b14d9f4","line":41,"updated":"2015-12-15 09:23:56.000000000","message":"1) I prefer to move this line inside test_webmks_console_get and remove this method.\n\n2) I don\u0027t understand why _test_console_get checks that command raises an exception. https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/functional/v2/legacy/test_consoles.py#L34","commit_id":"fe0709eb8c581349804cf66d0f00eae90eb9dd58"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4033644e04e801459f9a86ed06e1a4ee6130b574","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    COMPUTE_API_VERSION \u003d \"2.8\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _test_webmks_console_get(self):"},{"line_number":41,"context_line":"        self._test_console_get(\u0027get-mks-console %s \u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_webmks_console_get(self):"},{"line_number":44,"context_line":"        self._test_webmks_console_get()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_7d17bea3","line":41,"in_reply_to":"5a710552_6b14d9f4","updated":"2015-12-15 10:27:21.000000000","message":"yeah, I can do it for #1 \n\nbecause it\u0027s not supported , usually the instance won\u0027t allow such console be created without configuration, so it will not allow the creation and HTTP 400 is returned\n\nthere are some logs in the n-api log :)","commit_id":"fe0709eb8c581349804cf66d0f00eae90eb9dd58"}],"novaclient/v2/shell.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"83e774db553fd5e6fb77ca54bd0acd19bc86179d","unresolved":false,"context_lines":[{"line_number":2435,"context_line":"    print_console(cs, data)"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":""},{"line_number":2438,"context_line":"@api_versions.wraps(\u00272.8\u0027)"},{"line_number":2439,"context_line":"@cliutils.arg(\u0027server\u0027, metavar\u003d\u0027\u003cserver\u003e\u0027, help\u003d_(\u0027Name or ID of server.\u0027))"},{"line_number":2440,"context_line":"def do_get_mks_console(cs, args):"},{"line_number":2441,"context_line":"    \"\"\"Get a serial console to a server.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_8b9b45c9","line":2438,"updated":"2015-12-15 09:23:56.000000000","message":"I need to take closer on this issue.","commit_id":"fe0709eb8c581349804cf66d0f00eae90eb9dd58"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4033644e04e801459f9a86ed06e1a4ee6130b574","unresolved":false,"context_lines":[{"line_number":2435,"context_line":"    print_console(cs, data)"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":""},{"line_number":2438,"context_line":"@api_versions.wraps(\u00272.8\u0027)"},{"line_number":2439,"context_line":"@cliutils.arg(\u0027server\u0027, metavar\u003d\u0027\u003cserver\u003e\u0027, help\u003d_(\u0027Name or ID of server.\u0027))"},{"line_number":2440,"context_line":"def do_get_mks_console(cs, args):"},{"line_number":2441,"context_line":"    \"\"\"Get a serial console to a server.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_9d586a58","line":2438,"in_reply_to":"5a710552_8b9b45c9","updated":"2015-12-15 10:27:21.000000000","message":"https://github.com/openstack/nova/blob/master/nova/api/openstack/wsgi.py#L1081\n\nthe framework copied from nova, I guess the comments make sense here , too","commit_id":"fe0709eb8c581349804cf66d0f00eae90eb9dd58"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9abbd9edf4b77959d9afcddb401436a8bd420a39","unresolved":false,"context_lines":[{"line_number":2435,"context_line":"    print_console(cs, data)"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":""},{"line_number":2438,"context_line":"@api_versions.wraps(\u00272.8\u0027)"},{"line_number":2439,"context_line":"@cliutils.arg(\u0027server\u0027, metavar\u003d\u0027\u003cserver\u003e\u0027, help\u003d_(\u0027Name or ID of server.\u0027))"},{"line_number":2440,"context_line":"def do_get_mks_console(cs, args):"},{"line_number":2441,"context_line":"    \"\"\"Get a serial console to a server.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_6e9b82ca","line":2438,"in_reply_to":"5a710552_9d586a58","updated":"2015-12-15 10:57:03.000000000","message":"no, it was not copied:) nova\u0027s code was taken as the base, but it should work better(I was an author of it)","commit_id":"fe0709eb8c581349804cf66d0f00eae90eb9dd58"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"afca2f557ee8017c996d5afa5515f560c82ed606","unresolved":false,"context_lines":[{"line_number":2435,"context_line":"    print_console(cs, data)"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":""},{"line_number":2438,"context_line":"@api_versions.wraps(\u00272.8\u0027)"},{"line_number":2439,"context_line":"@cliutils.arg(\u0027server\u0027, metavar\u003d\u0027\u003cserver\u003e\u0027, help\u003d_(\u0027Name or ID of server.\u0027))"},{"line_number":2440,"context_line":"def do_get_mks_console(cs, args):"},{"line_number":2441,"context_line":"    \"\"\"Get a serial console to a server.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_6d461625","line":2438,"in_reply_to":"5a710552_9d586a58","updated":"2015-12-15 16:00:40.000000000","message":"ok. thanks for pointing me to this issue. fix is here - https://review.openstack.org/257974","commit_id":"fe0709eb8c581349804cf66d0f00eae90eb9dd58"}]}