)]}'
{"id":"openstack%2Fpython-novaclient~257974","triplet_id":"openstack%2Fpython-novaclient~master~Ief316a8597555db6cb02c9f23406b9f1f09f8313","project":"openstack/python-novaclient","branch":"master","topic":"wraps","hashtags":[],"change_id":"Ief316a8597555db6cb02c9f23406b9f1f09f8313","subject":"[microversions] share one object for shell arguments","status":"MERGED","created":"2015-12-15 15:56:57.000000000","updated":"2016-01-05 15:50:18.000000000","submitted":"2016-01-05 15:50:18.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"020605a6fa503ee9ce62abe121f2f2dba2354ff1","_number":257974,"virtual_id_number":257974,"owner":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-01-05 15:50:18.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-12-29 18:07:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":2,"date":"2016-01-05 14:53:32.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":1,"date":"2016-01-05 14:53:32.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-15 20:34:20.000000000","updated_by":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"reviewer":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"state":"REVIEWER"},{"updated":"2015-12-29 18:07:41.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-01-05 14:53:32.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2016-01-05 15:50:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"371dbc5df444abb8be16b8a906e72e1f785e3012","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-12-15 15:56:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c6287b17f8174e44102670cea0a9c130eb3f5c4c","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-12-15 16:00:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d2508cecbecee9573d675749e581204f132e7cac","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-12-15 16:58:30.000000000","message":"Patch Set 2:\n\n1. Should this have a test of some sort?  That\u0027s a question, not an order :)\n\n2. I don\u0027t fully understand the algorithm by which arguments are added to the parser, particularly given that the argument parser is constructed before the microversion is known from those arguments.  Could you clarify this some?","accounts_in_message":[],"_revision_number":2},{"id":"7b15fef0957fc52a5d7c1c303d0f92c035375024","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-15 18:57:11.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/74/257974/2/check/gate-python-novaclient-pep8/832bd17/ : SUCCESS in 1m 25s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/74/257974/2/check/gate-python-novaclient-docs/f58b2d6//doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-novaclient-python27 http://logs.openstack.org/74/257974/2/check/gate-python-novaclient-python27/3b9b5a3/ : FAILURE in 1m 25s\n- gate-python-novaclient-python34 http://logs.openstack.org/74/257974/2/check/gate-python-novaclient-python34/079b6e3/ : FAILURE in 2m 07s\n- gate-python-novaclient-pypy http://logs.openstack.org/74/257974/2/check/gate-python-novaclient-pypy/7e84197/ : FAILURE in 2m 15s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/74/257974/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/2c87f9b/ : SUCCESS in 53m 10s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/74/257974/2/check/gate-novaclient-dsvm-functional/86a10fb/ : SUCCESS in 29m 28s","accounts_in_message":[],"_revision_number":2},{"id":"4a3ee99a6b708d9fda884057550a3f572684bf97","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2015-12-15 20:34:20.000000000","message":"Patch Set 2:\n\nyeah, unit test is needed I think\n\nand ,we can add a coding suggestion to make the api_version \nas top level just like nova did, it should be acceptable so we don\u0027t need to make internal code consider too many possible logics","accounts_in_message":[],"_revision_number":2},{"id":"3b139b19156e5a443be6f699cfe8865d90aa47b3","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-12-15 22:15:31.000000000","message":"Patch Set 2: Workflow-1\n\n\u003ewe can add a coding suggestion to make the api_version as top level just like nova did\n\nI dislike such idea, since \n\n  1) it is not user-friendly, \n  2) reviewers can miss it or we need some hacking rule(novaclient doesn\u0027t support own rules yet)\n\nPS: I\u0027ll add unittests and extend commit message","accounts_in_message":[],"_revision_number":2},{"id":"cf69bdd645ffbcfbf924e5579770d2985e7040a7","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2015-12-16 08:39:58.000000000","message":"Patch Set 2:\n\nI didn\u0027t involve in the original coding\nso I don\u0027t know how complex it is... so let me dig into code more ,thx","accounts_in_message":[],"_revision_number":2},{"id":"54e24c8b64dc85c7d90b38f965844c1d758bac28","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-12-16 22:19:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"bb31f5c5441de6154d950269a3219edf16975fd9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-12-16 22:33:13.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"1fdeb66ade4083fe1db1a4963d5fdf6ccee9ecb9","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-12-16 23:09:32.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"4d5fc3986b5319b9aef7f9f0dd727d23e0831a5d","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-12-16 23:10:57.000000000","message":"Patch Set 4:\n\nmake change a little bit simpler","accounts_in_message":[],"_revision_number":4},{"id":"b7696076b5a1e4ba76f3d27022953a3662ea6c81","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-17 01:15:09.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/74/257974/4/check/gate-python-novaclient-pep8/846fded/ : SUCCESS in 1m 04s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/74/257974/4/check/gate-python-novaclient-docs/24591eb//doc/build/html/ : SUCCESS in 1m 31s\n- gate-python-novaclient-python27 http://logs.openstack.org/74/257974/4/check/gate-python-novaclient-python27/3178f9b/ : SUCCESS in 1m 46s\n- gate-python-novaclient-python34 http://logs.openstack.org/74/257974/4/check/gate-python-novaclient-python34/b4e1560/ : FAILURE in 3m 54s\n- gate-python-novaclient-pypy http://logs.openstack.org/74/257974/4/check/gate-python-novaclient-pypy/89b7176/ : SUCCESS in 3m 13s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/74/257974/4/check/gate-tempest-dsvm-neutron-src-python-novaclient/92caa2d/ : SUCCESS in 1h 16m 06s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/74/257974/4/check/gate-novaclient-dsvm-functional/8df99bd/ : SUCCESS in 35m 49s","accounts_in_message":[],"_revision_number":4},{"id":"48e1ad010f1d03d5032dba92ac93708c7b037838","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-12-22 13:17:23.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"b66ee2dd9c1c5e10d0671c4ae83de45e2de34b30","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-22 15:06:03.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/74/257974/5/check/gate-python-novaclient-pep8/963b67c/ : SUCCESS in 1m 17s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/74/257974/5/check/gate-python-novaclient-docs/9545152//doc/build/html/ : SUCCESS in 1m 37s\n- gate-python-novaclient-python27 http://logs.openstack.org/74/257974/5/check/gate-python-novaclient-python27/2a61ac4/ : SUCCESS in 1m 39s\n- gate-python-novaclient-python34 http://logs.openstack.org/74/257974/5/check/gate-python-novaclient-python34/5363834/ : SUCCESS in 2m 25s\n- gate-python-novaclient-pypy http://logs.openstack.org/74/257974/5/check/gate-python-novaclient-pypy/abc12b9/ : SUCCESS in 3m 05s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/74/257974/5/check/gate-tempest-dsvm-neutron-src-python-novaclient/048292b/ : SUCCESS in 1h 08m 07s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/74/257974/5/check/gate-novaclient-dsvm-functional/b3e491f/ : SUCCESS in 36m 35s","accounts_in_message":[],"_revision_number":5},{"id":"20b92f6369071b990f7b5200566f73e63c1643fb","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-12-29 18:07:41.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"99bb5eab73ddde13af405f68aa2633233e6d8a21","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-01-05 14:53:32.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"8554872b8664443aa221381516d756b273f08563","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-05 14:53:39.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"d0a4dfd335ca564b30b5040033fc9b7a3cd33002","date":"2016-01-05 15:50:18.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":5},{"id":"9d0827a43653ae4e92518d5b477ff8d7b8579095","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-05 15:50:18.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/74/257974/5/gate/gate-python-novaclient-docs/7c1063c//doc/build/html/ : SUCCESS in 1m 08s\n- gate-python-novaclient-pep8 http://logs.openstack.org/74/257974/5/gate/gate-python-novaclient-pep8/e292339/ : SUCCESS in 56s\n- gate-python-novaclient-python27 http://logs.openstack.org/74/257974/5/gate/gate-python-novaclient-python27/e2840c6/ : SUCCESS in 1m 23s\n- gate-python-novaclient-python34 http://logs.openstack.org/74/257974/5/gate/gate-python-novaclient-python34/d188ba6/ : SUCCESS in 1m 34s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/74/257974/5/gate/gate-tempest-dsvm-neutron-src-python-novaclient/17deab6/ : SUCCESS in 56m 30s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/74/257974/5/gate/gate-novaclient-dsvm-functional/76b933c/ : SUCCESS in 32m 17s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"fd450d8c60e174677ccc9d4f08dec17eb053b644","revisions":{"3d86ca475869257959a14e2b15e51c28b082bde6":{"kind":"REWORK","_number":1,"created":"2015-12-15 15:56:57.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/74/257974/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/74/257974/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/1"}}},"commit":{"parents":[{"commit":"aa2687b3f7dd4a2a00a6a8937200643243b89f62","subject":"Merge \"[microversions] Increase max version to 2.12\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa2687b3f7dd4a2a00a6a8937200643243b89f62"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-12-15 15:51:33.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-12-15 15:51:33.000000000","tz":120},"subject":"[microversions] share one object for shell arguments","message":"[microversions] share one object for shell arguments\n\n_find_action shell method obtains cli arguments from \"arguments\" property\nof original fucntion(not versioned). In case of versioned methods, cli\narguments can be stored(it depends on order of `arg` and\n`api_versions.wraps decorator`) partially(or fully) in substitution.\nThis patch add shared list object for arguments for all versioned methods\n\nChange-Id: Ief316a8597555db6cb02c9f23406b9f1f09f8313\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3d86ca475869257959a14e2b15e51c28b082bde6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3d86ca475869257959a14e2b15e51c28b082bde6"}]},"branch":"refs/heads/master"},"39debf9939689569dda6abb07dd110fd6e118672":{"kind":"REWORK","_number":2,"created":"2015-12-15 16:00:29.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/74/257974/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/74/257974/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/2"}}},"commit":{"parents":[{"commit":"aa2687b3f7dd4a2a00a6a8937200643243b89f62","subject":"Merge \"[microversions] Increase max version to 2.12\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa2687b3f7dd4a2a00a6a8937200643243b89f62"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-12-15 15:51:33.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-12-15 16:00:18.000000000","tz":120},"subject":"[microversions] share one object for shell arguments","message":"[microversions] share one object for shell arguments\n\n_find_action shell method obtains cli arguments from \"arguments\" property\nof original fucntion(not versioned). In case of versioned methods, cli\narguments can be stored(it depends on order of `arg` and\n`api_versions.wraps decorator`) partially(or fully) in substitution.\nThis patch add shared list object for arguments for all versioned methods\n\nChange-Id: Ief316a8597555db6cb02c9f23406b9f1f09f8313\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/39debf9939689569dda6abb07dd110fd6e118672"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/39debf9939689569dda6abb07dd110fd6e118672"}]},"branch":"refs/heads/master"},"a32c33b861db176fcd98036213b5d7d14d57cab7":{"kind":"REWORK","_number":3,"created":"2015-12-16 22:19:45.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/74/257974/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/74/257974/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/3"}}},"commit":{"parents":[{"commit":"aa2687b3f7dd4a2a00a6a8937200643243b89f62","subject":"Merge \"[microversions] Increase max version to 2.12\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa2687b3f7dd4a2a00a6a8937200643243b89f62"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-12-15 15:51:33.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-12-16 17:31:48.000000000","tz":120},"subject":"[microversions] share one object for shell arguments","message":"[microversions] share one object for shell arguments\n\nI8d599b712b17dcfc0be940a61c537d2dfe1b715b change provides a wrong fix for\nan issue with cli arguments.\n\n_find_actions method is designed to find all action methods(do_server_list,\ndo_server_show and etc). Since one module can include several versions of\none action(after microversion implementation) and only the last one will\nbe registrated in module, _find_actions method was adopted to handle\nversioned methods.\nNow it checks that discovered method is related to versioning stuff and\nreplace it by appropriate(in terms of microversions) functions. In this case,\nthe substituation is used only to determine function name and that it relates\nto versioning methods. That is why the change(see a change-id above) is not\nhelp at all.\n\nWe should share list object named \"arguments\"(it used by all action methods to\nstore cli arguments) with substitution and original method(which will be used\nby _find_action). It will allow to put api_versions.wraps and cliutils.arg\ndecorators in any order.\n\nChange-Id: Ief316a8597555db6cb02c9f23406b9f1f09f8313\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a32c33b861db176fcd98036213b5d7d14d57cab7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a32c33b861db176fcd98036213b5d7d14d57cab7"}]},"branch":"refs/heads/master"},"a19fd94aaa070309da0a3d7a48972906d09ca63d":{"kind":"REWORK","_number":4,"created":"2015-12-16 23:09:32.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/74/257974/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/74/257974/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/4"}}},"commit":{"parents":[{"commit":"aa2687b3f7dd4a2a00a6a8937200643243b89f62","subject":"Merge \"[microversions] Increase max version to 2.12\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa2687b3f7dd4a2a00a6a8937200643243b89f62"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-12-15 15:51:33.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2015-12-16 23:09:23.000000000","tz":120},"subject":"[microversions] share one object for shell arguments","message":"[microversions] share one object for shell arguments\n\nI8d599b712b17dcfc0be940a61c537d2dfe1b715b change provides a wrong fix for\nan issue with cli arguments.\n\n_find_actions method is designed to find all action methods(do_server_list,\ndo_server_show and etc). Since one module can include several versions of\none action(after microversion implementation) and only the last one will\nbe registrated in module, _find_actions method was adopted to handle\nversioned methods.\nNow it checks that discovered method is related to versioning stuff and\nreplace it by appropriate(in terms of microversions) functions. In this case,\nthe substituation is used only to determine function name and that it relates\nto versioning methods. That is why the change(see a change-id above) is not\nhelp at all.\n\nWe should share list object named \"arguments\"(it used by all action methods to\nstore cli arguments) with substitution and original method(which will be used\nby _find_action). It will allow to put api_versions.wraps and cliutils.arg\ndecorators in any order.\n\nChange-Id: Ief316a8597555db6cb02c9f23406b9f1f09f8313\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a19fd94aaa070309da0a3d7a48972906d09ca63d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a19fd94aaa070309da0a3d7a48972906d09ca63d"}]},"branch":"refs/heads/master"},"fd450d8c60e174677ccc9d4f08dec17eb053b644":{"kind":"REWORK","_number":5,"created":"2015-12-22 13:17:23.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/74/257974/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/74/257974/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/74/257974/5"}}},"commit":{"parents":[{"commit":"aa2687b3f7dd4a2a00a6a8937200643243b89f62","subject":"Merge \"[microversions] Increase max version to 2.12\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa2687b3f7dd4a2a00a6a8937200643243b89f62"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-12-15 15:51:33.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-12-22 13:17:12.000000000","tz":120},"subject":"[microversions] share one object for shell arguments","message":"[microversions] share one object for shell arguments\n\nI8d599b712b17dcfc0be940a61c537d2dfe1b715b change provides a wrong fix for\nan issue with cli arguments.\n\n_find_actions method is designed to find all action methods(do_server_list,\ndo_server_show and etc). Since one module can include several versions of\none action(after microversion implementation) and only the last one will\nbe registrated in module, _find_actions method was adopted to handle\nversioned methods.\nNow it checks that discovered method is related to versioning stuff and\nreplace it by appropriate(in terms of microversions) functions. In this case,\nthe substituation is used only to determine function name and that it relates\nto versioning methods. That is why the change(see a change-id above) is not\nhelp at all.\n\nWe should share list object named \"arguments\"(it used by all action methods to\nstore cli arguments) with substitution and original method(which will be used\nby _find_action). It will allow to put api_versions.wraps and cliutils.arg\ndecorators in any order.\n\nChange-Id: Ief316a8597555db6cb02c9f23406b9f1f09f8313\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fd450d8c60e174677ccc9d4f08dec17eb053b644"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fd450d8c60e174677ccc9d4f08dec17eb053b644"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}