)]}'
{"id":"openstack%2Fpython-novaclient~25802","triplet_id":"openstack%2Fpython-novaclient~master~Ida07b6429eae988a9a64535381082a500f31a521","project":"openstack/python-novaclient","branch":"master","topic":"bug/1162622","hashtags":[],"change_id":"Ida07b6429eae988a9a64535381082a500f31a521","subject":"Skip security groups w/ no protocol.","status":"MERGED","created":"2013-04-01 01:20:43.000000000","updated":"2013-04-02 16:10:32.000000000","submitted":"2013-04-02 16:10:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4691c9176689d71a8594bfdd70e830c2bb841787","_number":25802,"virtual_id_number":25802,"owner":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":2,"date":"2013-04-02 16:10:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":2,"date":"2013-04-02 15:25:20.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-04-01 11:17:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":2,"date":"2013-04-01 14:44:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2013-04-01 14:42:26.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":1,"date":"2013-04-02 07:21:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":1,"date":"2013-04-02 15:25:20.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"date":"2013-04-01 14:35:18.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2013-04-01 14:42:26.000000000","_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-04-01 11:17:20.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2013-04-01 14:35:18.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-04-02 07:21:45.000000000","updated_by":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"reviewer":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"state":"REVIEWER"},{"updated":"2013-04-02 15:25:20.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2013-04-02 16:10:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6ca5756a7d08f74ce9cc864dde5af1a89b324a8d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-01 02:00:59.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25802/1/check/gate-python-novaclient-pep8/1351 : SUCCESS\n- http://logs.openstack.org/25802/1/check/gate-python-novaclient-docs/1040 : SUCCESS\n- http://logs.openstack.org/25802/1/check/gate-python-novaclient-python26/1139 : SUCCESS\n- http://logs.openstack.org/25802/1/check/gate-python-novaclient-python26-rhel6/25 : SUCCESS (non-voting)\n- http://logs.openstack.org/25802/1/check/gate-python-novaclient-python27/1359 : SUCCESS\n- http://logs.openstack.org/25802/1/check/gate-tempest-devstack-vm-full/11109 : SUCCESS\n- http://logs.openstack.org/25802/1/check/gate-tempest-devstack-vm-postgres-full/10825 : SUCCESS\n- http://logs.openstack.org/25802/1/check/gate-tempest-devstack-vm-quantum/16754 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"a7e7eb326c741b7973fdfc50534f009311f00074","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-04-01 11:17:20.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"7304835de688b8033f4fb93801d73f4d67fdbf5d","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-04-01 14:35:18.000000000","message":"Patch Set 1:\n\nSo a rule containing no protocol cannot be deleted?  Is that a nova limitation?","accounts_in_message":[],"_revision_number":1},{"id":"6a56bb38ed50684a275ed412b15b91ba12ad8bfe","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2013-04-01 14:42:26.000000000","message":"Patch Set 1:\n\nKevin: Currently no. I\u0027ve got a different tracking that issue here: https://bugs.launchpad.net/nova/+bug/1161002\n\nWhat I\u0027m doing in this commit is essentially just making things work until we get better Nova integration with quantum security groups (if possible).","accounts_in_message":[],"_revision_number":1},{"id":"e111884c649b62109f69142e1b736366361138f2","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-04-01 14:44:00.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nOK, fair enough…","accounts_in_message":[],"_revision_number":1},{"id":"b8f6f4c0a343ed720979f588b21c58404414b547","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-04-02 07:21:45.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nLooks good to me. \n\nMy only question is now is it possible to do this via the cli directly and if so how (also how did you generate that error original)? \n\n$ nova secgroup-delete-rule \nusage: nova secgroup-delete-rule \u003csecgroup\u003e \u003cip-proto\u003e \u003cfrom-port\u003e \u003cto-port\u003e\n                                 \u003ccidr\u003e","accounts_in_message":[],"_revision_number":1},{"id":"3e0c41bfe6f0b714ebb39a159bc1344164720fdc","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-04-02 15:25:20.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ba4ccbde5baef6e1c95c63828d96e5c010fc5a44","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-02 15:25:22.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"50e7e7e9d7ed9f88e4f2f5d828f0d54627943a82","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-02 16:10:31.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/25802/1/gate/gate-python-novaclient-docs/1048 : SUCCESS\n- http://logs.openstack.org/25802/1/gate/gate-python-novaclient-pep8/1359 : SUCCESS\n- http://logs.openstack.org/25802/1/gate/gate-python-novaclient-python26/1147 : SUCCESS\n- http://logs.openstack.org/25802/1/gate/gate-python-novaclient-python27/1367 : SUCCESS\n- http://logs.openstack.org/25802/1/gate/gate-tempest-devstack-vm-full/11259 : SUCCESS\n- http://logs.openstack.org/25802/1/gate/gate-tempest-devstack-vm-postgres-full/10975 : SUCCESS\n- http://logs.openstack.org/25802/1/gate/gate-tempest-devstack-vm-quantum/16940 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"651de6c68a28a7752305017994aba187ada500a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-02 16:10:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7f0df56ea355bbccd8fb5db4d557dbbf126991af","revisions":{"7f0df56ea355bbccd8fb5db4d557dbbf126991af":{"kind":"REWORK","_number":1,"created":"2013-04-01 01:20:43.000000000","uploader":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"ref":"refs/changes/02/25802/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/02/25802/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/25802/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/25802/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/25802/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/02/25802/1"}}},"commit":{"parents":[{"commit":"593adf229aacabf66ce8aea4f147c131c9765374","subject":"Merge \"Ensure shell tests use isolated env variables set\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/593adf229aacabf66ce8aea4f147c131c9765374"}]}],"author":{"name":"Dan Prince","email":"dprince@redhat.com","date":"2013-04-01 01:16:26.000000000","tz":-240},"committer":{"name":"Dan Prince","email":"dprince@redhat.com","date":"2013-04-01 01:16:26.000000000","tz":-240},"subject":"Skip security groups w/ no protocol.","message":"Skip security groups w/ no protocol.\n\nWhen using Nova w/ the new Quantum security groups driver security\ngroups can exist which have no protocol. Theses entries\ncause ERROR: \u0027NoneType\u0027 object has no attribute \u0027upper\u0027\nwhen you try to delete other (editable) security groups.\n\nThis patch updates novaclient so that it skips over entries with\nno protocol when determining which security group to delete.\nThis fixes novaclient so that deleting *any* security group works\nwhen the new quantum security group driver is enabled.\n\nFixes LP Bug #1162622.\n\nChange-Id: Ida07b6429eae988a9a64535381082a500f31a521\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7f0df56ea355bbccd8fb5db4d557dbbf126991af"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7f0df56ea355bbccd8fb5db4d557dbbf126991af"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}