)]}'
{"id":"openstack%2Fpython-novaclient~262655","triplet_id":"openstack%2Fpython-novaclient~master~I5839294060c33fa12d9fc67c83821df11fb727be","project":"openstack/python-novaclient","branch":"master","topic":"bug/1434172","hashtags":[],"change_id":"I5839294060c33fa12d9fc67c83821df11fb727be","subject":"Security group create returns an error without --description supplied.","status":"ABANDONED","created":"2015-12-31 04:35:14.000000000","updated":"2016-06-10 15:54:56.000000000","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b486868474abd80a98849c4b875e428c5525edb6","_number":262655,"virtual_id_number":262655,"owner":{"_account_id":17872,"name":"Alan","email":"kaihongd@cn.ibm.com","username":"Alan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2015-12-31 05:28:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-12-31 04:35:27.000000000","_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":-1,"date":"2016-01-04 16:58:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-1,"date":"2015-12-31 13:22:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-31 04:35:27.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2015-12-31 05:28:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-12-31 13:22:10.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2016-01-04 16:58:31.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"}],"messages":[{"id":"ed3122a678dea4907a6cce4003009881b4d84162","author":{"_account_id":17872,"name":"Alan","email":"kaihongd@cn.ibm.com","username":"Alan"},"date":"2015-12-31 04:35:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3822437b15a45b0f0f9fe9987edd93e785a94c08","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2015-12-31 04:35:27.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"8d49d65da540230a39760c8bf1dc3068d0e86cdb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-31 05:28:31.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/55/262655/1/check/gate-python-novaclient-pep8/a3cfd41/ : FAILURE in 1m 02s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/55/262655/1/check/gate-python-novaclient-docs/616cab3//doc/build/html/ : SUCCESS in 1m 23s\n- gate-python-novaclient-python27 http://logs.openstack.org/55/262655/1/check/gate-python-novaclient-python27/0521fca/ : FAILURE in 1m 42s\n- gate-python-novaclient-python34 http://logs.openstack.org/55/262655/1/check/gate-python-novaclient-python34/34e1103/ : FAILURE in 2m 11s\n- gate-python-novaclient-pypy http://logs.openstack.org/55/262655/1/check/gate-python-novaclient-pypy/5e4be6d/ : FAILURE in 2m 49s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/55/262655/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/97042b1/ : SUCCESS in 53m 10s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/55/262655/1/check/gate-novaclient-dsvm-functional/a5710a4/ : SUCCESS in 30m 04s","accounts_in_message":[],"_revision_number":1},{"id":"91fc9b4053a9443cf12d7b6cefda6753e0440e18","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-12-31 13:22:10.000000000","message":"Patch Set 1: Code-Review-1\n\n(7 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ac6212b43fe8a3aa4d49aedf58bd701ffc3b24f5","author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"date":"2016-01-04 01:34:38.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nYou might also update the unit test to cover the no description case [1].\n\n[1] https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/v2/test_security_groups.py#L58-l61","accounts_in_message":[],"_revision_number":1},{"id":"e412840df54d21af1b8f2666968e27e6940bf869","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-01-04 16:58:31.000000000","message":"Patch Set 1: Code-Review-1\n\nTests should also be updated to test the new condition on description.","accounts_in_message":[],"_revision_number":1},{"id":"85501e569cf578cb37b1681fdf8116d8997fc884","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-01-29 20:06:07.000000000","message":"Patch Set 1:\n\nThis change hasn\u0027t been updated since the beginning of January, and tests failed at the time it was proposed.  Are you still working on this change?","accounts_in_message":[],"_revision_number":1},{"id":"51f2f859652bde676338f3b444412e065ec4d0d1","author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"date":"2016-03-01 04:48:11.000000000","message":"Removed the following votes:\n\n* Code-Review-1 by li,chen \u003cshchenli@cn.ibm.com\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"caae57711ff4823b7585c5658ccf4524c3678284","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-06-10 15:54:56.000000000","message":"Abandoned\n\nNot updated since December.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b8f4d594b9bbeaf06bc3d4dcad2f33c5ae7961d0","revisions":{"b8f4d594b9bbeaf06bc3d4dcad2f33c5ae7961d0":{"kind":"REWORK","_number":1,"created":"2015-12-31 04:35:14.000000000","uploader":{"_account_id":17872,"name":"Alan","email":"kaihongd@cn.ibm.com","username":"Alan"},"ref":"refs/changes/55/262655/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/55/262655/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/55/262655/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/55/262655/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/55/262655/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/55/262655/1"}}},"commit":{"parents":[{"commit":"fecf833ba5d150756f31ab5ae03d69f630d7f955","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fecf833ba5d150756f31ab5ae03d69f630d7f955"}]}],"author":{"name":"Alan","email":"kaihongd@cn.ibm.com","date":"2015-12-31 04:13:29.000000000","tz":-300},"committer":{"name":"Alan","email":"kaihongd@cn.ibm.com","date":"2015-12-31 04:34:24.000000000","tz":-300},"subject":"Security group create returns an error without --description supplied.","message":"Security group create returns an error without --description supplied.\n\nDescription parameter should be an optional when creating security\ngroup.it has been changed in python-openstackclient,to use name as default\ndescription value,I did similar modification for python-novaclient to ensure\ndescription has default vlaue when it is not spcified by user.\n\nChange-Id: I5839294060c33fa12d9fc67c83821df11fb727be\nCloses-Bug: #1434172\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b8f4d594b9bbeaf06bc3d4dcad2f33c5ae7961d0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b8f4d594b9bbeaf06bc3d4dcad2f33c5ae7961d0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
