)]}'
{"id":"openstack%2Fpython-novaclient~263561","triplet_id":"openstack%2Fpython-novaclient~master~I66110e5fc1afdf9dd6824b1f7bcb7b2c091a272d","project":"openstack/python-novaclient","branch":"master","topic":"bug/1512207","hashtags":[],"change_id":"I66110e5fc1afdf9dd6824b1f7bcb7b2c091a272d","subject":"Use assertTrue/False instead of assertEqual(T/F)","status":"MERGED","created":"2016-01-05 05:34:45.000000000","updated":"2016-01-06 14:55:20.000000000","submitted":"2016-01-06 14:55:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"75b8f6c4272e25aef725f28faa5456ab892272e1","_number":263561,"virtual_id_number":263561,"owner":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-01-06 14:55:19.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},{"value":0,"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-01-06 07:25:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},{"value":1,"date":"2016-01-05 09:20:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},{"value":2,"date":"2016-01-05 19:48:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2016-01-06 02:31:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},{"value":1,"date":"2016-01-05 11:05:31.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":2,"date":"2016-01-06 13:56:10.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},{"value":0,"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":1,"date":"2016-01-06 13:56:10.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},{"value":0,"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},{"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-05 09:20:11.000000000","updated_by":{"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},"reviewer":{"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},"state":"REVIEWER"},{"updated":"2016-01-05 11:05:31.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2016-01-05 19:48:38.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-01-06 02:31:59.000000000","updated_by":{"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},"reviewer":{"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},"state":"REVIEWER"},{"updated":"2016-01-06 07:25:43.000000000","updated_by":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"reviewer":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"state":"REVIEWER"},{"updated":"2016-01-06 13:56:10.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2016-01-06 14:55:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"25396baa7398327ab6e9f13d2dadc8caf7fa73bf","author":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"date":"2016-01-05 05:34:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5f4599424de025dca1e195ecff12917ecbfbdfb6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-05 06:33:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/61/263561/1/check/gate-python-novaclient-pep8/6e62846/ : SUCCESS in 1m 09s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/61/263561/1/check/gate-python-novaclient-docs/71e75a8//doc/build/html/ : SUCCESS in 1m 24s\n- gate-python-novaclient-python27 http://logs.openstack.org/61/263561/1/check/gate-python-novaclient-python27/c18ee37/ : SUCCESS in 1m 41s\n- gate-python-novaclient-python34 http://logs.openstack.org/61/263561/1/check/gate-python-novaclient-python34/ccda351/ : SUCCESS in 1m 50s\n- gate-python-novaclient-pypy http://logs.openstack.org/61/263561/1/check/gate-python-novaclient-pypy/d872d98/ : FAILURE in 1m 47s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/61/263561/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/4e6c32e/ : SUCCESS in 58m 39s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/61/263561/1/check/gate-novaclient-dsvm-functional/4abb7f3/ : SUCCESS in 30m 15s","accounts_in_message":[],"_revision_number":1},{"id":"1e1c1613ce5d819b3ea28fc01f0cd7f6270c75f1","author":{"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},"date":"2016-01-05 09:20:11.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"02f9594c6df7b3e07f369884f4782a9b350de653","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-01-05 11:05:31.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"7ccf3b71a384113090334bf5b821dcff936018c9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-01-05 19:48:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"853fef943a16d563132fa4c997715a98594b6d72","author":{"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},"date":"2016-01-06 02:31:59.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d0e9d4c914dee7940e2d111b5091c6b503994c59","author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"date":"2016-01-06 07:25:43.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b42cc07285a6a77f7dfd4423ae59847b6d21eb73","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-01-06 13:56:10.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nIt is better to provide a 2nd param explaining what went wrong, but this is fine.","accounts_in_message":[],"_revision_number":1},{"id":"e389485db72717559f372d2e2e69aec64577de15","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-06 13:56:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3004cd6bfac9f7b4203cb99eedc01ed0b9dae836","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-06 14:55:19.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/61/263561/1/gate/gate-python-novaclient-docs/beee135//doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-novaclient-pep8 http://logs.openstack.org/61/263561/1/gate/gate-python-novaclient-pep8/53ca9c7/ : SUCCESS in 44s\n- gate-python-novaclient-python27 http://logs.openstack.org/61/263561/1/gate/gate-python-novaclient-python27/06772cf/ : SUCCESS in 1m 33s\n- gate-python-novaclient-python34 http://logs.openstack.org/61/263561/1/gate/gate-python-novaclient-python34/e5b84ae/ : SUCCESS in 1m 43s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/61/263561/1/gate/gate-tempest-dsvm-neutron-src-python-novaclient/79fa475/ : SUCCESS in 57m 41s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/61/263561/1/gate/gate-novaclient-dsvm-functional/94cdcde/ : SUCCESS in 27m 59s","accounts_in_message":[],"_revision_number":1},{"id":"d821ffe234f995eb11863b818c14fe1a54a0260d","date":"2016-01-06 14:55:20.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"06be50b97a28f490951ca44f9880be161a54ecc1","revisions":{"06be50b97a28f490951ca44f9880be161a54ecc1":{"kind":"REWORK","_number":1,"created":"2016-01-05 05:34:45.000000000","uploader":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"ref":"refs/changes/61/263561/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/61/263561/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/263561/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/263561/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/263561/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/61/263561/1"}}},"commit":{"parents":[{"commit":"60997a599708a7f9fc980e4309fe1bef54c1de2e","subject":"Merge \"Validate the fixed ip address passed with --nic\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/60997a599708a7f9fc980e4309fe1bef54c1de2e"}]}],"author":{"name":"yangyapeng","email":"yang.yapeng@99cloud.net","date":"2016-01-04 14:39:02.000000000","tz":-300},"committer":{"name":"yangyapeng","email":"yang.yapeng@99cloud.net","date":"2016-01-04 14:52:04.000000000","tz":-300},"subject":"Use assertTrue/False instead of assertEqual(T/F)","message":"Use assertTrue/False instead of assertEqual(T/F)\n\nThe usage of assertEqual(True/False, ***) should be changed\nto a meaningful format of assertTrue/False(***).\n\nChange-Id: I66110e5fc1afdf9dd6824b1f7bcb7b2c091a272d\nCloses-Bug: #1512207\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/06be50b97a28f490951ca44f9880be161a54ecc1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/06be50b97a28f490951ca44f9880be161a54ecc1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}