)]}'
{"id":"openstack%2Fpython-novaclient~26405","triplet_id":"openstack%2Fpython-novaclient~master~I57636b4a1e525c440925caba0bbb51bbcd94b080","project":"openstack/python-novaclient","branch":"master","topic":"bug/1166464","hashtags":[],"change_id":"I57636b4a1e525c440925caba0bbb51bbcd94b080","subject":"Correct a unit test failure that crept into trunk","status":"MERGED","created":"2013-04-08 21:38:21.000000000","updated":"2013-04-09 00:00:34.000000000","submitted":"2013-04-09 00:00:34.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ca1a49c103ef64a3fae4c044d0b1a5e94202c5a3","_number":26405,"virtual_id_number":26405,"owner":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},{"value":2,"date":"2013-04-09 00:00:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"recommended":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"all":[{"value":1,"date":"2013-04-08 22:54:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-04-08 22:29:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"date":"2013-04-08 22:57:43.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2013-04-08 23:07:00.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":2,"date":"2013-04-08 23:21:13.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"date":"2013-04-08 22:57:43.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2013-04-08 23:07:00.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":1,"date":"2013-04-08 23:21:13.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-04-08 22:29:57.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2013-04-08 22:54:02.000000000","updated_by":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"reviewer":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"state":"REVIEWER"},{"updated":"2013-04-08 23:07:00.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-04-08 23:21:13.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-04-09 00:00:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b6f237314a67ff1f02ff588c9c77efa5d8661c75","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-04-08 22:29:57.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"6678ecd8c41ee1eb3170192426cb22e1e670f575","author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"date":"2013-04-08 22:54:02.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nA tad bit concerned, would it not be better for the nova list method to return {} or None instead of a table.\r\nDo we want a very specific test for table formatting like this.","accounts_in_message":[],"_revision_number":1},{"id":"520b2d603270a06bbf3eb711d58fccfdf88d427f","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-04-08 22:57:43.000000000","message":"Patch Set 1:\n\nmalini, we\u0027re talking about the \"nova list\" shell command, not the API method.","accounts_in_message":[],"_revision_number":1},{"id":"9e4f341b4d110591c21996427d79a8b139d04abb","author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"date":"2013-04-08 23:01:34.000000000","message":"Patch Set 1:\n\nThanks Kevin! My bad.","accounts_in_message":[],"_revision_number":1},{"id":"379e8f77916d02044cd4e0ab605e5bc20940361a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-08 23:04:57.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/26405/1/check/gate-python-novaclient-pep8/1396 : SUCCESS\n- http://logs.openstack.org/26405/1/check/gate-python-novaclient-docs/1087 : SUCCESS\n- http://logs.openstack.org/26405/1/check/gate-python-novaclient-python26/1186 : SUCCESS\n- http://logs.openstack.org/26405/1/check/gate-python-novaclient-python26-rhel6/54 : SUCCESS (non-voting)\n- http://logs.openstack.org/26405/1/check/gate-python-novaclient-python27/1405 : SUCCESS\n- http://logs.openstack.org/26405/1/check/gate-tempest-devstack-vm-full/11940 : SUCCESS\n- http://logs.openstack.org/26405/1/check/gate-tempest-devstack-vm-postgres-full/11655 : SUCCESS\n- http://logs.openstack.org/26405/1/check/gate-tempest-devstack-vm-quantum/17720 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"17ec440b493e91245d4ea0a02bb60868e3c3bfcb","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-04-08 23:07:00.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"b388bfef07a22a92395abfb8a908997a6a5ab3f4","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-04-08 23:21:13.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"c1b8a2dfd02eab634a537d8268432b3fce3399e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-08 23:21:14.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"0b85d4ffe2892f6bb650d706c063a51a4f39ea43","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-09 00:00:34.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"a9dbbc009c0d5ab8dd02f62d4c38aae358101a14","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-09 00:00:34.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/26405/1/gate/gate-python-novaclient-docs/1089 : SUCCESS\n- http://logs.openstack.org/26405/1/gate/gate-python-novaclient-pep8/1398 : SUCCESS\n- http://logs.openstack.org/26405/1/gate/gate-python-novaclient-python26/1188 : SUCCESS\n- http://logs.openstack.org/26405/1/gate/gate-python-novaclient-python27/1407 : SUCCESS\n- http://logs.openstack.org/26405/1/gate/gate-tempest-devstack-vm-full/11950 : SUCCESS\n- http://logs.openstack.org/26405/1/gate/gate-tempest-devstack-vm-postgres-full/11665 : SUCCESS\n- http://logs.openstack.org/26405/1/gate/gate-tempest-devstack-vm-quantum/17730 : SUCCESS\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"69f9971da54b46a8883148e4cef6346c7933b6ec","revisions":{"69f9971da54b46a8883148e4cef6346c7933b6ec":{"kind":"REWORK","_number":1,"created":"2013-04-08 21:38:21.000000000","uploader":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"ref":"refs/changes/05/26405/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/05/26405/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/05/26405/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/05/26405/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/05/26405/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/05/26405/1"}}},"commit":{"parents":[{"commit":"ea94b09ad712adcf932a4f217e4061522ad875d1","subject":"Make \"multi_host\" True when it is set to \u0027T\u0027 in network_create.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ea94b09ad712adcf932a4f217e4061522ad875d1"}]}],"author":{"name":"Kevin L. Mitchell","email":"kevin.mitchell@rackspace.com","date":"2013-04-08 21:38:07.000000000","tz":-300},"committer":{"name":"Kevin L. Mitchell","email":"kevin.mitchell@rackspace.com","date":"2013-04-08 21:38:07.000000000","tz":-300},"subject":"Correct a unit test failure that crept into trunk","message":"Correct a unit test failure that crept into trunk\n\nAt some point, the \"nova list\" command started returning an\nempty table when no results were obtained, while the\ntests.test_shell.ShellTest.test_password test was expecting\na single newline.  Whichever commit caused this change in\nbehavior somehow made it past the gate without forcing the\ntest to be updated.\n\nThis commit fixes the issue by changing the output that\ntest_shell.test_password is expecting.\n\nFixes bug 1166464.\n\nChange-Id: I57636b4a1e525c440925caba0bbb51bbcd94b080\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/69f9971da54b46a8883148e4cef6346c7933b6ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/69f9971da54b46a8883148e4cef6346c7933b6ec"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}