)]}'
{"id":"openstack%2Fpython-novaclient~264308","triplet_id":"openstack%2Fpython-novaclient~master~Ie4fe7b40e3f4350db94b350395269340ee6acf11","project":"openstack/python-novaclient","branch":"master","topic":"bug/1268480","hashtags":[],"change_id":"Ie4fe7b40e3f4350db94b350395269340ee6acf11","subject":"Replace assertTrue(isinstance()) by optimal assert","status":"MERGED","created":"2016-01-06 18:58:18.000000000","updated":"2016-01-07 03:30:24.000000000","submitted":"2016-01-07 03:30:24.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"969c5124d64af1acad5052350f085867835300a3","_number":264308,"virtual_id_number":264308,"owner":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2016-01-07 03:30:24.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2016-01-07 02:25:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-01-06 19:02:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":2,"date":"2016-01-06 19:12:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2016-01-06 19:27:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2016-01-07 02:25:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-06 19:02:25.000000000","updated_by":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"reviewer":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"state":"REVIEWER"},{"updated":"2016-01-06 19:12:34.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-01-06 19:27:43.000000000","updated_by":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"reviewer":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"state":"REVIEWER"},{"updated":"2016-01-07 02:25:06.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2016-01-07 03:30:24.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1726da46323c796ac4df7f1fdc5d6d2ddedf93b6","author":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"date":"2016-01-06 18:58:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b0c223a87d6c25897d553fad13ca0c5645eccbc2","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2016-01-06 19:02:25.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"1a562226205d036831fc1271d29a9fe3b5c9a212","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-01-06 19:12:34.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cca0219cf48db8c273c78c2c562138b8200e4b95","author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"date":"2016-01-06 19:27:43.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"30f9d684e637fafc5a163a2866cc0c10f2b856ae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-06 21:06:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/08/264308/1/check/gate-python-novaclient-pep8/a1b7531/ : SUCCESS in 40s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/08/264308/1/check/gate-python-novaclient-docs/e456348//doc/build/html/ : SUCCESS in 47s\n- gate-python-novaclient-python27 http://logs.openstack.org/08/264308/1/check/gate-python-novaclient-python27/0867414/ : SUCCESS in 3m 05s\n- gate-python-novaclient-python34 http://logs.openstack.org/08/264308/1/check/gate-python-novaclient-python34/f44dfa0/ : SUCCESS in 2m 41s\n- gate-python-novaclient-pypy http://logs.openstack.org/08/264308/1/check/gate-python-novaclient-pypy/383ff4b/ : SUCCESS in 3m 14s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/08/264308/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/ca66e4c/ : SUCCESS in 1h 03m 01s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/08/264308/1/check/gate-novaclient-dsvm-functional/0429485/ : SUCCESS in 40m 25s","accounts_in_message":[],"_revision_number":1},{"id":"5dc7fc4e7d13fd1cb439b9ce3730136bfc2e728d","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2016-01-07 02:25:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"d9c11e7feed737f417bfdd110342019863bd86c4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-07 02:25:11.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"c24a0e33e1d40021eaf21951a640676e51b6b033","date":"2016-01-07 03:30:24.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"6b7c6b9351c62e197db2cbbaee6cb62047e20749","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-07 03:30:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/08/264308/1/gate/gate-python-novaclient-docs/f714107//doc/build/html/ : SUCCESS in 1m 22s\n- gate-python-novaclient-pep8 http://logs.openstack.org/08/264308/1/gate/gate-python-novaclient-pep8/a947043/ : SUCCESS in 1m 12s\n- gate-python-novaclient-python27 http://logs.openstack.org/08/264308/1/gate/gate-python-novaclient-python27/81816b9/ : SUCCESS in 1m 41s\n- gate-python-novaclient-python34 http://logs.openstack.org/08/264308/1/gate/gate-python-novaclient-python34/0bcbf47/ : SUCCESS in 1m 51s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/08/264308/1/gate/gate-tempest-dsvm-neutron-src-python-novaclient/d4425c5/ : SUCCESS in 1h 04m 57s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/08/264308/1/gate/gate-novaclient-dsvm-functional/d265cdd/ : SUCCESS in 33m 00s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6d023a6bc299cb355f0ee90d626603456aa982f8","revisions":{"6d023a6bc299cb355f0ee90d626603456aa982f8":{"kind":"REWORK","_number":1,"created":"2016-01-06 18:58:18.000000000","uploader":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"ref":"refs/changes/08/264308/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/08/264308/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/264308/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/264308/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/264308/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/08/264308/1"}}},"commit":{"parents":[{"commit":"7d05f540eac29a6e899212b00595888cc06e73ed","subject":"Merge \"Use assertTrue/False instead of assertEqual(T/F)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7d05f540eac29a6e899212b00595888cc06e73ed"}]}],"author":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-06 18:55:45.000000000","tz":480},"committer":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-06 18:55:45.000000000","tz":480},"subject":"Replace assertTrue(isinstance()) by optimal assert","message":"Replace assertTrue(isinstance()) by optimal assert\n\nassertTrue(isinstance(A, B)) or assertEqual(type(A), B) in tests\nshould be replaced by assertIsInstance(A, B) provided by testtools.\n\nChange-Id: Ie4fe7b40e3f4350db94b350395269340ee6acf11\nRelated-bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6d023a6bc299cb355f0ee90d626603456aa982f8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6d023a6bc299cb355f0ee90d626603456aa982f8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}