)]}'
{"novaclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"4ddc2714c7a8354b34e322c36d4560fc5c9d8e33","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    def get_endpoint(self):"},{"line_number":139,"context_line":"        # check if endpoint matches expected format (eg, v2.1)"},{"line_number":140,"context_line":"        if (hasattr(self, \u0027endpoint_type\u0027) and"},{"line_number":141,"context_line":"           ENDPOINT_TYPE_RE.search(self.endpoint_type)):"},{"line_number":142,"context_line":"            return \"http://nova-api:8774/%s/\" % self.endpoint_type"},{"line_number":143,"context_line":"        else:"},{"line_number":144,"context_line":"            return ("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_9e763fd7","line":141,"updated":"2016-01-07 16:50:02.000000000","message":"femtonit: it would be nice to update the indentation here as well, for consistency…","commit_id":"02d50445153e8a0a76eeefe858d1b76ce1c65d4c"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"559ccab9aba77933a54c35e72fa25ce30d8e0f77","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    def get_endpoint(self):"},{"line_number":139,"context_line":"        # check if endpoint matches expected format (eg, v2.1)"},{"line_number":140,"context_line":"        if (hasattr(self, \u0027endpoint_type\u0027) and"},{"line_number":141,"context_line":"           ENDPOINT_TYPE_RE.search(self.endpoint_type)):"},{"line_number":142,"context_line":"            return \"http://nova-api:8774/%s/\" % self.endpoint_type"},{"line_number":143,"context_line":"        else:"},{"line_number":144,"context_line":"            return ("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_4e118303","line":141,"in_reply_to":"fa69d971_6ec70e65","updated":"2016-01-09 08:27:28.000000000","message":"Ah, thanks for the explanation. Fixed.","commit_id":"02d50445153e8a0a76eeefe858d1b76ce1c65d4c"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"dc1e5004d48dbe650b5caf941ecca29b8c5c0ed6","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    def get_endpoint(self):"},{"line_number":139,"context_line":"        # check if endpoint matches expected format (eg, v2.1)"},{"line_number":140,"context_line":"        if (hasattr(self, \u0027endpoint_type\u0027) and"},{"line_number":141,"context_line":"           ENDPOINT_TYPE_RE.search(self.endpoint_type)):"},{"line_number":142,"context_line":"            return \"http://nova-api:8774/%s/\" % self.endpoint_type"},{"line_number":143,"context_line":"        else:"},{"line_number":144,"context_line":"            return ("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_b36c9137","line":141,"in_reply_to":"fa69d971_9e763fd7","updated":"2016-01-07 20:21:28.000000000","message":"This is not possible, using visual indent then triggers the warning: \n\nE129 visually indented line with same indent as next logical line\n\nUsing a hanging indent is perfectly fine though imho.","commit_id":"02d50445153e8a0a76eeefe858d1b76ce1c65d4c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3cdc4cb9e92908c5baebe8e21c5cc375f8fecaec","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    def get_endpoint(self):"},{"line_number":139,"context_line":"        # check if endpoint matches expected format (eg, v2.1)"},{"line_number":140,"context_line":"        if (hasattr(self, \u0027endpoint_type\u0027) and"},{"line_number":141,"context_line":"           ENDPOINT_TYPE_RE.search(self.endpoint_type)):"},{"line_number":142,"context_line":"            return \"http://nova-api:8774/%s/\" % self.endpoint_type"},{"line_number":143,"context_line":"        else:"},{"line_number":144,"context_line":"            return ("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_6ec70e65","line":141,"in_reply_to":"fa69d971_b36c9137","updated":"2016-01-07 20:40:59.000000000","message":"Then you\u0027re not indenting the way I meant :)  If you look at the case in the other file, you\u0027ll notice that the second line of the condition is indented a further four spaces beyond the \"visual indent\" condition.  As far as I know, that\u0027s the convention we\u0027re intending to use throughout novaclient, and it would certainly make the distinction between the second line of the condition and the following return statement much more visually clear.","commit_id":"02d50445153e8a0a76eeefe858d1b76ce1c65d4c"}]}