)]}'
{"id":"openstack%2Fpython-novaclient~264760","triplet_id":"openstack%2Fpython-novaclient~master~I9d0f6909d0e649fe740b748b831894ccb4e80b15","project":"openstack/python-novaclient","branch":"master","topic":"pep8","hashtags":[],"change_id":"I9d0f6909d0e649fe740b748b831894ccb4e80b15","subject":"Fix W503 line break before binary operator","status":"MERGED","created":"2016-01-07 13:14:18.000000000","updated":"2016-01-12 01:43:47.000000000","submitted":"2016-01-12 01:43:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ad4b26839c7200b3ace89af9c3cee8998cba81d0","_number":264760,"virtual_id_number":264760,"owner":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2016-01-12 01:43:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":2,"date":"2016-01-12 00:49:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-11 17:35:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2016-01-10 21:03:57.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":1,"date":"2016-01-12 00:49:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-10 21:03:57.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2016-01-11 17:35:00.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-01-12 00:49:13.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2016-01-12 01:43:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"90fe4c60232358647d4e2216ac815e212320413c","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2016-01-07 13:14:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"098a9d62c30a4395df7b074b4f5e60a729debcfe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-07 14:17:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/60/264760/1/check/gate-python-novaclient-pep8/5024287/ : SUCCESS in 59s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/60/264760/1/check/gate-python-novaclient-docs/074db30//doc/build/html/ : SUCCESS in 1m 27s\n- gate-python-novaclient-python27 http://logs.openstack.org/60/264760/1/check/gate-python-novaclient-python27/4b3ab91/ : SUCCESS in 1m 33s\n- gate-python-novaclient-python34 http://logs.openstack.org/60/264760/1/check/gate-python-novaclient-python34/f295ce6/ : SUCCESS in 2m 15s\n- gate-python-novaclient-pypy http://logs.openstack.org/60/264760/1/check/gate-python-novaclient-pypy/6f7ce03/ : SUCCESS in 3m 58s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/60/264760/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/4531288/ : FAILURE in 1h 01m 10s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/60/264760/1/check/gate-novaclient-dsvm-functional/332ec8b/ : SUCCESS in 41m 50s","accounts_in_message":[],"_revision_number":1},{"id":"4ddc2714c7a8354b34e322c36d4560fc5c9d8e33","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-01-07 16:50:02.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"dc1e5004d48dbe650b5caf941ecca29b8c5c0ed6","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2016-01-07 20:21:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3cdc4cb9e92908c5baebe8e21c5cc375f8fecaec","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-01-07 20:40:59.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"559ccab9aba77933a54c35e72fa25ce30d8e0f77","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2016-01-09 08:27:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cf3b788c662efa61b6aa268ff2fd0393716ae0ae","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2016-01-09 08:27:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ddb2c1fac368c953f1edef0830f931b9c8298ac8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-09 09:26:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/60/264760/2/check/gate-python-novaclient-pep8/246e67c/ : SUCCESS in 1m 09s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/60/264760/2/check/gate-python-novaclient-docs/d882bd8//doc/build/html/ : SUCCESS in 1m 25s\n- gate-python-novaclient-python27 http://logs.openstack.org/60/264760/2/check/gate-python-novaclient-python27/fc460ca/ : SUCCESS in 1m 44s\n- gate-python-novaclient-python34 http://logs.openstack.org/60/264760/2/check/gate-python-novaclient-python34/9037c1f/ : SUCCESS in 2m 02s\n- gate-python-novaclient-pypy http://logs.openstack.org/60/264760/2/check/gate-python-novaclient-pypy/c223ca6/ : SUCCESS in 2m 32s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/60/264760/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/032ddb9/ : SUCCESS in 58m 33s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/60/264760/2/check/gate-novaclient-dsvm-functional/9b844dd/ : SUCCESS in 30m 58s","accounts_in_message":[],"_revision_number":2},{"id":"c0994097befbb567542f0a843e624fd7536f3d39","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-01-09 15:02:40.000000000","message":"Patch Set 2:\n\nIf pep8 cares about this why wasn\u0027t it being flagged as a problem before? And I don\u0027t see us excluding it in our flake8 runs:\n\nhttps://github.com/openstack/python-novaclient/blob/master/tox.ini#L54\n\nSo if we\u0027re not going to enforce it in the pep8 job I don\u0027t really see the reason in changing this.","accounts_in_message":[],"_revision_number":2},{"id":"511ad1a5543a6e6d54f282653decd853fb99ffb4","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-01-10 21:03:57.000000000","message":"Patch Set 2: Code-Review+1\n\nI\u0027m wondering, why `tox -e pep8` doesn\u0027t check this rule?\nPS: patch looks good to me","accounts_in_message":[],"_revision_number":2},{"id":"8c4f53f6cdb4f64c888bb217a9249e6ce16a51b9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-01-11 17:35:00.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"78bf9f25f5ffd3007c5a15d64b5ff42fc8240ad0","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2016-01-12 00:49:13.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLooks like this check is new in pep8 1.6.2 [1] and we\u0027ve got pep8\u003d\u003d1.5.7 installing in our pep8 job because we have flake8\u003e\u003d2.2.4,\u003c\u003d2.4.1 in global requirements.\n\nI was able to see the W503 errors, among others, with flake8\u003d\u003d2.5.1 and pep8\u003d\u003d1.6.2.\n\nSo, the pep8 job won\u0027t be failing on this for awhile but I think it doesn\u0027t hurt to address them now\n\n[1] https://github.com/PyCQA/pep8/blob/dcfdfda785/CHANGES.txt#L5-L10","accounts_in_message":[],"_revision_number":2},{"id":"abd9691f97c686d9239816fd2ceb07436bcb8224","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-12 00:49:18.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7e01d3f248a37718e960262e3a0a897a9b355240","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-12 01:43:46.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/60/264760/2/gate/gate-python-novaclient-docs/4bb45f8//doc/build/html/ : SUCCESS in 1m 23s\n- gate-python-novaclient-pep8 http://logs.openstack.org/60/264760/2/gate/gate-python-novaclient-pep8/c7cde45/ : SUCCESS in 1m 44s\n- gate-python-novaclient-python27 http://logs.openstack.org/60/264760/2/gate/gate-python-novaclient-python27/387427e/ : SUCCESS in 1m 28s\n- gate-python-novaclient-python34 http://logs.openstack.org/60/264760/2/gate/gate-python-novaclient-python34/8a4bcfe/ : SUCCESS in 1m 49s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/60/264760/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient/dab6165/ : SUCCESS in 54m 25s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/60/264760/2/gate/gate-novaclient-dsvm-functional/9d633dc/ : SUCCESS in 30m 32s","accounts_in_message":[],"_revision_number":2},{"id":"829199900bd987681dabbf1710c077abf3467593","date":"2016-01-12 01:43:47.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fa3a8edf20c6e83524c125a156aa13d2bcd30165","revisions":{"02d50445153e8a0a76eeefe858d1b76ce1c65d4c":{"kind":"REWORK","_number":1,"created":"2016-01-07 13:14:18.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/60/264760/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/60/264760/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/60/264760/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/60/264760/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/60/264760/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/60/264760/1"}}},"commit":{"parents":[{"commit":"6d023a6bc299cb355f0ee90d626603456aa982f8","subject":"Replace assertTrue(isinstance()) by optimal assert","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6d023a6bc299cb355f0ee90d626603456aa982f8"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2016-01-07 13:13:34.000000000","tz":60},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2016-01-07 13:13:34.000000000","tz":60},"subject":"Fix W503 line break before binary operator","message":"Fix W503 line break before binary operator\n\nAccording to PEP8 the line break should be always after\na binary operator.\n\nChange-Id: I9d0f6909d0e649fe740b748b831894ccb4e80b15\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/02d50445153e8a0a76eeefe858d1b76ce1c65d4c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/02d50445153e8a0a76eeefe858d1b76ce1c65d4c"}]},"branch":"refs/heads/master"},"fa3a8edf20c6e83524c125a156aa13d2bcd30165":{"kind":"REWORK","_number":2,"created":"2016-01-09 08:27:45.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/60/264760/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/60/264760/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/60/264760/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/60/264760/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/60/264760/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/60/264760/2"}}},"commit":{"parents":[{"commit":"ff980114b6990daf60fb22554b1f00c89a22dbb1","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff980114b6990daf60fb22554b1f00c89a22dbb1"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2016-01-07 13:13:34.000000000","tz":60},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2016-01-09 08:27:38.000000000","tz":60},"subject":"Fix W503 line break before binary operator","message":"Fix W503 line break before binary operator\n\nAccording to PEP8 the line break should be always after\na binary operator.\n\nChange-Id: I9d0f6909d0e649fe740b748b831894ccb4e80b15\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fa3a8edf20c6e83524c125a156aa13d2bcd30165"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fa3a8edf20c6e83524c125a156aa13d2bcd30165"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}