)]}'
{"id":"openstack%2Fpython-novaclient~265122","triplet_id":"openstack%2Fpython-novaclient~master~I06b52f3d75a5d62064ca9c7fa658a049e95ed40b","project":"openstack/python-novaclient","branch":"master","topic":"use_oslo_reflection","hashtags":[],"change_id":"I06b52f3d75a5d62064ca9c7fa658a049e95ed40b","subject":"Use the oslo.utils.reflection to extract the class name","status":"ABANDONED","created":"2016-01-08 07:46:55.000000000","updated":"2016-07-18 02:20:06.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"923969633347b10aafe4eed24190e21e5c6e8d80","_number":265122,"virtual_id_number":265122,"owner":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":1,"date":"2016-01-08 10:26:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"disliked":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":-1,"date":"2016-01-12 01:06:43.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-08 16:47:02.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-08 10:26:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-01-08 16:47:02.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-01-12 01:06:43.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"}],"messages":[{"id":"ba68d302224be6b18a49613e86ddd4a982597c5d","author":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"date":"2016-01-08 07:46:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9f96bddff7047230c364c77c8593f3b71f030b6f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 08:56:53.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/22/265122/1/check/gate-python-novaclient-pep8/50c8561/ : FAILURE in 1m 16s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/22/265122/1/check/gate-python-novaclient-docs/ba9ce2f//doc/build/html/ : SUCCESS in 1m 34s\n- gate-python-novaclient-python27 http://logs.openstack.org/22/265122/1/check/gate-python-novaclient-python27/25bb090/ : SUCCESS in 2m 02s\n- gate-python-novaclient-python34 http://logs.openstack.org/22/265122/1/check/gate-python-novaclient-python34/ab58c67/ : SUCCESS in 2m 00s\n- gate-python-novaclient-pypy http://logs.openstack.org/22/265122/1/check/gate-python-novaclient-pypy/a2b07e1/ : SUCCESS in 3m 14s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/22/265122/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/bcb4ad1/ : SUCCESS in 1h 09m 11s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/22/265122/1/check/gate-novaclient-dsvm-functional/600b2f6/ : SUCCESS in 29m 47s","accounts_in_message":[],"_revision_number":1},{"id":"36450cb3f1187cb3bf8161d06f6c57ef020a7ed7","author":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"date":"2016-01-08 08:59:48.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0473616899cf51104843c86039de36deb974c63a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 10:26:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/22/265122/2/check/gate-python-novaclient-pep8/b2cfc23/ : SUCCESS in 1m 06s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/22/265122/2/check/gate-python-novaclient-docs/46c73eb//doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-novaclient-python27 http://logs.openstack.org/22/265122/2/check/gate-python-novaclient-python27/5ceac60/ : SUCCESS in 1m 39s\n- gate-python-novaclient-python34 http://logs.openstack.org/22/265122/2/check/gate-python-novaclient-python34/0d3a5c3/ : SUCCESS in 2m 57s\n- gate-python-novaclient-pypy http://logs.openstack.org/22/265122/2/check/gate-python-novaclient-pypy/e154538/ : SUCCESS in 3m 28s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/22/265122/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/9ec66ec/ : SUCCESS in 1h 16m 35s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/22/265122/2/check/gate-novaclient-dsvm-functional/02dab1a/ : SUCCESS in 29m 21s","accounts_in_message":[],"_revision_number":2},{"id":"4c6c3215d23816e1222db410469077b55081213e","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-01-08 16:47:02.000000000","message":"Patch Set 2: Code-Review+2\n\n*shrug* appears trivial…","accounts_in_message":[],"_revision_number":2},{"id":"d300c638537b4b8fe79278a069b73b9b3e888048","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2016-01-12 01:06:43.000000000","message":"Patch Set 2: Code-Review-1\n\nFrom what I understand, self.__class__.__name__ will contain the class name in python 2 and python 3, without the introspection checks this function adds. From the docstring, get_class_name is useful for getting the class name when you don\u0027t know if the object you\u0027re calling about is a type or an instance of a class","accounts_in_message":[],"_revision_number":2},{"id":"825367722bd6e8f7bca71cea0c4291f65fea1a18","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-06-10 15:56:26.000000000","message":"Patch Set 2:\n\nAre you still working on this change?  It hasn\u0027t been updated since January, and you haven\u0027t responded to review comments…","accounts_in_message":[],"_revision_number":2},{"id":"13d425e44b506072cd647569dbb2330619ae0cc1","author":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"date":"2016-07-18 02:20:06.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"136aec6294b695d339f47fee1b9bc7471df1cde4","revisions":{"a2891a07883399a341f3605eb9f7de90e8a0226a":{"kind":"REWORK","_number":1,"created":"2016-01-08 07:46:55.000000000","uploader":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"ref":"refs/changes/22/265122/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/22/265122/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/265122/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/265122/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/265122/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/22/265122/1"}}},"commit":{"parents":[{"commit":"7d05f540eac29a6e899212b00595888cc06e73ed","subject":"Merge \"Use assertTrue/False instead of assertEqual(T/F)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7d05f540eac29a6e899212b00595888cc06e73ed"}]}],"author":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-08 07:46:32.000000000","tz":480},"committer":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-08 07:46:32.000000000","tz":480},"subject":"Use the oslo.utils.reflection to extract the class name","message":"Use the oslo.utils.reflection to extract the class name\n\nThe oslo.utils reflection module/code handles more variations\n of where a class name may come from (on python 2 and python 3)\nso its usage allows getting more accurate class names so we might\nas well use it.\n\nChange-Id: I06b52f3d75a5d62064ca9c7fa658a049e95ed40b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a2891a07883399a341f3605eb9f7de90e8a0226a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a2891a07883399a341f3605eb9f7de90e8a0226a"}]},"branch":"refs/heads/master"},"136aec6294b695d339f47fee1b9bc7471df1cde4":{"kind":"REWORK","_number":2,"created":"2016-01-08 08:59:48.000000000","uploader":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"ref":"refs/changes/22/265122/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/22/265122/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/265122/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/265122/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/22/265122/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/22/265122/2"}}},"commit":{"parents":[{"commit":"7d05f540eac29a6e899212b00595888cc06e73ed","subject":"Merge \"Use assertTrue/False instead of assertEqual(T/F)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7d05f540eac29a6e899212b00595888cc06e73ed"}]}],"author":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-08 07:46:32.000000000","tz":480},"committer":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-08 08:59:33.000000000","tz":480},"subject":"Use the oslo.utils.reflection to extract the class name","message":"Use the oslo.utils.reflection to extract the class name\n\nThe oslo.utils reflection module/code handles more variations\n of where a class name may come from (on python 2 and python 3)\nso its usage allows getting more accurate class names so we might\nas well use it.\n\nChange-Id: I06b52f3d75a5d62064ca9c7fa658a049e95ed40b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/136aec6294b695d339f47fee1b9bc7471df1cde4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/136aec6294b695d339f47fee1b9bc7471df1cde4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}