)]}'
{"id":"openstack%2Fpython-novaclient~265725","triplet_id":"openstack%2Fpython-novaclient~master~I70682e54874860f1d67d29325811c9da616bb705","project":"openstack/python-novaclient","branch":"master","topic":"bug/1532711","hashtags":[],"change_id":"I70682e54874860f1d67d29325811c9da616bb705","subject":"Test: Clean v2 client userwarning","status":"MERGED","created":"2016-01-11 09:13:19.000000000","updated":"2016-01-13 19:32:43.000000000","submitted":"2016-01-13 19:32:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6a6cdc1cb08c14d95a805b77055e7794202ad8e0","_number":265725,"virtual_id_number":265725,"owner":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-01-13 19:32:43.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-12 17:54:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2016-01-12 10:00:56.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},{"value":2,"date":"2016-01-13 17:24:10.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},{"value":1,"date":"2016-01-13 17:24:13.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-12 10:00:56.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2016-01-12 17:54:11.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-01-13 17:24:13.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2016-01-13 19:32:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"62a935d2c0d8e109ceaf919593a44b37a4d76fa3","author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"date":"2016-01-11 09:13:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3ef50ce995582a89b17a9a0db987330c57787b03","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-01-11 10:05:23.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"73abaf5aa3b12a80b66754a6b0dabe95b3c71c77","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-11 10:09:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/25/265725/1/check/gate-python-novaclient-pep8/d4cc92b/ : SUCCESS in 1m 36s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/25/265725/1/check/gate-python-novaclient-docs/8dcb5bc//doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-novaclient-python27 http://logs.openstack.org/25/265725/1/check/gate-python-novaclient-python27/182f55c/ : SUCCESS in 1m 33s\n- gate-python-novaclient-python34 http://logs.openstack.org/25/265725/1/check/gate-python-novaclient-python34/4400c1e/ : SUCCESS in 2m 11s\n- gate-python-novaclient-pypy http://logs.openstack.org/25/265725/1/check/gate-python-novaclient-pypy/9ce0e42/ : SUCCESS in 2m 30s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/25/265725/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/f000050/ : SUCCESS in 56m 13s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/25/265725/1/check/gate-novaclient-dsvm-functional/ec818ce/ : SUCCESS in 40m 14s","accounts_in_message":[],"_revision_number":1},{"id":"ba4de87dd72406e1cf8242d3a956f65bdd5dc63c","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-01-11 10:13:32.000000000","message":"Patch Set 1: Code-Review-1\n\nbtw, test_auth_plugin and test_client should use novaclient.client.Client endpoint.","accounts_in_message":[],"_revision_number":1},{"id":"d454c5968b51e2c94ff3bcd0f6564cabc4d41dd3","author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"date":"2016-01-11 10:44:26.000000000","message":"Patch Set 1:\n\n@Andrey Hi,Thanks for your review. I\u0027m sure we are using v2client in test_auth_plugins.py and test_client.py. Please recheck.","accounts_in_message":[],"_revision_number":1},{"id":"5fe53401b3630ab812d0c8d74639c7b9c6d5c026","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-01-11 12:42:27.000000000","message":"Patch Set 1:\n\n@Chaozhe: there is no reason to use novaclient.v2.client.Client directly in test_client and test_auth_plugins . novaclient.client.Client will initialize novaclient.v2.client.Client correctly without setting direct_usage\u003dFalse . We should use novaclient.client.Client entry-point in all places, except tests for novaclient.v2.client.Client","accounts_in_message":[],"_revision_number":1},{"id":"850cae942cbfe911832716edcb06db0644c3c94f","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-01-11 17:40:06.000000000","message":"Patch Set 1: Code-Review+2\n\nPersonally, I think this will solve the warnings just fine, and a later change can convert over to the updated usage.  Alternatively, if someone proposes a change that converts over to the updated usage, I\u0027ll +2 that and -1 this, suggesting that effort be focused on the conversion.  Or Chen can earn some points and do it in this change, if he\u0027s so inclined :)","accounts_in_message":[],"_revision_number":1},{"id":"f54b18132768644ab4fb07095678fccbf7e74e04","author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"date":"2016-01-12 04:11:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4e96c136543e10571ae33d3ebd7bd4da5326ad3b","author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"date":"2016-01-12 04:59:15.000000000","message":"Patch Set 1:\n\n@Andrey, @Kevin. I will take your advice, use updated usage instead of using v2.client directly in \u0027testclient\u0027 and \u0027test_auth_plugins\u0027.","accounts_in_message":[],"_revision_number":1},{"id":"6fadf445e9761accaf9b35a6ddc5fbfdb188f89c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-12 05:03:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/25/265725/2/check/gate-python-novaclient-pep8/e8abc41/ : SUCCESS in 1m 07s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/25/265725/2/check/gate-python-novaclient-docs/a04aef2//doc/build/html/ : SUCCESS in 1m 31s\n- gate-python-novaclient-python27 http://logs.openstack.org/25/265725/2/check/gate-python-novaclient-python27/592ff5a/ : SUCCESS in 3m 22s\n- gate-python-novaclient-python34 http://logs.openstack.org/25/265725/2/check/gate-python-novaclient-python34/d6e492c/ : SUCCESS in 1m 44s\n- gate-python-novaclient-pypy http://logs.openstack.org/25/265725/2/check/gate-python-novaclient-pypy/5a104ce/ : SUCCESS in 2m 22s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/25/265725/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/a380663/ : SUCCESS in 52m 21s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/25/265725/2/check/gate-novaclient-dsvm-functional/7226b4c/ : SUCCESS in 41m 00s","accounts_in_message":[],"_revision_number":2},{"id":"228e3a810d5a254a3699aa5a191bb0573accd58b","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-01-12 10:00:56.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM, thanks","accounts_in_message":[],"_revision_number":2},{"id":"2c00aee4a8cf65a8448b325407f31a73d5bf5ed6","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-01-12 17:54:11.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3f77035b2091176a9c5244e2a8d36540cabfef38","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-01-13 17:24:10.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9adcf73a23889361915eafaec37f7d533451f220","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-01-13 17:24:13.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"01eecaa66906facdb9f7f73bec5571df0beac9f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-13 17:24:20.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"02238f5b4dc7285615d8fa03fe200687d92b3db5","date":"2016-01-13 19:32:43.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"2f584cafe7454c0dfadd2c666226c729b04bdf6f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-13 19:32:43.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/25/265725/2/gate/gate-python-novaclient-docs/72e3891//doc/build/html/ : SUCCESS in 56s\n- gate-python-novaclient-pep8 http://logs.openstack.org/25/265725/2/gate/gate-python-novaclient-pep8/a08aa45/ : SUCCESS in 35s\n- gate-python-novaclient-python27 http://logs.openstack.org/25/265725/2/gate/gate-python-novaclient-python27/0a656de/ : SUCCESS in 1m 12s\n- gate-python-novaclient-python34 http://logs.openstack.org/25/265725/2/gate/gate-python-novaclient-python34/869c865/ : SUCCESS in 1m 05s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/25/265725/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient/c97e5d7/ : SUCCESS in 1h 11m 31s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/25/265725/2/gate/gate-novaclient-dsvm-functional/25b0f89/ : SUCCESS in 28m 41s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"14f63647e9d9b6f44a3e99c545b6cb97fe31f0ff","revisions":{"52f6276c7a3c1622a5b9a46ad88e0efe2dc49742":{"kind":"REWORK","_number":1,"created":"2016-01-11 09:13:19.000000000","uploader":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"ref":"refs/changes/25/265725/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/25/265725/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/265725/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/265725/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/265725/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/25/265725/1"}}},"commit":{"parents":[{"commit":"ff980114b6990daf60fb22554b1f00c89a22dbb1","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff980114b6990daf60fb22554b1f00c89a22dbb1"}]}],"author":{"name":"Chaozhe.Chen","email":"chaozhe.chen@easystack.cn","date":"2016-01-11 08:45:25.000000000","tz":480},"committer":{"name":"Chaozhe.Chen","email":"chaozhe.chen@easystack.cn","date":"2016-01-11 09:07:35.000000000","tz":480},"subject":"Test: Clean v2 client userwarning","message":"Test: Clean v2 client userwarning\n\nWhen we run nova client unit test, there are lots of UserWarnings\nprinted on the screen. These warnings mean to remind users not to\nuse v2.client directly. This patch will clean those warnings with\nsetting direct_use False.\n\nChange-Id: I70682e54874860f1d67d29325811c9da616bb705\nCloses-Bug: #1532711\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/52f6276c7a3c1622a5b9a46ad88e0efe2dc49742"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/52f6276c7a3c1622a5b9a46ad88e0efe2dc49742"}]},"branch":"refs/heads/master"},"14f63647e9d9b6f44a3e99c545b6cb97fe31f0ff":{"kind":"REWORK","_number":2,"created":"2016-01-12 04:11:01.000000000","uploader":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"ref":"refs/changes/25/265725/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/25/265725/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/265725/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/265725/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/265725/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/25/265725/2"}}},"commit":{"parents":[{"commit":"ff980114b6990daf60fb22554b1f00c89a22dbb1","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff980114b6990daf60fb22554b1f00c89a22dbb1"}]}],"author":{"name":"Chaozhe.Chen","email":"chaozhe.chen@easystack.cn","date":"2016-01-11 08:45:25.000000000","tz":480},"committer":{"name":"Chaozhe.Chen","email":"chaozhe.chen@easystack.cn","date":"2016-01-12 04:05:50.000000000","tz":480},"subject":"Test: Clean v2 client userwarning","message":"Test: Clean v2 client userwarning\n\nProblem:\nWhen we run nova client unit test, there are lots of UserWarnings\nprinted on the screen. These warnings mean to remind users not to\nuse v2.client directly.\n\nSolution:\n1. In top level tests such as some tests in test_auth_plugins.py\ntest_client.py and fixture_data/client.py, we use updated usage\nnovaclient.client instead of using novaclient.v2.client directly.\n2. In v2 unit tests, we clean those warnings with setting direct_use\nFalse.\n\nChange-Id: I70682e54874860f1d67d29325811c9da616bb705\nCloses-Bug: #1532711\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/14f63647e9d9b6f44a3e99c545b6cb97fe31f0ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/14f63647e9d9b6f44a3e99c545b6cb97fe31f0ff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}