)]}'
{"id":"openstack%2Fpython-novaclient~2668","triplet_id":"openstack%2Fpython-novaclient~master~I73d64f9e0ea6a1c913f427d1fd07b76d19e9f6a3","project":"openstack/python-novaclient","branch":"master","topic":"bp/public-and-private-dns","hashtags":[],"change_id":"I73d64f9e0ea6a1c913f427d1fd07b76d19e9f6a3","subject":"Add the python api for floating IP DNS.","status":"MERGED","created":"2011-12-28 23:43:33.000000000","updated":"2011-12-29 22:42:05.000000000","submitted":"2011-12-29 22:42:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":12,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9bc58df7fa7fd3a3ad467322d6239075b02cae9d","_number":2668,"virtual_id_number":2668,"owner":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2011-12-29 22:42:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"date":"2011-12-29 22:42:05.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2011-12-29 22:39:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2011-12-29 22:41:55.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2011-12-29 22:39:36.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2011-12-29 22:41:55.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-12-29 22:39:36.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2011-12-29 22:41:55.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"},{"updated":"2011-12-29 22:42:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a8cad08f7077acaa058b22885fa0946937827b54","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2011-12-29 00:03:01.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\n(2 inline comments)\n\nYou\u0027ve got some real funk flying around in the added tests; see in-line comments.  Otherwise, this looks fairly OK, but I\u0027ll want to go over it more once you clean up the tests.","accounts_in_message":[],"_revision_number":1},{"id":"4fdced003fb0fc6dec63393717295f4582ace009","author":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"date":"2011-12-29 00:13:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"70a838c8df325c5294d67eb494df3ef3297cb2b8","author":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"date":"2011-12-29 00:13:48.000000000","message":"Patch Set 1: (2 inline comments)\n\nSo many needless brackets!  Should be cleaned up now.","accounts_in_message":[],"_revision_number":1},{"id":"38d242e1667cd53c97094d548db06b870a80549c","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-12-29 15:11:34.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t submit this\n\n(2 inline comments)\n\nLooks good, Andrew. Just a few style comments inline.","accounts_in_message":[],"_revision_number":2},{"id":"2e3a121773a9d502b978856551bf7f41e49354aa","author":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"date":"2011-12-29 18:34:23.000000000","message":"Patch Set 2: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"0fb2371e60b358b8504080149d5e0eeda2288e10","author":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"date":"2011-12-29 20:44:08.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"873a218d673ac64de54bbef00658e7accddbef5b","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2011-12-29 21:13:48.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"68653cfbd7eed8285d3c496d1dc1cb76cb2a9326","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-12-29 21:46:17.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t submit this\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"696a60b560afb286ebaf575eb9b3925239889e1e","author":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"date":"2011-12-29 22:10:09.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"cf35b83b8bc8317f3850640c234af4b43fe219d5","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2011-12-29 22:17:16.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t submit this\n\n(2 inline comments)\n\nI really don\u0027t see any point in using update() if you don\u0027t have to...and if we\u0027re setting a single element, we don\u0027t have to use update().","accounts_in_message":[],"_revision_number":4},{"id":"fe90a598c6a58db5fa51ee612e00ac2ed2a1c84a","author":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"date":"2011-12-29 22:21:45.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"0bdcdf294d05894cb9d0b0677a3b8ae82d374f1b","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2011-12-29 22:39:36.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"27d927149af771688eda15633633222fd168bb85","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-12-29 22:41:55.000000000","message":"Patch Set 5: Looks good to me (core reviewer); Approved\n\nThanks for working with us!","accounts_in_message":[],"_revision_number":5},{"id":"e1f8fecdd11169856e531bd8e0323d824d89fca7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-29 22:42:05.000000000","message":"Patch Set 5: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/49/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/49/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/51/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"e0a89e8e57f5a39304b5db7470bf2f1672721fde","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-29 22:42:05.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"c9d87f9bacae04443de1889533e91b18e0df8236","revisions":{"6487d62268ca9af60df09f960fe33f5beaf02509":{"kind":"REWORK","_number":1,"created":"2011-12-28 23:43:33.000000000","uploader":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"ref":"refs/changes/68/2668/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/68/2668/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/1"}}},"commit":{"parents":[{"commit":"24388696551f97d41195241ff1a3bb0087305039","subject":"Improve the test framework to handle urls with args.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/24388696551f97d41195241ff1a3bb0087305039"}]}],"author":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2011-12-28 23:33:43.000000000","tz":-360},"committer":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2011-12-28 23:42:33.000000000","tz":-360},"subject":"Add the python api for floating IP DNS.","message":"Add the python api for floating IP DNS.\n\nFor blueprint public-and-private-dns.\n\nChange-Id: I73d64f9e0ea6a1c913f427d1fd07b76d19e9f6a3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6487d62268ca9af60df09f960fe33f5beaf02509"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6487d62268ca9af60df09f960fe33f5beaf02509"}]},"branch":"refs/heads/master"},"e5d340b7a582d781216e0c44f1cbe09e8c1b0509":{"kind":"REWORK","_number":2,"created":"2011-12-29 00:13:20.000000000","uploader":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"ref":"refs/changes/68/2668/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/68/2668/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/2"}}},"commit":{"parents":[{"commit":"24388696551f97d41195241ff1a3bb0087305039","subject":"Improve the test framework to handle urls with args.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/24388696551f97d41195241ff1a3bb0087305039"}]}],"author":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2011-12-28 23:33:43.000000000","tz":-360},"committer":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2011-12-29 00:12:50.000000000","tz":-360},"subject":"Add the python api for floating IP DNS.","message":"Add the python api for floating IP DNS.\n\nFor blueprint public-and-private-dns.\n\nChange-Id: I73d64f9e0ea6a1c913f427d1fd07b76d19e9f6a3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e5d340b7a582d781216e0c44f1cbe09e8c1b0509"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e5d340b7a582d781216e0c44f1cbe09e8c1b0509"}]},"branch":"refs/heads/master"},"1216d71427be251b3d9c76227bf9337e56f63025":{"kind":"REWORK","_number":3,"created":"2011-12-29 20:44:08.000000000","uploader":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"ref":"refs/changes/68/2668/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/68/2668/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/3"}}},"commit":{"parents":[{"commit":"90212e9317581eace8c4329367f5645403a30989","subject":"Remove unused imports and fix NameError on exc","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/90212e9317581eace8c4329367f5645403a30989"}]}],"author":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2011-12-28 23:33:43.000000000","tz":-360},"committer":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2011-12-29 20:46:49.000000000","tz":-360},"subject":"Add the python api for floating IP DNS.","message":"Add the python api for floating IP DNS.\n\nFor blueprint public-and-private-dns.\n\nChange-Id: I73d64f9e0ea6a1c913f427d1fd07b76d19e9f6a3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/1216d71427be251b3d9c76227bf9337e56f63025"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/1216d71427be251b3d9c76227bf9337e56f63025"}]},"branch":"refs/heads/master"},"3e7e39b53d4ef1e088530e3af4e5837fb9e18080":{"kind":"REWORK","_number":4,"created":"2011-12-29 22:10:09.000000000","uploader":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"ref":"refs/changes/68/2668/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/68/2668/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/4"}}},"commit":{"parents":[{"commit":"90212e9317581eace8c4329367f5645403a30989","subject":"Remove unused imports and fix NameError on exc","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/90212e9317581eace8c4329367f5645403a30989"}]}],"author":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2011-12-28 23:33:43.000000000","tz":-360},"committer":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2011-12-29 22:16:25.000000000","tz":-360},"subject":"Add the python api for floating IP DNS.","message":"Add the python api for floating IP DNS.\n\nFor blueprint public-and-private-dns.\n\nChange-Id: I73d64f9e0ea6a1c913f427d1fd07b76d19e9f6a3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3e7e39b53d4ef1e088530e3af4e5837fb9e18080"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3e7e39b53d4ef1e088530e3af4e5837fb9e18080"}]},"branch":"refs/heads/master"},"c9d87f9bacae04443de1889533e91b18e0df8236":{"kind":"REWORK","_number":5,"created":"2011-12-29 22:21:45.000000000","uploader":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"ref":"refs/changes/68/2668/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/68/2668/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/68/2668/5"}}},"commit":{"parents":[{"commit":"90212e9317581eace8c4329367f5645403a30989","subject":"Remove unused imports and fix NameError on exc","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/90212e9317581eace8c4329367f5645403a30989"}]}],"author":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2011-12-28 23:33:43.000000000","tz":-360},"committer":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2011-12-29 22:22:25.000000000","tz":-360},"subject":"Add the python api for floating IP DNS.","message":"Add the python api for floating IP DNS.\n\nFor blueprint public-and-private-dns.\n\nChange-Id: I73d64f9e0ea6a1c913f427d1fd07b76d19e9f6a3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c9d87f9bacae04443de1889533e91b18e0df8236"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c9d87f9bacae04443de1889533e91b18e0df8236"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}