)]}'
{"novaclient/tests/functional/hooks/post_test_hook.sh":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f6efe1fa9938e7ddf136bbb3fd515d7b9d7b67ea","unresolved":false,"context_lines":[{"line_number":43,"context_line":"echo \"Running novaclient functional test suite\""},{"line_number":44,"context_line":"set +e"},{"line_number":45,"context_line":"# Preserve env for OS_ credentials"},{"line_number":46,"context_line":"sudo -E -H -u jenkins tox -e ${TOX_ENV:-functional}"},{"line_number":47,"context_line":"EXIT_CODE\u003d$?"},{"line_number":48,"context_line":"set -e"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"da6ed579_18f031c9","line":46,"range":{"start_line":46,"start_character":31,"end_line":46,"end_character":38},"updated":"2016-01-15 21:39:58.000000000","message":"Where does this variable come from? I\u0027m trying to understand how this is supposed to work before approving","commit_id":"426f6afb3ce09ae1325d10930eba134e0573f78e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"77f0186bb7b671aa8233d4ebb5405918b48f3c36","unresolved":false,"context_lines":[{"line_number":43,"context_line":"echo \"Running novaclient functional test suite\""},{"line_number":44,"context_line":"set +e"},{"line_number":45,"context_line":"# Preserve env for OS_ credentials"},{"line_number":46,"context_line":"sudo -E -H -u jenkins tox -e ${TOX_ENV:-functional}"},{"line_number":47,"context_line":"EXIT_CODE\u003d$?"},{"line_number":48,"context_line":"set -e"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"da6ed579_c344ea1c","line":46,"range":{"start_line":46,"start_character":31,"end_line":46,"end_character":38},"in_reply_to":"da6ed579_18f031c9","updated":"2016-01-15 22:02:46.000000000","message":"This hook is used in gates. I already posted a change to project-config( https://review.openstack.org/#/c/266955/ ) for new job. It uses existing methods, but with overriding this variable","commit_id":"426f6afb3ce09ae1325d10930eba134e0573f78e"}],"tox.ini":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7eb2590f644edfaaa332d07c8f6698888ed11691","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  OS_TEST_PATH \u003d ./novaclient/tests/functional"},{"line_number":41,"context_line":"commands \u003d python setup.py testr --testr-args\u003d\u0027--concurrency\u003d1 {posargs}\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[testenv:py34-functional]"},{"line_number":44,"context_line":"basepython \u003d python3.4"},{"line_number":45,"context_line":"setenv \u003d"},{"line_number":46,"context_line":"  OS_TEST_PATH \u003d ./novaclient/tests/functional"}],"source_content_type":"text/x-properties","patch_set":3,"id":"da6ed579_6f001302","line":43,"range":{"start_line":43,"start_character":9,"end_line":43,"end_character":24},"updated":"2016-01-13 17:15:59.000000000","message":"I have a slight preference for \"functional-py34\", but I can\u0027t offer a good reason why :)","commit_id":"acba97f0ff1c808e69b744c7061222f776b98fed"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0b748fd2510067bf02a3a7d1683b31448f6719b1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  OS_TEST_PATH \u003d ./novaclient/tests/functional"},{"line_number":41,"context_line":"commands \u003d python setup.py testr --testr-args\u003d\u0027--concurrency\u003d1 {posargs}\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[testenv:py34-functional]"},{"line_number":44,"context_line":"basepython \u003d python3.4"},{"line_number":45,"context_line":"setenv \u003d"},{"line_number":46,"context_line":"  OS_TEST_PATH \u003d ./novaclient/tests/functional"}],"source_content_type":"text/x-properties","patch_set":3,"id":"da6ed579_5cf0f8c8","line":43,"range":{"start_line":43,"start_character":9,"end_line":43,"end_character":24},"in_reply_to":"da6ed579_6f001302","updated":"2016-01-15 13:25:56.000000000","message":"Since job template supports only job suffix(there is no reason to change it), new job will be called gate-novaclient-dsvm-functional-py34 . That is why it would be nice if tox env will be the same:)","commit_id":"acba97f0ff1c808e69b744c7061222f776b98fed"}]}