)]}'
{"tests/test_auth_plugins.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"76396e3c1281d9ccf7c190a2c9a6a07d0e6251b2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                               \"auth_url/v2.0\", auth_system\u003d\"fake\","},{"line_number":96,"context_line":"                               auth_plugin\u003dplugin)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            with mock.patch.object(cs.client.http, \"request\") as mock_request:"},{"line_number":99,"context_line":"                mock_request.side_effect \u003d mock_http_request()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"                cs.client.authenticate()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F144%3D","line":98,"updated":"2013-04-18 16:06:59.000000000","message":"Why not update the original decorator instead of switching to the with syntax?  (In fact, ideally, *all* of the mocks would be decorators on test_auth_system_success(), rather than on inner functions…)","commit_id":"a6f32d658a9bf6b829d01d5fee2f4951e23b8bcd"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"e3a5ef8e96799208a0a54d1035026c5d4ee85c6e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                               \"auth_url/v2.0\", auth_system\u003d\"fake\","},{"line_number":96,"context_line":"                               auth_plugin\u003dplugin)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            with mock.patch.object(cs.client.http, \"request\") as mock_request:"},{"line_number":99,"context_line":"                mock_request.side_effect \u003d mock_http_request()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"                cs.client.authenticate()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F1wU%3D","line":98,"in_reply_to":"AAAAOn%2F%2F11c%3D","updated":"2013-04-18 19:55:41.000000000","message":"Good point. Missed that. Will fix in the next patch set. Thanks for your advice! I\u0027d better read mock documentation once again...","commit_id":"a6f32d658a9bf6b829d01d5fee2f4951e23b8bcd"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"b63e0bc81abc9be56053af6abdba0a0ce9342da8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                               \"auth_url/v2.0\", auth_system\u003d\"fake\","},{"line_number":96,"context_line":"                               auth_plugin\u003dplugin)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            with mock.patch.object(cs.client.http, \"request\") as mock_request:"},{"line_number":99,"context_line":"                mock_request.side_effect \u003d mock_http_request()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"                cs.client.authenticate()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F14o%3D","line":98,"in_reply_to":"AAAAOn%2F%2F144%3D","updated":"2013-04-18 16:17:04.000000000","message":"Kevin, I\u0027d rather keep the original approach that uses decorators, but at that point HTTPClient instance hasn\u0027t been created yet, so I can\u0027t patch its method.","commit_id":"a6f32d658a9bf6b829d01d5fee2f4951e23b8bcd"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"165c3e45357f5bb283a01f54619990d1adcd9277","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                               \"auth_url/v2.0\", auth_system\u003d\"fake\","},{"line_number":96,"context_line":"                               auth_plugin\u003dplugin)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            with mock.patch.object(cs.client.http, \"request\") as mock_request:"},{"line_number":99,"context_line":"                mock_request.side_effect \u003d mock_http_request()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"                cs.client.authenticate()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F11c%3D","line":98,"in_reply_to":"AAAAOn%2F%2F14o%3D","updated":"2013-04-18 17:30:09.000000000","message":"Well, you can patch the class, rather than the specific object; that\u0027s usually what I do, in fact.","commit_id":"a6f32d658a9bf6b829d01d5fee2f4951e23b8bcd"}]}