)]}'
{"id":"openstack%2Fpython-novaclient~27251","triplet_id":"openstack%2Fpython-novaclient~master~If9e6aaf8eb631819bf8e1c915cb1da64d6fcd2f4","project":"openstack/python-novaclient","branch":"master","topic":"bp/instance-action-list-output","hashtags":[],"change_id":"If9e6aaf8eb631819bf8e1c915cb1da64d6fcd2f4","subject":"Fix nova instance-action-list output field and order","status":"MERGED","created":"2013-04-22 07:10:54.000000000","updated":"2013-04-29 15:52:47.000000000","submitted":"2013-04-29 15:52:47.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7a16c9ad7eee6c6dab565e764f1972eb5ea884d3","_number":27251,"virtual_id_number":27251,"owner":{"_account_id":6761,"name":"leo-toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","username":"leo-toyoda"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":2,"date":"2013-04-29 15:52:47.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6761,"name":"leo-toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","username":"leo-toyoda"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":2,"date":"2013-04-22 18:35:47.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"date":"2013-04-22 20:34:48.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-04-22 15:22:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2013-04-23 02:03:28.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6761,"name":"leo-toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","username":"leo-toyoda"},{"value":2,"date":"2013-04-29 11:15:09.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"date":"2013-04-22 18:35:47.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"date":"2013-04-22 20:34:48.000000000","_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-04-29 15:08:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6761,"name":"leo-toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","username":"leo-toyoda"},{"value":0,"date":"2013-04-29 11:15:09.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6761,"name":"leo-toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","username":"leo-toyoda"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":6761,"name":"leo-toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","username":"leo-toyoda"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-04-22 18:35:47.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2013-04-22 20:34:48.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2013-04-29 11:15:09.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-04-29 15:08:14.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-04-29 15:52:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6e6a66cf1475e6900edf95ed65e94bb3e0f7a320","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-22 08:01:36.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27251/1/check/gate-python-novaclient-pep8/1429 : SUCCESS\n- http://docs-draft.openstack.org/27251/1/check/gate-python-novaclient-docs/1120/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/27251/1/check/gate-python-novaclient-python26/1219 : SUCCESS\n- http://logs.openstack.org/27251/1/check/gate-python-novaclient-python26-rhel6/79 : SUCCESS (non-voting)\n- http://logs.openstack.org/27251/1/check/gate-python-novaclient-python27/1438 : SUCCESS\n- http://logs.openstack.org/27251/1/check/gate-tempest-devstack-vm-full/13129 : SUCCESS\n- http://logs.openstack.org/27251/1/check/gate-tempest-devstack-vm-postgres-full/12844 : SUCCESS\n- http://logs.openstack.org/27251/1/check/gate-tempest-devstack-vm-quantum/19030 : SUCCESS\n- http://logs.openstack.org/27251/1/check/gate-grenade-devstack-vm/1025 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"4428902b30ebcecfdbf7bd7b38f2325ccac67efc","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-04-22 15:22:30.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nLGTM, but is there any change you could add a test to verify the behavior?","accounts_in_message":[],"_revision_number":1},{"id":"c39e32d9ca90b6069e8addb5dce307595976f652","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-04-22 18:35:47.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nLGTM pending a possible test.","accounts_in_message":[],"_revision_number":1},{"id":"0932129463efc109539cad06f55ddda2bbffd49c","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2013-04-22 20:34:48.000000000","message":"Patch Set 1:\n\nSome general comments.\n\nI withheld the time originally because it just doesn\u0027t look good.  I see no reason not to display it, but it would also be nice to format it a bit more nicely.\n\nAlso, the output is sorted by the db query in Nova that retrieves the actions.  I see no problem with sorting it in the client, but it is already sorted.","accounts_in_message":[],"_revision_number":1},{"id":"b07d4096d5b9ecb9a3037b46e0b53f3d9cb027c9","author":{"_account_id":6761,"name":"leo-toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","username":"leo-toyoda"},"date":"2013-04-23 02:03:28.000000000","message":"Patch Set 1:\n\nHi Andrew, thanks for your review.\n\nThe output is using print_list in utils.py, and the default value is specified sortby_index\u003d0.\nTherefore it is sorted of \u0027Action\u0027 by the client at present.\nI think that it is necessary to specify the \u0027sortby_index\u0027.","accounts_in_message":[],"_revision_number":1},{"id":"f0a3411fe470bc6ae9d4bc3db25291fb42e80554","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2013-04-23 14:53:19.000000000","message":"Patch Set 1:\n\nleo-toyoda: Thanks for pointing out the default sort behaviour.  I was not aware of that, and think that\u0027s actually a poor design.\n\nBut as others have mentioned, a test for ensuring it\u0027s sorted properly would be good, otherwise it looks good(except for the formatting I wish could be nicer).","accounts_in_message":[],"_revision_number":1},{"id":"0772c6918cdf543b38d39cb12d13996b5f57fc2c","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-04-29 11:15:09.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nDo we really need a test for a change which just tweaks sorting order?","accounts_in_message":[],"_revision_number":1},{"id":"d96a93d0efdbc1e5c4a0b478e882a00238d13dc9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-04-29 15:08:14.000000000","message":"Patch Set 1: Approved\n\nStrictly speaking, no, which is why I hit +2; the ask for a test was just a thought.  Since no one else has -1\u0027d for the test, I\u0027ll go ahead and approve, and if we decide we really must have a test, that can be done as a separate patch :)","accounts_in_message":[],"_revision_number":1},{"id":"ef48afe9a2fdf71ede3aac7b29aac6be31fef1d9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-29 15:08:16.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"76c6614e72124ed9d21763ed1cbe92955f5e41e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-29 15:52:47.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"26bb75d0cb08c83367b17f3de370665839c97de3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-29 15:52:47.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/27251/1/gate/gate-python-novaclient-docs/1141/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/27251/1/gate/gate-python-novaclient-pep8/1450 : SUCCESS\n- http://logs.openstack.org/27251/1/gate/gate-python-novaclient-python26/1240 : SUCCESS\n- http://logs.openstack.org/27251/1/gate/gate-python-novaclient-python27/1459 : SUCCESS\n- http://logs.openstack.org/27251/1/gate/gate-tempest-devstack-vm-full/13896 : SUCCESS\n- http://logs.openstack.org/27251/1/gate/gate-tempest-devstack-vm-postgres-full/13611 : FAILURE (non-voting)\n- http://logs.openstack.org/27251/1/gate/gate-tempest-devstack-vm-quantum/19918 : SUCCESS\n- http://logs.openstack.org/27251/1/gate/gate-grenade-devstack-vm/1734 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e5d2e2c2d4c7fa413517080edad907c757737872","revisions":{"e5d2e2c2d4c7fa413517080edad907c757737872":{"kind":"REWORK","_number":1,"created":"2013-04-22 07:10:54.000000000","uploader":{"_account_id":6761,"name":"leo-toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","username":"leo-toyoda"},"ref":"refs/changes/51/27251/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/51/27251/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/51/27251/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/51/27251/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/51/27251/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/51/27251/1"}}},"commit":{"parents":[{"commit":"dccdd02e4840f27d5476d3fe06967bc2718ec386","subject":"Cleanup unused import","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/dccdd02e4840f27d5476d3fe06967bc2718ec386"}]}],"author":{"name":"Leo Toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","date":"2013-04-22 05:31:02.000000000","tz":540},"committer":{"name":"Leo Toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","date":"2013-04-22 07:10:38.000000000","tz":540},"subject":"Fix nova instance-action-list output field and order","message":"Fix nova instance-action-list output field and order\n\n\u0027instance-action-list\u0027 is not possible to identify the order\nand time of the specified instance actions.\nThis patch fixes the sort of \u0027Start_time\u0027 and add field.\n\nChange-Id: If9e6aaf8eb631819bf8e1c915cb1da64d6fcd2f4\nImplements: blueprint instance-action-list-output\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e5d2e2c2d4c7fa413517080edad907c757737872"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e5d2e2c2d4c7fa413517080edad907c757737872"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}