)]}'
{"id":"openstack%2Fpython-novaclient~27403","triplet_id":"openstack%2Fpython-novaclient~master~I915cd2d8266cb6e32c80691a6ff27d8a23488c98","project":"openstack/python-novaclient","branch":"master","topic":"bug/1172179","hashtags":[],"change_id":"I915cd2d8266cb6e32c80691a6ff27d8a23488c98","subject":"Add \u0027flavor-list --all\u0027 admin switch","status":"MERGED","created":"2013-04-24 08:28:41.000000000","updated":"2013-04-28 04:50:42.000000000","submitted":"2013-04-28 04:50:42.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"16c0aaf9be428f70a459872315ddd13ba13264ad","_number":27403,"virtual_id_number":27403,"owner":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-04-28 04:50:42.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-04-25 23:54:34.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},{"value":2,"date":"2013-04-26 15:19:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":2,"date":"2013-04-28 04:04:24.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-04-25 23:49:25.000000000","_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},{"value":0,"date":"2013-04-26 15:19:17.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":1,"date":"2013-04-28 04:04:24.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-04-25 22:15:30.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-04-26 15:19:17.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-04-28 04:04:24.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-04-28 04:50:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"529c8a0a65372bef284c109ecb4d2e86e90b8699","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-24 09:17:34.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27403/1/check/gate-python-novaclient-pep8/1432 : SUCCESS\n- http://docs-draft.openstack.org/27403/1/check/gate-python-novaclient-docs/1123/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/27403/1/check/gate-python-novaclient-python26/1222 : SUCCESS\n- http://logs.openstack.org/27403/1/check/gate-python-novaclient-python26-rhel6/80 : SUCCESS (non-voting)\n- http://logs.openstack.org/27403/1/check/gate-python-novaclient-python27/1441 : SUCCESS\n- http://logs.openstack.org/27403/1/check/gate-tempest-devstack-vm-full/13420 : SUCCESS\n- http://logs.openstack.org/27403/1/check/gate-tempest-devstack-vm-postgres-full/13135 : FAILURE (non-voting)\n- http://logs.openstack.org/27403/1/check/gate-tempest-devstack-vm-quantum/19369 : SUCCESS\n- http://logs.openstack.org/27403/1/check/gate-grenade-devstack-vm/1298 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"929a53c0f750b846727dc7df2f130e968db84c2b","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-04-24 15:05:45.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nI have one problem with test_flavors.py, marked inline; also, I don\u0027t see a test on the shell argument, and I would like to see that.  Otherwise, this looks pretty good to me, except I\u0027m bothered a bit on an aesthetic level by \"?is_public\u003dNone\"; but if that\u0027s what nova expects…","accounts_in_message":[],"_revision_number":1},{"id":"59cfe0f513ed61e4484244ce364c9c7a9eaaad6a","author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"date":"2013-04-25 23:49:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bfacc1edd7b65c0a034a2057bf54a0435ed1a1f2","author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"date":"2013-04-25 23:54:34.000000000","message":"Patch Set 2:\n\nThe API is a bit awkward. It does accept lowercased values, so it would be possible to make it \"is_public\u003dnone\"?","accounts_in_message":[],"_revision_number":2},{"id":"23171fcff3fe4bd80d8737a82a100619e559924b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-26 00:35:22.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27403/2/check/gate-python-novaclient-pep8/1437 : SUCCESS\n- http://docs-draft.openstack.org/27403/2/check/gate-python-novaclient-docs/1128/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/27403/2/check/gate-python-novaclient-python26/1227 : SUCCESS\n- http://logs.openstack.org/27403/2/check/gate-python-novaclient-python26-rhel6/85 : SUCCESS (non-voting)\n- http://logs.openstack.org/27403/2/check/gate-python-novaclient-python27/1446 : SUCCESS\n- http://logs.openstack.org/27403/2/check/gate-tempest-devstack-vm-full/13643 : SUCCESS\n- http://logs.openstack.org/27403/2/check/gate-tempest-devstack-vm-postgres-full/13358 : FAILURE (non-voting)\n- http://logs.openstack.org/27403/2/check/gate-tempest-devstack-vm-quantum/19606 : SUCCESS\n- http://logs.openstack.org/27403/2/check/gate-grenade-devstack-vm/1500 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"c5d401cf5e036d6ade244ef82899fbbeeba9a6f3","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-04-26 15:19:17.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nThanks for the updates :)  As for the \"is_public\u003dnone\" vs. \"is_public\u003dNone\" issue: six of one, half-dozen of the other; I vote for leaving it as-is.  What I would really prefer would be a change on the nova API, but I doubt something like that will go through in v2, so don\u0027t worry about it for now.","accounts_in_message":[],"_revision_number":2},{"id":"ffc88d05feb280665b2cf819182d5c450b25573f","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-04-28 04:04:24.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"d1f238eecc35cb8086380b5dbeccb300da06a4b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-28 04:04:26.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"9f63547d83dac8faf57c8bbf594d8ed591ee3d5a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-28 04:50:42.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/27403/2/gate/gate-python-novaclient-docs/1130/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/27403/2/gate/gate-python-novaclient-pep8/1439 : SUCCESS\n- http://logs.openstack.org/27403/2/gate/gate-python-novaclient-python26/1229 : SUCCESS\n- http://logs.openstack.org/27403/2/gate/gate-python-novaclient-python27/1448 : SUCCESS\n- http://logs.openstack.org/27403/2/gate/gate-tempest-devstack-vm-full/13817 : SUCCESS\n- http://logs.openstack.org/27403/2/gate/gate-tempest-devstack-vm-postgres-full/13532 : FAILURE (non-voting)\n- http://logs.openstack.org/27403/2/gate/gate-tempest-devstack-vm-quantum/19801 : SUCCESS\n- http://logs.openstack.org/27403/2/gate/gate-grenade-devstack-vm/1660 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"2494e06a00c03ae5c8536eb13bc2497054f5a70f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-28 04:50:42.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"50fe79b47d566bb0d15c9517b7b64d758688d853","revisions":{"efc4e9f12d57060f202f49d6d4c31ad9e4ec567a":{"kind":"REWORK","_number":1,"created":"2013-04-24 08:28:41.000000000","uploader":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"ref":"refs/changes/03/27403/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/03/27403/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/03/27403/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/03/27403/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/03/27403/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/03/27403/1"}}},"commit":{"parents":[{"commit":"b9f27f6d94b22e488a5763bad5f0000417878232","subject":"Merge \"Make list flavor show extra specs optional.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b9f27f6d94b22e488a5763bad5f0000417878232"}]}],"author":{"name":"Kieran Spear","email":"kispear@gmail.com","date":"2013-04-24 07:55:48.000000000","tz":600},"committer":{"name":"Kieran Spear","email":"kispear@gmail.com","date":"2013-04-24 08:28:24.000000000","tz":600},"subject":"Add \u0027flavor-list --all\u0027 admin switch","message":"Add \u0027flavor-list --all\u0027 admin switch\n\nNova gives admins public flavors and flavors from their own projects\nonly by default. For flavor management, admins need to see all flavors\nregardless of access.\n\nChanges:\n- Adds an \u0027is_public\u0027 argument to flavors.list() that mirrors the\n  Nova API. is_public\u003dNone can be used to see all flavors.\n- Adds an --all switch to flavor-list in the CLI for use by admins\n  when all flavors are wanted.\n\nFixes bug 1172179.\n\nChange-Id: I915cd2d8266cb6e32c80691a6ff27d8a23488c98\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/efc4e9f12d57060f202f49d6d4c31ad9e4ec567a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/efc4e9f12d57060f202f49d6d4c31ad9e4ec567a"}]},"branch":"refs/heads/master"},"50fe79b47d566bb0d15c9517b7b64d758688d853":{"kind":"REWORK","_number":2,"created":"2013-04-25 23:49:25.000000000","uploader":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"ref":"refs/changes/03/27403/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/03/27403/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/03/27403/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/03/27403/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/03/27403/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/03/27403/2"}}},"commit":{"parents":[{"commit":"b9f27f6d94b22e488a5763bad5f0000417878232","subject":"Merge \"Make list flavor show extra specs optional.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b9f27f6d94b22e488a5763bad5f0000417878232"}]}],"author":{"name":"Kieran Spear","email":"kispear@gmail.com","date":"2013-04-24 07:55:48.000000000","tz":600},"committer":{"name":"Kieran Spear","email":"kispear@gmail.com","date":"2013-04-25 23:49:29.000000000","tz":600},"subject":"Add \u0027flavor-list --all\u0027 admin switch","message":"Add \u0027flavor-list --all\u0027 admin switch\n\nNova gives admins public flavors and flavors from their own projects\nonly by default. For flavor management, admins need to see all flavors\nregardless of access.\n\nChanges:\n- Adds an \u0027is_public\u0027 argument to flavors.list() that mirrors the\n  Nova API. is_public\u003dNone can be used to see all flavors.\n- Adds an --all switch to flavor-list in the CLI for use by admins\n  when all flavors are wanted.\n\nFixes bug 1172179.\n\nChange-Id: I915cd2d8266cb6e32c80691a6ff27d8a23488c98\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/50fe79b47d566bb0d15c9517b7b64d758688d853"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/50fe79b47d566bb0d15c9517b7b64d758688d853"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}