)]}'
{"id":"openstack%2Fpython-novaclient~274410","triplet_id":"openstack%2Fpython-novaclient~master~I73af5d1be39769f70cbe4c1ec83144d56f94f91a","project":"openstack/python-novaclient","branch":"master","hashtags":[],"change_id":"I73af5d1be39769f70cbe4c1ec83144d56f94f91a","subject":"Remove unnecessary filter from Resource\u0027s __repr__() function","status":"MERGED","created":"2016-01-31 07:43:47.000000000","updated":"2016-02-03 23:12:45.000000000","submitted":"2016-02-03 23:12:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"178784a10ff6e0c3665c8879556f11caf20ea33b","_number":274410,"virtual_id_number":274410,"owner":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2016-02-03 23:12:45.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"all":[{"value":1,"date":"2016-02-03 02:14:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-02-02 16:25:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2016-02-03 13:55:49.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":2,"date":"2016-02-03 21:36:13.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":1,"date":"2016-02-03 21:36:13.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-31 10:38:21.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2016-02-02 16:25:11.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-02-03 02:14:32.000000000","updated_by":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"reviewer":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"state":"REVIEWER"},{"updated":"2016-02-03 13:55:49.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2016-02-03 21:36:13.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2016-02-03 23:12:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2182b4d6869d13b613438a882960a52b79b3b04d","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-01-31 07:43:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3a33c8650297147dd139248724dfc983028f5768","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-31 08:40:13.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/10/274410/1/check/gate-python-novaclient-pep8/7cfdd70/ : SUCCESS in 1m 16s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/10/274410/1/check/gate-python-novaclient-docs/67ef13a//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-novaclient-python27 http://logs.openstack.org/10/274410/1/check/gate-python-novaclient-python27/979f542/ : SUCCESS in 2m 08s\n- gate-python-novaclient-python34 http://logs.openstack.org/10/274410/1/check/gate-python-novaclient-python34/da104dc/ : SUCCESS in 2m 17s\n- gate-python-novaclient-pypy http://logs.openstack.org/10/274410/1/check/gate-python-novaclient-pypy/167dbdd/ : SUCCESS in 2m 33s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/10/274410/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/6effed2/ : SUCCESS in 56m 18s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/10/274410/1/check/gate-novaclient-dsvm-functional/ea08517/ : FAILURE in 32m 35s","accounts_in_message":[],"_revision_number":1},{"id":"cec7f346fb9036257360ce4842c6a3e0bdb4675a","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-02-01 16:36:16.000000000","message":"Patch Set 1:\n\nI don\u0027t understand your commit message.  I can\u0027t see a single instance of request_id being defined as a function—even a property.","accounts_in_message":[],"_revision_number":1},{"id":"08a5793b8869616d5345dd49fb4f5b307931e64a","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-02-02 01:39:35.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"34d4b0d90f85f2b421b7a1e1bc2cd45a48d67ea7","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-02-02 01:53:03.000000000","message":"Patch Set 2:\n\n\u003e I don\u0027t understand your commit message.  I can\u0027t see a single\n \u003e instance of request_id being defined as a function—even a property.\n\nHi, Kevin L. Mitchell\nThank you for your review.\nAnd sorry for my mistake to leave wrong info in commit message.\nIt\u0027s \u0027request_ids\u0027 not \u0027request_id\u0027.\nI mean this function:\n##############################################\n    @property\n    def request_ids(self):\n        return self.x_openstack_request_ids\n##############################################\nAnd Resource().__dict__.keys() doesn\u0027t contains it, just like this:\n\n\u003e\u003e\u003e class Test(object):\n...     def __init__(self):\n...         self.x_openstack_request_ids \u003d \u0027id\u0027\n...     @property\n...     def request_ids(self):\n...         return self.x_openstack_request_ids\n... \n\u003e\u003e\u003e Test().__dict__.keys()\n[\u0027x_openstack_request_ids\u0027]\n\nThanks.","accounts_in_message":[],"_revision_number":2},{"id":"b0f2dbe1941b1aafdd76889fd50a1a9413344792","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-02 02:38:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/10/274410/2/check/gate-python-novaclient-pep8/85c37a5/ : SUCCESS in 1m 10s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/10/274410/2/check/gate-python-novaclient-docs/d8ebb85//doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-novaclient-python27 http://logs.openstack.org/10/274410/2/check/gate-python-novaclient-python27/bc8194c/ : SUCCESS in 1m 41s\n- gate-python-novaclient-python34 http://logs.openstack.org/10/274410/2/check/gate-python-novaclient-python34/3f7f774/ : SUCCESS in 2m 16s\n- gate-python-novaclient-pypy http://logs.openstack.org/10/274410/2/check/gate-python-novaclient-pypy/91d819a/ : SUCCESS in 2m 31s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/10/274410/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/0f9aaa4/ : SUCCESS in 58m 07s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/10/274410/2/check/gate-novaclient-dsvm-functional/0c4537f/ : SUCCESS in 35m 14s","accounts_in_message":[],"_revision_number":2},{"id":"a8e503ba5b6094f010f25aee4dbd57910519b656","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-02-02 16:25:11.000000000","message":"Patch Set 2: Code-Review+2\n\nOK, that makes sense…","accounts_in_message":[],"_revision_number":2},{"id":"b8f4ecf24c1bac3e17b417cabb7ca2bb138b44d7","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2016-02-03 02:14:32.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM, thanks Cao.","accounts_in_message":[],"_revision_number":2},{"id":"19d53ccc5542ea64297c797effa8c6eb2a6e09b5","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-02-03 13:55:49.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ad0e4f7286b2af67253b8bbfe36fb540eab2367f","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-02-03 21:36:13.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"0d81ca28912fa71c2cd4338093588d3a6327ffe1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-03 21:36:25.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"74e98a336b61395d894aea1e41dd441c17658ebf","date":"2016-02-03 23:12:45.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"178784a10ff6e0c3665c8879556f11caf20ea33b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-03 23:12:45.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/10/274410/2/gate/gate-python-novaclient-docs/32fd5cd//doc/build/html/ : SUCCESS in 1m 29s\n- gate-python-novaclient-pep8 http://logs.openstack.org/10/274410/2/gate/gate-python-novaclient-pep8/25b59b4/ : SUCCESS in 1m 09s\n- gate-python-novaclient-python27 http://logs.openstack.org/10/274410/2/gate/gate-python-novaclient-python27/3012b86/ : SUCCESS in 1m 48s\n- gate-python-novaclient-python34 http://logs.openstack.org/10/274410/2/gate/gate-python-novaclient-python34/f7b004d/ : SUCCESS in 1m 57s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/10/274410/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient/8382c26/ : SUCCESS in 1h 31m 39s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/10/274410/2/gate/gate-novaclient-dsvm-functional/62443b1/ : SUCCESS in 33m 25s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2131f777eb8b7cc3b1bd96cbd717cad5a307cd68","revisions":{"0da972161c2bf00e5978394255cbdee9a1b62fef":{"kind":"REWORK","_number":1,"created":"2016-01-31 07:43:47.000000000","uploader":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"ref":"refs/changes/10/274410/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/10/274410/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/274410/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/274410/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/274410/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/10/274410/1"}}},"commit":{"parents":[{"commit":"209f17224224e000a7e2c1ed3e698d7f7cb36864","subject":"Add return-request-id-to-caller function(5/5)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/209f17224224e000a7e2c1ed3e698d7f7cb36864"}]}],"author":{"name":"Cao Shufeng","email":"caosf.fnst@cn.fujitsu.com","date":"2016-02-01 07:25:45.000000000","tz":480},"committer":{"name":"Cao Shufeng","email":"caosf.fnst@cn.fujitsu.com","date":"2016-02-01 07:40:09.000000000","tz":480},"subject":"Remove unnecessary filter from Resource\u0027s __repr__","message":"Remove unnecessary filter from Resource\u0027s __repr__\n\n\u0027request_id\u0027 is a function, Resource().__dict__.keys() doesn\u0027t\ncontains it.\n\nChange-Id: I73af5d1be39769f70cbe4c1ec83144d56f94f91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0da972161c2bf00e5978394255cbdee9a1b62fef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0da972161c2bf00e5978394255cbdee9a1b62fef"}]},"branch":"refs/heads/master"},"2131f777eb8b7cc3b1bd96cbd717cad5a307cd68":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-02-02 01:39:35.000000000","uploader":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"ref":"refs/changes/10/274410/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/10/274410/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/274410/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/274410/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/274410/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/10/274410/2"}}},"commit":{"parents":[{"commit":"209f17224224e000a7e2c1ed3e698d7f7cb36864","subject":"Add return-request-id-to-caller function(5/5)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/209f17224224e000a7e2c1ed3e698d7f7cb36864"}]}],"author":{"name":"Cao Shufeng","email":"caosf.fnst@cn.fujitsu.com","date":"2016-02-01 07:25:45.000000000","tz":480},"committer":{"name":"Cao Shufeng","email":"caosf.fnst@cn.fujitsu.com","date":"2016-02-03 01:29:58.000000000","tz":480},"subject":"Remove unnecessary filter from Resource\u0027s __repr__() function","message":"Remove unnecessary filter from Resource\u0027s __repr__() function\n\n\u0027request_ids\u0027 is a function of class RequestIdMixin.\nResource().__dict__.keys() doesn\u0027t contains a function. So it not\nnecessary to filter it.\n\nChange-Id: I73af5d1be39769f70cbe4c1ec83144d56f94f91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2131f777eb8b7cc3b1bd96cbd717cad5a307cd68"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2131f777eb8b7cc3b1bd96cbd717cad5a307cd68"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}