)]}'
{"novaclient/v1_1/shell.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a5a6339dfc3e6e369313f418cc9ceb9aca1583aa","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            image \u003d _find_image(cs, image)"},{"line_number":841,"context_line":"            image.delete()"},{"line_number":842,"context_line":"        except Exception as e:"},{"line_number":843,"context_line":"            print e"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"@utils.arg(\u0027--reservation-id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FsTU%3D","line":843,"updated":"2013-04-28 03:24:26.000000000","message":"I think we could do something nicer here, perhaps a message like:\n\n\"Image delete failed: %s\" % e","commit_id":"71cc35ed275e4f8a98dea6e81c5af61d4c367473"},{"author":{"_account_id":4340,"name":"Sulochan Acharya","email":"sulochan@gmail.com","username":"sulochan-acharya"},"change_message_id":"c439fb7d64362aa833f201546e6032ec23d82cbf","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            image \u003d _find_image(cs, image)"},{"line_number":841,"context_line":"            image.delete()"},{"line_number":842,"context_line":"        except Exception as e:"},{"line_number":843,"context_line":"            print e"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"@utils.arg(\u0027--reservation-id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FsF8%3D","line":843,"in_reply_to":"AAAAOn%2F%2FsTU%3D","updated":"2013-04-28 19:39:02.000000000","message":"Ok, sounds good, i\u0027ll make this change, thx.","commit_id":"71cc35ed275e4f8a98dea6e81c5af61d4c367473"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"4acf432939cd60ad63658e0a413e769dbf462f16","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            image \u003d _find_image(cs, image)"},{"line_number":841,"context_line":"            image.delete()"},{"line_number":842,"context_line":"        except Exception as e:"},{"line_number":843,"context_line":"            print \"Image delete failed: %s\" % e"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"@utils.arg(\u0027--reservation-id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FrSs%3D","line":843,"updated":"2013-04-29 15:16:54.000000000","message":"As a refinement, let me suggest adding the image ID here, so the user knows which image delete failed…","commit_id":"05bd2a367f0340aaff6f601843e508d096e710e1"},{"author":{"_account_id":4340,"name":"Sulochan Acharya","email":"sulochan@gmail.com","username":"sulochan-acharya"},"change_message_id":"21cc838cc67bbfba3e770fd42f32973f81dcc858","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            image \u003d _find_image(cs, image)"},{"line_number":841,"context_line":"            image.delete()"},{"line_number":842,"context_line":"        except Exception as e:"},{"line_number":843,"context_line":"            print \"Image delete failed: %s\" % e"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"@utils.arg(\u0027--reservation-id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FrN8%3D","line":843,"in_reply_to":"AAAAOn%2F%2FrSs%3D","updated":"2013-04-29 16:06:12.000000000","message":"We can do something like:\ntry:\n    _find_image(cs, image).delete()\nexcept Exception as e:\n    print \"Delete for image %s failed: %s\" % (image, e)\n\nit will have a slightly longer msg for some cases but i think this will be better ?\nI\u0027ll make the change and submit again. Thanks for the suggestion.","commit_id":"05bd2a367f0340aaff6f601843e508d096e710e1"}]}