)]}'
{"id":"openstack%2Fpython-novaclient~278384","triplet_id":"openstack%2Fpython-novaclient~master~Ia6e608aac41d2f2d59b9504d21647e4f88af3335","project":"openstack/python-novaclient","branch":"master","topic":"microversions","hashtags":[],"change_id":"Ia6e608aac41d2f2d59b9504d21647e4f88af3335","subject":"[microversions] Skip microversion 2.18","status":"MERGED","created":"2016-02-10 14:08:51.000000000","updated":"2016-02-11 01:33:19.000000000","submitted":"2016-02-11 01:33:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fdbe06cd6a6573a0c15dc926c65ac15484d3aed4","_number":278384,"virtual_id_number":278384,"owner":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":2,"date":"2016-02-11 01:33:19.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"all":[{"value":2,"date":"2016-02-10 19:16:53.000000000","_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-02-10 19:38:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-02-10 19:38:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-10 14:09:54.000000000","updated_by":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"reviewer":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"state":"REVIEWER"},{"updated":"2016-02-10 19:16:53.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2016-02-10 19:38:31.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-02-11 01:33:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3bff2a4e5347f9a928a051126f466d3f10b9715f","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-02-10 14:08:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9eade7c2e81d894da467926b36002eeabb8ea7f7","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2016-02-10 14:09:54.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"1db046426983ae49e70773b5db9f75d6f18ad0e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-10 15:47:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/84/278384/1/check/gate-python-novaclient-pep8/7fdaacb/ : SUCCESS in 43s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/84/278384/1/check/gate-python-novaclient-docs/a92a0c9//doc/build/html/ : SUCCESS in 51s\n- gate-python-novaclient-python27 http://logs.openstack.org/84/278384/1/check/gate-python-novaclient-python27/ac529b9/ : SUCCESS in 1m 31s\n- gate-python-novaclient-python34 http://logs.openstack.org/84/278384/1/check/gate-python-novaclient-python34/23650e3/ : SUCCESS in 2m 01s\n- gate-python-novaclient-pypy http://logs.openstack.org/84/278384/1/check/gate-python-novaclient-pypy/88f666b/ : SUCCESS in 2m 09s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/84/278384/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/db1a166/ : SUCCESS in 46m 56s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/84/278384/1/check/gate-novaclient-dsvm-functional/89d2551/ : SUCCESS in 28m 21s","accounts_in_message":[],"_revision_number":1},{"id":"d83ed4ef4203b6ca5845ad7c091c4a3a15c3d80e","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-02-10 16:22:18.000000000","message":"Patch Set 1:\n\nI don\u0027t understand this change.  If we don\u0027t make the required changes in HttpClient and SessionClient, how can we advertise support for this or later microversions?  Conversely, if we\u0027re able to advertise support for later microversions, why do we need to do anything at all to HttpClient and SessionClient to support this microversion?\n\nFor that matter, what *are* the required changes?","accounts_in_message":[],"_revision_number":1},{"id":"68a3d4d46cb9be0d2a11be22e558b4b2fb776875","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-02-10 16:50:51.000000000","message":"Patch Set 1:\n\n@Kevin:\n1) The change on Nova-API side adds only check for existence of \"project_id\" at the url. It doesn\u0027t check microversion, so all latest microversions can work with or without project_id. Proof: all functional tests are succeed(several of them use latest microversion).\n\n2) In case of HttpClient, we need to cut down \"project_id\" here - https://github.com/openstack/python-novaclient/blob/3.2.0/novaclient/client.py#L414-L416 . SessionClient requires deeper change.\n\nThe main problem of required change to HttpClient and SessionClient:\n\n1) we need to split nova\u0027s related requests and others(authentication, volume...), which are still requires project_id at the url.\n\n2) lack of time - there is only one week before final release, so I just want to add support of most microversions at first and, then, come back to 2.18","accounts_in_message":[],"_revision_number":1},{"id":"b4ff0599d2a70a0ccd111804f795e1abeba8b5e9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-02-10 17:49:38.000000000","message":"Patch Set 1: Code-Review+2\n\nOK, makes better sense to me.  As a femtonit: that explanation could be in the commit message.","accounts_in_message":[],"_revision_number":1},{"id":"7c194bf9ec51b7ece78d7b348646d1e7f1977ea6","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-02-10 19:04:18.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"df67b5270d474ad1158b7ddbc353bf76d9f57b55","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2016-02-10 19:16:53.000000000","message":"Patch Set 2: Code-Review+2\n\nThis is fair to skip. A user of novaclient should never request 2.18 since there is no visible change to their usage of the API.","accounts_in_message":[],"_revision_number":2},{"id":"43125aeab6c6d713ebb24c67c94f46f772121fed","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-02-10 19:38:31.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"b6242720f7ed7336103818c66c15c8f49202223a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-10 23:53:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/84/278384/2/check/gate-python-novaclient-pep8/403d152/ : SUCCESS in 34s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/84/278384/2/check/gate-python-novaclient-docs/62bb6d9//doc/build/html/ : SUCCESS in 46s\n- gate-python-novaclient-python27 http://logs.openstack.org/84/278384/2/check/gate-python-novaclient-python27/5cd9219/ : SUCCESS in 1m 30s\n- gate-python-novaclient-python34 http://logs.openstack.org/84/278384/2/check/gate-python-novaclient-python34/685890b/ : SUCCESS in 2m 16s\n- gate-python-novaclient-pypy http://logs.openstack.org/84/278384/2/check/gate-python-novaclient-pypy/72b78d5/ : SUCCESS in 2m 18s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/84/278384/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/ca2f900/ : SUCCESS in 1h 02m 04s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/84/278384/2/check/gate-novaclient-dsvm-functional/ed1accf/ : SUCCESS in 33m 33s","accounts_in_message":[],"_revision_number":2},{"id":"118eb0ed725c099a1a77100aec43560f88396092","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-10 23:53:56.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"43afd9a58b4651440a276194b8fdace1df5f68c4","date":"2016-02-11 01:33:19.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"27275618f9f06e0aad9bd153d6de2239523720da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-11 01:33:19.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/84/278384/2/gate/gate-python-novaclient-docs/29fc0aa//doc/build/html/ : SUCCESS in 35s\n- gate-python-novaclient-pep8 http://logs.openstack.org/84/278384/2/gate/gate-python-novaclient-pep8/1f5a270/ : SUCCESS in 31s\n- gate-python-novaclient-python27 http://logs.openstack.org/84/278384/2/gate/gate-python-novaclient-python27/538638c/ : SUCCESS in 1m 16s\n- gate-python-novaclient-python34 http://logs.openstack.org/84/278384/2/gate/gate-python-novaclient-python34/ecd4579/ : SUCCESS in 1m 43s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/84/278384/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient/70f8a9d/ : SUCCESS in 48m 15s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/84/278384/2/gate/gate-novaclient-dsvm-functional/6f47f47/ : SUCCESS in 26m 47s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ecaca2279e1779c0c9f68c98e08d6ff2c9bb1bdb","revisions":{"61a7eb62d4184a41a8ca9dd7b908da4338408468":{"kind":"REWORK","_number":1,"created":"2016-02-10 14:08:51.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/84/278384/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/84/278384/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/278384/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/278384/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/278384/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/84/278384/1"}}},"commit":{"parents":[{"commit":"3da2728ce61aea60a6e8b4a50f10ba861d8e6673","subject":"Merge \"Make _poll_for_status more user-friendly\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3da2728ce61aea60a6e8b4a50f10ba861d8e6673"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2016-02-10 11:49:53.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2016-02-10 11:49:53.000000000","tz":120},"subject":"[microversions] Skip 2.18 microversion","message":"[microversions] Skip 2.18 microversion\n\nThis microversion requires changes in core logic of HttpClient and\nSessionClient. Let\u0027s skip this complex change for now to unblock\nimplementation of further microversions.\n\nChange-Id: Ia6e608aac41d2f2d59b9504d21647e4f88af3335\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/61a7eb62d4184a41a8ca9dd7b908da4338408468"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/61a7eb62d4184a41a8ca9dd7b908da4338408468"}]},"branch":"refs/heads/master"},"ecaca2279e1779c0c9f68c98e08d6ff2c9bb1bdb":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-02-10 19:04:18.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/84/278384/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/84/278384/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/278384/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/278384/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/278384/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/84/278384/2"}}},"commit":{"parents":[{"commit":"3da2728ce61aea60a6e8b4a50f10ba861d8e6673","subject":"Merge \"Make _poll_for_status more user-friendly\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3da2728ce61aea60a6e8b4a50f10ba861d8e6673"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2016-02-10 11:49:53.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2016-02-10 19:04:08.000000000","tz":0},"subject":"[microversions] Skip microversion 2.18","message":"[microversions] Skip microversion 2.18\n\n2.18 - Establishes a set of routes that makes project_id an optional\n       construct in v2.1.\n\nThe change on Nova-API side adds only check for existence of\n\"project_id\" at the url. It doesn\u0027t check microversion, so all latest\nand previous microversions can work with or without project_id.\nProof: all functional tests are succeed on this change (several of them\n       use latest microversion).\n\nTo cut down \"project_id\" from the url at the novaclient side, we need to\nmodify ``novaclient.client.HttpClient`` and\n``novaclient.client.SessionClient``. This change requires splitting\nNova\u0027s related requests and the others(authentication, volume...), which\nare still require \"project_id\" at the url.\n\nIt is a complex task, which can be skipped for now to unblock\nimplementation of further microversions.\n\nChange-Id: Ia6e608aac41d2f2d59b9504d21647e4f88af3335\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ecaca2279e1779c0c9f68c98e08d6ff2c9bb1bdb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ecaca2279e1779c0c9f68c98e08d6ff2c9bb1bdb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}