)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"7acbace4eec697dcb23bfdecb159d444ef1263ac","unresolved":false,"context_lines":[{"line_number":12,"context_line":"provide a way to not discover extension via python path an entry-point."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I030f4c55c2795c7f7973f5f12e54b9819c4a5578"},{"line_number":15,"context_line":"Closes-Bug: #1509500"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dae33548_e3557c50","line":15,"updated":"2016-02-16 19:06:14.000000000","message":"Shouldn\u0027t this be PartialBug, since changes are still needed for neutron, etc. to use this?","commit_id":"fea873e88f466540ae3b4e25856253ec6b291258"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6c8b646402a0bfbc5ae0560ce1bde5b10fc07a63","unresolved":false,"context_lines":[{"line_number":12,"context_line":"provide a way to not discover extension via python path an entry-point."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I030f4c55c2795c7f7973f5f12e54b9819c4a5578"},{"line_number":15,"context_line":"Closes-Bug: #1509500"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dae33548_d16754b5","line":15,"in_reply_to":"dae33548_e3557c50","updated":"2016-02-17 01:44:25.000000000","message":"No, this closes-bug will close a bug only for novaclient project, neutron\u0027s bug-report will be not changed.","commit_id":"fea873e88f466540ae3b4e25856253ec6b291258"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7f257362976e0e192d71cfa3aaaf2098eca41545","unresolved":false,"context_lines":[{"line_number":12,"context_line":"provide a way to not discover extension via python path an entry-point."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I030f4c55c2795c7f7973f5f12e54b9819c4a5578"},{"line_number":15,"context_line":"Closes-Bug: #1509500"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_57cb5553","line":15,"updated":"2016-02-27 00:43:37.000000000","message":"I think we can add\n\n Closes-Bug: #1524831\n\nWhat do you think?","commit_id":"c18ccb1bfae574b4b496c138e9192fc737ed9c20"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a86c3b72d703ce9e8b9dc249fba8cb65eadee987","unresolved":false,"context_lines":[{"line_number":12,"context_line":"provide a way to not discover extension via python path an entry-point."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I030f4c55c2795c7f7973f5f12e54b9819c4a5578"},{"line_number":15,"context_line":"Closes-Bug: #1509500"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_8b01da08","line":15,"in_reply_to":"9aed3d3a_1ca72850","updated":"2016-02-29 23:59:09.000000000","message":"Okay, thanks","commit_id":"c18ccb1bfae574b4b496c138e9192fc737ed9c20"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"80de2755af9baecb9def2beeceafda623bd1ce40","unresolved":false,"context_lines":[{"line_number":12,"context_line":"provide a way to not discover extension via python path an entry-point."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I030f4c55c2795c7f7973f5f12e54b9819c4a5578"},{"line_number":15,"context_line":"Closes-Bug: #1509500"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_1ca72850","line":15,"in_reply_to":"9aed3d3a_57cb5553","updated":"2016-02-27 09:44:21.000000000","message":"No, we can\u0027t do it. All places of initialization novaclient looks the similar:\n\n   def nova(*some_args):\n       from novaclient import client\n   \n       extensions \u003d [ext for ext in client.discove_extensions() \n                     if ext.name in ()]\n       return client.Client(extensions\u003dextensions, *some_args)\n\nMethod nova is called each time when some service needs novaclient, so discover_extensions is called each time too. I agreed that this patch will reduce the time of discovery, but we need to provide the better solution - cache mechanism. Also, to speed up the process of bug-fix before release, heat can cache extensions by itself.\n\nI\u0027ll contact the assignee of novaclient\u0027s bug and we will try to fix the bug on novaclient\u0027s side before release, but it will be done in the separate patch:)","commit_id":"c18ccb1bfae574b4b496c138e9192fc737ed9c20"}],"novaclient/tests/unit/test_client.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"78afcdd67762681e456acab3bb3cc45a34a1d161","unresolved":false,"context_lines":[{"line_number":497,"context_line":"                                   mock_discover_via_contrib_path,"},{"line_number":498,"context_line":"                                   mock_discover_via_entry_points):"},{"line_number":499,"context_line":"        mock_discover_via_contrib_path.return_value \u003d [(\"name\", \"module\")]"},{"line_number":500,"context_line":"        # these methods should not be called"},{"line_number":501,"context_line":"        mock_discover_via_python_path.side_effect \u003d Exception"},{"line_number":502,"context_line":"        mock_discover_via_entry_points.side_effect \u003d Exception"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        version \u003d novaclient.api_versions.APIVersion(\"2.0\")"},{"line_number":505,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_71ac89a0","line":502,"range":{"start_line":500,"start_character":8,"end_line":502,"end_character":62},"updated":"2016-02-17 01:20:27.000000000","message":"Wouldn\u0027t it be better to self.assertFalse(mock_discover_via_*.called) at the end instead of this?","commit_id":"fea873e88f466540ae3b4e25856253ec6b291258"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6c8b646402a0bfbc5ae0560ce1bde5b10fc07a63","unresolved":false,"context_lines":[{"line_number":497,"context_line":"                                   mock_discover_via_contrib_path,"},{"line_number":498,"context_line":"                                   mock_discover_via_entry_points):"},{"line_number":499,"context_line":"        mock_discover_via_contrib_path.return_value \u003d [(\"name\", \"module\")]"},{"line_number":500,"context_line":"        # these methods should not be called"},{"line_number":501,"context_line":"        mock_discover_via_python_path.side_effect \u003d Exception"},{"line_number":502,"context_line":"        mock_discover_via_entry_points.side_effect \u003d Exception"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        version \u003d novaclient.api_versions.APIVersion(\"2.0\")"},{"line_number":505,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_5112240a","line":502,"range":{"start_line":500,"start_character":8,"end_line":502,"end_character":62},"in_reply_to":"dae33548_71ac89a0","updated":"2016-02-17 01:44:25.000000000","message":"will fix tomorrow.","commit_id":"fea873e88f466540ae3b4e25856253ec6b291258"}]}
