)]}'
{"id":"openstack%2Fpython-novaclient~283454","triplet_id":"openstack%2Fpython-novaclient~master~I55e9161a4df9197546603385228ea85528de43a7","project":"openstack/python-novaclient","branch":"master","topic":"bug/1510006","hashtags":[],"change_id":"I55e9161a4df9197546603385228ea85528de43a7","subject":"Use assertIsNone instead of assertEqual(None, ***)","status":"MERGED","created":"2016-02-23 08:59:25.000000000","updated":"2016-02-24 23:02:40.000000000","submitted":"2016-02-24 23:02:40.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f167b67f036627d066206affdce3b305f57818e9","_number":283454,"virtual_id_number":283454,"owner":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-02-24 23:02:40.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-02-23 11:19:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":2,"date":"2016-02-23 21:22:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"value":2,"date":"2016-02-24 22:06:25.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"value":1,"date":"2016-02-24 22:06:25.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-23 09:11:03.000000000","updated_by":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"reviewer":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"state":"REVIEWER"},{"updated":"2016-02-23 11:19:31.000000000","updated_by":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"reviewer":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"state":"REVIEWER"},{"updated":"2016-02-23 21:22:05.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-02-24 22:06:25.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2016-02-24 23:02:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f44524a35841b09906bec145501d7557f49f4441","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2016-02-23 08:59:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f915a6fe11fd73df78d79c8e4e3ab250132440ef","author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"date":"2016-02-23 09:11:03.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks good to me, thanks! ;)","accounts_in_message":[],"_revision_number":1},{"id":"27dd29eaca6c56fa8092182e3c25573937ae1ebd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-23 09:52:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/54/283454/1/check/gate-python-novaclient-pep8/cd780bb/ : SUCCESS in 1m 23s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/54/283454/1/check/gate-python-novaclient-docs/6e7602b//doc/build/html/ : SUCCESS in 57s\n- gate-python-novaclient-python27 http://logs.openstack.org/54/283454/1/check/gate-python-novaclient-python27/2c6c3fd/ : SUCCESS in 1m 28s\n- gate-python-novaclient-python34 http://logs.openstack.org/54/283454/1/check/gate-python-novaclient-python34/5dd1294/ : SUCCESS in 2m 34s\n- gate-python-novaclient-pypy http://logs.openstack.org/54/283454/1/check/gate-python-novaclient-pypy/a0afeb3/ : SUCCESS in 2m 19s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/54/283454/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/690e2ea/ : SUCCESS in 52m 47s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/54/283454/1/check/gate-novaclient-dsvm-functional/5e88011/ : SUCCESS in 24m 54s","accounts_in_message":[],"_revision_number":1},{"id":"f3e0cb49d5241a15a5e47bcf4b3c13ffc96a4204","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-02-23 09:56:25.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nlooks good but I think assertFalse should be discussed","accounts_in_message":[],"_revision_number":1},{"id":"89f92c305d754ac272a884e87d4de3c532322ad0","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2016-02-23 11:16:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"00eec80860383e93879aa7cc45f686743866fc7b","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-02-23 11:19:31.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"95aa372356ecdeb3868d68b880da9e7b9a6579ec","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2016-02-23 11:23:58.000000000","message":"Patch Set 2:\n\nBéla, ZhiQiang,\n\nThank you for your reviews.\n\nZhiQiang,\n\nIn \u0027__init__\u0027 method of class DeprecatedAction in novaclient/shell.py,\nreal_action_args is False or a tuple.\nSo real_action_args never be None or \u0027\u0027.\n\nBut they are tests. So I undid them.","accounts_in_message":[],"_revision_number":2},{"id":"28813f688d6ecbf31971b97270a1dbd97035e787","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-23 12:10:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/54/283454/2/check/gate-python-novaclient-pep8/56ef754/ : SUCCESS in 57s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/54/283454/2/check/gate-python-novaclient-docs/61dec1d//doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-novaclient-python27 http://logs.openstack.org/54/283454/2/check/gate-python-novaclient-python27/f71d21f/ : SUCCESS in 1m 27s\n- gate-python-novaclient-python34 http://logs.openstack.org/54/283454/2/check/gate-python-novaclient-python34/430d474/ : SUCCESS in 2m 10s\n- gate-python-novaclient-pypy http://logs.openstack.org/54/283454/2/check/gate-python-novaclient-pypy/a11605c/ : SUCCESS in 2m 16s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/54/283454/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/fa11540/ : SUCCESS in 53m 48s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/54/283454/2/check/gate-novaclient-dsvm-functional/072fade/ : SUCCESS in 24m 32s","accounts_in_message":[],"_revision_number":2},{"id":"999d964f18ec312c33866090e46d3e8e788c35c2","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-02-23 21:22:05.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1a720f8bc5af9f479a16c20038fd41b8a23163a8","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-02-24 22:06:25.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"30a4f14f811152cf7984e0f51ba7869fd43400a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-24 22:06:31.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"136084a81c22bb8e89ba6318657b4b401adc7dce","date":"2016-02-24 23:02:40.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"18cc5df5e3bf39c196731bf8e0a5a9e5237b4d86","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-24 23:02:40.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs http://docs-draft.openstack.org/54/283454/2/gate/gate-python-novaclient-docs/2151cea//doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-novaclient-pep8 http://logs.openstack.org/54/283454/2/gate/gate-python-novaclient-pep8/9626134/ : SUCCESS in 49s\n- gate-python-novaclient-python27 http://logs.openstack.org/54/283454/2/gate/gate-python-novaclient-python27/7cf0d8b/ : SUCCESS in 1m 24s\n- gate-python-novaclient-python34 http://logs.openstack.org/54/283454/2/gate/gate-python-novaclient-python34/4093dd5/ : SUCCESS in 2m 05s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/54/283454/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient/1154208/ : SUCCESS in 55m 57s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/54/283454/2/gate/gate-novaclient-dsvm-functional/c2772fe/ : SUCCESS in 27m 49s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f55e426dd4bd2373a00b0299e1aef8394bf9361c","revisions":{"3feab75653139cc4e572763955df05ee21f49201":{"kind":"REWORK","_number":1,"created":"2016-02-23 08:59:25.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/54/283454/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/54/283454/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/54/283454/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/54/283454/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/54/283454/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/54/283454/1"}}},"commit":{"parents":[{"commit":"4e2761d6b9a31228780a6bef898cfb0684ed39f8","subject":"Merge \"[microversions] Turn off check for header in response\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4e2761d6b9a31228780a6bef898cfb0684ed39f8"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2016-02-23 08:47:59.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2016-02-23 08:57:21.000000000","tz":540},"subject":"Use assertIsNone, assertFalse instead of assertEqual","message":"Use assertIsNone, assertFalse instead of assertEqual\n\nInstead of using assertEqual(None, ***), developers should\nuse assertIsNone(***).\nInstead of using assertEqual(False, ***), developers should\nuse assertFalse(***).\n\nChange-Id: I55e9161a4df9197546603385228ea85528de43a7\nCloses-Bug: #1510006\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3feab75653139cc4e572763955df05ee21f49201"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3feab75653139cc4e572763955df05ee21f49201"}]},"branch":"refs/heads/master"},"f55e426dd4bd2373a00b0299e1aef8394bf9361c":{"kind":"REWORK","_number":2,"created":"2016-02-23 11:16:13.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/54/283454/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/54/283454/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/54/283454/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/54/283454/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/54/283454/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/54/283454/2"}}},"commit":{"parents":[{"commit":"4e2761d6b9a31228780a6bef898cfb0684ed39f8","subject":"Merge \"[microversions] Turn off check for header in response\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4e2761d6b9a31228780a6bef898cfb0684ed39f8"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2016-02-23 08:47:59.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2016-02-23 11:15:06.000000000","tz":540},"subject":"Use assertIsNone instead of assertEqual(None, ***)","message":"Use assertIsNone instead of assertEqual(None, ***)\n\nInstead of using assertEqual(None, ***), developers should\nuse assertIsNone(***).\n\nChange-Id: I55e9161a4df9197546603385228ea85528de43a7\nCloses-Bug: #1510006\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f55e426dd4bd2373a00b0299e1aef8394bf9361c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f55e426dd4bd2373a00b0299e1aef8394bf9361c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}