)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"0214eea928b2076579c759cac01480ea28cdeb29","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add changes-since support when list servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-bug : #1551591"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I27f2d1e33a56d357e247111b338c93861716cfee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7af24918_ba03cc72","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":21},"updated":"2016-03-02 02:05:25.000000000","message":"s/../Closes-Bug: #1551591 ,it doesn\u0027t link to the bug.","commit_id":"a87dd4791f04cb5b9e9ee56a6318688d38541758"}],"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"1b7c70a21ff3d81d7f105f9a0599fd057f90ef3a","unresolved":false,"context_lines":[{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"    def test_list_with_changes_since_invalid_value(self):"},{"line_number":1068,"context_line":"        self.assertRaises(exceptions.CommandError,"},{"line_number":1069,"context_line":"                          self.run_command, \u0027list --changes-since 0123456789\u0027)"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    def test_meta_parsing(self):"},{"line_number":1072,"context_line":"        meta \u003d [\u0027key1\u003dmeta1\u0027, \u0027key2\u003dmeta2\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_b12fa8f5","line":1069,"range":{"start_line":1069,"start_character":66,"end_line":1069,"end_character":76},"updated":"2016-03-07 08:54:06.000000000","message":"I\u0027m not sure if the changes-since format is like \u00272001-00-00T66:72:88Z\u0027, the server side should raise error?","commit_id":"20865ad66a4489a4401322290ec154c551f80293"}],"novaclient/v2/shell.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"0214eea928b2076579c759cac01480ea28cdeb29","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"    dest\u003d\u0027changes_since\u0027,"},{"line_number":1465,"context_line":"    metavar\u003d\u0027\u003cchanges_since\u003e\u0027,"},{"line_number":1466,"context_line":"    default\u003dNone,"},{"line_number":1467,"context_line":"    help\u003d_(\"List only servers changed after a certain point of time.\"))"},{"line_number":1468,"context_line":"def do_list(cs, args):"},{"line_number":1469,"context_line":"    \"\"\"List active servers.\"\"\""},{"line_number":1470,"context_line":"    imageid \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_5a78c8f2","line":1467,"range":{"start_line":1467,"start_character":4,"end_line":1467,"end_character":71},"updated":"2016-03-02 02:05:25.000000000","message":"seem from you UT, I think you need to add what the value of --change-since should like. It should be an ISO 8601 date format. For ex:\n\n2016-01-01\n2016-02-29T06:23:22 etc.\n\nsee https://zh.wikipedia.org/wiki/ISO_8601","commit_id":"a87dd4791f04cb5b9e9ee56a6318688d38541758"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"42f5b3b96befe533103fe77cef99871fb6f3bf89","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"    dest\u003d\u0027changes_since\u0027,"},{"line_number":1465,"context_line":"    metavar\u003d\u0027\u003cchanges_since\u003e\u0027,"},{"line_number":1466,"context_line":"    default\u003dNone,"},{"line_number":1467,"context_line":"    help\u003d_(\"List only servers changed after a certain point of time.\""},{"line_number":1468,"context_line":"           \"The provided time should be an ISO 8061 formated time.\"))"},{"line_number":1469,"context_line":"def do_list(cs, args):"},{"line_number":1470,"context_line":"    \"\"\"List active servers.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_f5b381e7","line":1467,"range":{"start_line":1467,"start_character":54,"end_line":1467,"end_character":59},"updated":"2016-03-02 14:29:19.000000000","message":"s/point/period/  ?","commit_id":"95a8df819834e4475aceb0fe836509af59e2cca4"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"32086c0dbdbedbc36f33534bb996121a259fbba1","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"    dest\u003d\u0027changes_since\u0027,"},{"line_number":1465,"context_line":"    metavar\u003d\u0027\u003cchanges_since\u003e\u0027,"},{"line_number":1466,"context_line":"    default\u003dNone,"},{"line_number":1467,"context_line":"    help\u003d_(\"List only servers changed after a certain point of time.\""},{"line_number":1468,"context_line":"           \"The provided time should be an ISO 8061 formated time.\"))"},{"line_number":1469,"context_line":"def do_list(cs, args):"},{"line_number":1470,"context_line":"    \"\"\"List active servers.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_e30ed98a","line":1467,"range":{"start_line":1467,"start_character":54,"end_line":1467,"end_character":59},"in_reply_to":"7af24918_ce04c84b","updated":"2016-03-03 13:45:20.000000000","message":"ok,","commit_id":"95a8df819834e4475aceb0fe836509af59e2cca4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"5c9cef69970b53af3e1fe34105197f4d3b60ad84","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"    dest\u003d\u0027changes_since\u0027,"},{"line_number":1465,"context_line":"    metavar\u003d\u0027\u003cchanges_since\u003e\u0027,"},{"line_number":1466,"context_line":"    default\u003dNone,"},{"line_number":1467,"context_line":"    help\u003d_(\"List only servers changed after a certain point of time.\""},{"line_number":1468,"context_line":"           \"The provided time should be an ISO 8061 formated time.\"))"},{"line_number":1469,"context_line":"def do_list(cs, args):"},{"line_number":1470,"context_line":"    \"\"\"List active servers.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_ce04c84b","line":1467,"range":{"start_line":1467,"start_character":54,"end_line":1467,"end_character":59},"in_reply_to":"7af24918_f5b381e7","updated":"2016-03-03 01:43:11.000000000","message":"no I guess not, it\u0027s not period, it list servers changed after a timestamp. But I will try to look up for more acurate words.","commit_id":"95a8df819834e4475aceb0fe836509af59e2cca4"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"42f5b3b96befe533103fe77cef99871fb6f3bf89","unresolved":false,"context_lines":[{"line_number":1491,"context_line":"        \u0027host\u0027: args.host,"},{"line_number":1492,"context_line":"        \u0027deleted\u0027: args.deleted,"},{"line_number":1493,"context_line":"        \u0027instance_name\u0027: args.instance_name,"},{"line_number":1494,"context_line":"        \u0027changes-since\u0027: args.changes_since}"},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"    filters \u003d {\u0027flavor\u0027: lambda f: f[\u0027id\u0027],"},{"line_number":1497,"context_line":"               \u0027security_groups\u0027: utils._format_security_groups}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_15842dd2","line":1494,"range":{"start_line":1494,"start_character":30,"end_line":1494,"end_character":43},"updated":"2016-03-02 14:29:19.000000000","message":"not sure it\u0027s worthy, check whether format is correct before use it?","commit_id":"95a8df819834e4475aceb0fe836509af59e2cca4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"5c9cef69970b53af3e1fe34105197f4d3b60ad84","unresolved":false,"context_lines":[{"line_number":1491,"context_line":"        \u0027host\u0027: args.host,"},{"line_number":1492,"context_line":"        \u0027deleted\u0027: args.deleted,"},{"line_number":1493,"context_line":"        \u0027instance_name\u0027: args.instance_name,"},{"line_number":1494,"context_line":"        \u0027changes-since\u0027: args.changes_since}"},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"    filters \u003d {\u0027flavor\u0027: lambda f: f[\u0027id\u0027],"},{"line_number":1497,"context_line":"               \u0027security_groups\u0027: utils._format_security_groups}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_ee8ee4ce","line":1494,"range":{"start_line":1494,"start_character":30,"end_line":1494,"end_character":43},"in_reply_to":"7af24918_15842dd2","updated":"2016-03-03 01:43:11.000000000","message":"API side does the check, I think it is enough?","commit_id":"95a8df819834e4475aceb0fe836509af59e2cca4"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"42f5b3b96befe533103fe77cef99871fb6f3bf89","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"        if search_opts[\u0027all_tenants\u0027]:"},{"line_number":1565,"context_line":"            columns.insert(2, \u0027Tenant ID\u0027)"},{"line_number":1566,"context_line":"        if search_opts[\u0027changes-since\u0027]:"},{"line_number":1567,"context_line":"            columns.append(\u0027Updated\u0027)"},{"line_number":1568,"context_line":"    formatters[\u0027Networks\u0027] \u003d utils._format_servers_list_networks"},{"line_number":1569,"context_line":"    sortby_index \u003d 1"},{"line_number":1570,"context_line":"    if args.sort:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_708c9f7f","line":1567,"range":{"start_line":1567,"start_character":28,"end_line":1567,"end_character":35},"updated":"2016-03-02 14:29:19.000000000","message":"is this \u0027Updated At\u0027 better?","commit_id":"95a8df819834e4475aceb0fe836509af59e2cca4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"5c9cef69970b53af3e1fe34105197f4d3b60ad84","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"        if search_opts[\u0027all_tenants\u0027]:"},{"line_number":1565,"context_line":"            columns.insert(2, \u0027Tenant ID\u0027)"},{"line_number":1566,"context_line":"        if search_opts[\u0027changes-since\u0027]:"},{"line_number":1567,"context_line":"            columns.append(\u0027Updated\u0027)"},{"line_number":1568,"context_line":"    formatters[\u0027Networks\u0027] \u003d utils._format_servers_list_networks"},{"line_number":1569,"context_line":"    sortby_index \u003d 1"},{"line_number":1570,"context_line":"    if args.sort:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_89711aab","line":1567,"range":{"start_line":1567,"start_character":28,"end_line":1567,"end_character":35},"in_reply_to":"7af24918_708c9f7f","updated":"2016-03-03 01:43:11.000000000","message":"Yes, but the returned value is called updated, and if I change the columns to Updated At, it will return empty column, I will also look for better solutions.","commit_id":"95a8df819834e4475aceb0fe836509af59e2cca4"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"32086c0dbdbedbc36f33534bb996121a259fbba1","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"        if search_opts[\u0027all_tenants\u0027]:"},{"line_number":1565,"context_line":"            columns.insert(2, \u0027Tenant ID\u0027)"},{"line_number":1566,"context_line":"        if search_opts[\u0027changes-since\u0027]:"},{"line_number":1567,"context_line":"            columns.append(\u0027Updated\u0027)"},{"line_number":1568,"context_line":"    formatters[\u0027Networks\u0027] \u003d utils._format_servers_list_networks"},{"line_number":1569,"context_line":"    sortby_index \u003d 1"},{"line_number":1570,"context_line":"    if args.sort:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_c3611d3b","line":1567,"range":{"start_line":1567,"start_character":28,"end_line":1567,"end_character":35},"in_reply_to":"7af24918_89711aab","updated":"2016-03-03 13:45:20.000000000","message":"seems sometimes we call it updated sometimes updated At\nneed consistent :)","commit_id":"95a8df819834e4475aceb0fe836509af59e2cca4"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7f4d8fd57fa5f0935ed3abe0654802cb88f197c4","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"    dest\u003d\u0027changes_since\u0027,"},{"line_number":1465,"context_line":"    metavar\u003d\u0027\u003cchanges_since\u003e\u0027,"},{"line_number":1466,"context_line":"    default\u003dNone,"},{"line_number":1467,"context_line":"    help\u003d_(\"List only servers changed after a certain point of time.\""},{"line_number":1468,"context_line":"           \"The provided time should be an ISO 8061 formated time.\"))"},{"line_number":1469,"context_line":"def do_list(cs, args):"},{"line_number":1470,"context_line":"    \"\"\"List active servers.\"\"\""},{"line_number":1471,"context_line":"    imageid \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_dea6ecac","line":1468,"range":{"start_line":1467,"start_character":12,"end_line":1468,"end_character":65},"updated":"2016-03-04 02:33:41.000000000","message":"Hi, Zheng:\nI think you can \"copy\" some code from \"nova usage\" subcommand[1] about the time-dealing thing.\nFrankly speaking, I have to google about the ISO 8601 formatted time before using this command.\nAt least you can leave an example in the help message.\n\n[1]:https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L3493","commit_id":"54a55effe9eb4cc4779623bcc35a2a214ecca238"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"65353f18a9568368bb4077fd975ed69de5509139","unresolved":false,"context_lines":[{"line_number":1466,"context_line":"    default\u003dNone,"},{"line_number":1467,"context_line":"    help\u003d_(\"List only servers changed after a certain point of time.\""},{"line_number":1468,"context_line":"           \"The provided time should be an ISO 8061 formated time.\""},{"line_number":1469,"context_line":"           \"ex 2016-03-04T06:27:59Z .\"))"},{"line_number":1470,"context_line":"def do_list(cs, args):"},{"line_number":1471,"context_line":"    \"\"\"List active servers.\"\"\""},{"line_number":1472,"context_line":"    imageid \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_137cc2ea","line":1469,"range":{"start_line":1469,"start_character":15,"end_line":1469,"end_character":36},"updated":"2016-03-04 09:11:53.000000000","message":"it would be nice to check the format of transmitted value at novaclient\u0027s side.","commit_id":"e4a3726cb109a3032055d62519c7ad6e433a4874"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7b41c02bff961ca2e8fce5e1e7c7ce3cb8ad5191","unresolved":false,"context_lines":[{"line_number":1466,"context_line":"    default\u003dNone,"},{"line_number":1467,"context_line":"    help\u003d_(\"List only servers changed after a certain point of time.\""},{"line_number":1468,"context_line":"           \"The provided time should be an ISO 8061 formated time.\""},{"line_number":1469,"context_line":"           \"ex 2016-03-04T06:27:59Z .\"))"},{"line_number":1470,"context_line":"def do_list(cs, args):"},{"line_number":1471,"context_line":"    \"\"\"List active servers.\"\"\""},{"line_number":1472,"context_line":"    imageid \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_197ce3ea","line":1469,"range":{"start_line":1469,"start_character":15,"end_line":1469,"end_character":36},"in_reply_to":"7af24918_137cc2ea","updated":"2016-03-04 09:45:35.000000000","message":"yeah, I added similar comment in previous patch\nseems it\u0027s worthy","commit_id":"e4a3726cb109a3032055d62519c7ad6e433a4874"}]}