)]}'
{"id":"openstack%2Fpython-novaclient~287024","triplet_id":"openstack%2Fpython-novaclient~master~I09e5671ec32216deb79864345cc824a4763bcc12","project":"openstack/python-novaclient","branch":"master","topic":"bug/1494116","hashtags":[],"change_id":"I09e5671ec32216deb79864345cc824a4763bcc12","subject":"Add last_request_id parameter to SessionClient","status":"ABANDONED","created":"2016-03-02 07:39:02.000000000","updated":"2016-03-02 12:28:50.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7c43720d50738d09a763233170cab8a957b8f07f","_number":287024,"virtual_id_number":287024,"owner":{"_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2016-03-02 11:43:12.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-03-02 11:31:56.000000000","_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"date":"2016-03-02 11:13:06.000000000","_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"},{"value":0,"date":"2016-03-02 11:21:05.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-02 11:13:06.000000000","updated_by":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"reviewer":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"state":"REVIEWER"},{"updated":"2016-03-02 11:21:05.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2016-03-02 11:43:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f5171324e3e424f7787db000b2e432a9c34b1107","author":{"_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"},"date":"2016-03-02 07:39:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"97d30e38218dc3dcf90041ea10256409cb2a7756","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2016-03-02 07:39:12.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"228fafd767f7db708e4c1382a60a7345fedb2c42","author":{"_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"},"date":"2016-03-02 08:31:35.000000000","message":"Patch Set 1:\n\nHi OpenStack :)","accounts_in_message":[],"_revision_number":1},{"id":"cd175c37d9956f5acec74047d02701ee4c83ef0b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-02 09:01:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/24/287024/1/check/gate-python-novaclient-pep8/8454ea1/ : SUCCESS in 43s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/24/287024/1/check/gate-python-novaclient-docs/b676c93//doc/build/html/ : SUCCESS in 1m 12s\n- gate-python-novaclient-python27 http://logs.openstack.org/24/287024/1/check/gate-python-novaclient-python27/5716367/ : SUCCESS in 1m 43s\n- gate-python-novaclient-python34 http://logs.openstack.org/24/287024/1/check/gate-python-novaclient-python34/879adb2/ : SUCCESS in 2m 03s\n- gate-python-novaclient-pypy http://logs.openstack.org/24/287024/1/check/gate-python-novaclient-pypy/8bf8328/ : SUCCESS in 4m 02s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/24/287024/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/5e2a0a8/ : SUCCESS in 1h 06m 50s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/24/287024/1/check/gate-novaclient-dsvm-functional/9e673a9/ : SUCCESS in 39m 28s","accounts_in_message":[],"_revision_number":1},{"id":"908fd7c93d71adc29edf4b6eb64a137c697decf9","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-03-02 10:14:30.000000000","message":"Patch Set 1:\n\nWe don\u0027t use apiclient.base.Resource any more.\nWe use base.Resource instead.\nCan you reproduce this bug in master branch now?","accounts_in_message":[],"_revision_number":1},{"id":"7060e761c4bd5396d58540ae73aa2e17db7dc13d","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-03-02 10:49:48.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"01c2b55939ed99ed5718fba9e2061263e9424d11","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-03-02 10:50:05.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM, thanks","accounts_in_message":[],"_revision_number":2},{"id":"6a29adb2539c594a11d426a8fecf88a76435505d","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-03-02 11:13:06.000000000","message":"Patch Set 2:\n\nHi, Andrey:\nAre you sure we still need this?\nWe have deleted related code in this change:\nhttps://review.openstack.org/#/c/258802/10/novaclient/base.py@195\n\nThanks","accounts_in_message":[],"_revision_number":2},{"id":"020c933006fcb287793a4da40397b74bda221ec1","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2016-03-02 11:21:05.000000000","message":"Patch Set 2: -Code-Review\n\n@Cao ShuFeng:\nyeah, it looks like you are right and we don\u0027t need it anymore. I was misled by HTTPClient(last_request_id logic was not removed there - https://github.com/openstack/python-novaclient/blob/3.2.0/novaclient/client.py#L390-L391 )","accounts_in_message":[],"_revision_number":2},{"id":"bc15b8178ec4cab5c770a3722c7f94f7832f9c00","author":{"_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"},"date":"2016-03-02 11:31:56.000000000","message":"Patch Set 2:\n\n@Cao you are right. it seems my test environment was not up-to-date. so is this needed to be abandoned ( I am new here:) )?","accounts_in_message":[],"_revision_number":2},{"id":"9ec7ee13d70fb9bf10d1e22dfcb74b1ec2e4c8c6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-02 11:43:12.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/24/287024/2/check/gate-python-novaclient-pep8/019afae/ : SUCCESS in 41s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/24/287024/2/check/gate-python-novaclient-docs/460f166//doc/build/html/ : SUCCESS in 53s\n- gate-python-novaclient-python27 http://logs.openstack.org/24/287024/2/check/gate-python-novaclient-python27/ea13940/ : SUCCESS in 3m 16s\n- gate-python-novaclient-python34 http://logs.openstack.org/24/287024/2/check/gate-python-novaclient-python34/c5dfbc5/ : FAILURE in 40m 15s\n- gate-python-novaclient-pypy http://logs.openstack.org/24/287024/2/check/gate-python-novaclient-pypy/d52f0d7/ : SUCCESS in 2m 11s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/24/287024/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/d7f2997/ : SUCCESS in 53m 03s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/24/287024/2/check/gate-novaclient-dsvm-functional/dac8f0f/ : SUCCESS in 38m 27s","accounts_in_message":[],"_revision_number":2},{"id":"45b3639464c3f89fbcd665cec2c40658b2867e79","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-03-02 11:51:50.000000000","message":"Patch Set 2:\n\n\u003e @Cao you are right. it seems my test environment was not\n \u003e up-to-date. so is this needed to be abandoned ( I am new here:) )?\n\nHi, meretiko:\nIf you are sure this bug can\u0027t be reproduced in newest environment, you can just abandon it.So that it will not take other reviewer\u0027s time.\nThanks","accounts_in_message":[],"_revision_number":2},{"id":"c75d1feb0a6066c1d76dd609c40d3c6aeff1cc47","author":{"_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"},"date":"2016-03-02 12:28:26.000000000","message":"Patch Set 2:\n\n\u003e \u003e @Cao you are right. it seems my test environment was not\n \u003e \u003e up-to-date. so is this needed to be abandoned ( I am new here:)\n \u003e )?\n \u003e \n \u003e Hi, meretiko:\n \u003e If you are sure this bug can\u0027t be reproduced in newest environment,\n \u003e you can just abandon it.So that it will not take other reviewer\u0027s\n \u003e time.\n \u003e Thanks\n\n@Cao No I could not reproduce this bug with the newest environment. Thanks for your help.","accounts_in_message":[],"_revision_number":2},{"id":"a12c15f042835f40706cefdaf7231091a9ad1e14","author":{"_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"},"date":"2016-03-02 12:28:50.000000000","message":"Abandoned\n\nhttps://review.openstack.org/#/c/258802 fixes the issue","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"af76a5687349fd2fd97cec9d8e92fc353dbad3c7","revisions":{"2510047b521a2e84413c512d038f0c1d9f29eb05":{"kind":"REWORK","_number":1,"created":"2016-03-02 07:39:02.000000000","uploader":{"_account_id":20808,"name":"meretiko","email":"meretikoesra@gmail.com","username":"meretiko"},"ref":"refs/changes/24/287024/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/24/287024/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/287024/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/287024/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/287024/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/24/287024/1"}}},"commit":{"parents":[{"commit":"32a28f8040fa28b4cefb34c5c57e11958c2fc257","subject":"Merge \"Support for abort an ongoing live migration\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/32a28f8040fa28b4cefb34c5c57e11958c2fc257"}]}],"author":{"name":"meretiko","email":"meretikoesra@gmail.com","date":"2016-03-02 07:09:05.000000000","tz":120},"committer":{"name":"meretiko","email":"meretikoesra@gmail.com","date":"2016-03-02 07:09:05.000000000","tz":120},"subject":"apiclient.base.Resource.get method requires manager.client to have last_request_id member [1]. Otherwise get operation fails with AttributeError exception.","message":"apiclient.base.Resource.get method requires manager.client to have\nlast_request_id member [1]. Otherwise get operation fails with\nAttributeError exception.\n\nThis patch adds last_request_id member to the SessionClient class\n\nChange-Id: I09e5671ec32216deb79864345cc824a4763bcc12\nCloses-Bug: #1494116\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2510047b521a2e84413c512d038f0c1d9f29eb05"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2510047b521a2e84413c512d038f0c1d9f29eb05"}]},"branch":"refs/heads/master"},"af76a5687349fd2fd97cec9d8e92fc353dbad3c7":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-03-02 10:49:48.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/24/287024/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/24/287024/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/287024/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/287024/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/24/287024/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/24/287024/2"}}},"commit":{"parents":[{"commit":"32a28f8040fa28b4cefb34c5c57e11958c2fc257","subject":"Merge \"Support for abort an ongoing live migration\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/32a28f8040fa28b4cefb34c5c57e11958c2fc257"}]}],"author":{"name":"meretiko","email":"meretikoesra@gmail.com","date":"2016-03-02 07:09:05.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2016-03-02 10:49:27.000000000","tz":0},"subject":"Add last_request_id parameter to SessionClient","message":"Add last_request_id parameter to SessionClient\n\n`novaclient.base.Resource.get` method requires manager.client to have\nlast_request_id member. Otherwise get operation fails with\nAttributeError exception.\n\nThis patch adds last_request_id member to the SessionClient class\n\nChange-Id: I09e5671ec32216deb79864345cc824a4763bcc12\nCloses-Bug: #1494116\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/af76a5687349fd2fd97cec9d8e92fc353dbad3c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/af76a5687349fd2fd97cec9d8e92fc353dbad3c7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}