)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3b2be82832c212f4965d895332cbf1abaca7aa30","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"flavor-id should be only integer or UUID"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"nova flavor-create should only work with"},{"line_number":10,"context_line":"flavorid as an integer or UUID, but"},{"line_number":11,"context_line":"currently a flavor is created even if the"},{"line_number":12,"context_line":"user enters a string, etc."},{"line_number":13,"context_line":"Included a condition to check if the user"},{"line_number":14,"context_line":"enters anything else than an interger or"},{"line_number":15,"context_line":"UUID."},{"line_number":16,"context_line":"Closes-Bug: #1426806"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iaa845a5e1f3e6ae04cc85f9d2f7f32435cd8a123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_3932da5f","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":5},"updated":"2016-03-09 11:45:25.000000000","message":"nit: please wrap this at ~79 characters","commit_id":"5c92fc721ff6c70e46afd202e1e7ce1382c03a12"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3c4b51fceed38215f2fbb3a3d5bf67c4000548e2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"flavor-id should be only integer or UUID"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"nova flavor-create should only work with"},{"line_number":10,"context_line":"flavorid as an integer or UUID, but"},{"line_number":11,"context_line":"currently a flavor is created even if the"},{"line_number":12,"context_line":"user enters a string, etc."},{"line_number":13,"context_line":"Included a condition to check if the user"},{"line_number":14,"context_line":"enters anything else than an interger or"},{"line_number":15,"context_line":"UUID."},{"line_number":16,"context_line":"Closes-Bug: #1426806"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iaa845a5e1f3e6ae04cc85f9d2f7f32435cd8a123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_85ec46f4","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":5},"in_reply_to":"5aef4532_3932da5f","updated":"2016-03-09 17:24:17.000000000","message":"Actually, the recommendation is 72 columns, and I have no trouble at all with wrapping lines at even fewer columns.","commit_id":"5c92fc721ff6c70e46afd202e1e7ce1382c03a12"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"34c3483583c1125c8302a5712b4e78a995529a42","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"flavor-id should be only integer or UUID"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"nova flavor-create should only work with"},{"line_number":10,"context_line":"flavorid as an integer or UUID, but"},{"line_number":11,"context_line":"currently a flavor is created even if the"},{"line_number":12,"context_line":"user enters a string, etc."},{"line_number":13,"context_line":"Included a condition to check if the user"},{"line_number":14,"context_line":"enters anything else than an interger or"},{"line_number":15,"context_line":"UUID."},{"line_number":16,"context_line":"Closes-Bug: #1426806"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iaa845a5e1f3e6ae04cc85f9d2f7f32435cd8a123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_f394cb8b","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":5},"in_reply_to":"5aef4532_85ec46f4","updated":"2016-03-10 10:48:22.000000000","message":"Whoops - meant 72 :)","commit_id":"5c92fc721ff6c70e46afd202e1e7ce1382c03a12"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3b2be82832c212f4965d895332cbf1abaca7aa30","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Included a condition to check if the user"},{"line_number":14,"context_line":"enters anything else than an interger or"},{"line_number":15,"context_line":"UUID."},{"line_number":16,"context_line":"Closes-Bug: #1426806"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iaa845a5e1f3e6ae04cc85f9d2f7f32435cd8a123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_5914069f","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"updated":"2016-03-09 11:45:25.000000000","message":"nit: put this line after the \u0027Change-Id\u0027 line","commit_id":"5c92fc721ff6c70e46afd202e1e7ce1382c03a12"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3c4b51fceed38215f2fbb3a3d5bf67c4000548e2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Included a condition to check if the user"},{"line_number":14,"context_line":"enters anything else than an interger or"},{"line_number":15,"context_line":"UUID."},{"line_number":16,"context_line":"Closes-Bug: #1426806"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iaa845a5e1f3e6ae04cc85f9d2f7f32435cd8a123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_a574e235","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"in_reply_to":"5aef4532_5914069f","updated":"2016-03-09 17:24:17.000000000","message":"I myself prefer that \"Closes-Bug\" be grouped with the \"Change-Id\" footer, but it really doesn\u0027t matter at all; the tooling that manages the link between the review and the bug is perfectly happy to recognize this sort of construction.","commit_id":"5c92fc721ff6c70e46afd202e1e7ce1382c03a12"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"34c3483583c1125c8302a5712b4e78a995529a42","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Included a condition to check if the user"},{"line_number":14,"context_line":"enters anything else than an interger or"},{"line_number":15,"context_line":"UUID."},{"line_number":16,"context_line":"Closes-Bug: #1426806"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iaa845a5e1f3e6ae04cc85f9d2f7f32435cd8a123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_13e1772d","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"in_reply_to":"5aef4532_a574e235","updated":"2016-03-10 10:48:22.000000000","message":"Yeah, just conventional to put it after, hence \u0027nit(pick)\u0027 prefix","commit_id":"5c92fc721ff6c70e46afd202e1e7ce1382c03a12"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"b030a2592bf49c3291dd50331b803fde656ae78f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"flavor-id should be only integer or UUID"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"nova flavor-create should only work with"},{"line_number":10,"context_line":"flavorid as an integer or UUID, but"},{"line_number":11,"context_line":"currently a flavor is created even if the"},{"line_number":12,"context_line":"user enters a string, etc."},{"line_number":13,"context_line":"Included a condition to check if the user"},{"line_number":14,"context_line":"enters anything else than an interger or"},{"line_number":15,"context_line":"UUID."},{"line_number":16,"context_line":"Closes-Bug: #1426806"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iaa845a5e1f3e6ae04cc85f9d2f7f32435cd8a123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1af94dfe_3a97bf91","line":16,"range":{"start_line":9,"start_character":0,"end_line":16,"end_character":20},"updated":"2016-03-16 06:37:11.000000000","message":"Is it needed to split the message across soo many lines?\nAlso you can include an empty line after the message body.","commit_id":"a3d5ca8b5294e6d4f78909dac286c631d8ed1e88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"71a51c3ca7d340585f76f1a605955cff96b03301","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     abhishek.talwar \u003cabhishek.talwar@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-22 10:44:06 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"flavor-id should be only integer or UUID"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"nova flavor-create should only work with"},{"line_number":10,"context_line":"flavorid as an integer or UUID, but"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3ac371cc_5d3fe6d5","line":7,"updated":"2016-08-16 21:22:10.000000000","message":"Pretty sure this isn\u0027t what the API schema says:\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/flavor_manage.py#L29\n\nSo I could do \"test flavor\".\n\nBy default, nova will generate the flavorid as a uuid, and the flavorid coming out of the API as an id is something we shouldn\u0027t have allowed in the past, as it leaks the id from the database.\n\nBut I don\u0027t think this restriction is valid given the API schema.","commit_id":"e561e083ea4637a83d6759c89cbb359ab1a966f4"}],"novaclient/v2/flavors.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"743bcb06af54e8b868dfaefe0268a303cf243f6b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_utils import strutils"},{"line_number":20,"context_line":"from oslo.utils import uuidutils"},{"line_number":21,"context_line":"from six.moves.urllib import parse"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from novaclient import base"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_8c6c0538","line":20,"updated":"2016-03-04 23:17:19.000000000","message":"Don\u0027t use \"oslo.\"; everyone should be using \"oslo_\" now.","commit_id":"e8154d7cedb113bbca79cc316bf4473df30a1b53"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3c4b51fceed38215f2fbb3a3d5bf67c4000548e2","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        if flavorid \u003d\u003d \"auto\":"},{"line_number":197,"context_line":"            flavorid \u003d None"},{"line_number":198,"context_line":"        elif type(flavorid) \u003d\u003d int:"},{"line_number":199,"context_line":"            pass"},{"line_number":200,"context_line":"        else:"},{"line_number":201,"context_line":"            flavor_id \u003d flavorid.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_85ed66b9","line":198,"updated":"2016-03-09 17:24:17.000000000","message":"Don\u0027t use comparisons to type(obj).  Also, \"int\" is incomplete.  I would suggest something of the form \"isinstance(flavorid, six.integer_types)\".","commit_id":"5c92fc721ff6c70e46afd202e1e7ce1382c03a12"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3c4b51fceed38215f2fbb3a3d5bf67c4000548e2","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            if flavor_id.isdigit():"},{"line_number":203,"context_line":"                pass"},{"line_number":204,"context_line":"            elif uuidutils.is_uuid_like(flavor_id):"},{"line_number":205,"context_line":"                pass"},{"line_number":206,"context_line":"            else:"},{"line_number":207,"context_line":"                raise exceptions.CommandError(_(\"Id must be an integer or \""},{"line_number":208,"context_line":"                                                \"UUID.\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_851ba6c9","line":205,"updated":"2016-03-09 17:24:17.000000000","message":"I would prefer this \u0027if\u0027 tree be turned into a single if that raises an exception, so that you eliminate the \u0027pass\u0027 statements.","commit_id":"5c92fc721ff6c70e46afd202e1e7ce1382c03a12"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3b2be82832c212f4965d895332cbf1abaca7aa30","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            raise exceptions.CommandError(_(\"Disk must be an integer.\"))"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        if flavorid \u003d\u003d \"auto\":"},{"line_number":197,"context_line":"            flavorid \u003d None"},{"line_number":198,"context_line":"        elif type(flavorid) \u003d\u003d int:"},{"line_number":199,"context_line":"            pass"},{"line_number":200,"context_line":"        else:"},{"line_number":201,"context_line":"            flavor_id \u003d flavorid.encode(\u0027utf-8\u0027)"},{"line_number":202,"context_line":"            if flavor_id.isdigit():"},{"line_number":203,"context_line":"                pass"},{"line_number":204,"context_line":"            elif uuidutils.is_uuid_like(flavor_id):"},{"line_number":205,"context_line":"                pass"},{"line_number":206,"context_line":"            else:"},{"line_number":207,"context_line":"                raise exceptions.CommandError(_(\"Id must be an integer or \""},{"line_number":208,"context_line":"                                                \"UUID.\"))"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        try:"},{"line_number":211,"context_line":"            swap \u003d int(swap)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_b9af0a29","line":208,"range":{"start_line":197,"start_character":0,"end_line":208,"end_character":57},"updated":"2016-03-09 11:45:25.000000000","message":"You\u0027re removing an test that\u0027s presumably testing \"invalid\" features, but you don\u0027t add new tests to test the \"valid\" case. Add one?","commit_id":"5c92fc721ff6c70e46afd202e1e7ce1382c03a12"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0cf218389f38e2fe637893d8c09d54dcee70e048","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":"Flavor interface."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_utils import strutils"},{"line_number":21,"context_line":"from oslo_utils import uuidutils"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_d30eefe3","line":18,"updated":"2016-03-10 10:51:21.000000000","message":"nit: Add a line between this and the docstring?","commit_id":"b637657a21c88be8a34fe54b32cf2d19163eb488"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"258f2084ee226d1e231cced5b49b9068c0ac465e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":"Flavor interface."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_utils import strutils"},{"line_number":21,"context_line":"from oslo_utils import uuidutils"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afc51ec_cc740d9e","line":18,"in_reply_to":"5aef4532_d30eefe3","updated":"2016-03-14 11:48:10.000000000","message":"this import should be grouped with other third-party libraries, so, please, put it between imports \"from oslo_utils import uuidutils\" and \"from six.moves.urllib import parse\"","commit_id":"b637657a21c88be8a34fe54b32cf2d19163eb488"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0cf218389f38e2fe637893d8c09d54dcee70e048","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            pass"},{"line_number":201,"context_line":"        else:"},{"line_number":202,"context_line":"            flavor_id \u003d flavorid.encode(\u0027utf-8\u0027)"},{"line_number":203,"context_line":"            if flavor_id.isdigit() or uuidutils.is_uuid_like(flavor_id):"},{"line_number":204,"context_line":"                pass"},{"line_number":205,"context_line":"            else:"},{"line_number":206,"context_line":"                raise exceptions.CommandError(_(\"Id must be an integer or \""},{"line_number":207,"context_line":"                                                \"UUID.\"))"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_1376976f","line":205,"range":{"start_line":203,"start_character":12,"end_line":205,"end_character":17},"updated":"2016-03-10 10:51:21.000000000","message":"Remove the pass using below?\n\n    if not flavor_id.isdigit() or not uuidutils...:","commit_id":"b637657a21c88be8a34fe54b32cf2d19163eb488"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e1f47e8c7363713dff39bcf34a59be0c757fe350","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                pass"},{"line_number":205,"context_line":"            else:"},{"line_number":206,"context_line":"                raise exceptions.CommandError(_(\"Id must be an integer or \""},{"line_number":207,"context_line":"                                                \"UUID.\"))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        try:"},{"line_number":210,"context_line":"            swap \u003d int(swap)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_750c51ed","line":207,"updated":"2016-03-17 19:00:40.000000000","message":"Please eliminate the \u0027if …: pass\u0027 clauses; simple changes to the \u0027if\u0027 condition will allow that.","commit_id":"d24444764ccddb5933a80eb9cad384b5a6a042f5"}]}