)]}'
{"id":"openstack%2Fpython-novaclient~291194","triplet_id":"openstack%2Fpython-novaclient~master~I0a5db39fb475ffa75c757bbe6854e901989be393","project":"openstack/python-novaclient","branch":"master","topic":"bp/python3","hashtags":[],"change_id":"I0a5db39fb475ffa75c757bbe6854e901989be393","subject":"replace six.iteritems() with dict.items()","status":"ABANDONED","created":"2016-03-10 14:08:05.000000000","updated":"2016-06-10 16:09:03.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"04acfd35ebe73ee0756a6d44b94496e228aa4a77","_number":291194,"virtual_id_number":291194,"owner":{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2016-04-05 11:06:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2016-03-14 00:41:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-10 20:30:42.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2016-03-11 03:53:02.000000000","updated_by":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"reviewer":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"state":"REVIEWER"},{"updated":"2016-04-05 11:06:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"530fa5aab82aa5c0fc40085e6cdec266aeae4f4e","author":{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},"date":"2016-03-10 14:08:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"29b1960ce1c233148aa380ba56622c28137d516e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-10 15:52:51.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/94/291194/1/check/gate-python-novaclient-pep8/f9cb4ce/ : FAILURE in 3m 19s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/94/291194/1/check/gate-python-novaclient-docs/02ab052//doc/build/html/ : SUCCESS in 3m 17s\n- gate-python-novaclient-python27 http://logs.openstack.org/94/291194/1/check/gate-python-novaclient-python27/994cf25/ : SUCCESS in 2m 54s\n- gate-python-novaclient-python34 http://logs.openstack.org/94/291194/1/check/gate-python-novaclient-python34/83b6f7e/ : SUCCESS in 3m 52s\n- gate-python-novaclient-pypy http://logs.openstack.org/94/291194/1/check/gate-python-novaclient-pypy/26ef07a/ : SUCCESS in 3m 49s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/94/291194/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/4cbfaf2/ : SUCCESS in 1h 13m 49s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/94/291194/1/check/gate-novaclient-dsvm-functional/32904e5/ : SUCCESS in 35m 46s","accounts_in_message":[],"_revision_number":1},{"id":"9c5094a54d0afbb315a35e495dedffa060752ccd","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-03-10 20:30:42.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nSo, AFAIK, novaclient is perfectly usable under Python 3 today, so this change doesn\u0027t really advance the python3 blueprint any at all.  Second, while I agree with the sentiment mentioned in that email (\"use .items() instead of six.iteritems()\"), I don\u0027t think it sufficiently justifies the churn being introduced by this change.  Sure, if any of this code is modified in the future, go ahead and switch back to simple .items(); and if you\u0027re replacing existing usages of .iteritems(), then yes, go to .items() as opposed to six.iteritems(); but I think this change doesn\u0027t really advance novaclient any.","accounts_in_message":[],"_revision_number":1},{"id":"b933d0d6484dbfbf96345ed2c599950999031cb5","author":{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},"date":"2016-03-10 23:37:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1723fa2ce54da0a90438a7087f66e19c8f684e61","author":{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},"date":"2016-03-10 23:42:26.000000000","message":"Patch Set 1:\n\n(1 comment)\n\n\u003e (1 comment)\n \u003e \n \u003e So, AFAIK, novaclient is perfectly usable under Python 3 today, so\n \u003e this change doesn\u0027t really advance the python3 blueprint any at\n \u003e all.  Second, while I agree with the sentiment mentioned in that\n \u003e email (\"use .items() instead of six.iteritems()\"), I don\u0027t think it\n \u003e sufficiently justifies the churn being introduced by this change. \n \u003e Sure, if any of this code is modified in the future, go ahead and\n \u003e switch back to simple .items(); and if you\u0027re replacing existing\n \u003e usages of .iteritems(), then yes, go to .items() as opposed to\n \u003e six.iteritems(); but I think this change doesn\u0027t really advance\n \u003e novaclient any.\n\nYeah, you are totally right. But at least it can make more consistent. Although we may touch them in future, but who knows, why not replace them and make things clear and code consistently?\n\nThanks,\nAllen","accounts_in_message":[],"_revision_number":1},{"id":"e4755ac4f12bca22dc08ea24585bbec0df882f16","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-11 00:47:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/94/291194/2/check/gate-python-novaclient-pep8/ccfc303/ : SUCCESS in 1m 36s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/94/291194/2/check/gate-python-novaclient-docs/6b163e0//doc/build/html/ : SUCCESS in 3m 46s\n- gate-python-novaclient-python27 http://logs.openstack.org/94/291194/2/check/gate-python-novaclient-python27/2eb3729/ : SUCCESS in 4m 45s\n- gate-python-novaclient-python34 http://logs.openstack.org/94/291194/2/check/gate-python-novaclient-python34/9668f72/ : SUCCESS in 2m 25s\n- gate-python-novaclient-pypy http://logs.openstack.org/94/291194/2/check/gate-python-novaclient-pypy/010b5d8/ : SUCCESS in 2m 36s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/94/291194/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/1e1afd4/ : SUCCESS in 1h 09m 28s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/94/291194/2/check/gate-novaclient-dsvm-functional/bf87b0d/ : SUCCESS in 23m 53s","accounts_in_message":[],"_revision_number":2},{"id":"2e1e29dc93f6e9d68678edbda1930ed482bca37e","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-03-11 03:53:02.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"a6dbd01ec95e85eebe31f1a3167d4555db024371","author":{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},"date":"2016-03-14 00:41:31.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"24a418b6957669256cbf37cab23437c8064dda09","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-14 01:45:08.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/94/291194/3/check/gate-python-novaclient-pep8/c04a882/ : SUCCESS in 3m 33s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/94/291194/3/check/gate-python-novaclient-docs/7f0c5a2//doc/build/html/ : SUCCESS in 3m 37s\n- gate-python-novaclient-python27 http://logs.openstack.org/94/291194/3/check/gate-python-novaclient-python27/dbbe99f/ : SUCCESS in 3m 59s\n- gate-python-novaclient-python34 http://logs.openstack.org/94/291194/3/check/gate-python-novaclient-python34/ae27a2d/ : SUCCESS in 2m 27s\n- gate-python-novaclient-pypy http://logs.openstack.org/94/291194/3/check/gate-python-novaclient-pypy/b455e69/ : SUCCESS in 2m 41s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/94/291194/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/659bd41/ : SUCCESS in 1h 03m 25s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/94/291194/3/check/gate-novaclient-dsvm-functional/52c9abf/ : SUCCESS in 34m 24s","accounts_in_message":[],"_revision_number":3},{"id":"2b95004658fe970c7d5e687ea83869fbdad3a1ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-05 11:06:34.000000000","message":"Patch Set 3: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"972aac87305fb8e9733043fd6ba3bca4f4f5d9c8","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2016-06-10 16:09:03.000000000","message":"Abandoned\n\nChange hasn\u0027t been updated since March.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6c92d2f18da9f149e7c1838e3d6580aad69ef372","revisions":{"9385ef4152c79b70769f315c71b75bb3d6fea492":{"kind":"REWORK","_number":1,"created":"2016-03-10 14:08:05.000000000","uploader":{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},"ref":"refs/changes/94/291194/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/94/291194/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/1"}}},"commit":{"parents":[{"commit":"b80d8cb6e6cd1e86c7dc3c99c3e7d92641c00097","subject":"nova add-secgroup help updated with secgroup id","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b80d8cb6e6cd1e86c7dc3c99c3e7d92641c00097"}]}],"author":{"name":"Allen Gao","email":"wanlong.gao@easystack.cn","date":"2016-03-10 14:06:13.000000000","tz":480},"committer":{"name":"Allen Gao","email":"wanlong.gao@easystack.cn","date":"2016-03-10 14:08:02.000000000","tz":480},"subject":"Use dict.items() for Python 3 compatibility","message":"Use dict.items() for Python 3 compatibility\n\nReplacing dict.iteritems()/.itervalues() with\nsix.iteritems(dict)/six.itervalues(dict) was preferred in the past,\nbut there was a discussion suggesting to avoid six for this.\n\nref:\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nPartially implements: blueprint python3\n\nChange-Id: I0a5db39fb475ffa75c757bbe6854e901989be393\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9385ef4152c79b70769f315c71b75bb3d6fea492"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9385ef4152c79b70769f315c71b75bb3d6fea492"}]},"branch":"refs/heads/master"},"d32c7aebaf9be83981b1e3931e943a34d6022c5a":{"kind":"REWORK","_number":2,"created":"2016-03-10 23:37:36.000000000","uploader":{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},"ref":"refs/changes/94/291194/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/94/291194/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/2"}}},"commit":{"parents":[{"commit":"b80d8cb6e6cd1e86c7dc3c99c3e7d92641c00097","subject":"nova add-secgroup help updated with secgroup id","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b80d8cb6e6cd1e86c7dc3c99c3e7d92641c00097"}]}],"author":{"name":"Allen Gao","email":"wanlong.gao@easystack.cn","date":"2016-03-10 14:06:13.000000000","tz":480},"committer":{"name":"Allen Gao","email":"wanlong.gao@easystack.cn","date":"2016-03-10 23:32:09.000000000","tz":480},"subject":"replace six.iteritems() with dict.items()","message":"replace six.iteritems() with dict.items()\n\nReplacing dict.iteritems()/.itervalues() with\nsix.iteritems(dict)/six.itervalues(dict) was preferred in the past,\nbut there was a discussion suggesting to avoid six for this.\n\nref:\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nOther places already using dict.items(), and we would better using it\nin future, so replace the current ones to get code consistency.\n\nChange-Id: I0a5db39fb475ffa75c757bbe6854e901989be393\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d32c7aebaf9be83981b1e3931e943a34d6022c5a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d32c7aebaf9be83981b1e3931e943a34d6022c5a"}]},"branch":"refs/heads/master"},"6c92d2f18da9f149e7c1838e3d6580aad69ef372":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2016-03-14 00:41:31.000000000","uploader":{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},"ref":"refs/changes/94/291194/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/94/291194/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/94/291194/3"}}},"commit":{"parents":[{"commit":"a7bffe8a71bb051b8c4df873fb8cb187c0f83643","subject":"Update reno for stable/mitaka","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a7bffe8a71bb051b8c4df873fb8cb187c0f83643"}]}],"author":{"name":"Allen Gao","email":"wanlong.gao@easystack.cn","date":"2016-03-10 14:06:13.000000000","tz":480},"committer":{"name":"Allen Gao","email":"wanlong.gao@gmail.com","date":"2016-03-14 00:41:31.000000000","tz":0},"subject":"replace six.iteritems() with dict.items()","message":"replace six.iteritems() with dict.items()\n\nReplacing dict.iteritems()/.itervalues() with\nsix.iteritems(dict)/six.itervalues(dict) was preferred in the past,\nbut there was a discussion suggesting to avoid six for this.\n\nref:\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nOther places already using dict.items(), and we would better using it\nin future, so replace the current ones to get code consistency.\n\nChange-Id: I0a5db39fb475ffa75c757bbe6854e901989be393\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6c92d2f18da9f149e7c1838e3d6580aad69ef372"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6c92d2f18da9f149e7c1838e3d6580aad69ef372"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}